From unknown Sun Jun 22 22:42:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36352 <36352@debbugs.gnu.org> To: bug#36352 <36352@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add solvespace. Reply-To: bug#36352 <36352@debbugs.gnu.org> Date: Mon, 23 Jun 2025 05:42:41 +0000 retitle 36352 [PATCH] gnu: Add solvespace. reassign 36352 guix-patches submitter 36352 Myles English severity 36352 normal tag 36352 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 24 08:27:31 2019 Received: (at submit) by debbugs.gnu.org; 24 Jun 2019 12:27:31 +0000 Received: from localhost ([127.0.0.1]:55745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfO4E-0003v0-15 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 08:27:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:40993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfO4C-0003ut-F8 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 08:27:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50066) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfO4A-0005EZ-Hs for guix-patches@gnu.org; Mon, 24 Jun 2019 08:27:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfO47-0006eh-H0 for guix-patches@gnu.org; Mon, 24 Jun 2019 08:27:22 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:54861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfO47-0006cM-AV for guix-patches@gnu.org; Mon, 24 Jun 2019 08:27:19 -0400 Received: by mail-wm1-x342.google.com with SMTP id g135so12583770wme.4 for ; Mon, 24 Jun 2019 05:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n/1V1H+5JKSDFeQe9codRRC4JBzD9aRvDbeerO9QZVQ=; b=kGdLPDTccqFBEhbU3T/M5WyANuhm2NW9zWpVWQ1Wrmt+tGwgKdMf5dGnpyf2rqa7np RDb36rEfFHA7dVz3/BUx5eiexBG6dJSekwE4Sn39Ej1XOyZVyg61HHYtpmBjFjaQSJ0T CefslBgSz4YQ9uQmbxE8CM5HCiS70TzcqTDM/sVkD4Tw5fU5iPeuEXePdWFWhfWqJMWU uXo/l3mqOYJpBgKzARS6ZivoFNr6C6PsrWlqaKe41/JN9VMzec2LZIiXd43ayzH/IBwV xBx+CnrRHMEr/lri/R2DFIk7N9wRC4GoD1G7o6D/ZWOiUKMPfUlaQdQ0Q1IsatBQ5V7j QlJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n/1V1H+5JKSDFeQe9codRRC4JBzD9aRvDbeerO9QZVQ=; b=JMq1aMdD+VglBnSQdAJ9Ws35Hs4M5+Rn+KYcE+unl+OE00AbQd55fGZ1eZPL/1Xl6m jVoxJxdRomsBP/HKmG9rdGulriVY2EQ7eb/IdU+PvH/iusHIPjE/4+xwcRj3QQJfebvl /ZUadkZK0uJie+zBXXufvUNM5hBwxO+kU8Vo4vigdY9XOoge8gCrUFof6Bi2zZ+GIgv5 3HfaUmH7dUnCypbCmzKV0/OWUbJgpVk+Dg2Dy4e2bxuFNg9r8Q0tSCjiiEMIarkfnBPr 9EP3va72A38P7zUimKX010EjkRuQXXyLVZPORBN8Oyv/4Qc0HZrx2B4DXQu8Oy+LUAol URfA== X-Gm-Message-State: APjAAAXSzqWELbJWHu0t+1APmgTG39JkAOTC/CM7nJeqEmsn3eSLzWv0 9nWcGzaoRZExElqKTfJKKCHFkY42 X-Google-Smtp-Source: APXvYqzb64GB/cZvC+dvzDOhzssrkSUEhly1XO0JXRNi6t2EQocYK6mkJ0Mgj/uSL2/N74pePru/nw== X-Received: by 2002:a1c:96:: with SMTP id 144mr3068866wma.45.1561379235238; Mon, 24 Jun 2019 05:27:15 -0700 (PDT) Received: from localhost (91.109.241.36.static-uk.cryptolayer.com. [91.109.241.36]) by smtp.googlemail.com with ESMTPSA id b9sm7357124wrm.11.2019.06.24.05.27.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 05:27:14 -0700 (PDT) From: Myles English X-Google-Original-From: Myles English To: guix-patches@gnu.org Subject: [PATCH] gnu: Add solvespace. Date: Mon, 24 Jun 2019 13:27:10 +0100 Message-Id: <20190624122710.22874-1-myles@tdma.co> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/game-development.scm (solvespace): New variable and dependencies on gnu package modules. --- gnu/packages/engineering.scm | 70 ++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 7d48414889..7fc06a6730 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2018, 2019 Jonathan Brielmaier ;;; Copyright © 2018, 2019 Arun Isaac ;;; Copyright © 2019 Tim Stahel +;;; Copyright © 2019 Myles English ;;; ;;; This file is part of GNU Guix. ;;; @@ -80,6 +81,7 @@ #:use-module (gnu packages python-xyz) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages serialization) #:use-module (gnu packages swig) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) @@ -87,6 +89,8 @@ #:use-module (gnu packages tex) #:use-module (gnu packages version-control) #:use-module (gnu packages wxwidgets) + #:use-module (gnu packages web) + #:use-module (gnu packages xml) #:use-module (gnu packages xorg)) (define-public librecad @@ -2062,3 +2066,69 @@ purpose circuit simulator and can perform DC and transient analyses, fourier analysis and AC analysis. The engine is designed to do true mixed-mode simulation.") (license license:gpl3+))) + +(define-public solvespace-3 + (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833") + (revision "1")) + (package + (name "solvespace") + (version (git-version "3.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/solvespace/solvespace.git") + (commit commit) + (recursive? #t))) + (sha256 + (base32 + "0kps2rgakdrbm9f6gwkb7za5ikkc4m6y2x162y3c53ixg5snmlr1")) + (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet + '(begin + ;; delete some recursive submodules in order to use guix packages + (delete-file-recursively "extlib/zlib") + (delete-file-recursively "extlib/libpng") + (delete-file-recursively "extlib/freetype") + ;; pixman only needed for tests? + (delete-file-recursively "extlib/pixman") + (delete-file-recursively "extlib/cairo") + (delete-file-recursively "extlib/flatbuffers") + #t)))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags + (list "-DCMAKE_BUILD_TYPE=Release" + (string-append + "-DFLATC=" + (assoc-ref %build-inputs "flatbuffers") "/bin/flatc")) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'set-git-commit-hash + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "CMakeLists.txt" + (("include\\(GetGitCommitHash\\)") + "#include(GetGitCommitHash)") + (("\\# set\\(GIT_COMMIT_HASH + 0000000000000000000000000000000000000000\\)") + (string-append "set(GIT_COMMIT_HASH " ,commit ")")) + (("message\\(STATUS \\\"Using in-tree flatbuffers\\\"\\)") + "message(STATUS \"Using guix flatbuffers\")") + (("add_subdirectory\\(extlib/flatbuffers EXCLUDE_FROM_ALL\\)") + "#add_subdirectory(extlib/flatbuffers EXCLUDE_FROM_ALL)")) + #t))))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("git" ,git) + ("json-c" ,json-c) + ("glu" ,glu) + ("gtkmm" ,gtkmm) + ("flatbuffers" ,flatbuffers))) + (home-page "http://solvespace.com") + (synopsis "Parametric 2D/3D CAD tool") + (description "Parametric 2D/3D computer aided design (CAD) tool and +constraint-based parametric modeler with simple mechanical simulation +capabilities.") + (license license:gpl3+)))) -- 2.22.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 16:35:38 2019 Received: (at submit) by debbugs.gnu.org; 25 Jun 2019 20:35:38 +0000 Received: from localhost ([127.0.0.1]:33616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsAB-0002KH-Hg for submit@debbugs.gnu.org; Tue, 25 Jun 2019 16:35:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:57633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsA6-0002K5-Es for submit@debbugs.gnu.org; Tue, 25 Jun 2019 16:35:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38871) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfsA3-00047A-LC for guix-patches@gnu.org; Tue, 25 Jun 2019 16:35:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfs9z-00075U-Gw for guix-patches@gnu.org; Tue, 25 Jun 2019 16:35:25 -0400 Received: from mx1.riseup.net ([198.252.153.129]:40640) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfs9u-0006h5-Nx for guix-patches@gnu.org; Tue, 25 Jun 2019 16:35:19 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 3B1951A0201 for ; Tue, 25 Jun 2019 13:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561494907; bh=Qxg4XRvjjKpKAfGztGxadPDuRbAafhl48omrouIcFko=; h=Subject:To:References:From:Date:In-Reply-To:From; b=AX+lyzrwCHgMb7s4TX3YDcLdhmkJc3ROTQxe6LV+BQlN8jCxqKEFhA1v2I+9RRhpn GUgmQB7VJp7mlbbluXD45sFcaX3PC7Q60Tv0BTdRaDb1+cEWVHUHHg6K+Jdkbt7m+d e1ZcLk3Opw2U6JqQeJs5lRxfdHD0MD8rylCGG03E= X-Riseup-User-ID: DA01071CA24B65FDED37BB754D5142D7FB0A436E5DD615CBB626994E9063621A Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 8DF84222DCE for ; Tue, 25 Jun 2019 13:35:06 -0700 (PDT) Subject: Re: [bug#36352] [PATCH] gnu: Add solvespace. To: guix-patches@gnu.org References: <20190624122710.22874-1-myles@tdma.co> From: swedebugia Message-ID: Date: Tue, 25 Jun 2019 22:35:03 +0200 MIME-Version: 1.0 In-Reply-To: <20190624122710.22874-1-myles@tdma.co> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.252.153.129 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 2019-06-24 14:27, Myles English wrote: > * gnu/packages/game-development.scm (solvespace): New variable and > dependencies on gnu package modules. > --- > gnu/packages/engineering.scm | 70 +++++++++++++++++++++++++++++++++++= + > 1 file changed, 70 insertions(+) >=20 > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.sc= m > index 7d48414889..7fc06a6730 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -11,6 +11,7 @@ > ;;; Copyright =C2=A9 2018, 2019 Jonathan Brielmaier > ;;; Copyright =C2=A9 2018, 2019 Arun Isaac > ;;; Copyright =C2=A9 2019 Tim Stahel > +;;; Copyright =C2=A9 2019 Myles English > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -80,6 +81,7 @@ > #:use-module (gnu packages python-xyz) > #:use-module (gnu packages qt) > #:use-module (gnu packages readline) > + #:use-module (gnu packages serialization) > #:use-module (gnu packages swig) > #:use-module (gnu packages tcl) > #:use-module (gnu packages texinfo) > @@ -87,6 +89,8 @@ > #:use-module (gnu packages tex) > #:use-module (gnu packages version-control) > #:use-module (gnu packages wxwidgets) > + #:use-module (gnu packages web) > + #:use-module (gnu packages xml) > #:use-module (gnu packages xorg)) > =20 > (define-public librecad > @@ -2062,3 +2066,69 @@ purpose circuit simulator and can perform DC and= transient analyses, fourier > analysis and AC analysis. The engine is designed to do true mixed-mo= de > simulation.") > (license license:gpl3+))) > + > +(define-public solvespace-3 > + (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833") > + (revision "1")) > + (package > + (name "solvespace") > + (version (git-version "3.0" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/solvespace/solvespace.git") > + (commit commit) > + (recursive? #t))) A stable release tarball is available on the release page it seems. https://github.com/solvespace/solvespace/releases > + (sha256 > + (base32 > + "0kps2rgakdrbm9f6gwkb7za5ikkc4m6y2x162y3c53ixg5snmlr1")) > + (file-name (git-file-name name version)) > + (modules '((guix build utils))) > + (snippet > + '(begin > + ;; delete some recursive submodules in order to use guix = packages > + (delete-file-recursively "extlib/zlib") > + (delete-file-recursively "extlib/libpng") > + (delete-file-recursively "extlib/freetype") > + ;; pixman only needed for tests? > + (delete-file-recursively "extlib/pixman") > + (delete-file-recursively "extlib/cairo") > + (delete-file-recursively "extlib/flatbuffers") > + #t)))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags > + (list "-DCMAKE_BUILD_TYPE=3DRelease" > + (string-append > + "-DFLATC=3D" > + (assoc-ref %build-inputs "flatbuffers") "/bin/flatc")) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'set-git-commit-hash > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "CMakeLists.txt" > + (("include\\(GetGitCommitHash\\)") > + "#include(GetGitCommitHash)") > + (("\\# set\\(GIT_COMMIT_HASH > + 0000000000000000000000000000000000= 000000\\)") > + (string-append "set(GIT_COMMIT_HASH " ,commit ")")) > + (("message\\(STATUS \\\"Using in-tree flatbuffers\\\"= \\)") > + "message(STATUS \"Using guix flatbuffers\")") > + (("add_subdirectory\\(extlib/flatbuffers EXCLUDE_FROM= _ALL\\)") > + "#add_subdirectory(extlib/flatbuffers EXCLUDE_FROM_A= LL)")) > + #t))))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("git" ,git) > + ("json-c" ,json-c) > + ("glu" ,glu) > + ("gtkmm" ,gtkmm) > + ("flatbuffers" ,flatbuffers))) > + (home-page "http://solvespace.com") > + (synopsis "Parametric 2D/3D CAD tool") > + (description "Parametric 2D/3D computer aided design (CAD) tool = and > +constraint-based parametric modeler with simple mechanical simulation > +capabilities.") > + (license license:gpl3+)))) >=20 The patch did not apply for some reason. I did not try to build this package because the recursive checkouts of=20 cairo et al took too much bandwidth. This is another reason to use the=20 tarball instead - less waste of bandwidth. Could you switch to that? --=20 Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 18:31:16 2019 Received: (at 36352) by debbugs.gnu.org; 2 Jul 2019 22:31:16 +0000 Received: from localhost ([127.0.0.1]:48108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRIx-0004gb-Mw for submit@debbugs.gnu.org; Tue, 02 Jul 2019 18:31:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRIw-0004gQ-ER for 36352@debbugs.gnu.org; Tue, 02 Jul 2019 18:31:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiRIe-0001ie-Qy; Tue, 02 Jul 2019 18:30:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34874 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiRIc-0007j6-8z; Tue, 02 Jul 2019 18:30:56 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Myles English Subject: Re: [bug#36352] [PATCH] gnu: Add solvespace. References: <20190624122710.22874-1-myles@tdma.co> Date: Wed, 03 Jul 2019 00:30:52 +0200 In-Reply-To: <20190624122710.22874-1-myles@tdma.co> (Myles English's message of "Mon, 24 Jun 2019 13:27:10 +0100") Message-ID: <87r2783w83.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36352 Cc: 36352@debbugs.gnu.org, Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Myles, Myles English skribis: > * gnu/packages/game-development.scm (solvespace): New variable and > dependencies on gnu package modules. The patch LGTM overall. Here are some comments/questions: > +(define-public solvespace-3 > + (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833") > + (revision "1")) > + (package > + (name "solvespace") > + (version (git-version "3.0" revision commit)) Why choose this commit specifically? =E2=80=98git describe=E2=80=99 returns =E2=80=9Cv2.1.rc1-570-g5df53fc=E2=80=9D, and in fact there=E2=80=99s no =E2= =80=9Cv3.0=E2=80=9D tag, so this version string is a bit misleading. The general policy is to use the latest release, but if there=E2=80=99s a compelling argument, we can use another commit; in that case, it=E2=80=99s better to have a comment explaining the choice. > + (uri (git-reference > + (url "https://github.com/solvespace/solvespace.git") > + (commit commit) > + (recursive? #t))) Is =E2=80=98recursive?=E2=80=99 needed? If it=E2=80=99s just for the bundl= ed dependencies under extlib/ that are not used anyway, perhaps we can omit it? > + (synopsis "Parametric 2D/3D CAD tool") > + (description "Parametric 2D/3D computer aided design (CAD) tool and > +constraint-based parametric modeler with simple mechanical simulation > +capabilities.") Could you make it a full sentence and perhaps expound a little bit, as per ? Thank you, and apologies for the delay! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 09:24:11 2019 Received: (at 36352) by debbugs.gnu.org; 2 Sep 2019 13:24:11 +0000 Received: from localhost ([127.0.0.1]:57571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4mJX-0002rw-4j for submit@debbugs.gnu.org; Mon, 02 Sep 2019 09:24:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4mJW-0002rj-0i for 36352@debbugs.gnu.org; Mon, 02 Sep 2019 09:24:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i4mJQ-0003Zv-HE; Mon, 02 Sep 2019 09:24:04 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=56284 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i4mJQ-0002nw-4L; Mon, 02 Sep 2019 09:24:04 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Myles English Subject: Re: [bug#36352] [PATCH] gnu: Add solvespace. References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org> Date: Mon, 02 Sep 2019 15:24:02 +0200 In-Reply-To: <87r2783w83.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 03 Jul 2019 00:30:52 +0200") Message-ID: <87v9ua96h9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36352 Cc: 36352@debbugs.gnu.org, Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Myles, Did you have a chance to look into that? (See below.) Thanks in advance, Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hello Myles, > > Myles English skribis: > >> * gnu/packages/game-development.scm (solvespace): New variable and >> dependencies on gnu package modules. > > The patch LGTM overall. Here are some comments/questions: > >> +(define-public solvespace-3 >> + (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833") >> + (revision "1")) >> + (package >> + (name "solvespace") >> + (version (git-version "3.0" revision commit)) > > > Why choose this commit specifically? =E2=80=98git describe=E2=80=99 retu= rns > =E2=80=9Cv2.1.rc1-570-g5df53fc=E2=80=9D, and in fact there=E2=80=99s no = =E2=80=9Cv3.0=E2=80=9D tag, so this > version string is a bit misleading. > > The general policy is to use the latest release, but if there=E2=80=99s a > compelling argument, we can use another commit; in that case, it=E2=80=99s > better to have a comment explaining the choice. > >> + (uri (git-reference >> + (url "https://github.com/solvespace/solvespace.git") >> + (commit commit) >> + (recursive? #t))) > > Is =E2=80=98recursive?=E2=80=99 needed? If it=E2=80=99s just for the bun= dled dependencies under > extlib/ that are not used anyway, perhaps we can omit it? > >> + (synopsis "Parametric 2D/3D CAD tool") >> + (description "Parametric 2D/3D computer aided design (CAD) tool a= nd >> +constraint-based parametric modeler with simple mechanical simulation >> +capabilities.") > > Could you make it a full sentence and perhaps expound a little bit, as > per ? > > Thank you, and apologies for the delay! > > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 20:28:48 2019 Received: (at 36352) by debbugs.gnu.org; 3 Sep 2019 00:28:48 +0000 Received: from localhost ([127.0.0.1]:59099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4wgh-0005PG-LL for submit@debbugs.gnu.org; Mon, 02 Sep 2019 20:28:48 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:37261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4wgf-0005Oy-Dy for 36352@debbugs.gnu.org; Mon, 02 Sep 2019 20:28:45 -0400 Received: by mail-vs1-f68.google.com with SMTP id q9so4066263vsl.4 for <36352@debbugs.gnu.org>; Mon, 02 Sep 2019 17:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RB/Nta5yMnFUWA+NDoTQfJ2VZOHiRUsQlQh3MZP1hqQ=; b=Ws5tFY69SCmxLXiTMnE4GK3lkeGwVoH7joR7kl+iXGW/s118vMLdhUnV8/CBrGrPU6 pS3SmfwynqLKp+8NHbIslATjxQFgc6ToWSZus0Y2pFdCxnCUCbBeAlhHkJwhpkQb6F3t 3aF66YjWoqb5bYn+M5eGk9XnahhkTnujsGjTNA08Wx8R2m1xCibbiQyL4k/g3T3nG4/E aCUxmdO1cQslk8Upsy+XbAFnf8hpz7nE9hm/a92lWV3uQpLNZLpUfnRNcIgFc+qaPyoK +o0TA0vFehWJ+f0Ujthqzx8kFXlo0eEZT/4DmB16EIFL9vh8UuTMfGBsplp5PtbgQZLG pfsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RB/Nta5yMnFUWA+NDoTQfJ2VZOHiRUsQlQh3MZP1hqQ=; b=B/gpoOeoaaSgXawW3EVIFz9TWqFOZeRCm2HkhqBuNuBez1H6KdCqe4szL0paXYfr5m uiojG5MzXiLGjtmG7JLOkyMVPp9GpENEglxjvIvwb1n3NkmWeKreLeE1TqokRLxB+X6T K8b7ncUbxthyXxizbLOgAXMGwDfMhNs5oD5lBck3hhj4nSWs0FfB/QECFJQ/x8c7khHB FsHLletK2LBmngb9mXtcFwb4EwaLnnp+bYOuwrfDHhzfipRDSB4XPafG+/6LhJDvh1hW Wsm4gXebmhrKJIr/YG5qrKtZguWOnnuVUw64catmdor4SAfxa6ICJ1XlPTDLm5LVbIRz bPMA== X-Gm-Message-State: APjAAAVxf7VfmEwSyxbH6I3Hu0P2Rriiq6DOrGUWa4h7UhpxMcURNbtE OefbZKaL1uayH7gF/bRKU9XMvjsDNIWLdS/vGl0= X-Google-Smtp-Source: APXvYqwopbkThQRbIqzkPcWnCg57kQFZuFUslqef3ea7kx7INbyrUytBAxauYqTCSSdpEz6IfClPrJThyZqAMvt9k9U= X-Received: by 2002:a67:783:: with SMTP id 125mr18087514vsh.16.1567470519820; Mon, 02 Sep 2019 17:28:39 -0700 (PDT) MIME-Version: 1.0 References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org> <87v9ua96h9.fsf@gnu.org> In-Reply-To: <87v9ua96h9.fsf@gnu.org> From: Myles English Date: Tue, 3 Sep 2019 01:28:28 +0100 Message-ID: Subject: Re: [bug#36352] [PATCH] gnu: Add solvespace. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="00000000000087a60105919b2b2d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36352 Cc: 36352@debbugs.gnu.org, Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000087a60105919b2b2d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo', Thanks a lot for your comments, sorry I hadn't replied yet. On Mon, 2 Sep 2019, 14:24 Ludovic Court=C3=A8s, wrote: > Did you have a chance to look into that? (See below.) > > Ludovic Court=C3=A8s skribis: > > > Hello Myles, > > > > Myles English skribis: > > > >> * gnu/packages/game-development.scm (solvespace): New variable and > game-development.scm? I think I put it in the wrong place. >> dependencies on gnu package modules. > > > > The patch LGTM overall. Here are some comments/questions: > > > >> +(define-public solvespace-3 > >> + (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833") > >> + (revision "1")) > >> + (package > >> + (name "solvespace") > >> + (version (git-version "3.0" revision commit)) > > > > > > Why choose this commit specifically? =E2=80=98git describe=E2=80=99 re= turns > > =E2=80=9Cv2.1.rc1-570-g5df53fc=E2=80=9D, and in fact there=E2=80=99s no= =E2=80=9Cv3.0=E2=80=9D tag, so this > > version string is a bit misleading. > > > > The general policy is to use the latest release, but if there=E2=80=99s= a > > compelling argument, we can use another commit; in that case, it=E2=80= =99s > > better to have a comment explaining the choice. > It looks as though a longawaited v3.0 release may be imminent, hence my delay in replying to your advice. I'll wait another week or two before asking if it is going to drop 'soon'. (I would have tried to justify my choice by referencing the unofficial Debian package, mentioned on the project's github page, using the master branch and calling itself v3.0.) >> + (uri (git-reference > >> + (url "https://github.com/solvespace/solvespace.git") > >> + (commit commit) > >> + (recursive? #t))) > > > > Is =E2=80=98recursive?=E2=80=99 needed? If it=E2=80=99s just for the b= undled dependencies under > > extlib/ that are not used anyway, perhaps we can omit it? > Some of them are still used (sorry I can't check which ones just now). I have trivially modified the build system so that if :recursive? is a list it only clones those submodules listed. I can find the patch later but its just a couple of lines. If this is adopted should may be rename :recursive? or add another parameter? >> + (synopsis "Parametric 2D/3D CAD tool") > >> + (description "Parametric 2D/3D computer aided design (CAD) tool > and > >> +constraint-based parametric modeler with simple mechanical simulation > >> +capabilities.") > > > > Could you make it a full sentence and perhaps expound a little bit, as > > per < > https://gnu.org/s/guix/manual/en/html_node/Synopses-and-Descriptions.html > >? > I'll try and improve this when I make a patch for the true v3.0. Myles > --00000000000087a60105919b2b2d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Ludo',

Thanks= a lot for your comments, sorry I hadn't replied yet.

On Mon, 2 Sep 2019, 14:24 Ludovic Court=C3=A8s, <ludo@gnu.org> wrote:
Did you have a chance to look into that?=C2=A0 (See below.)<= br>
Ludovic Court=C3=A8s <ludo@gnu.org> skribis:

> Hello Myles,
>
> Myles English <mylesenglish@gmail.com> skribis:
>
>> * gnu/packages/game-development.scm (solvespace): New variable and=

game-development.sc= m? I think I put it in the wrong place.
<= span style=3D"font-family:sans-serif">
>> dependencies on gnu package modules.
>
> The patch LGTM overall.=C2=A0 Here are some comments/questions:
>
>> +(define-public solvespace-3
>> +=C2=A0 (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd30328= 33")
>> +=C2=A0 =C2=A0 (revision "1"))
>> +=C2=A0 =C2=A0 (package
>> +=C2=A0 =C2=A0 =C2=A0 (name "solvespace")
>> +=C2=A0 =C2=A0 =C2=A0 (version (git-version "3.0" revisi= on commit))
>
>
> Why choose this commit specifically?=C2=A0 =E2=80=98git describe=E2=80= =99 returns
> =E2=80=9Cv2.1.rc1-570-g5df53fc=E2=80=9D, and in fact there=E2=80=99s n= o =E2=80=9Cv3.0=E2=80=9D tag, so this
> version string is a bit misleading.
>
> The general policy is to use the latest release, but if there=E2=80=99= s a
> compelling argument, we can use another commit; in that case, it=E2=80= =99s
> better to have a comment explaining the choice.
=

It looks as though a lo= ngawaited v3.0 release may be imminent, hence my delay in replying to your = advice.=C2=A0 I'll wait another week or two before asking if it is goin= g to drop 'soon'.=C2=A0 (I would have tried to justify my choice by= referencing the unofficial Debian package, mentioned on the project's = github page, using the master branch and calling itself v3.0.)

>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git= -reference
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "= ;https://github.com/solvespace/solvespace.git= ")
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit co= mmit)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(recursive= ? #t)))
>
> Is =E2=80=98recursive?=E2=80=99 needed?=C2=A0 If it=E2=80=99s just for= the bundled dependencies under
> extlib/ that are not used anyway, perhaps we can omit it?

Some of them are still used (sorry I can't check which one= s just now).=C2=A0 I have trivially modified the build system=C2=A0so that if=C2=A0:recursive?= is a list it only clones tho= se submodules listed. I can find the patch later but its just a couple of l= ines.=C2=A0 If this is adopted should may be rename :recursive? or add anot= her parameter?

>> +=C2=A0 =C2=A0 =C2=A0 (synopsis "Parametric 2D/3D CAD tool&qu= ot;)
>> +=C2=A0 =C2=A0 =C2=A0 (description "Parametric 2D/3D computer= aided design (CAD) tool and
>> +constraint-based parametric modeler with simple mechanical simula= tion
>> +capabilities.")
>
> Could you make it a full sentence and perhaps expound a little bit, as=
> per <htt= ps://gnu.org/s/guix/manual/en/html_node/Synopses-and-Descriptions.html&= gt;?

I'll try and improve this when I make a patch for the true v3.0.

Myles
--00000000000087a60105919b2b2d-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 03 05:20:04 2019 Received: (at 36352) by debbugs.gnu.org; 3 Sep 2019 09:20:04 +0000 Received: from localhost ([127.0.0.1]:59312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i54yp-0002OC-LS for submit@debbugs.gnu.org; Tue, 03 Sep 2019 05:20:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i54yo-0002Na-5c for 36352@debbugs.gnu.org; Tue, 03 Sep 2019 05:20:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i54yi-0001kO-MF; Tue, 03 Sep 2019 05:19:56 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60940 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i54yh-0002uP-Sp; Tue, 03 Sep 2019 05:19:56 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Myles English Subject: Re: [bug#36352] [PATCH] gnu: Add solvespace. References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org> <87v9ua96h9.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Fructidor an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 03 Sep 2019 11:19:54 +0200 In-Reply-To: (Myles English's message of "Tue, 3 Sep 2019 01:28:28 +0100") Message-ID: <87o901ybwl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36352 Cc: 36352@debbugs.gnu.org, Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Myles, Myles English skribis: > It looks as though a longawaited v3.0 release may be imminent, hence my > delay in replying to your advice. I'll wait another week or two before > asking if it is going to drop 'soon'. (I would have tried to justify my > choice by referencing the unofficial Debian package, mentioned on the > project's github page, using the master branch and calling itself v3.0.) Sounds good! >>> + (uri (git-reference >> >>> + (url "https://github.com/solvespace/solvespace.git") >> >> + (commit commit) >> >> + (recursive? #t))) >> > >> > Is =E2=80=98recursive?=E2=80=99 needed? If it=E2=80=99s just for the = bundled dependencies under >> > extlib/ that are not used anyway, perhaps we can omit it? >> > > Some of them are still used (sorry I can't check which ones just now). I > have trivially modified the build system so that if :recursive? is a list > it only clones those submodules listed. I can find the patch later but its > just a couple of lines. If this is adopted should may be rename > :recursive? or add another parameter? At first sight I think I=E2=80=99d keep it simple and just keep =E2=80=98re= cursive?=E2=80=99 as it is. After all, if that fetches too many submodules in this specific case, that=E2=80=99s not the end of the world and we can always delete them explicitly afterwards. I think it=E2=80=99s quite unusual to need some but= not all of the submodules. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 17:28:41 2023 Received: (at 36352-done) by debbugs.gnu.org; 20 Jun 2023 21:28:41 +0000 Received: from localhost ([127.0.0.1]:59927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBiu0-0007z4-Us for submit@debbugs.gnu.org; Tue, 20 Jun 2023 17:28:41 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:47168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBitv-0007yi-Te for 36352-done@debbugs.gnu.org; Tue, 20 Jun 2023 17:28:36 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687296515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bHLZymgEZzcUU6bRgdOB+yaKw6dlSOftFzMZ7fYVe7s=; b=iEqcOONBqzWA3vGUPAfl2ywa0oyZMDV3lyGh+/J2MEYSm4DVGsDIKU9SfA3GxEVfiVqe9R wN4OXpeNwNKCfRm0AQ0EyqwGNfGX0jgvjzvwLmj8rOStr30id+vtcYIfwD2PtOwxUR8/MA hws1lL6QWuyCDNia5Q6iLOAVbE9NfDg= To: 36352-done@debbugs.gnu.org Subject: Re: bug#36352: [PATCH] gnu: Add solvespace. In-Reply-To: <87o901ybwl.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 03 Sep 2019 11:19:54 +0200") References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org> <87v9ua96h9.fsf@gnu.org> <87o901ybwl.fsf@gnu.org> Date: Tue, 20 Jun 2023 23:28:34 +0200 Message-ID: <87ttv16cxp.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36352-done Cc: Myles English , Ludovic =?utf-8?Q?Court=C3=A8s?= , Myles English X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) We have solvespace@3.1 in guix master, closing! - Jelle From unknown Sun Jun 22 22:42:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Jul 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator