GNU bug report logs - #36343
26.2; [PATCH] `view-echo-area-messages': set `window-point' to `point-max'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36343 in the body.
You can then email your comments to 36343 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2; [PATCH] `view-echo-area-messages': set `window-point' to
 `point-max'
Date: Sun, 23 Jun 2019 09:29:42 -0700 (PDT)

`C-h f view-echo-area-messages' says this:

  View the log of recent echo-area messages: the '*Messages*' buffer.
  The number of messages retained in that buffer
  is specified by the variable 'message-log-max'.

It does that.  But one might expect "view the log of recent" to mean
make the most recent msgs logged visible.  That doesn't happen if
`*Messages*' is already displayed in a window other than the selected
one.

This definition fixes that.  It just sets `window-point'.

Hopefully you don't need an explicit *.patch to apply this fix.

(defun view-echo-area-messages ()
  "View the log of recent echo-area messages: the `*Messages*' buffer.
The number of messages retained in that buffer is specified by the
variable `message-log-max'."
  (interactive)
  (with-current-buffer (messages-buffer)
    (goto-char (point-max))
    (let ((win  (display-buffer (current-buffer))))
      (set-window-point win (point))
      win)))

This definition doesn't do anything special to make all parts of the
buffer visible - it doesn't `widen' or show any text that might be
hidden.  It just makes sure that the most recent msgs that are aleady
visible are on-screen.  I think that's probably what we want.

---

If you really think the current behavior is what users expect, and you
think it should be kept as the default behavior, then please consider at
least letting a prefix arg set the window point to `point-max':

(defun view-echo-area-messages (arg)
  "View the log of recent echo-area messages: the `*Messages*' buffer.
The number of messages retained in that buffer is specified by the
variable `message-log-max'.  With a prefix arg move `window-point' to
`point-max'."
  (interactive "P")
  (with-current-buffer (messages-buffer)
    (goto-char (point-max))
    (let ((win  (display-buffer (current-buffer))))
      (when arg (set-window-point win (point)))
      win)))

The code above (both versions) returns the window, like the current
code.  Dunno whether that's important, but at least that behavior is
preserved, just in case something depends on it.

---

Note: You might also want to consider giving users the ability
(i.e. option) to ensure that `message' itself always moves
`window-point' to `point-max' in any window that is already displaying
`*Messages*'.  Just a suggestion - not part of this bug report.

See, for example, https://stackoverflow.com/q/4682033/729907.


In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
 of 2019-04-13
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor `Microsoft Corp.', version 10.0.17134
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Message #8 received at 36343 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 36343 <at> debbugs.gnu.org
Subject: RE: bug#36343: 26.2; [PATCH] `view-echo-area-messages': set
 `window-point' to `point-max'
Date: Sun, 23 Jun 2019 09:47:22 -0700 (PDT)

A question might be whether _all_ windows showing
`*Messages*' should be handled this way.

I figured that if someone has multiple such windows
then probably she does _not_ want all to be handled
this way.

Another possibility is to give users some control
over this via the prefix arg.

Message #11 received at 36343 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 36343 <at> debbugs.gnu.org
Subject: Re: bug#36343: 26.2;
 [PATCH] `view-echo-area-messages': set `window-point' to `point-max'
Date: Sat, 06 Jul 2019 16:48:27 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> This definition fixes that.  It just sets `window-point'.

Makes sense.  I've inserted it in the Emacs trunk.

> Hopefully you don't need an explicit *.patch to apply this fix.

No, but that would be very convenient, especially if you write
ChangeLog-format change messages.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.