From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:30:51 2019 Received: (at submit) by debbugs.gnu.org; 23 Jun 2019 14:30:51 +0000 Received: from localhost ([127.0.0.1]:54090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf3W7-0007pv-1D for submit@debbugs.gnu.org; Sun, 23 Jun 2019 10:30:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:41493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf3W5-0007pn-DO for submit@debbugs.gnu.org; Sun, 23 Jun 2019 10:30:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36280) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf3W3-00043Q-Ga for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 10:30:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf3Vv-0003ld-Te for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 10:30:43 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hf3Vr-0003SM-TQ for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 10:30:37 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf3Vm-0006xO-PG for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 16:30:33 +0200 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent Date: Sun, 23 Jun 2019 16:30:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If I have the following in my Gnus dribble file (gnus-group-set-info '("nntp+news.gmane.org:gwene.org.jwz.blog.comments" 3 ((1 . 25172)) ((unexist) (seen (1 . 1032) (1044 . 5020) (5022 . 11580) (11629 . 15722) (15725 . 19758) (19774 . 25172))) "nntp:news.gmane.org")) and start Gnus, then the group buffer will then always show the same unread count as existed in the previous Gnus session. Entering the group and marking everything as read has no effect -- the group still shows the old number of unread articles. In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2019-06-23 built on stories Repository revision: abf7d0d802728e0ae8e064683eb5fb411bad911e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9 (stretch) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 11:35:11 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 15:35:11 +0000 Received: from localhost ([127.0.0.1]:54123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf4WN-0000uR-Dg for submit@debbugs.gnu.org; Sun, 23 Jun 2019 11:35:11 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:46104 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf4WL-0000uF-Nk for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 11:35:10 -0400 Received: from localhost (unknown [172.92.212.120]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 8F24FFA648; Sun, 23 Jun 2019 15:35:03 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: Date: Sun, 23 Jun 2019 08:34:57 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 16:30:30 +0200") Message-ID: <87v9wwuxge.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > If I have the following in my Gnus dribble file > > (gnus-group-set-info > '("nntp+news.gmane.org:gwene.org.jwz.blog.comments" 3 ((1 . 25172)) > ((unexist) (seen (1 . 1032) (1044 . 5020) (5022 . 11580) (11629 . > 15722) (15725 . 19758) (19774 . 25172))) "nntp:news.gmane.org")) > > and start Gnus, then the group buffer will then always show the same > unread count as existed in the previous Gnus session. Entering the > group and marking everything as read has no effect -- the group still > shows the old number of unread articles. > > > In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) > of 2019-06-23 built on stories > Repository revision: abf7d0d802728e0ae8e064683eb5fb411bad911e Would you be willing to build an earlier emacs, from before c1b63af44, and see if this is something I did? Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 11:41:28 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 15:41:28 +0000 Received: from localhost ([127.0.0.1]:54130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf4cS-00014Z-D1 for submit@debbugs.gnu.org; Sun, 23 Jun 2019 11:41:28 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf4cQ-00014O-Lf for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 11:41:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf4cM-0007b1-Fn; Sun, 23 Jun 2019 17:41:24 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEXSzs7///0aEBIIAgP/ //v+/fr///76+PV9dXb///z///85LzKln59cUlS4kUT6AAACXklEQVQ4jXXUzWsaQRQA8LGHNFhz eGAHukdzEcSLeylIDoWkEG9CU4gn99AJDAYiNAkNLVgCRfJxCLQHPbmHjOWhl3jLRljoRdLtJV5K E/+XvpldrRo7yMrOb97MvDe7y/YbjQsOAoRwBHCHfkIIdDbYB5C4oLnsPQD9LQSBCJcl+Y6jFNKN 4lU4lajU/I8+Y8xPsPgUKFEOgkQiSDDfD2YA1A7FqaltKFZ1NAhnqlOGQONcsKZBGCjqvfGZaXAC 1Bw+l0gELowLMMmjxE3//OJRhEtVnFuEQAmpOO14LErqnRAkzoIDrvbqT0vYYuwIv997NwZW7FEV xKd87UB2TjO3uJvKvDTwLKdhOXdTlZ1emsDOpEOwswQ/c/kl7PT6GlJhBHVVuTr2MnGsDLMa7DXK 4y2u1OtVS/2ojeJY/vUQx67taShQbR10xXHtCYE+p24YUTB7t9TAXw6PCDtB4E8grPVMdTW4Fs43 xZrYPjzcfyQ6ojL6fcaxrauBe3ShgUchDPMPIMs5O47qPnWC3Yx3TQkWqGgpDXl7STp3qyeU4JWG EoGdJkitxqwIslHElb0GcueuF+MwTH3RRfxD0MSu5/VBts5PYwCe9xl3+6NrAy3KFGR7UI+hGgS3 WAnookFXZCqD6IRp8cWph7VaBM1HXf8BenTkQqBZzRM2OY8pcCYgZ6dyuBDjE1T/AAVQc9hrM15H u0ZdBNPYJhS3Acy7YD4Dru59AUlWVOEI4K55qaK7JHsFyTHoFWAC24319U240Deu5egB+q2D52zL tDeNja2vjW+HZkP663L5FwseSvDlny9aAAAAAElFTkSuQmCC Date: Sun, 23 Jun 2019 17:41:22 +0200 In-Reply-To: <87v9wwuxge.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 23 Jun 2019 08:34:57 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Would you be willing to build an earlier emacs, from before c1b63af44, > and see if this is something I did? Sure; but I'm pretty sure that this started happening after the hash table rewrite, so perhaps it's just less work to try to debug it now. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Would you be willing to build an earlier emacs, from before c1b63af44, > and see if this is something I did? Sure; but I'm pretty sure that this started happening after the hash table rewrite, so perhaps it's just less work to try to debug it now. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 12:35:43 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 16:35:43 +0000 Received: from localhost ([127.0.0.1]:54298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5Sx-0002hF-EC for submit@debbugs.gnu.org; Sun, 23 Jun 2019 12:35:43 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:47896 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5Sv-0002gz-FB for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 12:35:41 -0400 Received: from localhost (unknown [172.92.212.120]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 657B3FA648; Sun, 23 Jun 2019 16:35:34 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> Date: Sun, 23 Jun 2019 09:35:23 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 17:41:22 +0200") Message-ID: <87mui8uuno.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> Would you be willing to build an earlier emacs, from before c1b63af44, >> and see if this is something I did? > > Sure; but I'm pretty sure that this started happening after the hash > table rewrite, so perhaps it's just less work to try to debug it now. :-) :( Okay, give me a day or so... From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 14:26:02 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 18:26:02 +0000 Received: from localhost ([127.0.0.1]:54565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7Bi-0000oy-DI for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:26:02 -0400 Received: from mout.gmx.net ([212.227.15.19]:35783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7Bf-0000oN-6p for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 14:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1561314341; bh=nX6P497U285Vc4REPYnKdeGZdW7vsXvP3zEIL0bh2F8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=FLgJdxLwDQwe9WdRPgxCVrl7UqvR9c2tddiDBTuh5558dbl1iOvwASpsatqMLkskc dIlJY8ZmlLiizQoUVUddl40AdnpHrOEetTAN0gEnFfUtQd6CEKD58ca6MKukAcIQKN 640eEzKERbmtULXgEZkEcAqZd0ZD5SdAsfVgD7DQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from dellcorei5dias ([46.177.203.249]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MK3W0-1hsnmd2RrS-00LWac; Sun, 23 Jun 2019 20:25:41 +0200 From: Deus Max To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> Date: Sun, 23 Jun 2019 21:25:35 +0300 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 17:41:22 +0200") Message-ID: <87mui8kvkw.fsf@aia00054aia.gr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:K/2uIL24diSYXvj+otUkjXsIsyi6k+B+3a4jvr5yHO9THjISPsq pj/pgp/RbBcWhkOwOSdMfDJiVT4jMQ/jcICN7q+LPofOg/hgabRRGf5Bsfjt3Xh29rcLGJr BlzASpUv+9x6Rqtk4w34j+65v9nIAl7DlKXn6sBl+FTKjJxFP/BwCb9NWDxYi0ZnGjZwk6N KeYa5vJtnWVnHbOJBUkAQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:36YUr/R+jD8=:PWAU0E9K0z4w6tJF1KAAdN xYMe4Jn4hWmVInAhCnlQBi3lhPDRidVAQqNaBs9iW4FDrN4cJV5DRjcas4z+q/dNrPvJiwrHs DsOpt2fk/zxmPTu5ZDCygbKdtA+MZDgI9xAh/umafMcCMnioV8p48lGhOoLaWO2AH0ji5Iycv ynWUo1C5Kv8WQmX2zeKn7eOoRWxvZXMBmdaJ1sp9gunO++b0n4vCReWUrH4n8rLAHAsJi5oKk QpoBK8qcJJITaOTXdCMTpv8xv388LocQC7xBiFBnZv24nZQTQRsgg+d/wkqvxqb+nqYfxNM1u TqGtQ3qwlkigIefq55HwlWkbQGeCXAt2eKdJdCYJy30koOIpwpAi+B3roV4yL4DTx4CCEX3DZ JLECkkxR1ceZKY1U3j+xa+RqH8PUSgQRH2tZBg+gkAIGcLnL3v6VtjQij2VpFyp2R0tKNDuVh +7WpKsHhNhUUWeHTBTBrrtJFd5EXwoaWaPp9079jmYCh2YFss9YkCdTdWS8YypxtEP0iSZjo3 BfpXNQNyIQrxGBOuenEOzS3BBfZ1kj6219yCUEq5G+qWbzfinIB4H/3mXKuQTUqbx4V2Sc+C/ GV5YI6gClwGH64471C8RTLlHOtCujwFKHypSaUO79kWOTErq1s1trSLtM1cZFspzbABlc/pOQ eNOCoA65JVRZ3xqeOyyRjmAQR+rDofslDUsjgLc6HivhrKhffeW6K2POeJoQSQWQspYu3THxb yHGSd6rNCwpWcCe3u/tvlVEn99pFSgSmqryBqMyL8a5gSNa3f4t1tzNd+3YKlYpMh0HLeyXtE LVtpBhWmFcS52ZXVWyiRcokmLFS0bVbb5+v0QDLw3VUmBfxjplAmPmiY3S7kT24WQP9CmPv7u cfj/e9DKx5eV655MzQca91JolHbchqyMVHw2DXUWDnrkQ+KdAWm6iAkVnrzfwlIsBytOm1HtR MrY0vNB7GBPLHnk/IYuRIgxS9TD60l+zcgVXsY895sNF3b0AYM8bG X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: Eric Abrahamsen , 36341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 23 2019, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> Would you be willing to build an earlier emacs, from before c1b63af44, >> and see if this is something I did? > > Sure; but I'm pretty sure that this started happening after the hash > table rewrite, so perhaps it's just less work to try to debug it now. :-) What was the hash-table rewrite and when was it ? Is there any info on it ? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 14:38:44 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 18:38:44 +0000 Received: from localhost ([127.0.0.1]:54614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7Nz-0003Qn-QA for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:38:44 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:51830 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7Nx-0003QW-7Q for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 14:38:41 -0400 Received: from localhost (unknown [172.92.212.120]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BDBAEFA05D; Sun, 23 Jun 2019 18:38:34 +0000 (UTC) From: Eric Abrahamsen To: Deus Max Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> Date: Sun, 23 Jun 2019 11:38:28 -0700 In-Reply-To: <87mui8kvkw.fsf@aia00054aia.gr> (Deus Max's message of "Sun, 23 Jun 2019 21:25:35 +0300") Message-ID: <87fto0tae3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: Lars Ingebrigtsen , 36341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Deus Max writes: > On Sun, Jun 23 2019, Lars Ingebrigtsen wrote: > >> Eric Abrahamsen writes: >> >>> Would you be willing to build an earlier emacs, from before c1b63af44, >>> and see if this is something I did? >> >> Sure; but I'm pretty sure that this started happening after the hash >> table rewrite, so perhaps it's just less work to try to debug it now. :-) > > What was the hash-table rewrite and when was it ? > Is there any info on it ? It started with the commit I mentioned above, included several patches to master, and (I hope) will be concluded with the scratch branch you helped me test. I'm pretty sure I just figured out what's wrong with the dribble file, but I'm setting out on a 80-mile bike ride now, and will fix it if/when I have survived that. Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 14:40:20 2019 Received: (at 36341) by debbugs.gnu.org; 23 Jun 2019 18:40:20 +0000 Received: from localhost ([127.0.0.1]:54618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7PY-0003Tx-7p for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:40:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:45338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf7PW-0003Tn-RM for 36341@debbugs.gnu.org; Sun, 23 Jun 2019 14:40:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf7PS-0000cg-SU; Sun, 23 Jun 2019 20:40:17 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEULCwsHBwc0MjNRTU+A fH0ZGRrSzc8QEBDiLqT7AAACS0lEQVQ4jV2UQW/cIBCFsaLKV0gPubZglGvL4Oy1iunmbhv5Gqkr crW8sfj7fQO73TTPF4uPNzMMHosv8aY9LhlqV5F30d7Wc9EqIIAHvC87sRzRRPTtA7iqbIYQKgpZ 19o1t0I0jRCqOKJQa8YjsCpk0zRyVaItDiXyegnRqOJQslS16BwtTDnvyL7R5sNh9yEITVqbuKDa MQzH93Q+prf5mJJwpONUjjEzOG3H9DoHAO2tnSwD4+npnADeuuLwzo49A/LkZ4BjBX1HeurRpnGA Y745ekPWOBjORMb/B4zWBIA20QWYVADqIhsXbmN3PnG5UwVkXHeIpcF+C+yY6jkg08eRu+5ruTfg +jg5zSBwqLEAAzBcQPd++geey+UBaEemm09bSq/V4WEY+uVOO1MAehUr8H4Ih2Vj4Eu5v8Zr8hB6 ADux4xP4nTdcC1XHSy1Xc5kDuajNxVGB1Xb0aRic1Vr7dz55BTFaEwLud4TjaSo5qiM6fxqw2yLH E06eLi3p47M/EYOo+Wqnj+APAwQzoUtzunwlADRxKB31hKgFpAq6x20guzPzQ3cFdnfnweaRUHDe jfYAXXXQYsLgljwacst9COGlgmV7zJmPgjGLegQ4VICPGWQfPZAQ7UjBHBl8UKNYmITM81FGhiXV FbSrAni4TJ4USl0djWrhuIGmejBUkkNdRxVDpxoJBCvnaHPmPGt1SdHAKtu9gKUWcNfRjxJQtnnn HLyKfeLO008pkaQCCcBhlfxq3PdSF/8TYsn6SRV8Xq1gj38BCRUOP4pOIfkAAAAASUVORK5CYII= Date: Sun, 23 Jun 2019 20:40:14 +0200 In-Reply-To: <87fto0tae3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 23 Jun 2019 11:38:28 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > I'm pretty sure I just figured out what's wrong with the dribble file, > but I'm setting out on a 80-mile bike ride now, and will fix it > if/when I have survived that. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > I'm pretty sure I just figured out what's wrong with the dribble file, > but I'm setting out on a 80-mile bike ride now, and will fix it > if/when I have survived that. Good luck! -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 18:30:13 2019 Received: (at 36341) by debbugs.gnu.org; 28 Jun 2019 22:30:13 +0000 Received: from localhost ([127.0.0.1]:43150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgzNl-0006cM-BQ for submit@debbugs.gnu.org; Fri, 28 Jun 2019 18:30:13 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:40730 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgzNi-0006bD-4j for 36341@debbugs.gnu.org; Fri, 28 Jun 2019 18:30:10 -0400 Received: from localhost (c-98-225-22-201.hsd1.wa.comcast.net [98.225.22.201]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 83F5AFA023; Fri, 28 Jun 2019 22:30:03 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> Date: Fri, 28 Jun 2019 15:30:02 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 20:40:14 +0200") Message-ID: <874l49s5qt.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 06/23/19 20:40 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> I'm pretty sure I just figured out what's wrong with the dribble file, >> but I'm setting out on a 80-mile bike ride now, and will fix it >> if/when I have survived that. > > Good luck! I survived! But I'm having trouble reproducing this. Can you give me a more basic recipe, like "mark some messages read, exit with `Q`, restart"? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 29 06:22:50 2019 Received: (at 36341) by debbugs.gnu.org; 29 Jun 2019 10:22:50 +0000 Received: from localhost ([127.0.0.1]:43496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhAVO-000145-48 for submit@debbugs.gnu.org; Sat, 29 Jun 2019 06:22:50 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhAVM-00013u-JE for 36341@debbugs.gnu.org; Sat, 29 Jun 2019 06:22:49 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhAVH-0006zW-My; Sat, 29 Jun 2019 12:22:46 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXoDwD+XQD+VQD+QwD+ lwT+TAD+OAD+awKIWcxFAAACcklEQVQ4jW1TQW4bMQzkKXeqNXQWDcHnLiG9wEDOlsD4GlSwet5i AX2/o7XbpEkEY9fgkBpyOEvb+b/zvI41uNh/0of44BCLHHt7B2zjeQx2tbaU+43eJY8VcbHc23Fe 9SBB2DmOtWrvTXHVeIRxS5RoyAeQUTG2f4CJmOZZYOkHjeftDNYVrFrtZRZ01XKlMTaEVw4c0Yvu QH65ehr7+c3sijZT1Z61uNNGvM58Fo+rdKmaVRP7dSPh4RgIc+yKCsC34DdU8GBxIQRXkdy09ZzC GGcS71EiwQmGSwr2qtcdCH4VJxc8akqIt6wntAoAt0OiVSr61zrn8+iTXCxewCASNZnOCRNCg4LI 2LsKUrVY1taSMHsqIbAbcmD5ltErxNW2SPQELfyKLbiAdkuFurlLcifi4udwBSutfdllT1IPngy9 CrtDMFMzqxnIYrKRLSVWzIcmLLkdKRbDRjHPHla/8upO7DHRUiATgHq9K49dDT+fkJUhYtICpSAJ SynCK56gRUUyWCDEiytiJgU9WBHnz2QJAdMSIIlOjcvBPBxCqQi81FKxpHZBsnOBJ9Bsegb6Wa0L 5ImGeWE2UiuxwRgZu0iogAar3wFNsefW5071EgTU2BMAaH2cnmy/5HCcvsZvmhMAcqfJNNUENcF+ 2SsMyFwnbrtVLzDMzn2mCAkN2dOEcprxMXagwZAYEF7r2YQDPpI7kG+p1NzAg69lqiXhDvQb5kNT oO9wCbqVOwfMlLU/Dng0Fd4H7G/n8b+lOeFfgOiJiPrrjmAtG71F6fF6hRXjdyTRx/PUlL/T5zg9 dazqc3hSlZP/GrDrIP0SWbY/XrkPcDa+1HsAAAAASUVORK5CYII= Date: Sat, 29 Jun 2019 12:22:43 +0200 In-Reply-To: <874l49s5qt.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 28 Jun 2019 15:30:02 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: >>> I'm pretty sure I just figured out what's wrong with the dribble file, >>> but I'm setting out on a 80-mile bike ride now, and will fix it >>> if/when I have survived that. >> >> Good luck! > > I [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: >>> I'm pretty sure I just figured out what's wrong with the dribble file, >>> but I'm setting out on a 80-mile bike ride now, and will fix it >>> if/when I have survived that. >> >> Good luck! > > I survived! Yay! > But I'm having trouble reproducing this. Can you give me a more basic > recipe, like "mark some messages read, exit with `Q`, restart"? First save with `s' so you have a "known good state". Then enter a group (that has some unread articles), mark everything as read (with `d'), `q' out of the group and then `Q' out of Emacs. You should now have a dribble file. Then say `M-x gnus' and answer `y' to the question about whether to read it. The group where you marked everything as read should now be displayed in the group buffer with the same number of unread articles as it had before you entered it the last time. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 15:46:21 2019 Received: (at 36341) by debbugs.gnu.org; 3 Jul 2019 19:46:21 +0000 Received: from localhost ([127.0.0.1]:50121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilCu-0000Cy-Jc for submit@debbugs.gnu.org; Wed, 03 Jul 2019 15:46:20 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:55708 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilCs-0000Cl-Et for 36341@debbugs.gnu.org; Wed, 03 Jul 2019 15:46:19 -0400 Received: from localhost (unknown [205.175.106.185]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 10D25FA01C; Wed, 3 Jul 2019 19:46:10 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> Date: Wed, 03 Jul 2019 12:46:09 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 29 Jun 2019 12:22:43 +0200") Message-ID: <87wogykike.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >>>> I'm pretty sure I just figured out what's wrong with the dribble file, >>>> but I'm setting out on a 80-mile bike ride now, and will fix it >>>> if/when I have survived that. >>> >>> Good luck! >> >> I survived! > > Yay! > >> But I'm having trouble reproducing this. Can you give me a more basic >> recipe, like "mark some messages read, exit with `Q`, restart"? > > First save with `s' so you have a "known good state". Then enter a > group (that has some unread articles), mark everything as read (with > `d'), `q' out of the group and then `Q' out of Emacs. You should now > have a dribble file. Then say `M-x gnus' and answer `y' to the question > about whether to read it. > > The group where you marked everything as read should now be displayed in > the group buffer with the same number of unread articles as it had > before you entered it the last time. Man, this is killing me. I've narrowed it down to: - If a dribble file is present, "g" (including gnus restart) ignores the dribble data, but "M-g" honors it. You can bounce back and forth between correct and incorrect unread counts by alternating "g" and "M-g". - The dribble file is *only* eval'ed at startup time, which must mean that there are good and bad "versions" of group info data floating around, and these two commands access different versions. - Only goes wrong for nntp groups - Once you hit "s", everything is fine (and the dribble file is deleted). - The code appears to be confused not about which articles are read, but how many/which articles exist in the group. Both "g" and "M-g" will eventually arrive at `gnus-get-unread-articles-in-group', and in the "g" case the info and active numbers are already wrong at that point. My current best guess is that, in the "M-g" case, the code will issue a 'request-scan call first, which updates the "real" active numbers for the group. nntp has no `nntp-request-scan' function (while nnimap, nnmaildir, etc, do), which might explain why the bug only shows up for nntp. So then the remaining mysteries are why does "s" clear it up, and what in my code changes could have caused this? Since I was mostly messing with the hash tables, I have to assume that data was supposed to be stored in some table, but isn't being retrieved correctly. Anyway, I'm just thinking out loud, I know what the next debugging steps are. I found another minor dribble-related bug, and will push a fix for that in a bit. Eric From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 09:43:23 2019 Received: (at 36341) by debbugs.gnu.org; 4 Jul 2019 13:43:23 +0000 Received: from localhost ([127.0.0.1]:50594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj21D-000217-LH for submit@debbugs.gnu.org; Thu, 04 Jul 2019 09:43:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj21B-00020y-Lq for 36341@debbugs.gnu.org; Thu, 04 Jul 2019 09:43:22 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hj217-000295-23; Thu, 04 Jul 2019 15:43:19 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUUDAwoFReFOjcMBgXL a11aJiaNjLxJAAACWUlEQVQ4jW2UTZLjIAyFRdzZQ9I+ACrYkya5gErsByrc/yrzhJ2ezbBwEj7r /ymU5/8Od+rh9xBO8PZ0+BEIXz05d9yc931dE115zk6zw0nPhw+6E23llThFx8zzzZkj7j0stlpf SbTvg7uB0UK4F7pXnBcL9zBymCP3GyzqAejFKr3f3sqD4y06XwgAj2tSiXlX4cSTo+VDd4f8f1S1 z5s2zYgUCU7I6qoPgDiSzozMJNKGnCyz+jJwU0UOcwCgbICwLZAB9r5PWKw64GqriCE5qc4+DFjY FWMDyG/VNnKbSaJ3ZzsRXKZ5w+uDrSWejuBPFRjoxK0Bd4KtPoUBxABOXB1fA3pKhkGbuE3MaOKq I5jFAoeBtjU/PGr9kbFqx7AZL5gj2KC9T02W1LDnB6x5fElS1uMIgIlhgYsMSSdIZvEBP9r1BHIA f7rS+O/+1xXV8mVNZ3PDegBH922BfLN32Vp8Ar8VAMkXSSyT9QSIAVmVi8SLKMc9fYApERZX7ReR HMZpYVn5ZQHABlZibYnbwGOX8IX27XwAt3QF4K7ZfzNDcav0tjbFLzB9GmnaFCHG5lcTIRK69l1t B8xgJIsBUACcfwuPbCESf+owCxeElZseIJ51bIXctwjmkFYTpS9N+WWBzYBurVtJJnRFZY2WnCmk oTzMPs9usl3pYlBhQM8I8G69m9SOAqH2ncPOjWeK+/TwUsyi0EsCFjPnjP3csfFn5Q96NfdnH4iD hZsWoSwQ6IKVQXQs827/CweAN+ixFnwn6wI+EdX2/FFdLXX9sNV+4B5x/wKuJbN8Ljru7QAAAABJ RU5ErkJggg== Date: Thu, 04 Jul 2019 15:43:16 +0200 In-Reply-To: <87wogykike.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 03 Jul 2019 12:46:09 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > So then the remaining mysteries are why does "s" clear it up, and what > in my code changes could have caused this? Since I was mostly messing > with the hash tables, I have to assume that data was [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > So then the remaining mysteries are why does "s" clear it up, and what > in my code changes could have caused this? Since I was mostly messing > with the hash tables, I have to assume that data was supposed to be > stored in some table, but isn't being retrieved correctly. Yeah, that would also be my guess... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 15:24:35 2019 Received: (at 36341) by debbugs.gnu.org; 5 Jul 2019 19:24:35 +0000 Received: from localhost ([127.0.0.1]:53796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTow-0006aE-JR for submit@debbugs.gnu.org; Fri, 05 Jul 2019 15:24:34 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:36630 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTot-0006a0-35 for 36341@debbugs.gnu.org; Fri, 05 Jul 2019 15:24:32 -0400 Received: from localhost (67-40-27-198.tukw.qwest.net [67.40.27.198]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 329ACFA01D; Fri, 5 Jul 2019 19:24:24 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> Date: Fri, 05 Jul 2019 12:24:22 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 04 Jul 2019 15:43:16 +0200") Message-ID: <87tvc0e13t.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 07/04/19 15:43 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> So then the remaining mysteries are why does "s" clear it up, and what >> in my code changes could have caused this? Since I was mostly messing >> with the hash tables, I have to assume that data was supposed to be >> stored in some table, but isn't being retrieved correctly. > > Yeah, that would also be my guess... Got it: when `gnus-group-set-info' reaches: (setcar (nthcdr 1 entry) info) Ie, it actually does the setting of the info based on the dribble file, that change is made in `gnus-newsrc-hashtb' but not `gnus-newsrc-alist'. "g" uses the alist, "M-g" uses the hashtable. So that explains that. I don't know why that happens, given that the entry in the hashtable and the alist are identical lisp objects, or at least they are everywhere else. But at least the solution is in sight! Eric From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 08:06:42 2019 Received: (at 36341) by debbugs.gnu.org; 6 Jul 2019 12:06:42 +0000 Received: from localhost ([127.0.0.1]:54328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjSk-0002ej-HS for submit@debbugs.gnu.org; Sat, 06 Jul 2019 08:06:42 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjSh-0002ea-UO for 36341@debbugs.gnu.org; Sat, 06 Jul 2019 08:06:40 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjjSd-0004In-Dk; Sat, 06 Jul 2019 14:06:37 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEXSSAvtrQn64gfliQpM AAFlAQX8KfDUAAACYklEQVQ4jVWUTZLcIAyFhTW9t+ACBi4gocx+qmLvnerx/a+SJ9ydqWjRdvPx kNCP6Zp2UhIpTo/5b4fR9b3vx8m5wUSUAnwHiJ+LZWutVM9FsXAEoVgnH320msXiNCxcExwnuayt FnfDWS9JAO1SuOYq3UyJP6cE4FQS8p4LTjIp5FNC++FKzb1KNbHUE/EvSAB+u5bk0nM3aMzVFcdf tLOze7Eq3n0rvGix74j0gL9F3bqP5mI1E2mcRV+FaDHGDVovvoqyF8R10FcnN0+CgEZei5Grxq3p +WCp/ClVJMvwwU3dIyVP7MbV/kQW64JEFskagIs1RPRpUIyCpEjN6wQiHvYw8Yqw3LP0jwkGkgfX ynd+JbeCDFOybD1Xa3BSM2qFN5ug1DwQUJs1BJDWUgDWUqGWdlu8txFgSVY0bW9Fym1tPBVMRIMS LSttJInSSstUrDQSUQqujFde1xts2G1EnFd62/SRlFmdCUVxfaLkjj0TxJbHeZ50nmjI+SYByBBO bnkmsbUuKJhOUMfM68i9Ztu2Vp3rBHzfbXndj3jUHp14ogIe/cCoqduKHu7bGWCprb/yAdUW7rZQ EEB9gxx7ZNGoB6XaXnkKhSCuRhMwVsYNRhuoc88xNHRS+6cYIaq9z/b5ovw/kBL32+mgpf3YyK3q HD/anyHBrdE2MynI/h4tGnMzV2YCelUuHzc4SDGDcZka48wlXKPbMWooQZRhGp7XDTBwUdTXsqk+ wjUm6jr2WJptGqM5PxUYWzyvYxJDG4XwFgBcByr6Y7eHCebH5+WDHvdBb4AnDuOXgyMW/gKo5ab4 Ov9kXgAAAABJRU5ErkJggg== Date: Sat, 06 Jul 2019 14:06:35 +0200 In-Reply-To: <87tvc0e13t.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 05 Jul 2019 12:24:22 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > I don't know why that happens, given that the entry in the hashtable and > the alist are identical lisp objects, or at least they are everywhere > else. But at least the solution is in sight! Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > I don't know why that happens, given that the entry in the hashtable and > the alist are identical lisp objects, or at least they are everywhere > else. But at least the solution is in sight! Great. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 07 19:56:50 2019 Received: (at 36341) by debbugs.gnu.org; 7 Jul 2019 23:56:50 +0000 Received: from localhost ([127.0.0.1]:57574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkH1V-0005qj-SN for submit@debbugs.gnu.org; Sun, 07 Jul 2019 19:56:50 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:34930 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkH1T-0005qV-AJ for 36341@debbugs.gnu.org; Sun, 07 Jul 2019 19:56:48 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id C3498FA02D; Sun, 7 Jul 2019 23:56:38 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> Date: Sun, 07 Jul 2019 16:56:36 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 06 Jul 2019 14:06:35 +0200") Message-ID: <87sgrhz9e3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> I don't know why that happens, given that the entry in the hashtable and >> the alist are identical lisp objects, or at least they are everywhere >> else. But at least the solution is in sight! > > Great. :-) I think it has to be done the ugly way -- setting the hashtable and alist separately. The problem (I write this more as part of digesting the issue than anything else) is that the alist is full of elements that look like '("group" 4 ((1 2 3) (4 5 6))), whereas the corresponding value in the hashtable looks like '(25 ("group" 4 ((1 2 3) (4 5 6)))). The alist element is `eq' to the `cadr' of the hashtable value: they're the same list object. If you reach inside that list and change values (ie set 4 to 7), they remain the same list, and the change is reflected in both hashtable and alist. If you replace the entire ("group"...) list, in the hashtable, it is no longer the same object as that in the alist, and you get divergence. This seems sensible in hindsight, but took me quite a while to figure out. I think `gnus-group-set-info' is the only place that happens, so it isn't too terrible to just explicitly set both hashtable and alist in that function. I've attached the commit that does that. My plan for avoiding this class of errors in the future is to change the representation of Gnus groups from lists to EIEIO objects. Then `gnus-newsrc-alist' would merely be a disk serialization format, and the hashtable would be the source of authority. That would also make the "dummy.group" unnecessary. But let's see if I get there, and if the changes are accepted... Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-sure-gnus-group-set-info-sets-both-the-hashtabl.patch >From c0b8589b1686d8488b4765783536217b7bb77b6c Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sun, 7 Jul 2019 16:25:14 -0700 Subject: [PATCH] Make sure gnus-group-set-info sets both the hashtable and alist * lisp/gnus/gnus-group.el (gnus-group-set-info): Apparently this method of updating the group info will only apply to the gnus-newsrc-hashtb, not gnus-newsrc-alist. Do the alist explicitly. --- lisp/gnus/gnus-group.el | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index ea695aaa97..2668e4fb7c 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -4506,7 +4506,14 @@ gnus-group-set-info (when (and (not (eq (car entry) t)) (gnus-active (gnus-info-group info))) (setcar entry (length - (gnus-list-of-unread-articles (car info)))))) + (gnus-list-of-unread-articles (car info))))) + ;; The above `setcar' will only affect the hashtable, not + ;; the alist: update the alist separately. + (push info (cdr (setq gnus-newsrc-alist + (remove (assoc-string + (gnus-info-group info) + gnus-newsrc-alist) + gnus-newsrc-alist))))) (error "No such group: %s" (gnus-info-group info)))))) ;; Ad-hoc function for inserting data from a different newsrc.eld -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 12:22:21 2019 Received: (at 36341) by debbugs.gnu.org; 8 Jul 2019 16:22:21 +0000 Received: from localhost ([127.0.0.1]:59374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWPF-0002Ke-3i for submit@debbugs.gnu.org; Mon, 08 Jul 2019 12:22:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWPA-0002KP-Ux for 36341@debbugs.gnu.org; Mon, 08 Jul 2019 12:22:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkWP6-0003HL-KY; Mon, 08 Jul 2019 18:22:15 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUCDDPo6NwQG0ALFTsA Bi3+/u4GEDY+R2UazpW6AAACZklEQVQ4jYWUQW/bMAyFCTlQzj0IuXpUZ181qVCuxmLk7oPhq2IX 6rVzmunv70lxtw4bNgaGDH0mH8lQoodhUOMw/mGk/tz7D3hQGX3Aw/2dmLlNKT3AxuGQDqmYGqnP tuuqGPfjtOs3+7yBYl/H6Smvkvb+d6Am5/t9wuv500hdiPE5xFOIs5qO6bF9eez77ksGPhLgBt5S egO4jHTW1lpttbazGub18bpu4KPGYNmIFqmdEerEPLN2FosazHN3TLwroFuiW5bFOWcBeseJeScR qotxwQ+WPSTbdLVPFdI9QxptwQOPWnznlrmWCNVTsR1JAVA1dmVuMjizZfhoLADGaG64yhpnSDu7 aOetmsyTEfzKp03cOY+sFoAmaAFf2VxKqDULwtTExPPKwmiAEwpAo0q6E1dNvLJ4nS+l8pyry+lm EFamq8gaqMNtWR1YNIGbijkDHzeDBz4Irq5YbHVwebJ4srqx87Et6cq7QwXxNrkgAh3TReVeZXnH 1qqDrT0JQ41+GUliV5fEIO6pocWQkceRKJZYstRhgiG/gRP/NLSEsGsoZtDdpcO9V1STDxSpLVOC At1dI4OAaaJjqcOWOnQJVUuTwYuijqSUIbcR4hq6MSIUwPld2ubKo8FH+KePahP3Po/PpGUtKYea 4eFcg3lz7Fz2qKtfwOp7D7UaWCNOQCiAvoN+Hh+SAGxFTdYUj/vwoI76NvB+5dC5uRbwiKH0ffHx NmixdvCvwpKBlNFXfvHhNukYUBAiO1XOhw8aUnQbXsu45gOq6DmfReZyuIf0LW2mKJ/893vh4/Xx r7vk7+AHYDoITYamAOAAAAAASUVORK5CYII= Date: Mon, 08 Jul 2019 18:22:12 +0200 In-Reply-To: <87sgrhz9e3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 07 Jul 2019 16:56:36 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > I think `gnus-group-set-info' is the only place that happens, so it > isn't too terrible to just explicitly set both hashtable and alist in > that function. I've attached the commit that does that. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > I think `gnus-group-set-info' is the only place that happens, so it > isn't too terrible to just explicitly set both hashtable and alist in > that function. I've attached the commit that does that. Sounds good -- please apply. > My plan for avoiding this class of errors in the future is to change the > representation of Gnus groups from lists to EIEIO objects. Then > `gnus-newsrc-alist' would merely be a disk serialization format, and the > hashtable would be the source of authority. That would also make the > "dummy.group" unnecessary. But let's see if I get there, and if the > changes are accepted... The whole point of that awkward structure is to allow inserting/removing/updating groups from the list-of-subscribed-groups as an O(1) operation. Updating is still fine as O(1) with just a hash table, but without the point-at-the-previous-element list, you can't remove the elements, or add new elements before the group, as an O(1) thing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 13:29:33 2019 Received: (at 36341) by debbugs.gnu.org; 8 Jul 2019 17:29:33 +0000 Received: from localhost ([127.0.0.1]:59421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXSG-0004kH-Vp for submit@debbugs.gnu.org; Mon, 08 Jul 2019 13:29:33 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:44962 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXSD-0004k3-AL for 36341@debbugs.gnu.org; Mon, 08 Jul 2019 13:29:30 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1113EFA02D; Mon, 8 Jul 2019 17:29:18 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> Date: Mon, 08 Jul 2019 10:29:17 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 08 Jul 2019 18:22:12 +0200") Message-ID: <878st8zb82.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 07/08/19 18:22 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> I think `gnus-group-set-info' is the only place that happens, so it >> isn't too terrible to just explicitly set both hashtable and alist in >> that function. I've attached the commit that does that. > > Sounds good -- please apply. Cool, will do. >> My plan for avoiding this class of errors in the future is to change the >> representation of Gnus groups from lists to EIEIO objects. Then >> `gnus-newsrc-alist' would merely be a disk serialization format, and the >> hashtable would be the source of authority. That would also make the >> "dummy.group" unnecessary. But let's see if I get there, and if the >> changes are accepted... > > The whole point of that awkward structure is to allow > inserting/removing/updating groups from the list-of-subscribed-groups as > an O(1) operation. Updating is still fine as O(1) with just a hash > table, but without the point-at-the-previous-element list, you can't > remove the elements, or add new elements before the group, as an O(1) > thing. Okay, I get that. But I wonder how important it is that add/delete operations be so efficient? Does subscription/unsubscription happen so often that it needs to be fast? As for sorting, in current master code sort-order is kept in `gnus-group-list' (when topic mode is off) and `gnus-topic-alist' (when it's on), so we're already sorting using plain lists of strings. In fact, right at the moment, there's already no need for the ordering in `gnus-newsrc-alist'. All of the "(while (setq info (pop newsrc))" loops could be replaced right now with "(dolist (g gnus-group-list) (setq group (gnus-get-info g))" Eric From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 13:37:48 2019 Received: (at 36341) by debbugs.gnu.org; 8 Jul 2019 17:37:48 +0000 Received: from localhost ([127.0.0.1]:59436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXaF-0004zr-Op for submit@debbugs.gnu.org; Mon, 08 Jul 2019 13:37:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXaE-0004zj-7t for 36341@debbugs.gnu.org; Mon, 08 Jul 2019 13:37:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkXa8-0003lp-Ok; Mon, 08 Jul 2019 19:37:43 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> <878st8zb82.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUAAAMeGi0AAAQGBhAD AwlaRlGUgGzSwZsCAgcBAQUQrQAvAAACZUlEQVQ4jWWTP2/bMBDFCbRDvVVIlXQMOsWjQQ3JGIgF qDEoKHcNUpMfwKi4NjAHcjNcDbxv23eilNjoATaM+/G9+0NatLKEUl1OURNlOuIri0e/25lnc2OG +mdKNJKm4+qU1uLVO+8G75z3e6JIMUXx8UR34mCts8Pgttb9opDhdBLdmtYi/Cg1mqbWEDxEus1H /BDBeoTzv73bp5hHjU+irhOvA3LeD35w+xxpzDqgh7ssDlV1VVWbK3x9TTFErTR1Ge2+DoO19tre uGGvY9S6bTAMih/s4G+4ZT/sIxSqbUK871C8f+6/Q3Hd716iUq1sZaO4q4Ozm6cN6mz7l6DbllfU yITizm/RFM++nxTTUIEVautmEDi/qSopWyVixLklSh7dN1qMGCdhsKhxAC7VFFKL3GW+Ayw1xmbO m+qqERBQSiCjhhMb1QZACkypI2AM7ARgEE+VFOyErWLkZhLUDCBhBc5npefKxvR2BwmDU0y5jLxh QW/tDHJKpdVSAcuGl4jsFeOFAF6VyCiuwjJbzecZPMFqTbQsqTLngMawgHoGKCKI5wizYALes4QV 9BDUAnqLJzlMIP/NOs5rLYIZ8CBsVZVeHb8/FBF4Yt2o3ofzCzgRdeMiMCXPXtNKomJg2Okc5HEC 9bvTokgUCujPwYm6FNv/QGmXDq0sV+QuQc4FmEuAZaHIdBcX4LRaf6NZstSYJr8ViE9BlluaBTw5 548it+X2ynm+jzlWh6qu7VsYuQBB4XG+P4OlN+oN3FNoN9P7NP09HseS//ACO7npGXwh/EWF/FNq fMZnFepK1hgL4B9gp5HpwLq33wAAAABJRU5ErkJggg== Date: Mon, 08 Jul 2019 19:37:40 +0200 In-Reply-To: <878st8zb82.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 08 Jul 2019 10:29:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Okay, I get that. But I wonder how important it is that add/delete > operations be so efficient? Does subscription/unsubscription happen so > often that it needs to be fast? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Okay, I get that. But I wonder how important it is that add/delete > operations be so efficient? Does subscription/unsubscription happen so > often that it needs to be fast? It's annoying if, say, killing ten groups takes a long time (and the user may have tens of thousands of subscribed groups)... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 00:54:09 2019 Received: (at 36341) by debbugs.gnu.org; 9 Jul 2019 04:54:09 +0000 Received: from localhost ([127.0.0.1]:60193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hki8n-0006d8-Ar for submit@debbugs.gnu.org; Tue, 09 Jul 2019 00:54:09 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:51642 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hki8l-0006cr-N4 for 36341@debbugs.gnu.org; Tue, 09 Jul 2019 00:54:08 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 67E72FA02D; Tue, 9 Jul 2019 04:53:58 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> <878st8zb82.fsf@ericabrahamsen.net> Date: Mon, 08 Jul 2019 21:53:56 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 08 Jul 2019 19:37:40 +0200") Message-ID: <87muhnzu3f.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 07/08/19 19:37 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> Okay, I get that. But I wonder how important it is that add/delete >> operations be so efficient? Does subscription/unsubscription happen so >> often that it needs to be fast? > > It's annoying if, say, killing ten groups takes a long time (and the > user may have tens of thousands of subscribed groups)... Okay, I am happy to look at that part of the code and see if we can do the deletions/insertions in bulk, after the group levels have been changed. Either way, I don't think this has to be a serious speed breaker for Gnus. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 13:50:55 2019 Received: (at 36341) by debbugs.gnu.org; 9 Jul 2019 17:50:55 +0000 Received: from localhost ([127.0.0.1]:34129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkuGU-0004AP-ME for submit@debbugs.gnu.org; Tue, 09 Jul 2019 13:50:54 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:45626 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkuGS-0004A4-Dp; Tue, 09 Jul 2019 13:50:52 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 0987EFA01E; Tue, 9 Jul 2019 17:50:44 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#36341: 27.0.50; Reading from the Gnus dribble file leaves data inconsistent References: <87v9wwuxge.fsf@ericabrahamsen.net> <87mui8kvkw.fsf@aia00054aia.gr> <87fto0tae3.fsf@ericabrahamsen.net> <874l49s5qt.fsf@ericabrahamsen.net> <87wogykike.fsf@ericabrahamsen.net> <87tvc0e13t.fsf@ericabrahamsen.net> <87sgrhz9e3.fsf@ericabrahamsen.net> <878st8zb82.fsf@ericabrahamsen.net> <87muhnzu3f.fsf@ericabrahamsen.net> Date: Tue, 09 Jul 2019 10:50:43 -0700 In-Reply-To: <87muhnzu3f.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 08 Jul 2019 21:53:56 -0700") Message-ID: <87ef2z85cc.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36341 Cc: 36341-done@debbugs.gnu.org, 36341@debbugs.gnu.org, Deus Max X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > On 07/08/19 19:37 PM, Lars Ingebrigtsen wrote: >> Eric Abrahamsen writes: >> >>> Okay, I get that. But I wonder how important it is that add/delete >>> operations be so efficient? Does subscription/unsubscription happen so >>> often that it needs to be fast? >> >> It's annoying if, say, killing ten groups takes a long time (and the >> user may have tens of thousands of subscribed groups)... > > Okay, I am happy to look at that part of the code and see if we can do > the deletions/insertions in bulk, after the group levels have been > changed. Either way, I don't think this has to be a serious speed > breaker for Gnus. And I'm going to close this particular report for now, and go back to working on completion of the larger patch set. From unknown Sat Jun 21 03:30:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Aug 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator