GNU bug report logs - #36317
[PATCH] Correct the name part of defun-prompt-regex in sh-script-mode

Previous Next

Full log

View this message in rfc822 format

From: Ola Nilsson <ola.nilsson <at> gmail.com>
To: rms <at> gnu.org
Cc: 36317 <at> debbugs.gnu.org
Subject: bug#36317: [PATCH] Correct the name part of defun-prompt-regex in sh-script-mode
Date: Mon, 24 Jun 2019 22:23:18 +0200

On Sat, Jun 22, 2019 at 6:13 AM Richard Stallman <rms <at> gnu.org> wrote:
>
> It should try to recognize anything that POSIX says is valid.
> However, rejecting something just because POSIX says it is invalid
> is a non-goal.

Ok, that makes total sense and is probably mentioned in the POSIX specification.

> Maybe shells don't support such function names.  If so, maybe the
> change not to highlight them is good -- maybe.  Highlighting erroneous
> function names might be helpful for the user.  When person runs the
> script, and gets an error, person will change the name.  Until then,
> highlighting the name during editing might still be helpful.

This is not actually about highlighting, but function navigation.
beginning-of-defun, end-of-defun, and narrow-to-defun does not
behave as expected for functions with underscores in their names.

I've sent a V2 patch.

-- 
Ola Nilsson

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.