From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2019 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36301@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156099680623257 (code B ref -1); Thu, 20 Jun 2019 02:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jun 2019 02:13:26 +0000 Received: from localhost ([127.0.0.1]:47659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZq-000633-64 for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:37983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZp-00062w-0D for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51574) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdmZj-0000US-9x for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 22:13:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdmIb-00064t-52 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:40 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:45992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdmIW-0005ea-WA for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:35 -0400 Received: by mail-io1-xd32.google.com with SMTP id e3so2132540ioc.12 for ; Wed, 19 Jun 2019 18:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=VbWGt5Bs7iBr6FE44DaiUlyddMyMtBrcjx5t9VYXOLsMnJ5QYHazcQrbKlpvtmK8H4 usUwgmhaSpqUrDkNrOKUK+iDpqsBnjG9mlapaqYhiaIUUFmypFZTJC+WyjJ2vdgkxvkS GSKSujoLQa0DoKkVyoGZVB7/D7Gj+bIBfaUZyUGIX2KOghReY1cZKcednw42CeDdGw7i lIuYABOyXDsHObNIRrt20CUjFmQUdPX1IThaBUbStyjg8SogsOOOVxgK8oqbFc3nOWCn j7k59qOmM+Z3LonGU8z69icsTKN6mmPflGjKqtVJBSSTSCSClkbK2lLiNZ1h7BF8QJh2 dQZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=raCE3TDatJHIO+IjMB27XYgqGrBgR9rvfY34I7eGcGmv5a4qNxi5H4q9miSBZBsXGt PvwIRVNDBsvS6TM9O1MCUHSoGpwk3HgDG6SBpVXYY0faZ8WJHh5UIyOiy39j3oufbl45 sRIP47YyUWo8rwn43RTcyYAOo19hTaCXFnDj+HFwq56b4qUi5o0mLodOIYk3h5CIeR4I AFilnqeaB6B0G5wNwQUl+Bxn1FVECQA/ZN/ICypGqR6NCWXfY4zyMbrf69OSQdFPgDwv mjndJqZVu15UkHS3Msz9JnQRyzW+WhZbH0qGvqmh1pGtw8K5TeSGdiizBzxve/taVOk/ ggIA== X-Gm-Message-State: APjAAAW9t1CH0CC90QKyadxB5l8UxJH0qnM6WXqj8u9pIfUg1N46WaAQ blOa1C7H6dQPdJYU14XnNjWzVWZzy5o= X-Google-Smtp-Source: APXvYqzvqiKIYGn0VA4/PpARJ9tgvf0ODEmI8gVj38ndN3FmT+jE9KknkIooXzkFyk27RecNAh8Ggw== X-Received: by 2002:a6b:f607:: with SMTP id n7mr5100074ioh.263.1560995729523; Wed, 19 Jun 2019 18:55:29 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p9sm15968199ioj.49.2019.06.19.18.55.28 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 18:55:28 -0700 (PDT) From: Thomas Fitzsimmons Date: Wed, 19 Jun 2019 21:55:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d32 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, The Package-Requires line in my GNU ELPA package, Excorporate, is much longer than 80 characters and I would like to wrap it. It would be nice if package.el allowed Package-Requires to span multiple lines (see patch). It's probably too late to change this but I thought I'd file a bug report anyway. Thomas diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 46f7c91272..5c9b12732d 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1016,7 +1016,8 @@ package-buffer-info (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) + (let* ((requires-str + (mapconcat 'identity (lm-header-multiline "package-requires") " ")) ;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2019 11:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thomas Fitzsimmons Cc: 36301@debbugs.gnu.org Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.15610305829667 (code B ref 36301); Thu, 20 Jun 2019 11:37:01 +0000 Received: (at 36301) by debbugs.gnu.org; 20 Jun 2019 11:36:22 +0000 Received: from localhost ([127.0.0.1]:47959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdvMb-0002Vl-SH for submit@debbugs.gnu.org; Thu, 20 Jun 2019 07:36:22 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:35590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdvMW-0002VM-Um; Thu, 20 Jun 2019 07:36:17 -0400 Received: by mail-io1-f54.google.com with SMTP id m24so312942ioo.2; Thu, 20 Jun 2019 04:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Bd00S7o8e1N2kM1ZvM2tC4eyzp14jiTr9QcvgmEDc9I=; b=VCLMepK7l/eBEFzT/TVWA6o1q8VsXItTWEHm7gXExTALI5+5ElzGDKRptg0aJkcThk sXWiCPGfr2VMj+nBxbj+st/jKdXOMIQWOYhRJwJalIpSqITd/MTx1QnqpmDu+54zcemO BnNIZDgjp39ip/EX1S4X7qdwxIVF+qgfUTgfG2GQ0cn68NUepg+VdRCRD6kezM3Wz3YE d8q7ziXPXHeaWnVBQMDlLYDMuAcp3u4h67O9RwAm+A2EUFZ8aGKxYOOfwcoq5ZR7g+t+ gBDJjOKdzYlyh/6gX/ap05xP1GmZFHd++vvIVgv9urXl1DUOXQpCm8vePZqc59MIViw7 0/IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Bd00S7o8e1N2kM1ZvM2tC4eyzp14jiTr9QcvgmEDc9I=; b=PtBB+Seur2MV/qb97C0VpsGj9A9FQO+oysk0sGnetVT2FlLZlkGdlexfuHXzWzev51 od2/yno2E8rbh4BPMK4fF6Q62xvQdUc/+MI+38c9wN5oneqP3RUCidB6+d2og0j2U4Li EZf0ONuBEH9JOmiz04XTi2HKmFZ2qzutnc6B8FXRC+gqMPdWzXaUxFwwxDovJqSf8CLB biC/Xn2bPbQka3eB1rc+++TVFGhL+b6bdS1FBMqmQdlLCK3dJYE8ZvW5O5bfcb3Rh8l5 N1x6CSXgbO1OB6LT0TlFeVAWEGDPaPFVdaNjrsJD82pq6XhPCwndSZWFzlhteyWDtmyw RS0g== X-Gm-Message-State: APjAAAXzpMi4WpCPMNsDRyosihfZUigqPeQHYlVjRfyl2cPdH0Eg8KC0 scCQ9SuKWoDXWOZif8oRoXXQeH+v X-Google-Smtp-Source: APXvYqwVsLOCwl02h8UndqlVuLY5BlPHq7MjiD9HWCzr5vRmdlsUUqPosFdn/DgnQuGLrkT7qO5Tag== X-Received: by 2002:a5d:884d:: with SMTP id t13mr16309987ios.233.1561030571157; Thu, 20 Jun 2019 04:36:11 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id k26sm15297649ios.38.2019.06.20.04.36.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2019 04:36:10 -0700 (PDT) From: Noam Postavsky References: Date: Thu, 20 Jun 2019 07:36:10 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 19 Jun 2019 21:55:27 -0400") Message-ID: <87d0j8wkt1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 36301 wishlist quit Thomas Fitzsimmons writes: > The Package-Requires line in my GNU ELPA package, Excorporate, is much > longer than 80 characters and I would like to wrap it. It would be nice > if package.el allowed Package-Requires to span multiple lines (see > patch). It's probably too late to change this but I thought I'd file a > bug report anyway. I don't see a problem with changing it now, except that you won't be able to actually wrap the Package-Requires line in Excorporate until that package requires Emacs 27 or later. From unknown Sun Jun 15 01:08:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Fitzsimmons Subject: bug#36301: closed (Re: bug#36301: Package-Requires should support multiple lines) Message-ID: References: X-Gnu-PR-Message: they-closed 36301 X-Gnu-PR-Package: emacs Reply-To: 36301@debbugs.gnu.org Date: Fri, 16 Aug 2019 04:04:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1565928242-8896-1" This is a multi-part message in MIME format... ------------=_1565928242-8896-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36301: Package-Requires should support multiple lines which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36301@debbugs.gnu.org. --=20 36301: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36301 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1565928242-8896-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36301-done) by debbugs.gnu.org; 16 Aug 2019 04:03:49 +0000 Received: from localhost ([127.0.0.1]:52892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyTSv-0002J4-Hn for submit@debbugs.gnu.org; Fri, 16 Aug 2019 00:03:49 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:37287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyTSu-0002Ir-6f for 36301-done@debbugs.gnu.org; Fri, 16 Aug 2019 00:03:48 -0400 Received: by mail-io1-f48.google.com with SMTP id q22so3639383iog.4 for <36301-done@debbugs.gnu.org>; Thu, 15 Aug 2019 21:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NywBEq4N4mxZZlQIp4re80LiTq5dybVTKLiZ/xXp+J0=; b=N9HaL2N8iZD+YnRI+lPPd4W9KV77PJxlSHzmzPJ6T4c3e7EnOIrgFHjda5vVJ4DU+R gZXfC9YmO2U/7GIU2BCKblIr9Rtr/aXfOgOHTy96qqNLAM/Dvp3JvfEZcSRrqEawhRKJ Zz+/LvrCHgVZRMz3QeV6HH2T1SXDsUSptWt2bHh4iTDREoJjP0DIKGro2MCC83ROMjFR dqOa59GTSyAQtmHEhLGsQquS2zMSwEmRE2Jl1egK1mEKGjmzl2tmQINXMDnUTxFiEeHJ 5e0Q03i8k0RYk4Pmfyy+Vuotmlux8ZnbpVUaJytOY6h8JxgcA7cCCycWlaSU6fER87iv XkCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NywBEq4N4mxZZlQIp4re80LiTq5dybVTKLiZ/xXp+J0=; b=r3WcpLeJPiZ3SVmOUubmGTHKSKgBLEzKfH83adnyQSBIDJPtF9Uxg12/bW+5qb9hF1 h+uXFDYB09YF1PTk9WNyi5mLCzkPp5+ewnZmSPhTzXvkPjEZMYdrLhadDg482A2uFRrb ZW2cHxLRfp472AwRh/I5CPIvFtwXI8ilZOnVuZLMgkzZNUbMMnXrE5MRv/BKCAEHpBTF LzxwpiWkdXVe1B7d5yu8yyeVP7J8Ayc9rweiJgAUHHnt4kykiCBjoZ8joxNOZzfanYYq 3cmj76uJiXdYMmjvhfWfg8ocff1AOFtWzm9QbhPwKwoQcpjUD2vAyGOD94SSMBxCZEoy r0NA== X-Gm-Message-State: APjAAAWf2SQPVWLcFbfyIza+hkPSaDboP+HaqkB04CD8Ve+yankNpysN KKPReGFS9oMfR42YA/H19QAvDEM9hO/+IA== X-Google-Smtp-Source: APXvYqysE1iotscix1p/SiAl8Fe+VAgyBGXXZj2zHZJgcKTyGeLOJw95iWy8QPb6cc181MLwEHhpXQ== X-Received: by 2002:a5d:9d49:: with SMTP id k9mr6061502iok.106.1565928222333; Thu, 15 Aug 2019 21:03:42 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 8sm4578248ion.26.2019.08.15.21.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2019 21:03:41 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#36301: Package-Requires should support multiple lines References: <87d0j8wkt1.fsf@gmail.com> Date: Fri, 16 Aug 2019 00:03:40 -0400 In-Reply-To: <87d0j8wkt1.fsf@gmail.com> (Noam Postavsky's message of "Thu, 20 Jun 2019 07:36:10 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 36301-done Cc: 36301-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Noam Postavsky writes: > severity 36301 wishlist > quit > > Thomas Fitzsimmons writes: > >> The Package-Requires line in my GNU ELPA package, Excorporate, is much >> longer than 80 characters and I would like to wrap it. It would be nice >> if package.el allowed Package-Requires to span multiple lines (see >> patch). It's probably too late to change this but I thought I'd file a >> bug report anyway. > > I don't see a problem with changing it now, except that you won't be > able to actually wrap the Package-Requires line in Excorporate until > that package requires Emacs 27 or later. OK, I pushed the change to master. Thanks, Thomas ------------=_1565928242-8896-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jun 2019 02:13:26 +0000 Received: from localhost ([127.0.0.1]:47659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZq-000633-64 for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:37983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZp-00062w-0D for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51574) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdmZj-0000US-9x for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 22:13:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdmIb-00064t-52 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:40 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:45992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdmIW-0005ea-WA for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:35 -0400 Received: by mail-io1-xd32.google.com with SMTP id e3so2132540ioc.12 for ; Wed, 19 Jun 2019 18:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=VbWGt5Bs7iBr6FE44DaiUlyddMyMtBrcjx5t9VYXOLsMnJ5QYHazcQrbKlpvtmK8H4 usUwgmhaSpqUrDkNrOKUK+iDpqsBnjG9mlapaqYhiaIUUFmypFZTJC+WyjJ2vdgkxvkS GSKSujoLQa0DoKkVyoGZVB7/D7Gj+bIBfaUZyUGIX2KOghReY1cZKcednw42CeDdGw7i lIuYABOyXDsHObNIRrt20CUjFmQUdPX1IThaBUbStyjg8SogsOOOVxgK8oqbFc3nOWCn j7k59qOmM+Z3LonGU8z69icsTKN6mmPflGjKqtVJBSSTSCSClkbK2lLiNZ1h7BF8QJh2 dQZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=raCE3TDatJHIO+IjMB27XYgqGrBgR9rvfY34I7eGcGmv5a4qNxi5H4q9miSBZBsXGt PvwIRVNDBsvS6TM9O1MCUHSoGpwk3HgDG6SBpVXYY0faZ8WJHh5UIyOiy39j3oufbl45 sRIP47YyUWo8rwn43RTcyYAOo19hTaCXFnDj+HFwq56b4qUi5o0mLodOIYk3h5CIeR4I AFilnqeaB6B0G5wNwQUl+Bxn1FVECQA/ZN/ICypGqR6NCWXfY4zyMbrf69OSQdFPgDwv mjndJqZVu15UkHS3Msz9JnQRyzW+WhZbH0qGvqmh1pGtw8K5TeSGdiizBzxve/taVOk/ ggIA== X-Gm-Message-State: APjAAAW9t1CH0CC90QKyadxB5l8UxJH0qnM6WXqj8u9pIfUg1N46WaAQ blOa1C7H6dQPdJYU14XnNjWzVWZzy5o= X-Google-Smtp-Source: APXvYqzvqiKIYGn0VA4/PpARJ9tgvf0ODEmI8gVj38ndN3FmT+jE9KknkIooXzkFyk27RecNAh8Ggw== X-Received: by 2002:a6b:f607:: with SMTP id n7mr5100074ioh.263.1560995729523; Wed, 19 Jun 2019 18:55:29 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p9sm15968199ioj.49.2019.06.19.18.55.28 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 18:55:28 -0700 (PDT) From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: Package-Requires should support multiple lines Date: Wed, 19 Jun 2019 21:55:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d32 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, The Package-Requires line in my GNU ELPA package, Excorporate, is much longer than 80 characters and I would like to wrap it. It would be nice if package.el allowed Package-Requires to span multiple lines (see patch). It's probably too late to change this but I thought I'd file a bug report anyway. Thomas diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 46f7c91272..5c9b12732d 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1016,7 +1016,8 @@ package-buffer-info (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) + (let* ((requires-str + (mapconcat 'identity (lm-header-multiline "package-requires") " ")) ;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version ------------=_1565928242-8896-1-- From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36301@debbugs.gnu.org Cc: fitzsim@fitzsim.org Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.156597144421939 (code B ref 36301); Fri, 16 Aug 2019 16:05:01 +0000 Received: (at 36301) by debbugs.gnu.org; 16 Aug 2019 16:04:04 +0000 Received: from localhost ([127.0.0.1]:54781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyehw-0005hn-5C for submit@debbugs.gnu.org; Fri, 16 Aug 2019 12:04:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyehu-0005hJ-9D for 36301@debbugs.gnu.org; Fri, 16 Aug 2019 12:04:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hyeho-0004FU-W4; Fri, 16 Aug 2019 12:03:57 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hyehn-0006Mb-Vh; Fri, 16 Aug 2019 12:03:56 -0400 From: Glenn Morris References: <87d0j8wkt1.fsf@gmail.com> X-Spook: Dateline Virual Hemorrhagic Fever MD4 Verisign 2600 X-Ran: .QOs|wS+xV|>A7;9iMT0V26D77Nmrxg'qdOc2h\4zv@=lP4m"nx X-Hue: magenta X-Attribution: GM Date: Fri, 16 Aug 2019 12:03:55 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 16 Aug 2019 00:03:40 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This causes test failures; ref https://hydra.nixos.org/build/98765298 From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 16:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 36301@debbugs.gnu.org Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.156597256423612 (code B ref 36301); Fri, 16 Aug 2019 16:23:02 +0000 Received: (at 36301) by debbugs.gnu.org; 16 Aug 2019 16:22:44 +0000 Received: from localhost ([127.0.0.1]:54787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyezz-00068m-Qy for submit@debbugs.gnu.org; Fri, 16 Aug 2019 12:22:44 -0400 Received: from mail-io1-f43.google.com ([209.85.166.43]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyezx-00068Z-C6 for 36301@debbugs.gnu.org; Fri, 16 Aug 2019 12:22:41 -0400 Received: by mail-io1-f43.google.com with SMTP id l7so7297802ioj.6 for <36301@debbugs.gnu.org>; Fri, 16 Aug 2019 09:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6eqkoPRWXzgVcRlQ+QDv9SgAGZ02hYQVkQLMGT6EO1g=; b=cdrcJC3MI6yd5L8BD2yqdnIkgwPBzKGD8mPsd75ol8QosBOEurUPF4QAgYZMhHZmkm peKYKq2QoCcfSrigdawv3m472xqxRaY3lj+astGKplOr90TBW2yPtwNtTKApzeHmJZV4 cTmtK5x4y46JLN01iR0ZRuz8E3auhu0QAUbgS8cLjJfcMJbjhs7964b7R0UQfjxMwbkz EUvYOhgr9UNQ2XdqqdP6oUm1fr+GLRbThr9aqyOs+geILpkB7Q8i5U0elX7mHVZmXYP3 W6HrSepMSOURWxBbQsPyo+J8w2HzhU4Rp8jlj29hFsNVlj0OagmiB6PG1G/drlCwQ4Q0 Ym0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6eqkoPRWXzgVcRlQ+QDv9SgAGZ02hYQVkQLMGT6EO1g=; b=J5l5uC0o93g+CRcXTCr3ZI8r/rqBtyZf+9Yo5nTRp5YWXiMpMIgqwV0DeyiJeFy73+ NV98l+1Cacj3V20V0gRxrrOhSq1D97dy1E/Y5mfLcJkQqLPP4yubsE3zKKXZoBulaiwx 32/picajSIrTwCBB3Csvoii05dEPTjzNbpfR5ngN7Rq2DhPFRa7tEKxzjgY/cIgxukiG DxGtemlGe0mr043q9buV4Xi5XfRXuezyrF0V/aBdYPLo9ZaCzb8YXdpphYmTPxpqk5DP 7cbxgT4oARlt9zZMK1vfaC+EkF6/wjVJq4CYvWvrer3zqLhVRuh7rFvXfE5aj/Y7bj3b l3DA== X-Gm-Message-State: APjAAAVRJ2TzB0t8zpLxHU9xGQBAdUwOaRHzW8FvSA4pI2SAtY63ujeG 0qj4wsXIc+hrmw1a3ErU8k2+qL9ZzRnSaQ== X-Google-Smtp-Source: APXvYqzy/2wEQyqRimXHc/3bIN25H/YQ6zYpnV5HWY4qj1dIVapiWfAOB5dBvQq1Oy4+MtED9Z0W5Q== X-Received: by 2002:a02:8663:: with SMTP id e90mr6056936jai.98.1565972555544; Fri, 16 Aug 2019 09:22:35 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id f1sm7701954ioh.73.2019.08.16.09.22.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 09:22:34 -0700 (PDT) From: Thomas Fitzsimmons References: <87d0j8wkt1.fsf@gmail.com> Date: Fri, 16 Aug 2019 12:22:33 -0400 In-Reply-To: (Glenn Morris's message of "Fri, 16 Aug 2019 12:03:55 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > This causes test failures; ref > https://hydra.nixos.org/build/98765298 reopen 36301 OK, thanks for reporting. I reverted the patch for now. Thomas From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 36301@debbugs.gnu.org Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.156599174530973 (code B ref 36301); Fri, 16 Aug 2019 21:43:01 +0000 Received: (at 36301) by debbugs.gnu.org; 16 Aug 2019 21:42:25 +0000 Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjzN-00083U-60 for submit@debbugs.gnu.org; Fri, 16 Aug 2019 17:42:25 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:42426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjzK-00083G-CL for 36301@debbugs.gnu.org; Fri, 16 Aug 2019 17:42:23 -0400 Received: by mail-io1-f50.google.com with SMTP id e20so9087356iob.9 for <36301@debbugs.gnu.org>; Fri, 16 Aug 2019 14:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3BnLqvspQb+xqcIYkBebQLjri4iZVaDVA2x8ybaqVYM=; b=hLOHNmpZf+/Gakn/2NtrCDJbTjpGSa4v0wX5pUgmzCESLNHc8oZkzbQCm0SZrM/DeB 9zlWs4NaY7nwf6MCb0TYJ3/oHE5IwyGItafzshFfX/jyMC5DeuGNU2K/9oOSAnz3UqWj 6Zwc2G3aEAJ8l0ucex28IFEJT8Zt/ZCMvPRW6cxy9CGEXfBURpEf2enFZl0JiR9xkyUU TVVOTE9EsjN3iK4xovIaZRm+vLjF8l9XjaoN+FI6WNk5HY4szpTBPwNpaSC82t82EzH5 DX/xWsQZBKaMFs/E4e9oOmw3lnCIeNgMS7paQA+NVSAl7ImcDEHkgOXBtIJbLsgiV+2R xkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3BnLqvspQb+xqcIYkBebQLjri4iZVaDVA2x8ybaqVYM=; b=bRjyZ/7irIz7JZKmEKR9A6y1YcJzWBAOW6BmMd89n/XkOo5Dx/n/fYFt4PEWbv7h2l WKMtGJh7UpZYx6Jum/ms2Yq/eGIXsGTYw79DcNAs5bef4DhqrMoOsoqafwm9a7lOyIgV rvm99JfbOTN9iSmmmpRQ2GM9kxeyvPz8DXQf7kN/fJz0B7rcyFmBElop6/ter2qPjped nv7ED14PIrvEQE+71qW3F4NlJxqXQ8JbV2ghOVyz1VF8QeuY0Az/wxAj2OHqKp1/tHL1 GA944luY6BIXGaLmOcWaiySRSWNXeRjYWGhYwxmCI/OA86UJ2pTvjG+uvkqDMwrR0+Ff ZskQ== X-Gm-Message-State: APjAAAWhiI7GM4NXvR1Z9iOeJuYp6PWhokQfjAwbSIECnb/+KE4A7ll9 NVxB3WGa+Cemv8lnbZ9FZ26as21KZkyvlQ== X-Google-Smtp-Source: APXvYqxKSr3eTWal4PAuYO/f0JLCMeZSKYIlInZkp+KDyfrdzxvJo6Ts7epQZlxIiIWbZvQWHB4YaQ== X-Received: by 2002:a02:a703:: with SMTP id k3mr12912707jam.12.1565991736388; Fri, 16 Aug 2019 14:42:16 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id o127sm10327869iof.45.2019.08.16.14.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 14:42:15 -0700 (PDT) From: Thomas Fitzsimmons References: <87d0j8wkt1.fsf@gmail.com> Date: Fri, 16 Aug 2019 17:42:14 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 16 Aug 2019 12:22:33 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thomas Fitzsimmons writes: > Glenn Morris writes: > >> This causes test failures; ref >> https://hydra.nixos.org/build/98765298 > > OK, thanks for reporting. I reverted the patch for now. Here is the updated patch that fixes the test failures the prior one introduced. "make check" still fails with and without the patch, but only on some unrelated Tramp and D-Bus tests. If this looks OK, I'll push it to master; in particular I wonder if there's a better way to do the equivalent of mapconcat but produce nil on a nil input sequence. Thanks, Thomas diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index a72522ad8f..b0416cb002 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1028,6 +1028,7 @@ package--prepare-dependencies deps)))) (declare-function lm-header "lisp-mnt" (header)) +(declare-function lm-header-multiline "lisp-mnt" (header)) (declare-function lm-homepage "lisp-mnt" (&optional file)) (declare-function lm-keywords-list "lisp-mnt" (&optional file)) (declare-function lm-maintainer "lisp-mnt" (&optional file)) @@ -1054,7 +1055,9 @@ package-buffer-info (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) + (let* ((requires-str (lm-header-multiline "package-requires")) + (requires-str (when requires-str + (mapconcat 'identity requires-str " "))) ;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thomas Fitzsimmons Cc: 36301@debbugs.gnu.org, Glenn Morris Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.156630775720124 (code B ref 36301); Tue, 20 Aug 2019 13:30:02 +0000 Received: (at 36301) by debbugs.gnu.org; 20 Aug 2019 13:29:17 +0000 Received: from localhost ([127.0.0.1]:60984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i04CK-0005EW-MW for submit@debbugs.gnu.org; Tue, 20 Aug 2019 09:29:16 -0400 Received: from mail-io1-f49.google.com ([209.85.166.49]:41603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i04CJ-0005EH-Kp for 36301@debbugs.gnu.org; Tue, 20 Aug 2019 09:29:16 -0400 Received: by mail-io1-f49.google.com with SMTP id j5so12110521ioj.8 for <36301@debbugs.gnu.org>; Tue, 20 Aug 2019 06:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CIN2tLnlaHvTCTfcP8ATrHibdcnO6cLL0ZezfdeBOwE=; b=Wif/0zUME20/+a8BkbJa/NdTPuhwfl/3uA/iZTs75YRmHY093aTSMSrToaRC+Bp3/M D/cPZqTc0Khf6kYj3eSKoGWwmEY4KYbfLKYdlUy5WPK3Q+vP9pISsRr+nOLRG8YLLq4D D6SNckljEPOSg15IfIeybbtA0rbNEn6aDTLX60SkdjZcZuRxvdmX1peGND9cPdmmJdSs PCk0lKE73J49/+eIvktQcvxxSPBebk1eQbDTb8Q+bRz8ouDtB5HodrKLkmQwGgmQBMlS ptp4NigTiSboTzHNB+o1qSLyLKM3v7s+gfyBwFr3Qo9MzNImP0wysXWKhgzDhmnr+44k 4gRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CIN2tLnlaHvTCTfcP8ATrHibdcnO6cLL0ZezfdeBOwE=; b=lKu1sgpxVelYKaIjt0dLoh2S1BX+weQrsoDnCyyOwt5VocvmJoe3m59y8qVuN8qVvS 7pxCKWBy/RyiJvG+ZZ83U7GFFlkvFWvAPMcPXWNEr+1nCIQ8b654TunW4lUCEers5GJ0 DiiVkrnK/M2H9K9EJV77qfJP3QQb5I8cOgsu/9VVi9HV6+ydks8+59mWYXUeoKqw1sE7 MiFrodI7llWr3mOC864mrugMu7yC/S4PGdNSIv1x9NHTQ7rvmIMMpa+Mq7NOY1mDePcE d1TuHhf4HNlmrO/qqgQtzm8RCUYOX4IlHUsUI6FEe/pWxRZ4H/tFuVwR4dXnS7dWR8JS 18GQ== X-Gm-Message-State: APjAAAXRK/h9TWSaaq/oIzBc1dIoEevuNJ3BG6cehOTYX+4tnBRqtVm1 3u5RFnoFRw8pI+HDLyE+r+DXu6ST X-Google-Smtp-Source: APXvYqwyG6lSh9+3g208iLzutqBDxMa9CspmTB5Drl5Dp6wKWwMDf0dYDf1KFwBxhJig0o1CBlhakg== X-Received: by 2002:a5d:8049:: with SMTP id b9mr16155594ior.199.1566307749783; Tue, 20 Aug 2019 06:29:09 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id q3sm11653522ios.70.2019.08.20.06.29.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 06:29:07 -0700 (PDT) From: Noam Postavsky References: <87d0j8wkt1.fsf@gmail.com> Date: Tue, 20 Aug 2019 09:29:07 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 16 Aug 2019 17:42:14 -0400") Message-ID: <85v9usj78c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > I wonder if there's a better way to do the equivalent of mapconcat but > produce nil on a nil input sequence. Not exactly, but I think this is good place for and-let*: --- i/lisp/emacs-lisp/package.el +++ w/lisp/emacs-lisp/package.el @@ -1028,6 +1028,7 @@ package--prepare-dependencies deps)))) (declare-function lm-header "lisp-mnt" (header)) +(declare-function lm-header-multiline "lisp-mnt" (header)) (declare-function lm-homepage "lisp-mnt" (&optional file)) (declare-function lm-keywords-list "lisp-mnt" (&optional file)) (declare-function lm-maintainer "lisp-mnt" (&optional file)) @@ -1054,8 +1055,7 @@ package-buffer-info (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) - ;; Prefer Package-Version; if defined, the package author + (let* (;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version (or (package-strip-rcs-id (lm-header "package-version")) @@ -1067,9 +1067,9 @@ package-buffer-info "Package lacks a \"Version\" or \"Package-Version\" header")) (package-desc-from-define file-name pkg-version desc - (if requires-str - (package--prepare-dependencies - (package-read-from-string requires-str))) + (and-let* ((require-lines (lm-header-multiline "package-requires"))) + (package--prepare-dependencies + (package-read-from-string (mapconcat #'identity require-lines " ")))) :kind 'single :url homepage :keywords keywords From unknown Sun Jun 15 01:08:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36301: Package-Requires should support multiple lines Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Sep 2019 01:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: 36301@debbugs.gnu.org, Glenn Morris Received: via spool by 36301-submit@debbugs.gnu.org id=B36301.15673020684674 (code B ref 36301); Sun, 01 Sep 2019 01:42:01 +0000 Received: (at 36301) by debbugs.gnu.org; 1 Sep 2019 01:41:08 +0000 Received: from localhost ([127.0.0.1]:56103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4Erc-0001DJ-CH for submit@debbugs.gnu.org; Sat, 31 Aug 2019 21:41:08 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:37189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4ErZ-0001CV-8P for 36301@debbugs.gnu.org; Sat, 31 Aug 2019 21:41:06 -0400 Received: by mail-io1-f42.google.com with SMTP id r4so7058229iop.4 for <36301@debbugs.gnu.org>; Sat, 31 Aug 2019 18:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hUbsDbNmMUZziNaSlfRctb9kV6pDOzsUNGjJKX31+ac=; b=ubydLd+eFOv/HPolRFZawFSvp8prpbfWGv/rQhEBstnhR1I9hLoSiPM94NSGTcsYKG Lj4gupSsVK2hEA225ITlXjloOJOo6mc7OHQghU0DW8MscjlfIyD/ZnkjgbbBCgltIvcK +iyPu56sm2pX7XIz3Epqlvz8VzHIFtHBlZkLdQyLAtsLKb91ktUZInhM2dM32/EsbTqf JfM347u+TUDqohmlEEFNwmss667Sdjv/RyGF2PEtHB7cwWJ+BetVhh8S40s/mH9IiIbL 0RGWAl/Coqdwb0t/KeT0i0x+pWWALGc8gBCdBKlGJGEPA3QXFR1Vnt99COTA+fTWjw0u dMHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hUbsDbNmMUZziNaSlfRctb9kV6pDOzsUNGjJKX31+ac=; b=WXjvaokkoQe+48Etsp5RIxNtFU+3G1k7+knwLEkwjSi+P/ln1vCy9a0R1n/P9kD5YP 3SG3VLwoCEVdKaPbmxo0t92zIXhRpBDer3nQborF6mqbaiXV5onqb9bR2G6f96LSs8fn 802rlmTL0zEop11V7UfNkywhrHwKcUOTTc8F3QnVz0F+MCZepHRmcotmlxeNE4lIgzSJ pKIoBI5ouJq5igAg869YDAzqCCa+Bot3ad3mFrdGTgmh5WwDMWn6z2TAvyYjzqQOhXnl JecKMw/k4apSY2zhBxeJGTwKYaMcx29WH6yE3Rpdcd6EZhr7s56Zws3oEkrdz0W7lVr6 0/sQ== X-Gm-Message-State: APjAAAWNYj/Jb/IARWfLQBaQpYjf13aVyInAQ+YotXIh+xwVJ4KRqss5 ViMBwwaoiIne1eYi/wlOOMXXGVYBPPs= X-Google-Smtp-Source: APXvYqyKaCHEC2eu1gT3vpsoZL8YZIQLvw/RqH6N+T+iJS63ILz1sJvxfMLaVfNFjQmrswhtptFIKQ== X-Received: by 2002:a6b:c947:: with SMTP id z68mr18082971iof.132.1567302059419; Sat, 31 Aug 2019 18:40:59 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id n25sm7646025iop.3.2019.08.31.18.40.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 18:40:58 -0700 (PDT) From: Thomas Fitzsimmons References: <87d0j8wkt1.fsf@gmail.com> <85v9usj78c.fsf@gmail.com> Date: Sat, 31 Aug 2019 21:40:57 -0400 In-Reply-To: <85v9usj78c.fsf@gmail.com> (Noam Postavsky's message of "Tue, 20 Aug 2019 09:29:07 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Thomas Fitzsimmons writes: >> I wonder if there's a better way to do the equivalent of mapconcat but >> produce nil on a nil input sequence. > > Not exactly, but I think this is good place for and-let*: Yes, looks good; "make check" passes on these tests, so I pushed this new patch. I'll wait for other test results before closing this. Thanks, Thomas From unknown Sun Jun 15 01:08:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Fitzsimmons Subject: bug#36301: closed (Re: bug#36301: Package-Requires should support multiple lines) Message-ID: References: X-Gnu-PR-Message: they-closed 36301 X-Gnu-PR-Package: emacs Reply-To: 36301@debbugs.gnu.org Date: Sun, 01 Sep 2019 17:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1567359302-24569-1" This is a multi-part message in MIME format... ------------=_1567359302-24569-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36301: Package-Requires should support multiple lines which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36301@debbugs.gnu.org. --=20 36301: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36301 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1567359302-24569-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36301-done) by debbugs.gnu.org; 1 Sep 2019 17:34:35 +0000 Received: from localhost ([127.0.0.1]:57162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4TkI-0006NM-Ro for submit@debbugs.gnu.org; Sun, 01 Sep 2019 13:34:35 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:44069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4TkF-0006Mq-VG for 36301-done@debbugs.gnu.org; Sun, 01 Sep 2019 13:34:32 -0400 Received: by mail-io1-f42.google.com with SMTP id j4so24721669iog.11 for <36301-done@debbugs.gnu.org>; Sun, 01 Sep 2019 10:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2/x70aM9do9kRylwfqkXpMkzFVqf4HY/9yBnkORaEzQ=; b=xCjKp1hEcAQhbNZjSJNT+NYfSEaPpkFHorn2XN+jI0+t0pGWp4dAkQQB+FAOURxjcA DlIziDp0MfMvEdAkXx/goie2yWkAFiIyCQcaZOWtM0gk8mMU8CHf7DySVCwOBV+svahi IGM/90UM1aM6tbe1htJ5IhB65FVTyZ6x5RfMjDG7sVoEnWVHJdkGX42vaGlikH7aQgMB DKYX/BD0r7uNmr1jbREm0r+K2dm7SasMhqISE6StwLuo0ojVqV/dR9qeQAo5126gxQVt J+oO84JkTy641lpV4mLkoPVjMXtIE+v7cZCL0OMR3ARnQd9i2pJjGP1by520gHryCMKO j3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2/x70aM9do9kRylwfqkXpMkzFVqf4HY/9yBnkORaEzQ=; b=BLMVYTgatpptc4mU46j8610U+XTcEyzOLckNQSnkdpaiJDsRdJqiDroK+OgxKBVrrC pwktjIcbNIp1fwTKqpvahjM/yImKuqpBzSBm9eQTtuDyyqUeQ/TjrhILeoR2SqNcxENl ciBMR0OcxMLPRsE3InRHTg6vpt6hkf8QTPxtbIOo7nBm9W1OUmfAuspY66PGWrpEfXBi sDxsVVEubfvbFSRKfoDP3yZ6oyBNQ6LUwfhTRzC6piK/fkBmtafGEVGDasJwQESUebAj w94sq2oYVI+5CuW1umS+b/Pq3Y6/vN0vqPnTzk2tU/k+tPtR9kgc4ql4OL5v6vXR3sUt TJTw== X-Gm-Message-State: APjAAAWHLI84I74YAjqPcz/RtANo4+/qx8poGuBVO+BInnOX3aBCtbej Wmn6rnW52q9JjiGD27Fb5jRCMGj/sIU= X-Google-Smtp-Source: APXvYqzx334xqS4NTshWpErES5DFbYMW9K5RWp0Jsj+FgYKii2kFYx7KV7ev0G0O1SloIV7ALFMRxA== X-Received: by 2002:a05:6638:a19:: with SMTP id 25mr9979857jan.27.1567359265942; Sun, 01 Sep 2019 10:34:25 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id o3sm12201076ioo.74.2019.09.01.10.34.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 10:34:25 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#36301: Package-Requires should support multiple lines References: <87d0j8wkt1.fsf@gmail.com> <85v9usj78c.fsf@gmail.com> Date: Sun, 01 Sep 2019 13:34:23 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 31 Aug 2019 21:40:57 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36301-done Cc: 36301-done@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > Noam Postavsky writes: > >> Thomas Fitzsimmons writes: >>> I wonder if there's a better way to do the equivalent of mapconcat but >>> produce nil on a nil input sequence. >> >> Not exactly, but I think this is good place for and-let*: > > Yes, looks good; "make check" passes on these tests, so I pushed this > new patch. I'll wait for other test results before closing this. The Hydra build succeeded too: https://hydra.nixos.org/build/99577710 so I'm closing this. Thanks, Thomas ------------=_1567359302-24569-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jun 2019 02:13:26 +0000 Received: from localhost ([127.0.0.1]:47659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZq-000633-64 for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:37983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdmZp-00062w-0D for submit@debbugs.gnu.org; Wed, 19 Jun 2019 22:13:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51574) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdmZj-0000US-9x for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 22:13:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdmIb-00064t-52 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:40 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:45992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdmIW-0005ea-WA for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 21:55:35 -0400 Received: by mail-io1-xd32.google.com with SMTP id e3so2132540ioc.12 for ; Wed, 19 Jun 2019 18:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=VbWGt5Bs7iBr6FE44DaiUlyddMyMtBrcjx5t9VYXOLsMnJ5QYHazcQrbKlpvtmK8H4 usUwgmhaSpqUrDkNrOKUK+iDpqsBnjG9mlapaqYhiaIUUFmypFZTJC+WyjJ2vdgkxvkS GSKSujoLQa0DoKkVyoGZVB7/D7Gj+bIBfaUZyUGIX2KOghReY1cZKcednw42CeDdGw7i lIuYABOyXDsHObNIRrt20CUjFmQUdPX1IThaBUbStyjg8SogsOOOVxgK8oqbFc3nOWCn j7k59qOmM+Z3LonGU8z69icsTKN6mmPflGjKqtVJBSSTSCSClkbK2lLiNZ1h7BF8QJh2 dQZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Q+ofOzDYU0wbPdFkFr8TDtDAW7n27FPJBPn37nR3Z+g=; b=raCE3TDatJHIO+IjMB27XYgqGrBgR9rvfY34I7eGcGmv5a4qNxi5H4q9miSBZBsXGt PvwIRVNDBsvS6TM9O1MCUHSoGpwk3HgDG6SBpVXYY0faZ8WJHh5UIyOiy39j3oufbl45 sRIP47YyUWo8rwn43RTcyYAOo19hTaCXFnDj+HFwq56b4qUi5o0mLodOIYk3h5CIeR4I AFilnqeaB6B0G5wNwQUl+Bxn1FVECQA/ZN/ICypGqR6NCWXfY4zyMbrf69OSQdFPgDwv mjndJqZVu15UkHS3Msz9JnQRyzW+WhZbH0qGvqmh1pGtw8K5TeSGdiizBzxve/taVOk/ ggIA== X-Gm-Message-State: APjAAAW9t1CH0CC90QKyadxB5l8UxJH0qnM6WXqj8u9pIfUg1N46WaAQ blOa1C7H6dQPdJYU14XnNjWzVWZzy5o= X-Google-Smtp-Source: APXvYqzvqiKIYGn0VA4/PpARJ9tgvf0ODEmI8gVj38ndN3FmT+jE9KknkIooXzkFyk27RecNAh8Ggw== X-Received: by 2002:a6b:f607:: with SMTP id n7mr5100074ioh.263.1560995729523; Wed, 19 Jun 2019 18:55:29 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p9sm15968199ioj.49.2019.06.19.18.55.28 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 18:55:28 -0700 (PDT) From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: Package-Requires should support multiple lines Date: Wed, 19 Jun 2019 21:55:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d32 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, The Package-Requires line in my GNU ELPA package, Excorporate, is much longer than 80 characters and I would like to wrap it. It would be nice if package.el allowed Package-Requires to span multiple lines (see patch). It's probably too late to change this but I thought I'd file a bug report anyway. Thomas diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 46f7c91272..5c9b12732d 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1016,7 +1016,8 @@ package-buffer-info (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) + (let* ((requires-str + (mapconcat 'identity (lm-header-multiline "package-requires") " ")) ;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version ------------=_1567359302-24569-1--