GNU bug report logs - #36297
[PATCH] gnu: weechat: update to 2.5

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36297 in the body.
You can then email your comments to 36297 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josh Holland <josh <at> inv.alid.pw>
To: guix-patches <at> gnu.org
Cc: Josh Holland <josh <at> inv.alid.pw>
Subject: [PATCH] gnu: weechat: update to 2.5
Date: Wed, 19 Jun 2019 20:55:29 +0100

* gnu/packages/irc.scm (weechat): update to 2.5
---
 gnu/packages/irc.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
index d3b3a51294..851bea05bf 100644
--- a/gnu/packages/irc.scm
+++ b/gnu/packages/irc.scm
@@ -166,14 +166,14 @@ SILC and ICB protocols via plugins.")
 (define-public weechat
   (package
     (name "weechat")
-    (version "2.1")
+    (version "2.5")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://weechat.org/files/src/weechat-"
                                   version ".tar.xz"))
               (sha256
                (base32
-                "0f7d2vdbxc5kgjl7lkamnbxvidgxwa8f9j3nr9fd4gr4z0gzi86d"))
+                "09sc5lf7z70x3iw87q4zh8rbyngsw89pwnzs5jk195zzqdspgj2j"))
               (patches (search-patches "weechat-python.patch"))))
     (build-system cmake-build-system)
     (native-inputs
@@ -212,7 +212,7 @@ SILC and ICB protocols via plugins.")
                ((".*\\$\\{plugin.name\\} == (javascript|php|ruby)" all)
                 (string-append "// SKIP" all)))
              (substitute* "tests/scripts/test-scripts.cpp"
-               ((".*\\{ \"(jvascript|php|ruby)\", " all) ; sic
+               ((".*\\{ \"(javascript|php|ruby)\", " all)
                 (string-append "// SKIP" all)))
              #t))
          (add-after 'install 'wrap
-- 
2.22.0

Message #8 received at 36297 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 36297 <at> debbugs.gnu.org, josh <at> inv.alid.pw
Subject: gnu: weechat: update to 2.5
Date: Thu, 20 Jun 2019 07:45:44 +0000

[Message part 1 (text/plain, inline)]

Hello,

Is removing the comment intentional?

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[Message part 2 (text/html, inline)]

Message #11 received at 36297 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 36297 <at> debbugs.gnu.org, Gábor Boskovits
 <boskovits <at> gmail.com>
Subject: Re: [bug#36297] gnu: weechat: update to 2.5
Date: Thu, 20 Jun 2019 10:06:11 +0200

[Message part 1 (text/plain, inline)]

Gábor,

Gábor Boskovits wrote:
> Is removing the comment intentional?

Yes.  It accompanied the deliberate ‘jvascript’ spelling, which 
has now been fixed.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 36297 <at> debbugs.gnu.org (full text, mbox):

From: "Josh Holland" <josh <at> inv.alid.pw>
To: Gábor Boskovits <boskovits <at> gmail.com>,
 36297 <at> debbugs.gnu.org
Subject: Re: gnu: weechat: update to 2.5
Date: Thu, 20 Jun 2019 09:08:21 +0100

Hi Gábor,

On Thu, 20 Jun 2019, at 8:46 AM, Gábor Boskovits wrote:
> Is removing the comment intentional?

Yes, the "sic"[0] was indicating that the typo of "jvascript" was intended (to match an upstream typo). That's now been fixed, so the comment is no longer necessary.

Thanks,
Josh

[0]: see e.g. https://en.wikipedia.org/wiki/Sic

Message #19 received at 36297-done <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 36297-done <at> debbugs.gnu.org
Subject: gnu: weechat: update to 2.5
Date: Thu, 20 Jun 2019 10:03:50 +0000

[Message part 1 (text/plain, inline)]

Fixed on master on commit 9553a41dbee956aeece7631321fc52a264311541
<http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9553a41dbee956aeece7631321fc52a264311541>

Thanks for the report,

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.