From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 04:45:36 2019 Received: (at submit) by debbugs.gnu.org; 17 Jun 2019 08:45:36 +0000 Received: from localhost ([127.0.0.1]:41922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcnGh-0002hi-MH for submit@debbugs.gnu.org; Mon, 17 Jun 2019 04:45:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:51284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcnGe-0002hY-6K for submit@debbugs.gnu.org; Mon, 17 Jun 2019 04:45:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46846) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcnGc-00084E-3s for guix-patches@gnu.org; Mon, 17 Jun 2019 04:45:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcnGZ-0005fl-TZ for guix-patches@gnu.org; Mon, 17 Jun 2019 04:45:30 -0400 Received: from mout02.posteo.de ([185.67.36.66]:36271) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcnGZ-0005Yv-BC for guix-patches@gnu.org; Mon, 17 Jun 2019 04:45:27 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 6893D2400FF for ; Mon, 17 Jun 2019 10:45:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1560761122; bh=HbhwFBZmLDq1HOlhqmR1G3sZuf51/JNm4Zo4iqSCdUI=; h=From:To:Cc:Subject:Date:From; b=OMaPnK5vve3fVen72lmWxbsfgxO8ZKhJnKaXS2/BVOvpA8kFzY/iiISLA4IxOrqhk Re0shQALebKYADJ8/L4sjSI5kBFcxBP81Z5uSWZSeZD53s8J72C88tyaSb0VuinVhM YCKLA04OuWxuL2cgXOyDYIi5skTkFXKlm+jDR39c5ZfGk1/3ScGyP/gudCwnAYQAMx pa8BhhkGZHgZrG3bbrsvQHNPbGUCMlw1QGZhkDZvxrkBPQgXGwAE6hGq5u5pwCGH7T 9wZfGS3A2HPHEBpypLbtVhwiLJSUQbt/NQNqOsdBXg/gs+aGgIUzmkvXlOW/KqwMdm TKTKtUmoxjMUw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45S4Xw3jmJz9rxK; Mon, 17 Jun 2019 10:45:20 +0200 (CEST) From: Guillaume LE VAILLANT To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: monero: Update to 0.14.1.0. Date: Mon, 17 Jun 2019 10:44:35 +0200 Message-Id: <20190617084436.12311-1-glv@posteo.net> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Guillaume LE VAILLANT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/finance.scm (monero): Update to 0.14.1.0. * gnu/packages/patches/monero-use-system-miniupnpc.patch: Update file. --- gnu/packages/finance.scm | 89 +++++++++-------- .../patches/monero-use-system-miniupnpc.patch | 95 +++---------------- 2 files changed, 61 insertions(+), 123 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 5b95bcb704..50a96183f7 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2018 Adriano Peluso ;;; Copyright =C2=A9 2018, 2019 Nicolas Goaziou ;;; Copyright =C2=A9 2018 Arun Isaac +;;; Copyright =C2=A9 2019 Guillaume Le Vaillant ;;; ;;; This file is part of GNU Guix. ;;; @@ -39,6 +40,7 @@ #:use-module (gnu packages base) #:use-module (gnu packages boost) #:use-module (gnu packages check) + #:use-module (gnu packages compression) #:use-module (gnu packages crypto) #:use-module (gnu packages databases) #:use-module (gnu packages documentation) @@ -68,6 +70,7 @@ #:use-module (gnu packages textutils) #:use-module (gnu packages tls) #:use-module (gnu packages upnp) + #:use-module (gnu packages version-control) #:use-module (gnu packages web) #:use-module (gnu packages xml) #:use-module (gnu packages gnuzilla)) @@ -428,49 +431,59 @@ other machines/servers. Electroncash does not down= load the Bitcoin Cash blockch =20 (define-public monero ;; This package bundles easylogging++ and lmdb. - ;; The bundled easylogging++ is modified, and the changes will not be = upstreamed. + ;; The bundled easylogging++ is modified, and the changes will not be + ;; upstreamed. ;; The devs deem the lmdb driver too critical a consenus component, to= use ;; the system's dynamically linked library. (package (name "monero") - (version "0.12.3.0") + (version "0.14.1.0") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/monero-project/monero") - (commit (string-append "v" version)))) + (url "https://github.com/monero-project/monero.git") + (commit (string-append "v" version)) + (recursive? #t))) (file-name (git-file-name name version)) (patches (search-patches "monero-use-system-miniupnpc.patch")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Delete bundled dependencies. + (for-each + delete-file-recursively + '("external/miniupnp" "external/rapidjson" + "external/unbound")) + #t)) (sha256 (base32 - "14db9kgjm2ha93c2x5fjdw01xaqshn756qr3x2cnzyyjh7caz5qd")))) + "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh")))) (build-system cmake-build-system) (native-inputs `(("doxygen" ,doxygen) - ("googletest" ,googletest) + ("git" ,git) ("graphviz" ,graphviz) - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("qttools" ,qttools))) (inputs - `(("bind" ,isc-bind) - ("boost" ,boost) - ("zeromq" ,zeromq) + `(("boost" ,boost) ("cppzmq" ,cppzmq) ("expat" ,expat) - ("libsodium" ,libsodium) + ("hidapi" ,hidapi) ("libunwind" ,libunwind) - ("lmdb" ,lmdb) - ("miniupnpc" ,monero-miniupnpc) + ("libsodium" ,libsodium) + ("miniupnpc" ,miniupnpc) ("openssl" ,openssl) ("rapidjson" ,rapidjson) - ("unbound" ,unbound))) + ("readline" ,readline) + ("unbound" ,unbound) + ("xz" ,xz) + ("zeromq" ,zeromq))) (arguments `(#:out-of-source? #t - #:build-type "release" - #:configure-flags '("-DBUILD_TESTS=3DON" - ,@(if (string=3D? "aarch64-linux" (%current-s= ystem)) - '("-DARCH=3Darmv8-a") - '()) + #:configure-flags '("-DARCH=3Ddefault" + "-DBUILD_TESTS=3DON" "-DBUILD_GUI_DEPS=3DON") #:phases (modify-phases %standard-phases @@ -479,24 +492,18 @@ other machines/servers. Electroncash does not down= load the Bitcoin Cash blockch (lambda _ (setenv "HOME" (getcwd)) #t)) - (add-after 'set-home 'fix-wallet-path-for-unit-tests - (lambda _ - (substitute* "tests/unit_tests/serialization.cpp" - (("\\.\\./\\.\\./\\.\\./\\.\\./") "../../")) - #t)) - (add-after 'fix-wallet-path-for-unit-tests 'change-log-path + (add-after 'set-home 'change-log-path (lambda _ (substitute* "contrib/epee/src/mlog.cpp" (("epee::string_tools::get_current_module_folder\\(\\)") - "\".bitmonero\"")) - (substitute* "contrib/epee/src/mlog.cpp" - (("return \\(") "return ((std::string(getenv(\"HOME\"))) = / ")) + "\".bitmonero\"") + (("return \\(") + "return ((std::string(getenv(\"HOME\"))) / ")) #t)) + ;; Only try tests that don't need access to network or system (replace 'check (lambda _ - (invoke "make" "ARGS=3D-E 'unit_tests|libwallet_api_tests'" - "test"))) - ;; The excluded unit tests need network access + (invoke "make" "ARGS=3D-R 'hash|core_tests'" "test"))) (add-after 'check 'unit-tests (lambda _ (let ((excluded-unit-tests @@ -506,22 +513,22 @@ other machines/servers. Electroncash does not down= load the Bitcoin Cash blockch "DNSResolver.IPv4Success" "DNSResolver.DNSSECSuccess" "DNSResolver.DNSSECFailure" - "DNSResolver.GetTXTRecord") + "DNSResolver.GetTXTRecord" + ;; TODO: Find why portability_wallet test fails + ;; Maybe the Boost version used to create the tes= t + ;; wallet and the current Boost version are not + ;; completely compatible? + "Serialization.portability_wallet" + "is_hdd.linux_os_root") ":"))) (invoke "tests/unit_tests/unit_tests" (string-append "--gtest_filter=3D-" - excluded-unit-tests))))) - (add-after 'install 'install-blockchain-import-export - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin"))) - (install-file "bin/monero-blockchain-import" bin) - (install-file "bin/monero-blockchain-export" bin))))))) + excluded-unit-tests)))))))) (home-page "https://getmonero.org/") (synopsis "Command-line interface to the Monero currency") (description - "Monero is a secure, private, untraceable currency. This package p= rovides the -Monero command line client and daemon.") + "Monero is a secure, private, untraceable currency. This package p= rovides +the Monero command line client and daemon.") (license license:bsd-3))) =20 (define-public monero-gui diff --git a/gnu/packages/patches/monero-use-system-miniupnpc.patch b/gnu= /packages/patches/monero-use-system-miniupnpc.patch index 6bc825d121..c5d376d793 100644 --- a/gnu/packages/patches/monero-use-system-miniupnpc.patch +++ b/gnu/packages/patches/monero-use-system-miniupnpc.patch @@ -1,111 +1,42 @@ -This reverts commit 1e20d705e7c64d2b17c031f345057d1e8850fafa, so that it= 's possible to use our own -miniupnpc, instead of a git submodule. ---- - CMakeLists.txt | 8 ++++++++ - external/CMakeLists.txt | 41 +++++++++++++++++++++++++++++++---------- - src/p2p/net_node.inl | 13 ++++++++++--- - 3 files changed, 49 insertions(+), 13 deletions(-) - -diff --git a/CMakeLists.txt b/CMakeLists.txt -index 3b93988e..ef948885 100644 ---- a/CMakeLists.txt -+++ b/CMakeLists.txt -@@ -430,6 +430,14 @@ include_directories("${CMAKE_CURRENT_BINARY_DIR}/tr= anslations") -=20 - add_subdirectory(external) -=20 -+# Final setup for miniupnpc -+if(UPNP_STATIC OR IOS) -+ add_definitions("-DUPNP_STATIC") -+else() -+ add_definitions("-DUPNP_DYNAMIC") -+ include_directories(${UPNP_INCLUDE}) -+endif() -+ - # Final setup for libunbound - include_directories(${UNBOUND_INCLUDE}) - link_directories(${UNBOUND_LIBRARY_DIRS}) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt -index 1fc4d64c..b4f712ee 100644 +index 7553f87e..8e865c6c 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt -@@ -34,21 +34,42 @@ - # We always compile if we are building statically to reduce static depe= ndency issues... - # ...except for FreeBSD, because FreeBSD is a special case that doesn't= play well with - # others. -+if(NOT IOS) -+ find_package(Miniupnpc QUIET) -+endif() +@@ -37,19 +37,7 @@ =20 --find_package(Miniupnpc REQUIRED) -+# If we have the correct shared version and we're not building static, = use it -+if(STATIC OR IOS) -+ set(USE_SHARED_MINIUPNPC false) -+elseif(MINIUPNP_FOUND AND MINIUPNPC_VERSION_1_7_OR_HIGHER) -+ set(USE_SHARED_MINIUPNPC true) -+endif() + find_package(Miniupnpc REQUIRED) =20 -message(STATUS "Using in-tree miniupnpc") -+if(USE_SHARED_MINIUPNPC) -+ message(STATUS "Using shared miniupnpc found at ${MINIUPNP_INCLUDE_DI= R}") -=20 -add_subdirectory(miniupnp/miniupnpc) -+ set(UPNP_STATIC false PARENT_SCOPE) -+ set(UPNP_INCLUDE ${MINIUPNP_INCLUDE_DIR} PARENT_SCOPE) -+ set(UPNP_LIBRARIES ${MINIUPNP_LIBRARY} PARENT_SCOPE) -+else() -+ if(STATIC) -+ message(STATUS "Using miniupnpc from local source tree for static b= uild") -+ else() -+ message(STATUS "Using miniupnpc from local source tree (/external/m= iniupnp/miniupnpc)") -+ endif() -=20 -set_property(TARGET libminiupnpc-static PROPERTY FOLDER "external") -if(MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPIL= E_FLAGS " -wd4244 -wd4267") -elseif(NOT MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPIL= E_FLAGS " -Wno-undef -Wno-unused-result -Wno-unused-value") -endif() -+ add_subdirectory(miniupnp/miniupnpc) -+ -+ set_property(TARGET libminiupnpc-static PROPERTY FOLDER "external") -+ if(MSVC) -+ set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMP= ILE_FLAGS " -wd4244 -wd4267") -+ elseif(NOT MSVC) -+ set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMP= ILE_FLAGS " -Wno-undef -Wno-unused-result -Wno-unused-value") -+ endif() -=20 +-if(CMAKE_SYSTEM_NAME MATCHES "NetBSD") +- set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE= _FLAGS " -D_NETBSD_SOURCE") +-endif() +- -set(UPNP_LIBRARIES "libminiupnpc-static" PARENT_SCOPE) -+ set(UPNP_STATIC true PARENT_SCOPE) -+ set(UPNP_LIBRARIES "libminiupnpc-static" PARENT_SCOPE) -+endif() ++set(UPNP_LIBRARIES "miniupnpc" PARENT_SCOPE) =20 find_package(Unbound) =20 diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl -index 9b21705e..76340a22 100644 +index 74924e4f..3554dd0d 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl -@@ -49,9 +49,16 @@ +@@ -49,9 +49,9 @@ #include "storages/levin_abstract_invoke2.h" #include "cryptonote_core/cryptonote_core.h" =20 -#include -#include -#include -+// We have to look for miniupnpc headers in different places, dependent= on if its compiled or external -+#ifdef UPNP_STATIC -+ #include -+ #include -+ #include -+#else -+ #include "miniupnpc.h" -+ #include "upnpcommands.h" -+ #include "upnperrors.h" -+#endif ++#include ++#include ++#include =20 #undef MONERO_DEFAULT_LOG_CATEGORY #define MONERO_DEFAULT_LOG_CATEGORY "net.p2p" ---=20 -2.16.2 - --=20 2.22.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 16:38:15 2019 Received: (at 36258) by debbugs.gnu.org; 22 Jun 2019 20:38:15 +0000 Received: from localhost ([127.0.0.1]:52570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hemm7-0004OH-DC for submit@debbugs.gnu.org; Sat, 22 Jun 2019 16:38:15 -0400 Received: from mx1.riseup.net ([198.252.153.129]:52176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hemm5-0004O9-7Q for 36258@debbugs.gnu.org; Sat, 22 Jun 2019 16:38:14 -0400 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 60BB51A0556; Sat, 22 Jun 2019 13:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561235892; bh=yW4mjmTYKY2jxxoGwXGQlMdB1MMh9xdxDLfQt6EtIKM=; h=Subject:To:References:From:Date:In-Reply-To:From; b=WEEEB4UL9WQsRoW0Vvx0J/7EqYtcGDSIJ/617rI6G0SYpzaQsnaCbjHpxmGvB50WB Hj763qbS5eMd+/RBE5k3mzwi7jSQHPKtI3JPXiAnB4rJPoAjUn48aZYKhb5a1El45a 3c7WBlbnvi+/DyLeS2TfsuJ3D0deBoKKZ/c70Gl0= X-Riseup-User-ID: AC1D44042D35AF933960110A737F83054BABCC1680C071DA65B2E17C2CF9CFDF Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 861461209F2; Sat, 22 Jun 2019 13:38:11 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: Guillaume LE VAILLANT , 36258@debbugs.gnu.org References: <20190617084436.12311-1-glv@posteo.net> From: swedebugia Message-ID: <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> Date: Sat, 22 Jun 2019 22:38:08 +0200 MIME-Version: 1.0 In-Reply-To: <20190617084436.12311-1-glv@posteo.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36258 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-06-17 10:44, Guillaume LE VAILLANT wrote: > * gnu/packages/finance.scm (monero): Update to 0.14.1.0. > * gnu/packages/patches/monero-use-system-miniupnpc.patch: Update file. > --- Thanks for the patch! I tried building it with 4GB ram and 4GB swap but it failed with this error which I suspect is memory-related. I'm building it again now with -c 1 and it got past this point :) I will review further once it is done. make -f src/wallet/CMakeFiles/obj_wallet.dir/build.make src/wallet/CMakeFiles/obj_wallet.dir/build make[2]: Entering directory '/tmp/guix-build-monero-0.14.1.0.drv-0/build' [ 32%] Building CXX object src/wallet/CMakeFiles/obj_wallet.dir/wallet2.cpp.o cd /tmp/guix-build-monero-0.14.1.0.drv-0/build/src/wallet && /gnu/store/n2p1zs14y89lwkg9da68y12pc10c6sw9-gcc-5.5.0/bin/c++ -DAUTO_INITIALIZE_EASYLOGGINGPP -DBLOCKCHAIN_DB=DB_LMDB -DDEFAULT_DB_TYPE=\"lmdb\" -DHAVE_EXPLICIT_BZERO -DHAVE_HIDAPI -DHAVE_STRPTIME -DPER_BLOCK_CHECKPOINT -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external/rapidjson/include -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external/easylogging++ -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/contrib/epee/include -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external -I/gnu/store/yl1vi61qmvvh83amwiwaik7s7jc03n5z-openssl-1.0.2p/include -I/tmp/guix-build-monero-0.14.1.0.drv-0/build/translations -I/gnu/store/2bpljhwxmm4w50ah93g80wrpzipzji2v-unbound-1.9.1/include -I/tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external/db_drivers/liblmdb -I/gnu/store/0rqzg8jrmvza1a6n9qg26j6dpy49850c-hidapi-0.8.0-rc1/include/hidapi -isystem /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include -pthread -maes -fno-strict-aliasing -std=c++11 -D_GNU_SOURCE -Wall -Wextra -Wpointer-arith -Wundef -Wvla -Wwrite-strings -Wno-error=extra -Wno-error=deprecated-declarations -Wno-unused-parameter -Wno-unused-variable -Wno-error=unused-variable -Wno-error=undef -Wno-error=uninitialized -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=cpp -Wno-reorder -Wno-missing-field-initializers -fPIC -Wformat -Wformat-security -fstack-protector -fstack-protector-strong -fno-strict-aliasing -ftemplate-depth=900 -O2 -g -DNDEBUG -o CMakeFiles/obj_wallet.dir/wallet2.cpp.o -c /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.cpp In file included from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/detail/endian.hpp:9:0, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external/boost/archive/portable_binary_archive.hpp:25, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/external/boost/archive/portable_binary_iarchive.hpp:33, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/cryptonote_basic/cryptonote_boost_serialization.h:40, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/cryptonote_basic/account_boost_serialization.h:34, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.h:46, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.cpp:47: /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/predef/detail/endian_compat.h:11:161: note: #pragma message: The use of BOOST_*_ENDIAN and BOOST_BYTE_ORDER is deprecated. Please include and use BOOST_ENDIAN_*_BYTE instead #pragma message("The use of BOOST_*_ENDIAN and BOOST_BYTE_ORDER is deprecated. Please include and use BOOST_ENDIAN_*_BYTE instead") ^ In file included from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/random/detail/integer_log2.hpp:19:0, from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/random/detail/large_arithmetic.hpp:19, from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/random/detail/const_mod.hpp:23, from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/random/detail/seed_impl.hpp:26, from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/random/mersenne_twister.hpp:30, from /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/uuid/random_generator.hpp:17, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/contrib/epee/include/net/network_throttle.hpp:61, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/contrib/epee/include/net/network_throttle-detail.hpp:40, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/contrib/epee/include/net/abstract_tcp_server2.h:59, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/contrib/epee/include/net/http_server_impl_base.h:36, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/message_transporter.h:35, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/message_store.h:46, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.h:65, from /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.cpp:47: /gnu/store/pz22lgiw476i9fla6ds5f1shchndk7ny-boost-1.69.0/include/boost/pending/integer_log2.hpp:7:89: note: #pragma message: This header is deprecated. Use instead. /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.cpp: In member function ‘void tools::wallet2::get_outs(std::vector > >&, const std::vector&, size_t)’: /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/src/wallet/wallet2.cpp:7729:12: warning: variable ‘existing_ring_found’ set but not used [-Wunused-but-set-variable] bool existing_ring_found = false; ^ c++: internal compiler error: Killed (program cc1plus) Please submit a full bug report, with preprocessed source if appropriate. See for instructions. make[2]: *** [src/wallet/CMakeFiles/obj_wallet.dir/build.make:66: src/wallet/CMakeFiles/obj_wallet.dir/wallet2.cpp.o] Error 4 make[2]: Leaving directory '/tmp/guix-build-monero-0.14.1.0.drv-0/build' make[1]: *** [CMakeFiles/Makefile2:2456: src/wallet/CMakeFiles/obj_wallet.dir/all] Error 2 -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 18:17:48 2019 Received: (at 36258) by debbugs.gnu.org; 22 Jun 2019 22:17:48 +0000 Received: from localhost ([127.0.0.1]:52633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heoKS-0006mb-3g for submit@debbugs.gnu.org; Sat, 22 Jun 2019 18:17:48 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heoKO-0006mL-FC for 36258@debbugs.gnu.org; Sat, 22 Jun 2019 18:17:46 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A9C3B2400E5 for <36258@debbugs.gnu.org>; Sun, 23 Jun 2019 00:17:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1561241857; bh=/D1c8PAGts0I8qubsBNYsJIPo8YIjZbFK7TTyfPDysQ=; h=From:To:Cc:Subject:Date:From; b=fo+lSKK8YkCCK+waBID5M6NcjBkV9aOSl/dIghw1862KTFFUaliTzX3xkPxp205Tx YulS0bECVhxnX949KxGdITvPd4MVJi9291VOopK1ynO0BOHhOXoWMgC6y+wFlMw1DU bgLnTXM+Zhu5OPcl9t5Uz2qCMkMPhl7ThsirrOtRWae94FURAZ3KO3K5PdnQexBw0k +lW2QSultxEemp/yeQYaHBZ+9x/DQgDdD84ZmvPlwjPO9w3QH35q/tFsVIwyjQihWu vqInEwbvUhuyNHp+EwLGL3SK2smymigQil7cKPfrvBgFitxfWDByLHVYUNZ4NUURL6 G6v8UUSGarnCw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45WVKq2pgqz9rxG; Sun, 23 Jun 2019 00:17:32 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume LE VAILLANT To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> Date: Sun, 23 Jun 2019 00:17:32 +0200 Message-ID: <87imsx2rk3.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258 Cc: 36258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) swedebugia a =C3=A9crit : > I tried building it with 4GB ram and 4GB swap but it failed with this err= or > which I suspect is memory-related. > > I'm building it again now with -c 1 and it got past this point :) I will = review > further once it is done. > > make -f src/wallet/CMakeFiles/obj_wallet.dir/build.make > src/wallet/CMakeFiles/obj_wallet.dir/build > make[2]: Entering directory '/tmp/guix-build-monero-0.14.1.0.drv-0/build' > [ 32%] Building CXX object src/wallet/CMakeFiles/obj_wallet.dir/wallet2.c= pp.o > > [...] > > c++: internal compiler error: Killed (program cc1plus) Yes I think it's a crash caused by an "out of memory" error. The wallet2.cpp file is pretty big (around 500 kB), and apparently g++ wants several gigabytes of RAM to compile it. When compiling on my system with 8 threads, 16 GB of RAM and 8 GB of swap, I often saw between 3 and 4 GB being swapped when the compiling process got to that file. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 07:31:30 2019 Received: (at 36258) by debbugs.gnu.org; 23 Jun 2019 11:31:30 +0000 Received: from localhost ([127.0.0.1]:52925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf0iY-0004d7-6R for submit@debbugs.gnu.org; Sun, 23 Jun 2019 07:31:30 -0400 Received: from mx1.riseup.net ([198.252.153.129]:40260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf0iW-0004bT-OJ for 36258@debbugs.gnu.org; Sun, 23 Jun 2019 07:31:29 -0400 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 1C1681A302F; Sun, 23 Jun 2019 04:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561289488; bh=NGjXIr2nBOR6b/G4gWVLPiemAS0BDKqTJVkQmFe7n2Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EAngIeE2G/YGM/frypvjXtfrs1INyyWv3Vjg6Wv/G4EiFCg7l5t2gMKFHiD7NjPw/ ZjlK3JJBF6jaurmc4UOhbdvKU4JtU41ij6lCdELMNC21w5sxmlDG76XUuQHV5b6tjI Yg9d/gFKS8fdLPRz2Ifong5toEtswwEFd2bgjTro= X-Riseup-User-ID: FEA408D79F7E62DC9EC39800CBD20D0275BF37C08A13BC978A532F709D54C313 Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 1E6EB1203DC; Sun, 23 Jun 2019 04:31:26 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: Guillaume LE VAILLANT References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> From: swedebugia Message-ID: Date: Sun, 23 Jun 2019 13:31:23 +0200 MIME-Version: 1.0 In-Reply-To: <87imsx2rk3.fsf@yamatai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36258 Cc: 36258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-06-23 00:17, Guillaume LE VAILLANT wrote: > > swedebugia a écrit : > >> I tried building it with 4GB ram and 4GB swap but it failed with this error >> which I suspect is memory-related. >> >> I'm building it again now with -c 1 and it got past this point :) I will review >> further once it is done. >> >> make -f src/wallet/CMakeFiles/obj_wallet.dir/build.make >> src/wallet/CMakeFiles/obj_wallet.dir/build >> make[2]: Entering directory '/tmp/guix-build-monero-0.14.1.0.drv-0/build' >> [ 32%] Building CXX object src/wallet/CMakeFiles/obj_wallet.dir/wallet2.cpp.o >> >> [...] >> >> c++: internal compiler error: Killed (program cc1plus) > > Yes I think it's a crash caused by an "out of memory" error. The > wallet2.cpp file is pretty big (around 500 kB), and apparently g++ wants > several gigabytes of RAM to compile it. When compiling on my system with > 8 threads, 16 GB of RAM and 8 GB of swap, I often saw between 3 and 4 GB > being swapped when the compiling process got to that file. > It finished compiling on 1 core but the tests stopped after an hour and was completely silent and no cpu use. How do I run the tests manually? I tried: cd into /tmp/guix-build-xxx source the env cd build make "ARGS=-R 'hash|core_tests'" "test" but got this error: Could not find executable /tmp/guix-build-monero-0.14.1.0.drv-0/build/tests/hash-target-tests -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 08:53:32 2019 Received: (at 36258) by debbugs.gnu.org; 23 Jun 2019 12:53:32 +0000 Received: from localhost ([127.0.0.1]:53023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf1zw-00039A-EJ for submit@debbugs.gnu.org; Sun, 23 Jun 2019 08:53:32 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf1zt-00038t-AS for 36258@debbugs.gnu.org; Sun, 23 Jun 2019 08:53:30 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 231F42400FB for <36258@debbugs.gnu.org>; Sun, 23 Jun 2019 14:53:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1561294402; bh=3+8wscUXx/fwLyK0u/iyDiA/S1O1BjF8L/7dgt8GNPk=; h=From:To:Cc:Subject:Date:From; b=mNeyoB0XPYt/42Yxrpk75RrYiFGSWUvriCr7Hws2i18huglu2i2AEgdTw2AEupmlw 4hNiGPDVaMGJaeA47CvDEt/MOGUYHmRGtTFavjmEksvnFQqwGpvHXuQjeivn0djTYZ gGz0gqi4+m/gwC5IQIWT+Wwgi3gdGgVybwoUccpMRFIcMW1nF0wbqCJNafgXo8aqBH /TBjRmH4hHop4bs2BntwEG6L93fFNIZvV8Z64iLH0jHNepEepEnPYgZcqDUcecNvfj toLr1Vyvwigz0eqEK8/oEF635CNDcgDCVSmCWQI2b+yGokXuulEmlx0cGvNnAE+tMa b888s8T4Z/kiA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45WsmH71Lsz9rxK; Sun, 23 Jun 2019 14:53:19 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume LE VAILLANT To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: Date: Sun, 23 Jun 2019 14:53:18 +0200 Message-ID: <87blyobgzl.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258 Cc: 36258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) swedebugia a =C3=A9crit : > It finished compiling on 1 core but the tests stopped after an hour and w= as > completely silent and no cpu use. > > How do I run the tests manually? > > I tried: > cd into /tmp/guix-build-xxx > source the env > cd build > make "ARGS=3D-R 'hash|core_tests'" "test" > but got this error: > Could not find executable > /tmp/guix-build-monero-0.14.1.0.drv-0/build/tests/hash-target-tests That's strange, if the compilation phase finished, the 'build/tests/hash-target-tests' file should exist. Do the 'build/tests/core_tests/core_tests' and 'build/tests/unit_tests/unit_tests' programs exist, or is your 'build/tests' directory empty? Also, 'core_tests' takes a long time to complete (around 40 minutes on my machine I think), and it doesn't print any message while it's running (but there should be 1 CPU core in use). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 09:19:03 2019 Received: (at 36258) by debbugs.gnu.org; 23 Jun 2019 13:19:03 +0000 Received: from localhost ([127.0.0.1]:53079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf2Oc-0005wi-Nk for submit@debbugs.gnu.org; Sun, 23 Jun 2019 09:19:02 -0400 Received: from mx1.riseup.net ([198.252.153.129]:35906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf2Oa-0005wH-0u for 36258@debbugs.gnu.org; Sun, 23 Jun 2019 09:19:01 -0400 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 4E9C51A308B; Sun, 23 Jun 2019 06:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561295939; bh=SV3baJfzOjRRB5vYw9ON+s4K/7h2LzTsf1E4Kdtd/Y8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XkpGtbSzd/GzjhgQwQtYBQ8pbML9daMivZhoTV23A/ke2l4I6cTzRluerKw4fnMWt AaSpclV8Afl8GEj6gm1V+vP8y4CpAXaN63TvVnjXu3oOOxQYDIe2cs0J1HKndIetM3 CuVr4t7HA0uCEwmSdqR+1tfD8bEs6EAh0GKWYo3c= X-Riseup-User-ID: 0E152B32B44F35147A69A2E33B3F3B4B380F995C93BCBF26E73BB7C32798448D Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 164A41207D9; Sun, 23 Jun 2019 06:18:57 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: Guillaume LE VAILLANT References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> From: swedebugia Message-ID: Date: Sun, 23 Jun 2019 15:18:53 +0200 MIME-Version: 1.0 In-Reply-To: <87blyobgzl.fsf@yamatai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36258 Cc: 36258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-06-23 14:53, Guillaume LE VAILLANT wrote: > > swedebugia a écrit : ... >> Could not find executable >> /tmp/guix-build-monero-0.14.1.0.drv-0/build/tests/hash-target-tests > > That's strange, if the compilation phase finished, the > 'build/tests/hash-target-tests' file should exist. > Do the 'build/tests/core_tests/core_tests' and > 'build/tests/unit_tests/unit_tests' programs exist, or is your > 'build/tests' directory empty? It did exist but the drv-paths in the makefiles was wrong. > > Also, 'core_tests' takes a long time to complete (around 40 minutes on > my machine I think), and it doesn't print any message while it's > running (but there should be 1 CPU core in use). > Got them running now. Will report back when they are done :) -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 24 02:20:36 2019 Received: (at submit) by debbugs.gnu.org; 24 Jun 2019 06:20:36 +0000 Received: from localhost ([127.0.0.1]:55430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfILD-0004yQ-SF for submit@debbugs.gnu.org; Mon, 24 Jun 2019 02:20:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:45112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfILC-0004yI-6x for submit@debbugs.gnu.org; Mon, 24 Jun 2019 02:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40507) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfILB-000509-8E for guix-patches@gnu.org; Mon, 24 Jun 2019 02:20:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfILA-0000iI-17 for guix-patches@gnu.org; Mon, 24 Jun 2019 02:20:33 -0400 Received: from mx1.riseup.net ([198.252.153.129]:60642) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfIL9-0000gL-NI for guix-patches@gnu.org; Mon, 24 Jun 2019 02:20:31 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 3857D1A22B2; Sun, 23 Jun 2019 23:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561357230; bh=TkniulqEmxGJp+iKnOMVebrEGJb/43zca9Q1GdRGib8=; h=Subject:To:References:From:Date:In-Reply-To:From; b=jHCBxSMsJpSxX6T49dz+TrIvkHHVNv398SiDWO6nX1wxy/G7fMfzt2XAVmFv4v+Mr aq4E3xuGtTn2RKyZdE8l1n0/4RMfpgzjUwwlwL41+kCRF8xdYQES6AWVtBVfjxhaF5 GFQycWHX4cCtJY3stLqXFpgRRz+a68h6IHwmJoQE= X-Riseup-User-ID: 453390EE14E1D4EFA098A072EFA70B890DD6925DB1210F38E017574B375155C1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id C5790222768; Sun, 23 Jun 2019 23:20:28 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: guix-patches@gnu.org, Guillaume LE VAILLANT References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> From: swedebugia Message-ID: <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> Date: Mon, 24 Jun 2019 08:20:24 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.252.153.129 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 2019-06-23 15:18, swedebugia wrote: > On 2019-06-23 14:53, Guillaume LE VAILLANT wrote: >> >> swedebugia a =C3=A9crit : > ... >=20 >>> Could not find executable >>> /tmp/guix-build-monero-0.14.1.0.drv-0/build/tests/hash-target-tests >> >> That's strange, if the compilation phase finished, the >> 'build/tests/hash-target-tests' file should exist. >> Do the 'build/tests/core_tests/core_tests' and >> 'build/tests/unit_tests/unit_tests' programs exist, or is your >> 'build/tests' directory empty? >=20 > It did exist but the drv-paths in the makefiles was wrong. >=20 >> >> Also, 'core_tests' takes a long time to complete (around 40 minutes on >> my machine I think), and it doesn't print any message while it's >> running (but there should be 1 CPU core in use). >> >=20 > Got them running now. Will report back when they are done :) >=20 Tests completed succesfully. I saw this note: + ;; TODO: Find why portability_wallet test fails + ;; Maybe the Boost version used to create the tes= t + ;; wallet and the current Boost version are not + ;; completely compatible? + "Serialization.portability_wallet" + "is_hdd.linux_os_root") Did you report this upstream? Could you include the failed test also (commented below the comment) Otherwise LGTM :) PS: I started working on Aeon (fork of monero) since they are very=20 similar it should be "easy" to package now that you got monero working=20 again. --=20 Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 24 05:54:38 2019 Received: (at submit) by debbugs.gnu.org; 24 Jun 2019 09:54:38 +0000 Received: from localhost ([127.0.0.1]:55589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfLgL-0004BX-M1 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 05:54:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:43286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfLgJ-0004BP-8Q for submit@debbugs.gnu.org; Mon, 24 Jun 2019 05:54:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34410) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfLgI-0007oW-6U for guix-patches@gnu.org; Mon, 24 Jun 2019 05:54:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfLgH-0001lN-50 for guix-patches@gnu.org; Mon, 24 Jun 2019 05:54:34 -0400 Received: from mout02.posteo.de ([185.67.36.66]:49291) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfLgG-0001g3-MD for guix-patches@gnu.org; Mon, 24 Jun 2019 05:54:33 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 0EF9D2400FB for ; Mon, 24 Jun 2019 11:54:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1561370068; bh=4hNK1lbkPH4p3bKcMpM+86kh61wHg/uaN+x+uNx8PWU=; h=From:To:Cc:Subject:Date:From; b=FCb2q+hSUpvmj4uskWGOw4qyzKQNRhYlY8LSgmtzy+TnSE7g1+JiIuV1facwZ0PlP 4CTy610Tp9L93NxBfbVXo9tASIYOfVnMvg7d3eYq2XItrzkXEPMA6mOVXZtVb2BXJp yWAIt4dXtxkc1v1Prfz6Hfo040+sziG/6V9EMS/9XSFI73yjuIb+vu8PHyK7RyEi7Q blH5MM1brSHELWldHHceqxFYkgJZkl4HFqG/7icrlYsho2gKk52HgYrqNELYKcc3Bb Idbb2i5dkMYp3rxvKztF40qVCCgp2/qu4gOKhmVRRzfcAn5eeIyDoFLLxhYsyOGY/t 9oDgHeI/q0g1w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45XPlR0n0dz9rxG; Mon, 24 Jun 2019 11:54:26 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume LE VAILLANT To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> Date: Mon, 24 Jun 2019 11:54:26 +0200 Message-ID: <87y31rtijx.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) swedebugia a =C3=A9crit : > Tests completed succesfully. I saw this note: > > + ;; TODO: Find why portability_wallet test fails > + ;; Maybe the Boost version used to create the test > + ;; wallet and the current Boost version are not > + ;; completely compatible? > + "Serialization.portability_wallet" > + "is_hdd.linux_os_root") > > Did you report this upstream? > Could you include the failed test also (commented below the comment) > > Otherwise LGTM :) > > PS: I started working on Aeon (fork of monero) since they are very simila= r it > should be "easy" to package now that you got monero working again. I'm not entirely sure why the "Serialization.portability_wallet" test fails. It might not be related to compatibility between Boost versions, because compiling with the same Boost version in two different ways gives different results. When I compile using 'guix build monero', the test fails. --- /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/tests/unit_t= ests/serialization.cpp:633: Failure Value of: r Actual: false Expected: true --- When I compile by hand using 'guix environment --pure monero', the test passes. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 06:07:20 2019 Received: (at submit) by debbugs.gnu.org; 25 Jun 2019 10:07:21 +0000 Received: from localhost ([127.0.0.1]:58674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfiMC-0005dp-7d for submit@debbugs.gnu.org; Tue, 25 Jun 2019 06:07:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:45961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfiMA-0005dg-Ko for submit@debbugs.gnu.org; Tue, 25 Jun 2019 06:07:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60350) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfiM6-0000Pv-Qp for guix-patches@gnu.org; Tue, 25 Jun 2019 06:07:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfiM4-0006G7-1C for guix-patches@gnu.org; Tue, 25 Jun 2019 06:07:14 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44757) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfiM3-0006CP-BB for guix-patches@gnu.org; Tue, 25 Jun 2019 06:07:11 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 09EB82400E6 for ; Tue, 25 Jun 2019 12:07:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1561457227; bh=TBhaAzaR9LMFQvTsNBXAnb09xkJCuvl9NyJX75cjlic=; h=From:To:Cc:Subject:Date:From; b=RQYAo1T6uE2mOrLRpvDSmNFHpy/owX16e1GB0alGFCJXWsTuh1YTPFt5MbRcCb8RP OkUDHRmIUa3Xy3gaRyo8xQEPKZ43lfGcMVlI3Ao7Q/2+YZOuWEca7kr7KCUTMw4gU8 5+3N7htzES68XUlq59H0ADr0izFCJLRcCRTbmkHOf4ZkfxZxm3SzjHQydgm9caNTwA pYqe/Afc+tPwYVI4io8ugOyprJ3klgVwSNFxCBtjZqxJMiCiwZFjST9p5yZuQVVU1u BHPJPzptrCLzFnWfFQze622GXsnqEdWMVDSbkTuVX7xyO8WveItvHCCrS5gBwT7icB f4TQ8LeeGlPLg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45Y1zW45Thz9rxK; Tue, 25 Jun 2019 12:07:03 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume LE VAILLANT To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: <87y31rtijx.fsf@yamatai> Date: Tue, 25 Jun 2019 12:07:02 +0200 Message-ID: <87mui63rnd.fsf@yamatai> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Guillaume LE VAILLANT a =C3=A9crit : > swedebugia a =C3=A9crit : > >> Tests completed succesfully. I saw this note: >> >> + ;; TODO: Find why portability_wallet test fails >> + ;; Maybe the Boost version used to create the te= st >> + ;; wallet and the current Boost version are not >> + ;; completely compatible? >> + "Serialization.portability_wallet" >> + "is_hdd.linux_os_root") >> >> Did you report this upstream? >> Could you include the failed test also (commented below the comment) >> >> Otherwise LGTM :) >> >> PS: I started working on Aeon (fork of monero) since they are very simil= ar it >> should be "easy" to package now that you got monero working again. > > I'm not entirely sure why the "Serialization.portability_wallet" test > fails. It might not be related to compatibility between Boost versions, > because compiling with the same Boost version in two different ways > gives different results. > > When I compile using 'guix build monero', the test fails. > --- > /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/tests/unit= _tests/serialization.cpp:633: Failure > Value of: r > Actual: false > Expected: true > --- > > When I compile by hand using 'guix environment --pure monero', the test > passes. I found out why the "Serialization.portability_wallet" failed; it was because of missing write permissions on some test files. Updated patch with the test enabled attached. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-monero-Update-to-0.14.1.0.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001-gnu-monero-Update-to-0.14.1.0.patch >From a41ff296f296e43834af07c20e60319b302b70f7 Mon Sep 17 00:00:00 2001 From: Guillaume LE VAILLANT Date: Sat, 15 Jun 2019 10:12:36 +0200 Subject: [PATCH 1/2] gnu: monero: Update to 0.14.1.0. * gnu/packages/finance.scm (monero): Update to 0.14.1.0. * gnu/packages/patches/monero-use-system-miniupnpc.patch: Update file. --- gnu/packages/finance.scm | 90 ++++++++++-------- .../patches/monero-use-system-miniupnpc.patch | 95 +++---------------- 2 files changed, 62 insertions(+), 123 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 5b95bcb704..7cdb41b372 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2018 Adriano Peluso ;;; Copyright =C2=A9 2018, 2019 Nicolas Goaziou ;;; Copyright =C2=A9 2018 Arun Isaac +;;; Copyright =C2=A9 2019 Guillaume Le Vaillant ;;; ;;; This file is part of GNU Guix. ;;; @@ -39,6 +40,7 @@ #:use-module (gnu packages base) #:use-module (gnu packages boost) #:use-module (gnu packages check) + #:use-module (gnu packages compression) #:use-module (gnu packages crypto) #:use-module (gnu packages databases) #:use-module (gnu packages documentation) @@ -68,6 +70,7 @@ #:use-module (gnu packages textutils) #:use-module (gnu packages tls) #:use-module (gnu packages upnp) + #:use-module (gnu packages version-control) #:use-module (gnu packages web) #:use-module (gnu packages xml) #:use-module (gnu packages gnuzilla)) @@ -428,49 +431,59 @@ other machines/servers. Electroncash does not downlo= ad the Bitcoin Cash blockch =20 (define-public monero ;; This package bundles easylogging++ and lmdb. - ;; The bundled easylogging++ is modified, and the changes will not be up= streamed. + ;; The bundled easylogging++ is modified, and the changes will not be + ;; upstreamed. ;; The devs deem the lmdb driver too critical a consenus component, to u= se ;; the system's dynamically linked library. (package (name "monero") - (version "0.12.3.0") + (version "0.14.1.0") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/monero-project/monero") - (commit (string-append "v" version)))) + (url "https://github.com/monero-project/monero.git") + (commit (string-append "v" version)) + (recursive? #t))) (file-name (git-file-name name version)) (patches (search-patches "monero-use-system-miniupnpc.patch")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Delete bundled dependencies. + (for-each + delete-file-recursively + '("external/miniupnp" "external/rapidjson" + "external/unbound")) + #t)) (sha256 (base32 - "14db9kgjm2ha93c2x5fjdw01xaqshn756qr3x2cnzyyjh7caz5qd")))) + "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh")))) (build-system cmake-build-system) (native-inputs `(("doxygen" ,doxygen) - ("googletest" ,googletest) + ("git" ,git) ("graphviz" ,graphviz) - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("qttools" ,qttools))) (inputs - `(("bind" ,isc-bind) - ("boost" ,boost) - ("zeromq" ,zeromq) + `(("boost" ,boost) ("cppzmq" ,cppzmq) ("expat" ,expat) - ("libsodium" ,libsodium) + ("hidapi" ,hidapi) ("libunwind" ,libunwind) - ("lmdb" ,lmdb) - ("miniupnpc" ,monero-miniupnpc) + ("libsodium" ,libsodium) + ("miniupnpc" ,miniupnpc) ("openssl" ,openssl) ("rapidjson" ,rapidjson) - ("unbound" ,unbound))) + ("readline" ,readline) + ("unbound" ,unbound) + ("xz" ,xz) + ("zeromq" ,zeromq))) (arguments `(#:out-of-source? #t - #:build-type "release" - #:configure-flags '("-DBUILD_TESTS=3DON" - ,@(if (string=3D? "aarch64-linux" (%current-sys= tem)) - '("-DARCH=3Darmv8-a") - '()) + #:configure-flags '("-DARCH=3Ddefault" + "-DBUILD_TESTS=3DON" "-DBUILD_GUI_DEPS=3DON") #:phases (modify-phases %standard-phases @@ -479,24 +492,24 @@ other machines/servers. Electroncash does not downlo= ad the Bitcoin Cash blockch (lambda _ (setenv "HOME" (getcwd)) #t)) - (add-after 'set-home 'fix-wallet-path-for-unit-tests - (lambda _ - (substitute* "tests/unit_tests/serialization.cpp" - (("\\.\\./\\.\\./\\.\\./\\.\\./") "../../")) - #t)) - (add-after 'fix-wallet-path-for-unit-tests 'change-log-path + (add-after 'set-home 'change-log-path (lambda _ (substitute* "contrib/epee/src/mlog.cpp" (("epee::string_tools::get_current_module_folder\\(\\)") - "\".bitmonero\"")) - (substitute* "contrib/epee/src/mlog.cpp" - (("return \\(") "return ((std::string(getenv(\"HOME\"))) / = ")) + "\".bitmonero\"") + (("return \\(") + "return ((std::string(getenv(\"HOME\"))) / ")) #t)) + (add-after 'change-log-path 'fix-file-permissions-for-tests + (lambda _ + (for-each (lambda (f) + (chmod f #o644)) + (find-files "tests/data/" "wallet_9svHk1.*")) + #t)) + ;; Only try tests that don't need access to network or system (replace 'check (lambda _ - (invoke "make" "ARGS=3D-E 'unit_tests|libwallet_api_tests'" - "test"))) - ;; The excluded unit tests need network access + (invoke "make" "ARGS=3D-R 'hash|core_tests'" "test"))) (add-after 'check 'unit-tests (lambda _ (let ((excluded-unit-tests @@ -506,22 +519,17 @@ other machines/servers. Electroncash does not downlo= ad the Bitcoin Cash blockch "DNSResolver.IPv4Success" "DNSResolver.DNSSECSuccess" "DNSResolver.DNSSECFailure" - "DNSResolver.GetTXTRecord") + "DNSResolver.GetTXTRecord" + "is_hdd.linux_os_root") ":"))) (invoke "tests/unit_tests/unit_tests" (string-append "--gtest_filter=3D-" - excluded-unit-tests))))) - (add-after 'install 'install-blockchain-import-export - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin"))) - (install-file "bin/monero-blockchain-import" bin) - (install-file "bin/monero-blockchain-export" bin))))))) + excluded-unit-tests)))))))) (home-page "https://getmonero.org/") (synopsis "Command-line interface to the Monero currency") (description - "Monero is a secure, private, untraceable currency. This package pro= vides the -Monero command line client and daemon.") + "Monero is a secure, private, untraceable currency. This package pro= vides +the Monero command line client and daemon.") (license license:bsd-3))) =20 (define-public monero-gui diff --git a/gnu/packages/patches/monero-use-system-miniupnpc.patch b/gnu/p= ackages/patches/monero-use-system-miniupnpc.patch index 6bc825d121..c5d376d793 100644 --- a/gnu/packages/patches/monero-use-system-miniupnpc.patch +++ b/gnu/packages/patches/monero-use-system-miniupnpc.patch @@ -1,111 +1,42 @@ -This reverts commit 1e20d705e7c64d2b17c031f345057d1e8850fafa, so that it's= possible to use our own -miniupnpc, instead of a git submodule. ---- - CMakeLists.txt | 8 ++++++++ - external/CMakeLists.txt | 41 +++++++++++++++++++++++++++++++---------- - src/p2p/net_node.inl | 13 ++++++++++--- - 3 files changed, 49 insertions(+), 13 deletions(-) - -diff --git a/CMakeLists.txt b/CMakeLists.txt -index 3b93988e..ef948885 100644 ---- a/CMakeLists.txt -+++ b/CMakeLists.txt -@@ -430,6 +430,14 @@ include_directories("${CMAKE_CURRENT_BINARY_DIR}/tran= slations") -=20 - add_subdirectory(external) -=20 -+# Final setup for miniupnpc -+if(UPNP_STATIC OR IOS) -+ add_definitions("-DUPNP_STATIC") -+else() -+ add_definitions("-DUPNP_DYNAMIC") -+ include_directories(${UPNP_INCLUDE}) -+endif() -+ - # Final setup for libunbound - include_directories(${UNBOUND_INCLUDE}) - link_directories(${UNBOUND_LIBRARY_DIRS}) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt -index 1fc4d64c..b4f712ee 100644 +index 7553f87e..8e865c6c 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt -@@ -34,21 +34,42 @@ - # We always compile if we are building statically to reduce static depend= ency issues... - # ...except for FreeBSD, because FreeBSD is a special case that doesn't p= lay well with - # others. -+if(NOT IOS) -+ find_package(Miniupnpc QUIET) -+endif() +@@ -37,19 +37,7 @@ =20=20 --find_package(Miniupnpc REQUIRED) -+# If we have the correct shared version and we're not building static, us= e it -+if(STATIC OR IOS) -+ set(USE_SHARED_MINIUPNPC false) -+elseif(MINIUPNP_FOUND AND MINIUPNPC_VERSION_1_7_OR_HIGHER) -+ set(USE_SHARED_MINIUPNPC true) -+endif() + find_package(Miniupnpc REQUIRED) =20=20 -message(STATUS "Using in-tree miniupnpc") -+if(USE_SHARED_MINIUPNPC) -+ message(STATUS "Using shared miniupnpc found at ${MINIUPNP_INCLUDE_DIR}= ") -=20 -add_subdirectory(miniupnp/miniupnpc) -+ set(UPNP_STATIC false PARENT_SCOPE) -+ set(UPNP_INCLUDE ${MINIUPNP_INCLUDE_DIR} PARENT_SCOPE) -+ set(UPNP_LIBRARIES ${MINIUPNP_LIBRARY} PARENT_SCOPE) -+else() -+ if(STATIC) -+ message(STATUS "Using miniupnpc from local source tree for static bui= ld") -+ else() -+ message(STATUS "Using miniupnpc from local source tree (/external/min= iupnp/miniupnpc)") -+ endif() -=20 -set_property(TARGET libminiupnpc-static PROPERTY FOLDER "external") -if(MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_= FLAGS " -wd4244 -wd4267") -elseif(NOT MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_= FLAGS " -Wno-undef -Wno-unused-result -Wno-unused-value") -endif() -+ add_subdirectory(miniupnp/miniupnpc) -+ -+ set_property(TARGET libminiupnpc-static PROPERTY FOLDER "external") -+ if(MSVC) -+ set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPIL= E_FLAGS " -wd4244 -wd4267") -+ elseif(NOT MSVC) -+ set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPIL= E_FLAGS " -Wno-undef -Wno-unused-result -Wno-unused-value") -+ endif() -=20 +-if(CMAKE_SYSTEM_NAME MATCHES "NetBSD") +- set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_F= LAGS " -D_NETBSD_SOURCE") +-endif() +- -set(UPNP_LIBRARIES "libminiupnpc-static" PARENT_SCOPE) -+ set(UPNP_STATIC true PARENT_SCOPE) -+ set(UPNP_LIBRARIES "libminiupnpc-static" PARENT_SCOPE) -+endif() ++set(UPNP_LIBRARIES "miniupnpc" PARENT_SCOPE) =20=20 find_package(Unbound) =20=20 diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl -index 9b21705e..76340a22 100644 +index 74924e4f..3554dd0d 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl -@@ -49,9 +49,16 @@ +@@ -49,9 +49,9 @@ #include "storages/levin_abstract_invoke2.h" #include "cryptonote_core/cryptonote_core.h" =20=20 -#include -#include -#include -+// We have to look for miniupnpc headers in different places, dependent o= n if its compiled or external -+#ifdef UPNP_STATIC -+ #include -+ #include -+ #include -+#else -+ #include "miniupnpc.h" -+ #include "upnpcommands.h" -+ #include "upnperrors.h" -+#endif ++#include ++#include ++#include =20=20 #undef MONERO_DEFAULT_LOG_CATEGORY #define MONERO_DEFAULT_LOG_CATEGORY "net.p2p" ---=20 -2.16.2 - --=20 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 07:32:28 2019 Received: (at submit) by debbugs.gnu.org; 25 Jun 2019 11:32:28 +0000 Received: from localhost ([127.0.0.1]:58767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjgX-0005hh-Vh for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:32:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:46589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjgW-0005g8-5T for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:32:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54706) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfjgV-00032Q-2I for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfjgT-0008Nw-PS for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:22 -0400 Received: from mx1.riseup.net ([198.252.153.129]:52562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfjgT-0008Ms-JT for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:21 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 7C8E51B939D; Tue, 25 Jun 2019 04:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1561462340; bh=ixkr+vGHG1hzBYwkRGEdRfqnfoRa1xN51UuBH0PotUo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=im4kyNK4uX9DmpSRi/lcGl6BTpE3BmReA+V0AWUX9JbzCQapdSmAgoG71yJ0EANYF 15YBf3Lp1bWAog6SfVHGX6aZGdwszw/U0XvLvATYDsgAQdMxfPSVOIyF0Hoj51KPKf GxULK/bXuWfiPaJI4pFx1fHH9X53D9bXG4qV1llM= X-Riseup-User-ID: F263DB217340C06EFC55D99E9FCD8AB0911EF6CD43300301D41AFD36F005D48C Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 521EA223BB6; Tue, 25 Jun 2019 04:32:18 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: Guillaume LE VAILLANT References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> From: swedebugia Message-ID: <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> Date: Tue, 25 Jun 2019 13:32:15 +0200 MIME-Version: 1.0 In-Reply-To: <87mui63rnd.fsf@yamatai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.252.153.129 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 2019-06-25 12:07, Guillaume LE VAILLANT wrote: >=20 > Guillaume LE VAILLANT a =C3=A9crit : >=20 >> swedebugia a =C3=A9crit : >> >>> Tests completed succesfully. I saw this note: >>> >>> + ;; TODO: Find why portability_wallet test fai= ls >>> + ;; Maybe the Boost version used to create the= test >>> + ;; wallet and the current Boost version are n= ot >>> + ;; completely compatible? >>> + "Serialization.portability_wallet" >>> + "is_hdd.linux_os_root") >>> >>> Did you report this upstream? >>> Could you include the failed test also (commented below the comment) >>> >>> Otherwise LGTM :) >>> >>> PS: I started working on Aeon (fork of monero) since they are very si= milar it >>> should be "easy" to package now that you got monero working again. >> >> I'm not entirely sure why the "Serialization.portability_wallet" test >> fails. It might not be related to compatibility between Boost versions= , >> because compiling with the same Boost version in two different ways >> gives different results. >> >> When I compile using 'guix build monero', the test fails. >> --- >> /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/tests/u= nit_tests/serialization.cpp:633: Failure >> Value of: r >> Actual: false >> Expected: true >> --- >> >> When I compile by hand using 'guix environment --pure monero', the tes= t >> passes. >=20 > I found out why the "Serialization.portability_wallet" failed; it was > because of missing write permissions on some test files. >=20 > Updated patch with the test enabled attached. >=20 Good catch :D I do not have commit access so someone else will have to commit this. I'm not going to review monero-gui because qt is too heavy for my=20 mobile bandwidth. --=20 Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 06:06:30 2019 Received: (at 36258-done) by debbugs.gnu.org; 3 Jul 2019 10:06:30 +0000 Received: from localhost ([127.0.0.1]:48407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hic9l-0006kG-RS for submit@debbugs.gnu.org; Wed, 03 Jul 2019 06:06:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hic9j-0006k1-Kl for 36258-done@debbugs.gnu.org; Wed, 03 Jul 2019 06:06:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hic9d-0001vT-9Q; Wed, 03 Jul 2019 06:06:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35226 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hic9c-0004e7-3i; Wed, 03 Jul 2019 06:06:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> Date: Wed, 03 Jul 2019 12:06:17 +0200 In-Reply-To: <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> (swedebugia@riseup.net's message of "Tue, 25 Jun 2019 13:32:15 +0200") Message-ID: <871rz74eli.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258-done Cc: Guillaume LE VAILLANT , 36258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, swedebugia skribis: > I do not have commit access so someone else will have to commit this. Applied! The =E2=80=98core_tests=E2=80=99 bit of the test suite always takes an awfu= l lot of time: --8<---------------cut here---------------start------------->8--- Test project /tmp/guix-build-monero-0.14.1.0.drv-0/build Start 1: hash-target 1/13 Test #1: hash-target ...................... Passed 0.85 sec Start 2: core_tests 2/13 Test #2: core_tests ....................... Passed 3871.80 sec Start 9: hash-fast --8<---------------cut here---------------end--------------->8--- Anyway, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 07:11:58 2019 Received: (at 36258-done) by debbugs.gnu.org; 14 Jul 2019 11:11:58 +0000 Received: from localhost ([127.0.0.1]:43910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmcQA-0003VT-HJ for submit@debbugs.gnu.org; Sun, 14 Jul 2019 07:11:58 -0400 Received: from mx1.riseup.net ([198.252.153.129]:47806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmcQ9-0003VM-36 for 36258-done@debbugs.gnu.org; Sun, 14 Jul 2019 07:11:57 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 7B6871A2E07; Sun, 14 Jul 2019 04:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1563102716; bh=MwrsyJg1UiwPuJHiRlA/UtE5vjI58TS9zeJplVaHxrk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=WGq+r7aarZv6MWC176/Xw8svONYK+x6PZLL4RmUJqPJnRKFxoewMHdGcxexjYBIsB uRybPSFmlM/QpQBRI7Szo08Uj2YGAI/3zoQEtkWFt4oZPmhk61nygt2r9AX7Lngle7 uwrYLUOAF+N9bcEU4KzhANRL8MB/gnhd97h+jZiM= X-Riseup-User-ID: C3B25B9BEA775C11C462781487AE1CE50E496BD318E1862405DCDEA5745B1B41 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 37DB0222796; Sun, 14 Jul 2019 04:11:54 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> From: swedebugia Message-ID: <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> Date: Sun, 14 Jul 2019 13:11:51 +0200 MIME-Version: 1.0 In-Reply-To: <871rz74eli.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36258-done Cc: Guillaume LE VAILLANT , 36258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-07-03 12:06, Ludovic Courtès wrote: > Hi, > > swedebugia skribis: > >> I do not have commit access so someone else will have to commit this. > > Applied! It times out: Start 1: hash-target 1/13 Test #1: hash-target ...................... Passed 1.00 sec Start 2: core_tests building of `/gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0.drv' timed out after 3600 seconds of silence @ build-failed /gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0.drv - timeout http://ci.guix.gnu.org/log/5n9alpgkb7kmv87gwn30fbwqmpd6k138-monero-0.14.1.0 -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 07:52:04 2019 Received: (at 36258-done) by debbugs.gnu.org; 14 Jul 2019 11:52:05 +0000 Received: from localhost ([127.0.0.1]:43931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmd2y-0006c1-Lk for submit@debbugs.gnu.org; Sun, 14 Jul 2019 07:52:04 -0400 Received: from mout02.posteo.de ([185.67.36.66]:39923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmd2t-0006ad-6k for 36258-done@debbugs.gnu.org; Sun, 14 Jul 2019 07:52:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 0435D2400FC for <36258-done@debbugs.gnu.org>; Sun, 14 Jul 2019 13:51:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1563105113; bh=4JaXAaCBDDR2Ea/C/W2L07eIKqfH7qK5PEwKXi+4ue4=; h=From:To:Cc:Subject:Date:From; b=AT7CK121SAfYs3ennWRko5z+4a9YmAvr9t3VQIkQsIrCW73mZvNkLS7J7oDtZMWch o9CSYdaeOVpeHxxC9jKlnXb4xZZo59FprqelHequ/65xgFi/wWCjkD/cBYgJOh2wbj 5NrF7VQHniE1zaDgpFjX9cQ3nPG0uHEitxWqSfS0Za7SYqcb313A/Zi7Pb9tMuDr56 cBv7Sd5BxgZEPGFdTexgzRoXKO9vixe1Nv6MVLTGE+1u/tljACb8FdouJrTJ3wiIyj etoVmFjC1K+jq7mMi/Qcfe/NXNffN3Eq09zqCjDFliaKw0o/c6jQNGbqDKEkVMnsSJ +OfZ53DsPxd3Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45mlPg0cWVz9rxG; Sun, 14 Jul 2019 13:51:49 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume Le Vaillant To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> Date: Sun, 14 Jul 2019 13:51:48 +0200 Message-ID: <87pnmcltpn.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258-done Cc: 36258-done@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) swedebugia a =C3=A9crit : > It times out: > > > Start 1: hash-target > 1/13 Test #1: hash-target ...................... Passed 1.00 sec > Start 2: core_tests > building of `/gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0.= drv' > timed out after 3600 seconds of silence > @ build-failed > /gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0.drv - timeout > > http://ci.guix.gnu.org/log/5n9alpgkb7kmv87gwn30fbwqmpd6k138-monero-0.14.1= .0 We could disable 'core_tests' in the test phase if the time they take is a problem. The other enabled tests should only take 5 or 10 minutes I think. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 09:32:30 2019 Received: (at 36258-done) by debbugs.gnu.org; 14 Jul 2019 13:32:30 +0000 Received: from localhost ([127.0.0.1]:44009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmecA-0002p1-51 for submit@debbugs.gnu.org; Sun, 14 Jul 2019 09:32:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmec7-0002on-6o for 36258-done@debbugs.gnu.org; Sun, 14 Jul 2019 09:32:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmec0-0007DX-4F; Sun, 14 Jul 2019 09:32:20 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59966 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmebz-0000L0-9T; Sun, 14 Jul 2019 09:32:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Guillaume Le Vaillant Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> <87pnmcltpn.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Messidor an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 14 Jul 2019 15:32:16 +0200 In-Reply-To: <87pnmcltpn.fsf@yamatai> (Guillaume Le Vaillant's message of "Sun, 14 Jul 2019 13:51:48 +0200") Message-ID: <87tvbo68tb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258-done Cc: swedebugia , 36258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi swedebugia and Guillaume, Guillaume Le Vaillant skribis: > swedebugia a =C3=A9crit : > >> It times out: >> >> >> Start 1: hash-target >> 1/13 Test #1: hash-target ...................... Passed 1.00 sec >> Start 2: core_tests >> building of `/gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0= .drv' >> timed out after 3600 seconds of silence >> @ build-failed >> /gnu/store/y35w9qpz1v9k7srxajpaqch4s7l8mind-monero-0.14.1.0.drv - timeout >> >> http://ci.guix.gnu.org/log/5n9alpgkb7kmv87gwn30fbwqmpd6k138-monero-0.14.= 1.0 Yeah, like I wrote earlier, this test takes a lot of time, and so, depending on the machine, it might take longer than the max-silent-timeout. Not great. > We could disable 'core_tests' in the test phase if the time they take is > a problem. The other enabled tests should only take 5 or 10 minutes > I think. I=E2=80=99d rather not disable tests just because they take a long time. An obvious workaround would be to have the test machinery display some sort of progress report or really anything that shows it=E2=80=99s still = =E2=80=9Cdoing something=E2=80=9D so that we don=E2=80=99t hit max-silent-timeout. Do you know if the build system or CTest has a flag that would make it more verbose? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 10:55:34 2019 Received: (at 36258-done) by debbugs.gnu.org; 14 Jul 2019 14:55:34 +0000 Received: from localhost ([127.0.0.1]:45617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmfuY-0005QK-0G for submit@debbugs.gnu.org; Sun, 14 Jul 2019 10:55:34 -0400 Received: from mx1.riseup.net ([198.252.153.129]:39726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmfuV-0005QC-Tt for 36258-done@debbugs.gnu.org; Sun, 14 Jul 2019 10:55:32 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 021D31A0705; Sun, 14 Jul 2019 07:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1563116131; bh=14aT2U1aPZX+yFKfdiScFJu9Mp1ucJylseUkTdD2BCA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nUCyeDvrSG9xLFJv45MOUAUB176vQV6NThrJ7Lo3CuuvRG1Oj5Av1A5JGUmKz3hEu 31kMGP+1PzUaxzoh/mrZfeIkl6vT7R7YNOqfyMaO/UOxkCPqyc/u5vbxR6wPQdaMYM dHudCHyOpe+RO04R+MjJdDD6Z+DHKxqX5Ilsozyc= X-Riseup-User-ID: 85F47CE54BFD83CF3CE255C883C5AF7839CFAA3005507D05288B589F16B102C1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id D0FA22201DE; Sun, 14 Jul 2019 07:55:29 -0700 (PDT) Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Guillaume Le Vaillant References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> <87pnmcltpn.fsf@yamatai> <87tvbo68tb.fsf@gnu.org> From: swedebugia Message-ID: Date: Sun, 14 Jul 2019 16:55:27 +0200 MIME-Version: 1.0 In-Reply-To: <87tvbo68tb.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36258-done Cc: 36258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-07-14 15:32, Ludovic Courtès wrote: ... > > I’d rather not disable tests just because they take a long time. > > An obvious workaround would be to have the test machinery display some > sort of progress report or really anything that shows it’s still “doing > something” so that we don’t hit max-silent-timeout. > > Do you know if the build system or CTest has a flag that would make it > more verbose? It has: https://linux.die.net/man/1/ctest -V,--verbose Enable verbose output from tests. Test output is normally suppressed and only summary information is displayed. This option will show all test output. -VV,--extra-verbose Enable more verbose output from tests. Test output is normally suppressed and only summary information is displayed. This option will show even more test output. --debug Displaying more verbose internals of CTest. This feature will result in large number of output that is mostly useful for debugging dashboard problems. Could you test those Guillaume and see if it helps us? -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 12:14:03 2019 Received: (at 36258-done) by debbugs.gnu.org; 14 Jul 2019 16:14:03 +0000 Received: from localhost ([127.0.0.1]:45703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmh8V-0003Gm-3m for submit@debbugs.gnu.org; Sun, 14 Jul 2019 12:14:03 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmh8T-0003GA-9p for 36258-done@debbugs.gnu.org; Sun, 14 Jul 2019 12:14:02 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AAEBC160060 for <36258-done@debbugs.gnu.org>; Sun, 14 Jul 2019 18:13:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1563120834; bh=iPaj/RLVBJoB6Y/oK26aJwqUYwpMMjjL6i5WibZRNRA=; h=From:To:Cc:Subject:Date:From; b=cP8ZRfRetUCJ3s6Ll+pEey5MH6v8ldydQAkWIwX9tFl+aiQz2072e/KDWOwBmUuid wW3rVks223iamwr9KrOahZjiGwQt15dBAs7MdcMHsMFhCQ7AqzqymebI6Di0KDZYXX XIVmEQ6DuaByawOi8qnFeSCPyJpyf15l2CL6nvwiJ94YGFh7WlFsYEaBB+MdFjxr8v ySaEnnKjKsSjAxwPUuEFMnYaL/1PRrovB+T6LZDYrci/VoSIGp5/XOAXS+d8lZMif5 wzMA+sN128IUhu4mEVGD22iEE5Otj0DptS9fuI/hPNJrVfBoIFu/a+G+uE2AfCTMSR E1AIBQG1XEcvg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45msD04zWnz6tm8; Sun, 14 Jul 2019 18:13:52 +0200 (CEST) References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> <87pnmcltpn.fsf@yamatai> <87tvbo68tb.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.2 From: Guillaume Le Vaillant To: swedebugia Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. In-reply-to: Date: Sun, 14 Jul 2019 18:13:51 +0200 Message-ID: <87o91wlhkw.fsf@yamatai> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258-done Cc: 36258-done@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable swedebugia a =C3=A9crit : > On 2019-07-14 15:32, Ludovic Court=C3=A8s wrote: > ... >> >> I=E2=80=99d rather not disable tests just because they take a long time. >> >> An obvious workaround would be to have the test machinery display some >> sort of progress report or really anything that shows it=E2=80=99s still= =E2=80=9Cdoing >> something=E2=80=9D so that we don=E2=80=99t hit max-silent-timeout. >> >> Do you know if the build system or CTest has a flag that would make it >> more verbose? > > It has: > https://linux.die.net/man/1/ctest > > -V,--verbose > Enable verbose output from tests. > Test output is normally suppressed and only summary information is displa= yed. > This option will show all test output. > > -VV,--extra-verbose > Enable more verbose output from tests. > Test output is normally suppressed and only summary information is displa= yed. > This option will show even more test output. > > --debug > Displaying more verbose internals of CTest. > This feature will result in large number of output that is mostly useful = for > debugging dashboard problems. > > Could you test those Guillaume and see if it helps us? Adding the '--verbose' option (patch in attachment) makes the test phase print many things, which should fix the 'max-silent-timeout' issue. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-gnu-monero-Make-tests-more-verbose.patch Content-Description: 0001-gnu-monero-Make-tests-more-verbose.patch >From 52c9affbebff3cf2e7d89b918060b46721fa6bd5 Mon Sep 17 00:00:00 2001 From: Guillaume Le Vaillant Date: Sun, 14 Jul 2019 17:37:19 +0200 Subject: [PATCH] gnu: monero: Make tests more verbose. Increase the verbosity of the 'check' phase to prevent 'core_tests' from hitting 'max-silent-timeout'. * gnu/packages/finance.scm (monero)[arguments]: Add '--verbose' option to 'check' phase. --- gnu/packages/finance.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 918ba006f2..977ac9c19c 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -509,7 +509,7 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch ;; Only try tests that don't need access to network or system (replace 'check (lambda _ - (invoke "make" "ARGS=-R 'hash|core_tests'" "test"))) + (invoke "make" "ARGS=-R 'hash|core_tests' --verbose" "test"))) (add-after 'check 'unit-tests (lambda _ (let ((excluded-unit-tests -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 15 06:50:24 2019 Received: (at 36258-done) by debbugs.gnu.org; 15 Jul 2019 10:50:24 +0000 Received: from localhost ([127.0.0.1]:46538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmyYq-0000OB-Hp for submit@debbugs.gnu.org; Mon, 15 Jul 2019 06:50:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmyYo-0000Nu-LP for 36258-done@debbugs.gnu.org; Mon, 15 Jul 2019 06:50:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmyYj-0004Yj-1a; Mon, 15 Jul 2019 06:50:17 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=39252 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmyYi-0001cH-KZ; Mon, 15 Jul 2019 06:50:16 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Guillaume Le Vaillant Subject: Re: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> <871rz74eli.fsf@gnu.org> <11a6e577-7cde-0be1-acf2-9f2ab13145ed@riseup.net> <87pnmcltpn.fsf@yamatai> <87tvbo68tb.fsf@gnu.org> <87o91wlhkw.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Messidor an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 15 Jul 2019 12:50:15 +0200 In-Reply-To: <87o91wlhkw.fsf@yamatai> (Guillaume Le Vaillant's message of "Sun, 14 Jul 2019 18:13:51 +0200") Message-ID: <87blxvpo60.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36258-done Cc: swedebugia , 36258-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Guillaume Le Vaillant skribis: >> Could you test those Guillaume and see if it helps us? > > Adding the '--verbose' option (patch in attachment) makes the test phase > print many things, which should fix the 'max-silent-timeout' issue. Applied! Now, that=E2=80=99s very verbose, so we might have the opposite problem, where we=E2=80=99re filling the disk with a big log file=E2=80=A6 = We=E2=80=99ll see! Thanks, Ludo=E2=80=99. From unknown Fri Jun 13 11:01:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Aug 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator