Subject: bug#36246: closed (Re: [bug#36246] [PATCH] guix import hackage: Add two expected failing test cases.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 20 Jun 2019 12:18:03 +0000

Your bug report

#36246: [PATCH] guix import hackage: Add two expected failing test cases.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
36246: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36246
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#36246] [PATCH] guix import hackage: Add two expected failing test cases.
From: Ludovic Courtès <[email-masked]>
To: Robert Vollmert <[email-masked]>
Cc: [email-masked]
Date: Thu, 20 Jun 2019 14:01:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Robert Vollmert <[email-masked]> skribis:

> This adds failing test cases for two hackage import bugs:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25138
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35743
>
> * tests/hackage.scm: Make comment style consistent. Add two
> cabal parsing tests, marked as expected failures.

Applied, thanks!

Ludo'.

Subject: [PATCH] guix import hackage: Add two expected failing test cases.
From: Robert Vollmert <[email-masked]>
To: [email-masked]
Cc: Robert Vollmert <[email-masked]>
Date: Sun, 16 Jun 2019 16:55:36 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

This adds failing test cases for two hackage import bugs:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25138
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35743

* tests/hackage.scm: Make comment style consistent. Add two
cabal parsing tests, marked as expected failures.
---
 tests/hackage.scm | 52 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 50 insertions(+), 2 deletions(-)

diff --git a/tests/hackage.scm b/tests/hackage.scm
index 14176b2cf9..77e333cbfc 100644
--- a/tests/hackage.scm
+++ b/tests/hackage.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Federico Beffa <[email-masked]>
+;;; Copyright © 2019 Robert Vollmert <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -236,7 +237,7 @@ library
 (test-assert "hackage->guix-package test 6"
   (eval-test-with-cabal test-cabal-6 match-ghc-foo-6))
 
-;; Check multi-line layouted description
+;; Check multi-line layouted description.
 (define test-cabal-multiline-layout
   "name: foo
 version: 1.0.0
@@ -254,7 +255,7 @@ executable cabal
 (test-assert "hackage->guix-package test multiline desc (layout)"
   (eval-test-with-cabal test-cabal-multiline-layout match-ghc-foo))
 
-;; Check multi-line braced description
+;; Check multi-line braced description.
 (define test-cabal-multiline-braced
   "name: foo
 version: 1.0.0
@@ -274,6 +275,53 @@ executable cabal
 (test-assert "hackage->guix-package test multiline desc (braced)"
   (eval-test-with-cabal test-cabal-multiline-braced match-ghc-foo))
 
+;; Check mixed layout. Compare e.g. warp.
+(define test-cabal-mixed-layout
+  "name: foo
+version: 1.0.0
+homepage: http://test.org
+synopsis: synopsis
+description: description
+license: BSD3
+executable cabal
+    build-depends:
+      HTTP       >= 4000.2.5 && < 4000.3,
+      mtl        >= 2.0      && < 3
+  ghc-options: -Wall
+")
+
+;; Fails: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35743
+(test-expect-fail 1)
+(test-assert "hackage->guix-package test mixed layout"
+  (eval-test-with-cabal test-cabal-mixed-layout match-ghc-foo))
+
+;; Check flag executable. Compare e.g. darcs.
+(define test-cabal-flag-executable
+  "name: foo
+version: 1.0.0
+homepage: http://test.org
+synopsis: synopsis
+description: description
+license: BSD3
+flag executable
+  description: Build executable
+  default:     True
+executable cabal
+  if !flag(executable)
+    buildable: False
+  else
+    buildable: True
+
+  build-depends:
+    HTTP       >= 4000.2.5 && < 4000.3,
+    mtl        >= 2.0      && < 3
+")
+
+;; Fails: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25138
+(test-expect-fail 1)
+(test-assert "hackage->guix-package test flag executable"
+  (eval-test-with-cabal test-cabal-flag-executable match-ghc-foo))
+
 ;; Check Hackage Cabal revisions.
 (define test-cabal-revision
   "name: foo
-- 
2.20.1 (Apple Git-117)