Subject: Re: [bug#36244] [PATCH] guix: canonical-newline-port: Fix handling of carriage return at buffer end.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 20 Jun 2019 13:59:13 +0200

Hi Robert,

Robert Vollmert <[email-masked]> skribis:

> Prior to this change the added test fails for me locally at byte
> 1024. It might depend on some default buffer sizes.
>
> Fixes https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35863
>
> * tests/utils.scm ("canonical-newline-port-1024"): Add test.
> * guix/utils.scm (canonical-newline-port): Correct comments on CR/LF.
> Remove CR even when they're at the end of the buffer.

Good catch.  I tweaked the commit log and applied it.

Thanks,
Ludo’.