From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 18:27:09 2019 Received: (at submit) by debbugs.gnu.org; 15 Jun 2019 22:27:09 +0000 Received: from localhost ([127.0.0.1]:39368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcH8e-000306-Q0 for submit@debbugs.gnu.org; Sat, 15 Jun 2019 18:27:09 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:45680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcH8c-0002zb-JL for submit@debbugs.gnu.org; Sat, 15 Jun 2019 18:27:07 -0400 Received: by mail-qt1-f172.google.com with SMTP id j19so6695311qtr.12 for ; Sat, 15 Jun 2019 15:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=JalDIvNEFAgjru/2xXzQYpeeh76l9+GJyQpK6mZ5rXU=; b=V9H1aE/J87jaiNmvqB60Dt0B7lMcKl46A2E2cwBketYzuzXPJt2njXeWPWZSII1WiV 6gpFEPR0ac2EhkCQ9xe+qEgtVPRNzPApGXWRIfEJmbKNbdfCo+AKaYhD5gFZl5tVtIBh f8cmlcb0bg4lcgBPTBuEUxeFOuEt7I5oURvgW682uVEDiFSxwQCaWAncOBxPXK4NnBYP 0nYodU+szJQwUSU6Ut7KDWDGSa/BocUbfc2QyYxrvOwkd6HOu9wBlkjfzPPTrXfz6EQc xW2N/hpEq65qOb5yrMjk/XqREKDXWXURCHql0KErsOiw4bI66dWGOPaxm2dZyvDZR9Zj cS/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :mime-version:content-disposition:user-agent; bh=JalDIvNEFAgjru/2xXzQYpeeh76l9+GJyQpK6mZ5rXU=; b=ZG2JiO0fQy07wqtqfq+5jUriwAKrmjJoNQcp6IBVGsghRK0ADzW/r9YVy2UqgGl8qs iDfzQ4gCCtfTXTJAou8xr9pAG+9VsGQsVrlrAHrc2dvO8KYftRdWRBHqwiU5089RS7Tf AJc9CpB3rXj8tWuPVXkt7d6VaBEDEfgWoishDRir0iJTs/HsgVaHSFjjgXtOqN40QEJZ w3crppIUxvrlkYnLMSC+20yqFrp1407n+d9SiVC7HWBFFWKRGzA8WE26xQypJITA0Sbf Y46AJWQgUM+JboLaxr/0xvLDbNdgdJG8x/S2WFWEXP0t4J9J3HEZMV7MVdblJ9tvD2xw XLBA== X-Gm-Message-State: APjAAAXWXhPzZLyeO1viPcuD+gI6M7ZRAtAdZP4uPB8tUgm6A3F1y1HK UdbYzuTIXKkJQPRby8kyf/kC5wxD X-Google-Smtp-Source: APXvYqz5DsVWD+5dxbJnPvhNEl9ZSpc3t5NwQESt++wRhF1cU3fKMqMstXwmV/JJSPXXE65NkB0uEw== X-Received: by 2002:a0c:b095:: with SMTP id o21mr15279840qvc.73.1560637620543; Sat, 15 Jun 2019 15:27:00 -0700 (PDT) Received: from zeta.rak.ac (c-98-239-128-52.hsd1.pa.comcast.net. [98.239.128.52]) by smtp.gmail.com with ESMTPSA id f26sm5790386qtf.44.2019.06.15.15.26.59 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 15 Jun 2019 15:26:59 -0700 (PDT) Date: Sat, 15 Jun 2019 18:26:59 -0400 From: Ryan Kavanagh To: submit@debbugs.gnu.org Subject: 26.1; reftex-toc-rename-label prompt incorrect Message-ID: <20190615222659.pbb5m7mjqtfm6ghs@zeta.rak.ac> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lkib3ehbc766lphy" Content-Disposition: inline X-message-flag: Please do NOT send HTML e-mail or MS Word attachments - use plain text instead X-GPG-ID: 0x8F7BF8FC4A11C97A X-GPG-Fingerprint: 4E46 9519 ED67 7734 268F BD95 8F7B F8FC 4A11 C97A User-Agent: NeoMutt/20180716 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --lkib3ehbc766lphy Content-Type: multipart/mixed; boundary="l3d3stasbguax3wl" Content-Disposition: inline --l3d3stasbguax3wl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: auctex Tags: patch The reftex-toc-rename-label function is used to rename labels from the TOC buffer. When the proposed new label already exists, the function warns the user of this fact and asks the user to confirm their intent. Unfortunately, it uses the wrong label name in the prompt: it warns the user that the old label already exists instead of warning the user that their proposed label already exists Please see attached for a patch fixing this issue. Emacs : GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.4) of 2019-02-03, modified by Debian Package: 26.1 current state: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D (setq window-system 'x reftex-plug-into-AUCTeX t ) --=20 |)|/ Ryan Kavanagh | GPG: 4E46 9519 ED67 7734 268F |\|\ https://rak.ac | BD95 8F7B F8FC 4A11 C97A --l3d3stasbguax3wl Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="reftex-toc.el.diff" --- reftex-toc.el.old 2019-06-15 18:12:47.662071109 -0400 +++ reftex-toc.el 2019-06-15 18:16:25.422666122 -0400 @@ -872,7 +872,7 @@ (setq newlabel (read-string (format "Rename label \"%s\" to:" label))) (if (assoc newlabel (symbol-value reftex-docstruct-symbol)) (if (not (y-or-n-p - (format-message "Label `%s' exists. Use anyway? " label))) + (format-message "Label `%s' exists. Use anyway? " newlabel))) (error "Abort"))) (save-excursion (save-window-excursion --l3d3stasbguax3wl-- --lkib3ehbc766lphy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQUzBAABCgAdFiEETkaVGe1ndzQmj72Vj3v4/EoRyXoFAl0FcK8ACgkQj3v4/EoR yXrN+igAiNb9eV+FdhHKt8y+xw8P+dkYSClw3Qks9sef6BPhweSeQa6CZIX66vXc h7i3OhUNDqaxDCzindIoY8EOgfucct2lAATpmTIi0MGGfTflOeKeqegj+TUCsbsO eXIADETENcPWW13lF8F49hA9rW4feiXCRGHNpN5YGvZIzidDPEdT7P9oqZ6oJ/Wa 3yTqIgpvJmWZp/P/f+Y/G6QtVhInECF/vl4aYzUI71OdciTG8MfsnNmUwLdauYRl 2viyTAVDT1DabNnubGCIJ9KUcSUItdm8kBptl28giDBFP+IABINKmb4jaQc8Kefv Di7xv5pekWqXzfCxRMttW4HAjQyAYLvX/j7O0Pwl2AFu2uJovfV9yZCaFN1bCntg KToHY2Shc+cGXJp2EtRbQOtBtQxIP6qFqoYPI9zGxiWsmqp3I+cesNzPobcSokL2 +VUqG6ln6BABwFdgm1mY75OhKOOXg2QmlhmqsKi034yBvhCrQuWu8ksvVDMoRTXj FIscXNhHaISCZSNx3BPTV/CfxN/7e0JuA+2RrkgznvWWLygQurBiYYzwt3BJSiQj xlzW1gphH1ZQkNFdyB6sReXO2+jBOFk+gMcIM/zuKE5K4ttHpnUqJ+/qzi5lvn5t 4ieTv02E06q3wfx0tzGv/QhTXGRoEY19G27WE7IEiojO+6+mIRItvlZZjgBJArsD sGQK7zhbA/9MAjAMhXvENtdc0pKTt/B4IHPDMeVmxQaVFSTsBzwToRMoZqlzNBNX X4FRzWTFogqtpnelQuSkWcWI8lj9ocejlC22yx4KesElFFrTXwNZyYzSIyT3pNZX YyfFlcsAgD0GhZjFl0m9m0gPg4kfN1Tu36V1jgcZXJJaFicIulFdhjjUUegSzPb2 8rID5u2Vdkvp1clZ17FzF8j+xKjelFk5OWcuw9uUJ1UJLh0Oj+DqwdA4yKQyMgtg togU9FHFpSJZiNEVzv5iKL8jqEdX/9pwepBiVHy3oIDjOoBL0jnbpCuEs6DqCVcI 23fESWbBVwxv94OvgGtTtmiuGSbNTrRoYBPZfrcqZcNkb7ddyUUkpmQV/BTXY4Pd mYfyOZmhHWXzRGrEVqFHrZnrxMwoRTCl9k70f7JOWljWUk4Gvdv246oq/7QJxQMs aQwVBhBskWY9Styf69ThR7yDg6fn7WrT16cuKPFJ3pT4FcF9j9bpDr2imNr+q8OG Zt2MLS6dcKNeGQW3gwDHfhRFQbpU6jMxiQXT1Qmp84HiyHHRQy1p4qReGj3hyZ+5 ouRMfeeoGlWcbYNvnhLc+M1k2r1A33bpseIMaWzg2RyayfHFvFDS8+HCZYQvuAyU 2Wz6A6iQcxgbJY2NxGpTQDwRKhkzMe1h8ybZARyJG3pov7zTG76FeG8thRAItrgf 2V/8h7xOHkXfU0/hqcAC9eLogmZBFqvtYsNHU4V5NXapL1+JNLcBnZpbWqguUNQI 8gk2J7qieN9ufNZfW3v323ia9/eba2I88gUO7cnjCXTZmtoWxAxlD+Z4UOyclnbU nCTumdI/YSQ/D8DiK4CsZENlVomSIHZrE9enUnDNqEqdzsXZEqYBUCVvMCEE4Z4L +9E3AtYUXGdN3HE3bAlLH0XIKRTllwQCa2rnrSMOw0Ja2ZrGo1348j1HkcTtUty9 Nhu/8A1rNiGo+zitM1z808Px20ZWjYgqDVqI7UFWQhxY7BiUIVQ= =PjF2 -----END PGP SIGNATURE----- --lkib3ehbc766lphy-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 10:07:21 2021 Received: (at 36235) by debbugs.gnu.org; 11 Oct 2021 14:07:21 +0000 Received: from localhost ([127.0.0.1]:60538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZvxZ-0001tx-48 for submit@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZvxX-0001tl-7n for 36235@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56044) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZvxR-0006xr-78; Mon, 11 Oct 2021 10:07:13 -0400 Received: from p5b3265dc.dip0.t-ipconnect.de ([91.50.101.220]:64044 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZvxQ-0007H8-8M; Mon, 11 Oct 2021 10:07:13 -0400 From: Arash Esbati To: Ryan Kavanagh Subject: Re: bug#36235: 26.1; reftex-toc-rename-label prompt incorrect Date: Mon, 11 Oct 2021 16:01:25 +0200 Message-ID: <86zgrf7j9m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36235 Cc: 36235@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ryan, Ryan Kavanagh writes: > The reftex-toc-rename-label function is used to rename labels from the > TOC buffer. When the proposed new label already exists, the function > warns the user of this fact and asks the user to confirm their intent. > > Unfortunately, it uses the wrong label name in the prompt: it warns > the user that the old label already exists instead of warning the user > that their proposed label already exists > > Please see attached for a patch fixing this issue. Thank you for this bug report and the suggested fix. I submitted your change (plus another minor issue) to Emacs repo and it will be fixed in Emacs 28.1[1]. My apologies that this issue took so long :-( Best, Arash Footnotes: [1] http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=915e044d60dfde0953327cb9cbfe8bb0f69e5dd4 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 10:07:33 2021 Received: (at control) by debbugs.gnu.org; 11 Oct 2021 14:07:33 +0000 Received: from localhost ([127.0.0.1]:60541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZvxl-0001uM-DK for submit@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZvxj-0001uA-Po for control@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56048) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZvxe-00074M-56 for control@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:26 -0400 Received: from p5b3265dc.dip0.t-ipconnect.de ([91.50.101.220]:64044 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZvxR-0007H8-Hd for control@debbugs.gnu.org; Mon, 11 Oct 2021 10:07:19 -0400 From: Arash Esbati To: control-debbugs Subject: Re: bug#36235: 26.1; reftex-toc-rename-label prompt incorrect Date: Mon, 11 Oct 2021 16:06:54 +0200 Message-ID: <86v9237j0h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 36235 quit From unknown Fri Jun 13 11:27:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Nov 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator