From unknown Tue Sep 09 21:33:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36233 <36233@debbugs.gnu.org> To: bug#36233 <36233@debbugs.gnu.org> Subject: Status: 26.2; Tokenization error in rcirc parser Reply-To: bug#36233 <36233@debbugs.gnu.org> Date: Wed, 10 Sep 2025 04:33:20 +0000 retitle 36233 26.2; Tokenization error in rcirc parser reassign 36233 emacs submitter 36233 "Jeff Johnson" severity 36233 minor tag 36233 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 18:08:38 2019 Received: (at submit) by debbugs.gnu.org; 15 Jun 2019 22:08:38 +0000 Received: from localhost ([127.0.0.1]:39333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcGqk-0002OV-1C for submit@debbugs.gnu.org; Sat, 15 Jun 2019 18:08:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:59471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcGkS-0001uJ-6m for submit@debbugs.gnu.org; Sat, 15 Jun 2019 18:02:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53505) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcGkQ-0007yy-Lr for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 18:02:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcGkO-0007kw-GH for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 18:02:06 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58353) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcGkN-0007eP-Uv for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 18:02:04 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A009720FBE; Sat, 15 Jun 2019 18:01:58 -0400 (EDT) Received: from imap5 ([10.202.2.55]) by compute7.internal (MEProxy); Sat, 15 Jun 2019 18:01:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h= mime-version:message-id:date:from:to:cc:subject:content-type; s= mar2016.fm; bh=r4APgct3dt3we8/hngE3WMlpA9shsbkjiDLH/1xP6I8=; b=s Hqochpibk05RJRwCWdgdkH0xa4JuLDuslum2fuPXW3B8U/48Gv7M/ExbUxkbwa1C ZhUQ30AWFpev/3vudij0Gutw6tdA7MNZmIjkz3YFOaKEBJU+YT99+ZZvU6QESaxp F3+n5Nx9NbJiBpMSUo6k5Zn1GntP3BV2hphrRP+Cj8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=r4APgct3dt3we8/hngE3WMlpA9shs bkjiDLH/1xP6I8=; b=uhX1oN6kl6O6x9pfl4+ilYtZXBjocz5SAQUstKPlXqI7n /NYx1NURCqRmbfTz9YsRkuzQ8DeHdNJpnN9hedPdMYeDfIV8AJn+X1wUw9nCKVug NHSnQ1Cyf4SphasReiP8sRbd6kivdws5MShRKjWf67wFaYCMRlk5Y/uQr9OmUB/7 JdtUfYp1Bt85j3yvy5xLFCA4CUjVU/k/+JtMtyI5Kliy7Ho8nMz8Xg2wDbpQ55Ln LpexaCrpggnc2Z7Brha5bRIVDkr6oBzCiBJP+4RWPtz6vJMJP5ue++lQhN29g0kn e5jsD9QE6l9e0YLM4HfvDvlewRxTKwhk2p27wWSCA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeigedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsehttdertd erredtnecuhfhrohhmpedflfgvfhhfucflohhhnhhsohhnfdcuoehtrhhnshiisehpohgs ohigrdgtohhmqeenucffohhmrghinhepihhnshhpihhrtggurdhorhhgnecurfgrrhgrmh epmhgrihhlfhhrohhmpehtrhhnshiisehpohgsohigrdgtohhmnecuvehluhhsthgvrhfu ihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1C8BE5C0095; Sat, 15 Jun 2019 18:01:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-663-gf46ad30-fmstable-20190607v1 Mime-Version: 1.0 Message-Id: <884c1235-744e-43b2-b379-77b3b3b04a9f@www.fastmail.com> Date: Sat, 15 Jun 2019 18:01:38 -0400 From: "Jeff Johnson" To: bug-gnu-emacs@gnu.org Subject: 26.2; Tokenization error in rcirc parser Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.26 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 15 Jun 2019 18:08:37 -0400 Cc: jhj@trnsz.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I'm reporting a bug that has to do with unused IRC protocol colon escaping combined with the use of certain unusual but not disallowed characters in channel keys. It should be noted that certain IRC servers that always colon escape the last token, (pedantic, but certainly valid per the IRC RFC's) often triggers a class of bugs, to most of which rcirc is immune, except when combing the use of ':' in a channel key, which leads the to the channel key being stripped of the ':' but not final argument. Example, if the server sends: "MODE #cchan +kl a:b :999" That is somehow parsed by rcirc as: "MODE +kl a b :999" Clearly incorrect - it should be "MODE +kl a:b 999". The colon *is* allowed as part of the channel key (as it is not disallowed in the RFC), except, of course, as the first character of the key, where it would break protocol. ircrc client does parse the case of "MODE #chan +k :a:b" correctly, yet fails for "MODE #chan +kl a:b :999". An example of an ircd that always escapes the final token and does not disallow colons in channel keys is inspircd, but there are many others. inspircd exactly follows the RFC - pedantically so - but does not conform to historical behavior - only standards compliance. Inspircd has a testnet at testnet.inspircd.org which can be easily used to reproduce the behavior reported. I've tested that this bugs exists and is reproducible on both Emacs 26.2 and 25.1 with the included rcirc. -- Jeff Johnson trnsz@pobox.com From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 16 16:10:19 2019 Received: (at 36233) by debbugs.gnu.org; 16 Jun 2019 20:10:19 +0000 Received: from localhost ([127.0.0.1]:41523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbTm-0001Sf-KV for submit@debbugs.gnu.org; Sun, 16 Jun 2019 16:10:19 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:45826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbTj-0001SD-PU; Sun, 16 Jun 2019 16:10:16 -0400 Received: by mail-io1-f66.google.com with SMTP id e3so16693975ioc.12; Sun, 16 Jun 2019 13:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MH9qmFwDvWV9umwvuT1e9mJ/1OVQ6+qeEaDgStRL71o=; b=HwvlMwPovYX0ie6AqcNzcdPAQTrnWsIqY8lW0bfQt0WgbN/qtWYs9abi8wHs78s6IM JYtkP34gi0L2K5x0X+HyLB0FG5xKyK5vy9CzrMKDBpKUUGCUibAQV6Sk6seURzW3qDwH YW3JPhIAYIyROBLPMHa0BtyjqRZ21dG9+avw1Y+9DR7MFJGtx1rZYsNaSI+rrzmn9KYd DPNnojBmfedsDSELTPb02MZa1EJbiq5iCGCsG4dR7UC6jl9oAvKr+kZNubrEcAN082du uIFJ25+l8olCRnmqoiNxsEaZMRDlLf1fxme8Fexh2Siiq3J2MmWKYcM12nMF4w2W3eJS ajbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MH9qmFwDvWV9umwvuT1e9mJ/1OVQ6+qeEaDgStRL71o=; b=Dq1TeBY7qdnsT+Xc3RM8/NA3FLjDpz6Y4YVrTDLgSZQX3lZOxTp7Z6WQj5ZY+ORiwQ 0KRAfzo4n0rFFxAys+zbf6X3o6utnNqa5dXDVtBjZ3zwBbOHfXfEVU8w0gjml24nTUE1 Axa7XGA7dFumHJQlPlpQUSLx+r0jo5cEHWW7VaDbaUnvySWgkbY9YAZiNDOlQGy9JB9J z2XBfOZzdgNXnFNj20eAVuyRMr/UPsxslMNx58WzT0T8erMyfrV1jXQ564XgxVS71e40 jLDPB6mCchbx535cgVJYRZpxtruRplIChbQgGjQazJup3uxIfxiNwhMIBHIuD+HKdkHM 5g/g== X-Gm-Message-State: APjAAAXzpBwb8TOZY4IUsK/ySOKIvFpn6yZvfP3KURv3eQ03+NDMh+/S eJqmZTZjT2QIOf5WFCErV7kuF5hO X-Google-Smtp-Source: APXvYqxKTZ6hkKI5qZ90E63X5Jsk3qVTo8m2ekuwILNEMx6R7eTrsP/MTQ6NYkTZNeQHhVGiZ3yAHA== X-Received: by 2002:a02:c88e:: with SMTP id m14mr64394207jao.69.1560715810079; Sun, 16 Jun 2019 13:10:10 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u187sm17894233iod.37.2019.06.16.13.10.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jun 2019 13:10:09 -0700 (PDT) From: Noam Postavsky To: "Jeff Johnson" Subject: Re: bug#36233: 26.2; Tokenization error in rcirc parser References: <884c1235-744e-43b2-b379-77b3b3b04a9f@www.fastmail.com> Date: Sun, 16 Jun 2019 16:10:08 -0400 In-Reply-To: <884c1235-744e-43b2-b379-77b3b3b04a9f@www.fastmail.com> (Jeff Johnson's message of "Sat, 15 Jun 2019 18:01:38 -0400") Message-ID: <87a7ehxpen.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36233 Cc: jhj@trnsz.com, 36233@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain severity 36233 minor tags 36233 + patch quit "Jeff Johnson" writes: > Example, if the server sends: > "MODE #cchan +kl a:b :999" > > That is somehow parsed by rcirc as: > "MODE +kl a b :999" Yeah, it was using [^:]* to match the middle args. Patch below. I added a test for this case in the patch, although this could probably use some more testing to make sure I haven't broken other cases. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-rcirc-parsing-more-RFC2812-compliant-Bug-36233.patch Content-Description: patch >From 9b0cb9e737e3c68f6553f1995983f524bdd92453 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 16 Jun 2019 13:48:56 -0400 Subject: [PATCH] Make rcirc parsing more RFC2812 compliant (Bug#36233) Do continue to allow multiple spaces between arguments, even though that is technically not allowed by the RFC. * lisp/net/rcirc.el (rcirc-process-server-response-1): Fix parsing of arguments which contain colons. * test/lisp/net/rcirc-tests.el: New test. --- lisp/net/rcirc.el | 25 ++++++++++++++------- test/lisp/net/rcirc-tests.el | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+), 8 deletions(-) create mode 100644 test/lisp/net/rcirc-tests.el diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 8926772b94..d81fa939b9 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -774,22 +774,31 @@ (defun rcirc-process-server-response (process text) (rcirc-process-server-response-1 process text))) (defun rcirc-process-server-response-1 (process text) - (if (string-match "^\\(:\\([^ ]+\\) \\)?\\([^ ]+\\) \\(.+\\)$" text) + ;; See https://tools.ietf.org/html/rfc2812#section-2.3.1. We accept + ;; multiple spaces between args, even though the RFC doesn't allow + ;; that. + (if (string-match "^\\(:\\([^ ]+\\) \\)?\\([^ ]+\\)" text) (let* ((user (match-string 2 text)) (sender (rcirc-user-nick user)) (cmd (match-string 3 text)) - (args (match-string 4 text)) + (cmd-end (match-end 3)) + (args nil) (handler (intern-soft (concat "rcirc-handler-" cmd)))) - (string-match "^\\([^:]*\\):?\\(.+\\)?$" args) - (let* ((args1 (match-string 1 args)) - (args2 (match-string 2 args)) - (args (delq nil (append (split-string args1 " " t) - (list args2))))) + (cl-loop with i = cmd-end + repeat 14 + while (eql i (string-match " +\\([^: ][^ ]*\\)" text i)) + do (progn (push (match-string 1 text) args) + (setq i (match-end 0))) + finally + (progn (if (eql i (string-match " +:?" text i)) + (push (substring text (match-end 0)) args) + (cl-assert (= i (length text)))) + (cl-callf nreverse args))) (if (not (fboundp handler)) (rcirc-handler-generic process cmd sender args text) (funcall handler process sender args text)) (run-hook-with-args 'rcirc-receive-message-functions - process cmd sender args text))) + process cmd sender args text)) (message "UNHANDLED: %s" text))) (defvar rcirc-responses-no-activity '("305" "306") diff --git a/test/lisp/net/rcirc-tests.el b/test/lisp/net/rcirc-tests.el new file mode 100644 index 0000000000..128cb2e754 --- /dev/null +++ b/test/lisp/net/rcirc-tests.el @@ -0,0 +1,52 @@ +;;; rcirc-tests.el --- Tests for rcirc -*- lexical-binding:t -*- + +;; Copyright (C) 2019 Free Software Foundation, Inc. + +;; This program is free software: you can redistribute it and/or +;; modify it under the terms of the GNU General Public License as +;; published by the Free Software Foundation, either version 3 of the +;; License, or (at your option) any later version. +;; +;; This program is distributed in the hope that it will be useful, but +;; WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +;; General Public License for more details. +;; +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see `https://www.gnu.org/licenses/'. + +;;; Code: + +(require 'ert) +(require 'rcirc) +(require 'cl-lib) + +(defun rcirc-tests--parse-server-response (cmd text) + (cl-letf* ((received-args nil) + ((symbol-function (intern (concat "rcirc-handler-" cmd))) + (lambda (_process sender args text) + (setq received-args (list sender cmd args text)))) + (rcirc-receive-message-functions nil) + (rcirc-trap-errors-flag nil)) + (rcirc-process-server-response nil text) + received-args)) + +(defmacro rcirc-tests--server-response-parse-should-be + (text expected-sender expected-cmd expected-args) + (declare (debug t)) + (macroexp-let2* nil ((cmd expected-cmd)) + `(should (equal (rcirc-tests--parse-server-response ,cmd ,text) + (list ,expected-sender ,cmd ,expected-args ,text))))) + +(ert-deftest rcirc-process-server-response () + (rcirc-tests--server-response-parse-should-be + "MODE #cchan +kl a:b :999" + nil "MODE" '("#cchan" "+kl" "a:b" "999")) + (rcirc-tests--server-response-parse-should-be + "MODE #cchan +kl a:b 999" + nil "MODE" '("#cchan" "+kl" "a:b" "999")) + (rcirc-tests--server-response-parse-should-be + "MODE #cchan +kl :a:b" + nil "MODE" '("#cchan" "+kl" "a:b"))) + +;;; rcirc-tests.el ends here -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 16 22:15:32 2019 Received: (at 36233) by debbugs.gnu.org; 17 Jun 2019 02:15:33 +0000 Received: from localhost ([127.0.0.1]:41773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hchBE-0007eC-7k for submit@debbugs.gnu.org; Sun, 16 Jun 2019 22:15:32 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcgto-0006ey-2w for 36233@debbugs.gnu.org; Sun, 16 Jun 2019 21:57:32 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 4B59114C644; Sun, 16 Jun 2019 21:57:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :cc:message-id:in-reply-to:references:subject:mime-version :content-type; s=sasl; bh=qddoLkBWb1wWW5BaR7t/f+ALO6s=; b=mTjF6X JIzzTnzQprwPshAEZmuCaR5VI1owf30wv/dk/lqPUYp1la7cc+FgRohfDYxcGacT MmOmhMjXmVMuFpi1AeijL/Qppv/06OV/EE2NWpcHpW0IKeGQDFvrAU/gB3Bww5kf +jIbhH6IomiMRqPBmlyCFZlkAsnHEKFN/HqoA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=date:from:to:cc :message-id:in-reply-to:references:subject:mime-version :content-type; q=dns; s=sasl; b=sNwrYeKsIFSnAzEqjGNBPFJu+5U3V02u yzcYu26Q5A5OGXZkUwn9SnARIQdCDdtv0Yz6ub9Uf+38dhhoF6QBgJMB0dTJDrsx kTi1u5/YXuS+HQjswtAwDvEMMeVfgqm1LPDcwVrcOT8LnM9+oZu325mXRfAT0N4j d3qlHyUU6yA= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 44AE414C643; Sun, 16 Jun 2019 21:57:31 -0400 (EDT) Received: from [192.168.1.140] (unknown [108.226.107.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 9495614C641; Sun, 16 Jun 2019 21:57:30 -0400 (EDT) Date: Sun, 16 Jun 2019 21:53:59 -0400 From: trnsz@pobox.com To: Noam Postavsky Message-ID: In-Reply-To: <87a7ehxpen.fsf@gmail.com> References: <884c1235-744e-43b2-b379-77b3b3b04a9f@www.fastmail.com> <87a7ehxpen.fsf@gmail.com> Subject: Re: bug#36233: 26.2; Tokenization error in rcirc parser X-Readdle-Message-ID: ba984989-350d-4927-a914-ced8da924409@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="5d06f388_79e2a9e3_42a" X-Pobox-Relay-ID: 4418845A-90A3-11E9-976D-72EEE64BB12D-32570403!pb-smtp2.pobox.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36233 X-Mailman-Approved-At: Sun, 16 Jun 2019 22:15:30 -0400 Cc: 36233@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --5d06f388_79e2a9e3_42a Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Jun 16, 2019, 4:10 PM -0400, Noam Postavsky=C2=A0, wrote: > Yeah, it was using =5B=5E:=5D* to match the middle args. Patch below. I= =C2=A0added a test for this case in the patch, although this could probab= ly=C2=A0use some more testing to make sure I haven't broken other cases. I can confirm this fix works, but I've not done extensive testing (I'm no= t normally an rcirc user). Thanks for addressing this so quickly and I look forward to seeing the fi= x in a future release. -- Jeffrey H. Johnson jhj=40trnsz.com --5d06f388_79e2a9e3_42a Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On Jun 16, 2019, 4:10 PM -0400, Noam Postavsky&=23160;, wrote:
Yeah, it was using =5B=5E= :=5D* to match the middle args. Patch below. I&=23160;added a test for th= is case in the patch, although this could probably&=23160;use some more t= esting to make sure I haven't broken other cases.

I can confirm this fix works, but I've not done extensive testing (I'm no= t normally an rcirc user).

Thanks for addressing this so quickly and I look fo= rward to seeing the fix in a future release.

--
Jeffrey H. Johnson
jhj=40trnsz.com
--5d06f388_79e2a9e3_42a-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 19:30:23 2019 Received: (at 36233) by debbugs.gnu.org; 22 Jun 2019 23:30:23 +0000 Received: from localhost ([127.0.0.1]:52685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hepSh-0002Nq-Gr for submit@debbugs.gnu.org; Sat, 22 Jun 2019 19:30:23 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:34520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hepSf-0002NN-B2; Sat, 22 Jun 2019 19:30:21 -0400 Received: by mail-io1-f65.google.com with SMTP id k8so242007iot.1; Sat, 22 Jun 2019 16:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ILoZ5LGUkt1a81XZwV+w2YDriutzU0psn+D2waKIM34=; b=JxYhEPjAVWE32GsMiswRM+aS2lyFW7xvsPL/5YZClLWy5jf86eB9DYWOK6yOx3X37G l0IYtyeuHZmMdzwJfTxteuuJcYH3D3mcjyvDHC9KnanWozejyTTMmh61VPH1Uwboywa+ hIfDo+e+JNkKCJ6vLcU0vpTGiUOntlQ9pgE5wD6IWNYXrSAMv92UyESFthC1cnB9srE8 NxygbtKMHeOlNm54xUgZsWbNbL8dlGOjT9SWhGTbCg2FHzpdWQtQlRe60b9608P1/KPE P+99lvfir/bPfHshXNI74YWFCNGG2EDtpy1gwi1/RqLbmhM6wEidel+THPoUO93rOG56 349Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ILoZ5LGUkt1a81XZwV+w2YDriutzU0psn+D2waKIM34=; b=HT3P+h0/jPO2z693X6vw8XnO7Hv28BYh+FTvyz7z6I8rWylM2ZpmLGeA2BakJJbfdS pkKJ8M9PFrPx23UbZyMn70SszUVSsSKcjCLzRZVoTFwWESNiZwPaDEN0Wt+tbpdQ5ptl Y8E/aOcIgcvty7ZlyFIkI4J1lx2TYMxvnyi9NKmHC6shubXj0XHcIWEyn9vnzErQucUH nwGHOaHA5Usu9nvBiELtTZk2zkiwX1//oKWeWuOhgQrSiXxC0VEcvjirtaF3AHJWsswv jYpkLXBzjV4Rf7NSQaVjfU6v1kS67isv7KZLliCRuCBwzNPihCnd9EcU7Rk4zEzxeLL9 Vaag== X-Gm-Message-State: APjAAAVhHVJFHELN4JjBEGBXqdWV2YsDTLhaDn6/7exMXKY9oKbYSbA5 /CrPB2qqLfphWwp1VTaobI/Hq7vx X-Google-Smtp-Source: APXvYqwT6qRMzoTSIxaiche8S2fc23CqcIdKyiPnYUM0LvLiX6xvct6U3KWJw9pZ9ZuJqXFFp7n0aQ== X-Received: by 2002:a02:b914:: with SMTP id v20mr97540622jan.83.1561246215583; Sat, 22 Jun 2019 16:30:15 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u187sm16543695iod.37.2019.06.22.16.30.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Jun 2019 16:30:14 -0700 (PDT) From: Noam Postavsky To: trnsz@pobox.com Subject: Re: bug#36233: 26.2; Tokenization error in rcirc parser References: <884c1235-744e-43b2-b379-77b3b3b04a9f@www.fastmail.com> <87a7ehxpen.fsf@gmail.com> Date: Sat, 22 Jun 2019 19:30:13 -0400 In-Reply-To: (trnsz@pobox.com's message of "Sun, 16 Jun 2019 21:53:59 -0400") Message-ID: <87v9wxtcze.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36233 Cc: 36233@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36233 fixed close 36233 27.1 quit trnsz@pobox.com writes: > On Jun 16, 2019, 4:10 PM -0400, Noam Postavsky=C2=A0, wrote: > I can confirm this fix works, but I've not done extensive testing (I'm no= t normally an rcirc user). Okay, I've run with it for a week and nothing bad happened (though I'm not a very advanced IRC user, I just hang out in #emacs on freenode). I'll push to master and we'll soon see if there are any prolems. f46b16b9fb 2019-06-22T19:25:44-04:00 "Make rcirc parsing more RFC2812 compl= iant (Bug#36233)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Df46b16b9fb00d341f2= 22422a9514f5bd62f29971 From unknown Tue Sep 09 21:33:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 Jul 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator