GNU bug report logs - #36225
26.2.90; Can't build master

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 36225 <at> debbugs.gnu.org
Subject: bug#36225: 26.2.90; Can't build master
Date: Sat, 15 Jun 2019 20:20:49 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sat, 15 Jun 2019 18:57:34 +0200
> Cc: 36225 <at> debbugs.gnu.org
> 
> > It says to update the pertinent hash in pdumper.c by manually copying
> > the hash from dmpstruct.h.  The hash to be updated is called out by
> > the error message.  So I think the information you need is there to
> > fix your build.
> 
> That is not what I mean. Of course that fixes the build, that's not
> the problem. But it would be incorrect and unsafe to blindly copy the
> hash without investigating whether there were any changes to
> Lisp_Buffer_Objfwd that would need to be reflected in pdumper.c.
> That's the whole point of the hash check: force people to adapt
> pdumper.c upon any struct change. That is what "If you change one of
> these structures, check that the pdumper.c code is still valid" means:
> whoever changed Lisp_Buffer_Objfwd (i.e., *not* me) needs to update
> pdumper.c.

If real changes were needed in pdumper.c which were omitted, it is
unlikely that the problem persisted for more than a few hours.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.