From unknown Thu Sep 11 11:56:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36182 <36182@debbugs.gnu.org> To: bug#36182 <36182@debbugs.gnu.org> Subject: Status: [PATCH] add freeorion Reply-To: bug#36182 <36182@debbugs.gnu.org> Date: Thu, 11 Sep 2025 18:56:31 +0000 retitle 36182 [PATCH] add freeorion reassign 36182 guix-patches submitter 36182 Jesse Gibbons severity 36182 normal tag 36182 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 12:22:30 2019 Received: (at submit) by debbugs.gnu.org; 12 Jun 2019 16:22:30 +0000 Received: from localhost ([127.0.0.1]:33961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb618-00046I-H8 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:22:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:39308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb616-00046B-IU for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50933) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb615-0005eu-EY for guix-patches@gnu.org; Wed, 12 Jun 2019 12:22:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb613-00064s-Us for guix-patches@gnu.org; Wed, 12 Jun 2019 12:22:27 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:34762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb613-000643-NJ for guix-patches@gnu.org; Wed, 12 Jun 2019 12:22:25 -0400 Received: by mail-pg1-x532.google.com with SMTP id p10so3337838pgn.1 for ; Wed, 12 Jun 2019 09:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version; bh=iPpDrXT9fHYk2Zdn4SpNWbF8qu80rzYwevBRnubPgWk=; b=ZaWPbLX0hdYClhXKKwWtiLo7SLHnpK7Vcx0zIt2WRlaUiSpGs/nS81MSimT9OPFSmg NBd/RpfEX/+yUPUyHVnvY5eA08CTIg73PKHhcglm1g55qtjGv9qWm1V9NqYHfNEqSuWs 1/dpo3gf74DHcer9FUAsmnwJjIf0AdqZ+Y+3UIydt8yV6WgrG0XR5+rCYvol4mw6Q944 Q1A7dn46BHxNYeRAt/Ft7WTLhfvsgP1zX9thKM6xP+VQhl4pEskjx6WSr4xAduq5IPjq YMtHpkQnHEajH8BqdtZ4DhKHiiuBdAnKRblq4zv487xYUC7iw0Q/2oY8Ut3jN8vYl1ZA Qd3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=iPpDrXT9fHYk2Zdn4SpNWbF8qu80rzYwevBRnubPgWk=; b=Cv5Z2NyIG0m/D3d+njfq2tsafMgrvjB9RuXUYll0qmMBwX53nZ/rUCFtI0JZgB/1Z3 253waUsaGoOun2X5dVN8MzDULdetaiht7f8+7p2OoPPXQ811YTiWsGkXQTraydkQLPVS No2oSzyVtzrNh9lQlSsW/yK+O4aC5k/A3M5ZYZ8/LKnnGzcD9p7uwVnUYEP185wQTj6U NGULoaxsE+SnmCgC4kJd6swJxCMyNEBzhkOnHROqI32belBR3qYqEy7/9WET/jf6vtFp oIWSDCukBsdjgCRo+tQvtm5C8vAQ+c4U6wQPF3pkPLygS8Pk77hSHVu1WUnw/u8UcxXf J8OA== X-Gm-Message-State: APjAAAU2Ciruz+KC2PF6rVLJC1yhQMSBsmw9BcVnVNJJ0LTi+M1lqXE3 IR14JxpTbExTUctjIqFbDHfaL8Xb X-Google-Smtp-Source: APXvYqwV81da1ci5zUDLcl0jmVacIHtZukaYSiYGEk9tnqHYkm2NsIwMLWZyqb6HNSXVnMzxVsaP9Q== X-Received: by 2002:a17:90a:af8e:: with SMTP id w14mr7884pjq.89.1560356543544; Wed, 12 Jun 2019 09:22:23 -0700 (PDT) Received: from localhost ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id e18sm25144pfh.176.2019.06.12.09.22.21 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 12 Jun 2019 09:22:22 -0700 (PDT) Date: Wed, 12 Jun 2019 10:22:19 -0600 From: Jesse Gibbons To: guix-patches@gnu.org Subject: [PATCH] add freeorion Message-ID: <20190612102219.6cc0d25f@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/fPQS=Lf+ZkBYXKlK+in.Hjc" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::532 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --MP_/fPQS=Lf+ZkBYXKlK+in.Hjc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Patch is attached. -Jesse --MP_/fPQS=Lf+ZkBYXKlK+in.Hjc Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-add-freeorion.patch >From cca52f508e84ac34e60a3c5167554d7ad2ad6564 Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Wed, 12 Jun 2019 10:07:32 -0600 Subject: [PATCH] add freeorion --- gnu/packages/games.scm | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 7a433a0bfd..1f7ace8888 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -7385,3 +7385,42 @@ full of enemies that can hurt it, obstacles and food to be eaten. The goal of the game is to stay alive and collect prizes. The robot program conveniently may be written in a plain text file in the Scheme programming language.") (license license:gpl3+))) + +(define-public freeorion + (package + (name "freeorion") + (version "0.4.8") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/freeorion/freeorion.git") + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) + (sha256 + (base32 + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) + (arguments + '(#:tests? #f)) + (build-system cmake-build-system) + (inputs `(("boost" ,boost) + ("boost_signals" ,boost-signals2) + ("freetype2" ,freetype) + ("python2" ,python-2.7) + ("openal" ,openal) + ("libogg" ,libogg) + ("libvorbis" ,libvorbis) + ("zlib" ,zlib) + ("libpng" ,libpng) + ("sdl2" ,sdl2) + ("glu" ,glu) + ("glew" ,glew))) + (home-page + "https://www.freeorion.org/index.php/Main_Page") + (synopsis + "Turn-based space empire and galactic conquest computer game") + (description + "FreeOrion is a free, open source, turn-based space empire and galactic +conquest (4X) computer game being designed and built by the FreeOrion project. +FreeOrion is inspired by the tradition of the Master of Orion games, but is not +a clone or remake of that series or any other game.") + (license (list license:gpl2 license:cc-by-sa3.0)))) -- 2.22.0 --MP_/fPQS=Lf+ZkBYXKlK+in.Hjc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 15:49:05 2019 Received: (at 36182) by debbugs.gnu.org; 12 Jun 2019 19:49:05 +0000 Received: from localhost ([127.0.0.1]:34098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb9F2-0005mt-V6 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 15:49:05 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb9F0-0005mQ-7N for 36182@debbugs.gnu.org; Wed, 12 Jun 2019 15:49:03 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 126A5240008; Wed, 12 Jun 2019 19:48:54 +0000 (UTC) From: Nicolas Goaziou To: Jesse Gibbons Subject: Re: [bug#36182] [PATCH] add freeorion References: <20190612102219.6cc0d25f@gmail.com> Date: Wed, 12 Jun 2019 21:48:52 +0200 In-Reply-To: <20190612102219.6cc0d25f@gmail.com> (Jesse Gibbons's message of "Wed, 12 Jun 2019 10:22:19 -0600") Message-ID: <871rzyshy3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36182 Cc: 36182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jesse Gibbons writes: > Patch is attached. -Jesse Thank you! Some comments follow. > From cca52f508e84ac34e60a3c5167554d7ad2ad6564 Mon Sep 17 00:00:00 2001 > From: Jesse Gibbons > Date: Wed, 12 Jun 2019 10:07:32 -0600 > Subject: [PATCH] add freeorion The commit message is incomplete. It should also include * gnu/packages/games.scm (freeorion): New variable. If you use Emacs, there is a template to automatically fill this. > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/freeorion/freeorion.git") > + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) Why do you need to use the latest commit instead of the latest stable release? Unless there is a good reason, Guix prefers using stable releases: (commit version) > + (sha256 > + (base32 > + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) > + (arguments > + '(#:tests? #f)) You should include a comment explaining why tests are removed. It could be, for example, '(#:tests? #f)) ;no test > + (home-page > + "https://www.freeorion.org/index.php/Main_Page") I think "https://www.freeorion.org" is enough, since it points to the page above. > + (description > + "FreeOrion is a free, open source, turn-based space empire and galactic > +conquest (4X) computer game being designed and built by the FreeOrion project. > +FreeOrion is inspired by the tradition of the Master of Orion games, but is not > +a clone or remake of that series or any other game.") It may be useful to explain what the "4X" means, or do not include it at all. Note that in the wiki, "4X" is a link, so you can get further information. > + (license (list license:gpl2 license:cc-by-sa3.0)))) Could you explain, in a comment, why there are two licenses? I assume the former is the project, and the latter is for assets. Would you mind sending an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 14:58:35 2019 Received: (at 36182) by debbugs.gnu.org; 13 Jun 2019 18:58:35 +0000 Received: from localhost ([127.0.0.1]:36120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbUvi-0004U8-Ka for submit@debbugs.gnu.org; Thu, 13 Jun 2019 14:58:35 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbUvg-0004Tp-Fw for 36182@debbugs.gnu.org; Thu, 13 Jun 2019 14:58:33 -0400 Received: by mail-pf1-f193.google.com with SMTP id c85so12407420pfc.1 for <36182@debbugs.gnu.org>; Thu, 13 Jun 2019 11:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=c9zrypKANLjYaaXaWm6kR52Kz5I94567PPFLYfLoBgU=; b=O+SGaIhK8S58ZVvwqvapUUV93kmOrffrsrGDFJ9PIWhESRunpW6qm1/xk6WJJ6kWui 20v/5VU1WXGdZzSAavWC9KXpxvy/BxE9g+0uZGvMzJLkkQJUsmWUFBazu3YYVDU2938F 9XmR9EwdEodJSR9euVGGKaVM1pEwPEyZiX2wi8+vTiuCleyFx3voy60en6mbE9QjNSna L1HEe5bWCmFCOfpKHY6NlJfkGSghxyBS5xIHRIEG01Jfnir+R/HP/LaF5YutVjFgJ+Q6 hUady729rHUgONPrUyW+zzKJDFC5DIYstI2UAeOD6gZcqBb/BTUuLnX4AZxjuKNlqYcx hOsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=c9zrypKANLjYaaXaWm6kR52Kz5I94567PPFLYfLoBgU=; b=uD6Jcx151aR58+Ul6SzYQ2QYJcmup3cyL1YqFNOo1V/W0AGwcunX3eWn1u28u8xbrM ooar4aqeKJl77NFCt2idIlvdcCgqPHRGZTIekO6o7nhmvxKK5BD7dIMumvZNpSk3pbKt HLRaj8phTxbCCqmd9b04WGgo+W/yRyzyAULL+Zs5j8QVQSEc5SUNL01zDhdRurBLjVYs nX9Tf6H/vIed2Eh/5wcciwRylX+F9YvwsNbaDcmFiN/0bCyqEksNPN1Zp4TC0Kbodooh YV2z5zODtp+eN/mQ2Ft9dAfwx8LC/Fi2y127O/oClMqckIHihKHmZVk8JsKnPqxiEn8k 0Wwg== X-Gm-Message-State: APjAAAVwnfhmZophu2E5NPAGHN3tSoafYQrCmjgsD6Qr19So/Ww9W5Jn tDRHi2DRzk2So2LoD/dqJZOWx0KD X-Google-Smtp-Source: APXvYqymfK95kCssXBN2wLBE0TPdQf4CE0lf5zaFUR+uSZNeOxk/eTLGa/UaE/KNWlv6obnc2q3/ag== X-Received: by 2002:a63:151a:: with SMTP id v26mr8332745pgl.9.1560452306165; Thu, 13 Jun 2019 11:58:26 -0700 (PDT) Received: from localhost ([38.141.50.171]) by smtp.gmail.com with ESMTPSA id g19sm532774pgb.26.2019.06.13.11.58.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 11:58:25 -0700 (PDT) Date: Thu, 13 Jun 2019 12:58:23 -0600 From: Jesse Gibbons To: Nicolas Goaziou Subject: Re: [bug#36182] [PATCH] add freeorion Message-ID: <20190613125823.5f51ed34@gmail.com> In-Reply-To: <871rzyshy3.fsf@nicolasgoaziou.fr> References: <20190612102219.6cc0d25f@gmail.com> <871rzyshy3.fsf@nicolasgoaziou.fr> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_//gV=odCxbBo/YTyTADMufto" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36182 Cc: 36182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_//gV=odCxbBo/YTyTADMufto Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wed, 12 Jun 2019 21:48:52 +0200 Nicolas Goaziou wrote: > Hello, > > Jesse Gibbons writes: > > > Patch is attached. -Jesse > > Thank you! Some comments follow. > > > From cca52f508e84ac34e60a3c5167554d7ad2ad6564 Mon Sep 17 00:00:00 > > 2001 From: Jesse Gibbons > > Date: Wed, 12 Jun 2019 10:07:32 -0600 > > Subject: [PATCH] add freeorion > > The commit message is incomplete. It should also include > > * gnu/packages/games.scm (freeorion): New variable. > > If you use Emacs, there is a template to automatically fill this. I did not know this. How do I use the template? > > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/freeorion/freeorion.git") > > + (commit > > "470d0711537804df3c2ca25532f674ab4bec58af"))) > > Why do you need to use the latest commit instead of the latest stable > release? Unless there is a good reason, Guix prefers using stable > releases: The most recent release won't build because it expects a dependency that no longer exists. I do not know which of the thousands of commits since then fixed that issue so, I cannot easily generate a patch. It follows that the best choice is to use the most recent commit, which I can confirm does not have that critical issue. I added a comment to explain why I specify the most recent commit. I also added a note that it should be updated when the next stable release is available (the maintainers seem to prefer announcing new releases every September). I will personally update this in mid-September or October if version 0.4.8.1 or 0.4.9 or 0.5 or 1.0 is available and no volunteer beats me to it. If you want I can also request release 0.4.8.1 ASAP so we can specify a release rather than a commit. I personally prefer to keep the commit and wait three or four months for the release. > > (commit version) > > > + (sha256 > > + (base32 > > + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) > > + (arguments > > + '(#:tests? #f)) > > You should include a comment explaining why tests are removed. It > could be, for example, > > '(#:tests? #f)) ;no test > > > + (home-page > > + "https://www.freeorion.org/index.php/Main_Page") > > I think "https://www.freeorion.org" is enough, since it points to the > page above. > > > + (description > > + "FreeOrion is a free, open source, turn-based space empire > > and galactic +conquest (4X) computer game being designed and built > > by the FreeOrion project. +FreeOrion is inspired by the tradition > > of the Master of Orion games, but is not +a clone or remake of that > > series or any other game.") > > It may be useful to explain what the "4X" means, or do not include it > at all. Note that in the wiki, "4X" is a link, so you can get further > information. The link says that 4X refers to a genre of strategy game centered around conquest. I think the current context is a sufficient explanation, but I did expand the description. I think it is best to keep the 4X in the description in case someone tries a search for that genre. > > > + (license (list license:gpl2 license:cc-by-sa3.0)))) > > Could you explain, in a comment, why there are two licenses? I assume > the former is the project, and the latter is for assets. I added comments to explain these licenses. > > Would you mind sending an updated patch? > > Regards, > Updated patch is attached. Is there anything else you want me to fix? --MP_//gV=odCxbBo/YTyTADMufto Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-add-freeorion.patch >From 698e471a78e0a4d44ff29f2705e61b15555d2035 Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Thu, 13 Jun 2019 12:51:46 -0600 Subject: [PATCH] add freeorion * gnu/packages/games.scm (freeorion): New variable. --- gnu/packages/games.scm | 48 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 7a433a0bfd..194c6f1db9 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -7385,3 +7385,51 @@ full of enemies that can hurt it, obstacles and food to be eaten. The goal of the game is to stay alive and collect prizes. The robot program conveniently may be written in a plain text file in the Scheme programming language.") (license license:gpl3+))) + +(define-public freeorion + (package + (name "freeorion") + (version "0.4.8") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/freeorion/freeorion.git") +;;;Most recent stable release uses boost_signals (v1) +;;;which was later replaced with boost-signals2 and +;;;no longer exists. This commit builds and runs. +;;;TODO: Update this when the next stable release when +;;;it is available. + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) + (sha256 + (base32 + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) + (arguments + '(#:tests? #f)) ;no test + (build-system cmake-build-system) + (inputs `(("boost" ,boost) + ("boost_signals" ,boost-signals2) + ("freetype2" ,freetype) + ("python2" ,python-2.7) + ("openal" ,openal) + ("libogg" ,libogg) + ("libvorbis" ,libvorbis) + ("zlib" ,zlib) + ("libpng" ,libpng) + ("sdl2" ,sdl2) + ("glu" ,glu) + ("glew" ,glew))) + (home-page + "https://www.freeorion.org/index.php/Main_Page") + (synopsis + "Turn-based space empire and galactic conquest computer game") + (description + "FreeOrion is a free, open source, turn-based space empire and galactic +conquest (4X) computer game being designed and built by the FreeOrion project. +Control an empire with the goal of exploring the galaxy, expanding your +territory, exploiting the resources, and exterminating rival alien empires. +FreeOrion is inspired by the tradition of the Master of Orion games, but is not +a clone or remake of that series or any other game.") + (license (list + license:gpl2 ;game code + license:cc-by-sa3.0)))) ;assets -- 2.22.0 --MP_//gV=odCxbBo/YTyTADMufto-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 16:56:54 2019 Received: (at 36182) by debbugs.gnu.org; 13 Jun 2019 20:56:54 +0000 Received: from localhost ([127.0.0.1]:36210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbWmE-0007Xv-8u for submit@debbugs.gnu.org; Thu, 13 Jun 2019 16:56:54 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbWmB-0007Xl-Vr for 36182@debbugs.gnu.org; Thu, 13 Jun 2019 16:56:53 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id BAEFC240003; Thu, 13 Jun 2019 20:56:46 +0000 (UTC) From: Nicolas Goaziou To: Jesse Gibbons Subject: Re: [bug#36182] [PATCH] add freeorion References: <20190612102219.6cc0d25f@gmail.com> <871rzyshy3.fsf@nicolasgoaziou.fr> <20190613125823.5f51ed34@gmail.com> Date: Thu, 13 Jun 2019 22:56:41 +0200 In-Reply-To: <20190613125823.5f51ed34@gmail.com> (Jesse Gibbons's message of "Thu, 13 Jun 2019 12:58:23 -0600") Message-ID: <87tvctp5km.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36182 Cc: 36182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jesse Gibbons writes: > On Wed, 12 Jun 2019 21:48:52 +0200 > Nicolas Goaziou wrote: >> If you use Emacs, there is a template to automatically fill this. > I did not know this. How do I use the template? See "The Perfect Setup" section of the Guix manual, in particular the part about Yasnippet. > I added a comment to explain why I specify the most recent commit. I > also added a note that it should be updated when the next stable > release is available (the maintainers seem to prefer announcing new > releases every September). I will personally update this in > mid-September or October if version 0.4.8.1 or 0.4.9 or 0.5 or 1.0 is > available and no volunteer beats me to it. If you want I can also > request release 0.4.8.1 ASAP so we can specify a release rather than a > commit. I personally prefer to keep the commit and wait three or four > months for the release. Fair enough. Thank you for the explanation. I think we also need a (file-name (git-file-name name version)) in the source. >> > + (home-page >> > + "https://www.freeorion.org/index.php/Main_Page") >> >> I think "https://www.freeorion.org" is enough, since it points to the >> page above. You probably overlooked that remark. > The link says that 4X refers to a genre of strategy game centered > around conquest. I think the current context is a sufficient > explanation, but I did expand the description. I think it is best to > keep the 4X in the description in case someone tries a search for that > genre. OK. > I added comments to explain these licenses. According to , the source code is released under gpl2, artwork, music and sounds, and in-game text are released under cc-by-sa3.0, and the game content scripts are released under both gpl2 and cc-by-sa3.0. So, the comments should include the description above, for completeness. > Updated patch is attached. Is there anything else you want me to fix? Great. I'm adding some small remarks, but overall the patch LGTM. > +;;;Most recent stable release uses boost_signals (v1) > +;;;which was later replaced with boost-signals2 and > +;;;no longer exists. This commit builds and runs. > +;;;TODO: Update this when the next stable release when > +;;;it is available. In Scheme, such comments use ";; " as a prefix. > + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) > + (sha256 > + (base32 > + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) > + (arguments > + '(#:tests? #f)) ;no test > + (build-system cmake-build-system) > + (inputs `(("boost" ,boost) > + ("boost_signals" ,boost-signals2) > + ("freetype2" ,freetype) > + ("python2" ,python-2.7) > + ("openal" ,openal) > + ("libogg" ,libogg) > + ("libvorbis" ,libvorbis) > + ("zlib" ,zlib) > + ("libpng" ,libpng) > + ("sdl2" ,sdl2) > + ("glu" ,glu) > + ("glew" ,glew))) Could you re-order inputs alphabetically? > + (home-page > + "https://www.freeorion.org/index.php/Main_Page") See above. Also, don't forget to add yourself to the Hall of Fame at the top of the "games.scm" file. Can you send an updated patch? Hopefully I should be able to apply it then. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 20:57:24 2019 Received: (at 36182) by debbugs.gnu.org; 14 Jun 2019 00:57:24 +0000 Received: from localhost ([127.0.0.1]:36340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbaWy-0007Kd-7h for submit@debbugs.gnu.org; Thu, 13 Jun 2019 20:57:24 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbaWu-0007KO-L9 for 36182@debbugs.gnu.org; Thu, 13 Jun 2019 20:57:22 -0400 Received: by mail-pl1-f194.google.com with SMTP id w10so58952plz.3 for <36182@debbugs.gnu.org>; Thu, 13 Jun 2019 17:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=zhCL8N7auT3LPMt5lMSHom3Rt4DNoIdEOT7YPJoe08o=; b=MCuIcxh+viTWe0drnTjrbRcFWH7dbtLvMWq5SRTZM3VEMVmy7lTTaM+aZIacnxAKhr UbQpNktB6o9rmj/17Dtiq1XopW7ZjLzNcBL/LFQWUjfnAedRPGd/C+m7gfsIpWnb/WHl M8QqqX5q+xIYwPRIpEUwviG0Jg5us0IlLgxE6gWKqjVVEwP9mhQxFSyYsAq2cJtccGwB s3fiBTQSVtbHUQjuWka0Bw2RhyZEP28CVVimUjIJIf9A3zULurtRpRc/XIgUZXAbA2t9 n3szZ9uig3GHj5kLcirlwVHyJM0lQwvl1/yugqyRk6Y2V10il5il8WlozFStbDmbZGa0 5dQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=zhCL8N7auT3LPMt5lMSHom3Rt4DNoIdEOT7YPJoe08o=; b=iYg9muaWrZdEPNdoU2mQNV5+H7OpkmPSEEZglxl7beXWVsP4zUyyqNEYr/0vp5SRz/ EPx2nOe9dDUu6VKzvhojcu8hWkHRFiDsqLl7JGADlRW6/ihN2T7a4dQf+psz8ccOXDXz fn2jF/2BO3viyJLzU2NBzmiIZm+NV8QzY583qVwvEkxmu5eYY5PvlY86u7fomJ6VYY7T B1BPcjKOClAmdgHwUbwCzI5dX8hmW60liH/+PQIFRVvGwsLX3rMk4HWYNvuzw92105Co qSVW7gRnIuxJC5zjY0jxlFwXECsYKOanmBf3sdiK/iV8l6ShuG2wYAmGLaxkGVo3VhTh PDMQ== X-Gm-Message-State: APjAAAVjkETEN6reRr+j1PklgFHTBQaVx4aTogtsINZm1cEAcTgY2UgO WI6TPRSfPVAlpYX/fvg/tizgVuqV X-Google-Smtp-Source: APXvYqwPDwZ2kWwWce12bWegC5zKl8VhwKIsMTC3+KPbOIhgz9MhVVNPA532bRyMrnfUMz6b7C2cnw== X-Received: by 2002:a17:902:8b8b:: with SMTP id ay11mr90396608plb.63.1560473834485; Thu, 13 Jun 2019 17:57:14 -0700 (PDT) Received: from localhost ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id s5sm920222pji.9.2019.06.13.17.57.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 17:57:13 -0700 (PDT) Date: Thu, 13 Jun 2019 18:57:09 -0600 From: Jesse Gibbons To: Nicolas Goaziou Subject: Re: [bug#36182] [PATCH] add freeorion Message-ID: <20190613185709.1a97b9ae@gmail.com> In-Reply-To: <87tvctp5km.fsf@nicolasgoaziou.fr> References: <20190612102219.6cc0d25f@gmail.com> <871rzyshy3.fsf@nicolasgoaziou.fr> <20190613125823.5f51ed34@gmail.com> <87tvctp5km.fsf@nicolasgoaziou.fr> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/dBIXrh_9P_NfqZ=J1vbmiHx" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36182 Cc: 36182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_/dBIXrh_9P_NfqZ=J1vbmiHx Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, 13 Jun 2019 22:56:41 +0200 Nicolas Goaziou wrote: > Jesse Gibbons writes: > > > On Wed, 12 Jun 2019 21:48:52 +0200 > > Nicolas Goaziou wrote: > > >> If you use Emacs, there is a template to automatically fill this. > > I did not know this. How do I use the template? > > See "The Perfect Setup" section of the Guix manual, in particular the > part about Yasnippet. I will look into this later. > > > I added a comment to explain why I specify the most recent commit. I > > also added a note that it should be updated when the next stable > > release is available (the maintainers seem to prefer announcing new > > releases every September). I will personally update this in > > mid-September or October if version 0.4.8.1 or 0.4.9 or 0.5 or 1.0 > > is available and no volunteer beats me to it. If you want I can also > > request release 0.4.8.1 ASAP so we can specify a release rather > > than a commit. I personally prefer to keep the commit and wait > > three or four months for the release. > > Fair enough. Thank you for the explanation. > > I think we also need a > > (file-name (git-file-name name version)) > > in the source. Ok. > > >> > + (home-page > >> > + "https://www.freeorion.org/index.php/Main_Page") > >> > >> I think "https://www.freeorion.org" is enough, since it points to > >> the page above. > > You probably overlooked that remark. No, i just forgot. It's fixed now, but 'guix lint' does not like it. > > > The link says that 4X refers to a genre of strategy game centered > > around conquest. I think the current context is a sufficient > > explanation, but I did expand the description. I think it is best to > > keep the 4X in the description in case someone tries a search for > > that genre. > > OK. > > > I added comments to explain these licenses. > > According to > , the > source code is released under gpl2, artwork, music and sounds, and > in-game text are released under cc-by-sa3.0, and the game content > scripts are released under both gpl2 and cc-by-sa3.0. I got my information from github. I'll update. > > So, the comments should include the description above, for > completeness. > > > Updated patch is attached. Is there anything else you want me to > > fix? > > Great. I'm adding some small remarks, but overall the patch LGTM. > > > +;;;Most recent stable release uses boost_signals (v1) > > +;;;which was later replaced with boost-signals2 and > > +;;;no longer exists. This commit builds and runs. > > +;;;TODO: Update this when the next stable release when > > +;;;it is available. > > In Scheme, such comments use ";; " as a prefix. Fixed. > > > + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) > > + (sha256 > > + (base32 > > + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) > > + (arguments > > + '(#:tests? #f)) ;no test > > + (build-system cmake-build-system) > > + (inputs `(("boost" ,boost) > > + ("boost_signals" ,boost-signals2) > > + ("freetype2" ,freetype) > > + ("python2" ,python-2.7) > > + ("openal" ,openal) > > + ("libogg" ,libogg) > > + ("libvorbis" ,libvorbis) > > + ("zlib" ,zlib) > > + ("libpng" ,libpng) > > + ("sdl2" ,sdl2) > > + ("glu" ,glu) > > + ("glew" ,glew))) > > Could you re-order inputs alphabetically? Done. > > > + (home-page > > + "https://www.freeorion.org/index.php/Main_Page") > > See above. > > Also, don't forget to add yourself to the Hall of Fame at the top of > the "games.scm" file. I did that when I added gnurobots. > > Can you send an updated patch? Hopefully I should be able to apply it > then. Attached. > > Thank you! --MP_/dBIXrh_9P_NfqZ=J1vbmiHx Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-add-freeorion.patch >From d6230c5286b95e9c8f2acc3662bddb1a20346251 Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Thu, 13 Jun 2019 18:48:43 -0600 Subject: [PATCH] add freeorion * gnu/packages/games.scm (freeorion): New variable. --- gnu/packages/games.scm | 49 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 86bdf99a32..4d6b06d55c 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -7455,3 +7455,52 @@ steam locomotive across many levels and collect all the coaches to win.") ;; The project is dual-licensed GPL2+ and GPL3+. (license (list license:gpl2+ license:gpl3+)))) + +(define-public freeorion + (package + (name "freeorion") + (version "0.4.8") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/freeorion/freeorion.git") + ;;Most recent stable release uses boost_signals (v1) which was later + ;;replaced with boost-signals2 and no longer exists. This commit builds + ;;and runs. + ;;TODO: Update this when the next stable release when it is available. + (commit "470d0711537804df3c2ca25532f674ab4bec58af"))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1wsw632l1cj17px6i88nqjzs0dngp5rsr67n6qkkjlfjfxi69j0f")))) + (arguments + '(#:tests? #f)) ;no test + (build-system cmake-build-system) + (inputs + `(("boost" ,boost) + ("boost_signals" ,boost-signals2) + ("freetype2" ,freetype) + ("glew" ,glew) + ("glu" ,glu) + ("libogg" ,libogg) + ("libpng" ,libpng) + ("libvorbis" ,libvorbis) + ("openal" ,openal) + ("python2" ,python-2.7) + ("sdl2" ,sdl2) + ("zlib" ,zlib))) + (home-page + "https://www.freeorion.org/") + (synopsis + "Turn-based space empire and galactic conquest computer game") + (description + "FreeOrion is a free, open source, turn-based space empire and galactic +conquest (4X) computer game being designed and built by the FreeOrion project. +Control an empire with the goal of exploring the galaxy, expanding your +territory, exploiting the resources, and exterminating rival alien empires. +FreeOrion is inspired by the tradition of the Master of Orion games, but is not +a clone or remake of that series or any other game.") + (license (list + license:gpl2 ;game code, game content, scripts + license:cc-by-sa3.0))));artwork, music, sound, game content, scripts -- 2.22.0 --MP_/dBIXrh_9P_NfqZ=J1vbmiHx-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 16 15:46:11 2019 Received: (at 36182-done) by debbugs.gnu.org; 16 Jun 2019 19:46:11 +0000 Received: from localhost ([127.0.0.1]:41498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcb6Q-0000qg-Bw for submit@debbugs.gnu.org; Sun, 16 Jun 2019 15:46:11 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:49761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcb6O-0000qV-3R for 36182-done@debbugs.gnu.org; Sun, 16 Jun 2019 15:46:08 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 45BEC100005; Sun, 16 Jun 2019 19:46:03 +0000 (UTC) From: Nicolas Goaziou To: Jesse Gibbons Subject: Re: [bug#36182] [PATCH] add freeorion References: <20190612102219.6cc0d25f@gmail.com> <871rzyshy3.fsf@nicolasgoaziou.fr> <20190613125823.5f51ed34@gmail.com> <87tvctp5km.fsf@nicolasgoaziou.fr> <20190613185709.1a97b9ae@gmail.com> Date: Sun, 16 Jun 2019 21:46:00 +0200 In-Reply-To: <20190613185709.1a97b9ae@gmail.com> (Jesse Gibbons's message of "Thu, 13 Jun 2019 18:57:09 -0600") Message-ID: <87fto9s493.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36182-done Cc: 36182-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jesse Gibbons writes: > No, i just forgot. It's fixed now, but 'guix lint' does not like it. Oh, you're right. I reverted my suggestion. > I got my information from github. I'll update. I also added lgpl2.1 since there is a bundled library (GiGi) with that license. I also unbundled DejaVu and Roboto fonts. >> Can you send an updated patch? Hopefully I should be able to apply it >> then. > Attached. I removed "free, open-source " from the description of the package and applied the changes above. Thank you! Regards, -- Nicolas Goaziou From unknown Thu Sep 11 11:56:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Jul 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator