GNU bug report logs - #36167
[PATCH] Replace manually crafted hex regexes with [[:xdigit:]]

Previous Next

Full log

Message #65 received at 36167 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> gmail.com, mattiase <at> acm.org, eggert <at> cs.ucla.edu
Cc: 36167 <at> debbugs.gnu.org, hi-angel <at> yandex.ru
Subject: Re: bug#36167: [PATCH] Replace manually crafted hex regexes with
 [[:xdigit:]]
Date: Tue, 11 Jun 2019 21:14:49 +0300

> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: mattiase <at> acm.org, eggert <at> cs.ucla.edu, 36167 <at> debbugs.gnu.org,
>  hi-angel <at> yandex.ru
> 
> I'm not against the replacement, I responded to the request to have a
> clear documentation of these character classes.

Specifically, this:

> > [0-9A-Fa-f] still has one advantage: the reader, and the
> > writer, know exactly which characters are included without looking it up. For
> > example:
> > 
> > - whether upper case, lower case, or both are accepted
> > - whether non-ascii digits are accepted (included in [:digit:] on many
> > platforms)
> 
> +1.  At least the doc for [:digit:] should say exactly
> what it matches.  Then it'll be clear for readers and
> writers.

The last part says "the doc should say" as if the doc doesn't already
say.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.