GNU bug report logs - #36167
[PATCH] Replace manually crafted hex regexes with [[:xdigit:]]

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36167: closed ([PATCH] Replace manually crafted hex regexes
 with [[:xdigit:]])
Date: Sat, 06 Jul 2019 08:05:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 06 Jul 2019 11:04:28 +0300
with message-id <834l3za8s3.fsf <at> gnu.org>
and subject line Re: bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]]
has caused the debbugs.gnu.org bug report #36167,
regarding [PATCH] Replace manually crafted hex regexes with [[:xdigit:]]
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36167: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36167
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]]
Date: Tue, 11 Jun 2019 14:59:46 +0300

Hopefully, this is more readable compared to older "[0-9a-fA-F]", 
because the intention is immediately obvious.

Fun fact: initially I started it because on my older Emacs this 
resulted in better performance; the difference was about 10x times. But 
I can't reproduce this on the current master anymore, i.e. the 
performance matches. Oh, well. I'm thus not sending the patch replacing 
[0-9] with [[:digit:]] because in terms of readability the intention is 
clear there, however replacing the hex regexes should still make code 
more readable.

P.S.: I'm not sure if the commit message looks okay, comments are 
welcome.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 36167-done <at> debbugs.gnu.org
Subject: Re: bug#36167: [PATCH v2] Replace manually crafted hex regexes wth
 [[:xdigit:]]
Date: Sat, 06 Jul 2019 11:04:28 +0300

> From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
> Date: Thu, 13 Jun 2019 03:18:43 +0300
> 
> * admin/charsets/mapconv:
> * build-aux/gitlog-to-changelog (parse_amend_file) (git_dir_option):
> * lisp/progmodes/verilog-mode.el (verilog-delay-re):
>     (verilog-type-font-keywords) (verilog-read-always-signals-recurse):
>     (verilog-is-number):

Thanks, I pushed this.

The log message was mis-formatted, which required me to tediously fix
it by hand.  Please in the future format the entries using "C-x 4 a"
or similar commands, to avoid that, okay?  In particular, lines longer
than 78 characters abort "git am", so please verify this doesn't
happen in the patches you submit.  "C-x 4 a" and friends format the
entries with leading TABs which you can later remove with "C-x TAB",
and that produces the optimal results, including when the log messages
are later used to generate ChangeLog files in the release tarballs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.