From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1560254399524 (code B ref -1); Tue, 11 Jun 2019 12:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2019 11:59:59 +0000 Received: from localhost ([127.0.0.1]:58118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafRX-00008N-6y for submit@debbugs.gnu.org; Tue, 11 Jun 2019 07:59:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:47824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafRU-00008C-Vj for submit@debbugs.gnu.org; Tue, 11 Jun 2019 07:59:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58432) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hafRT-00007e-G0 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hafRS-0007ee-5Q for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:55 -0400 Received: from forward104p.mail.yandex.net ([77.88.28.107]:55551) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hafRR-0007c3-HD for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:54 -0400 Received: from mxback17j.mail.yandex.net (mxback17j.mail.yandex.net [IPv6:2a02:6b8:0:1619::93]) by forward104p.mail.yandex.net (Yandex) with ESMTP id A68C94B00CCF for ; Tue, 11 Jun 2019 14:59:47 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback17j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id aqUPP7iBc4-xlnG2Td8; Tue, 11 Jun 2019 14:59:47 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560254387; bh=bgn7opccRo184EZWlaHZfWnlOSG0sXsEgedW0+p7Xjk=; h=To:Subject:From:Date:Message-Id; b=igjK8EkYrk29NELMNQ1NnAEKSS6TS0wd4UsU/OdeWpDasn4cGu9xeWOcNKDaKzhCa 0ctCe+9z0QY08OTe98vaJQY3cKt1Ec+oYrH1YRDEIIuncO/WE5diQLyK+h9yG9oRKs zi0MgGyvvApV2lWzZg3DNKBv9Php0T4lJkGr/9XA= Authentication-Results: mxback17j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id AeQQGHSO3B-xkxatwXk; Tue, 11 Jun 2019 14:59:47 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Tue, 11 Jun 2019 14:59:46 +0300 From: Konstantin Kharlamov Message-Id: <1560254386.25060.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 77.88.28.107 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hopefully, this is more readable compared to older "[0-9a-fA-F]", because the intention is immediately obvious. Fun fact: initially I started it because on my older Emacs this resulted in better performance; the difference was about 10x times. But I can't reproduce this on the current master anymore, i.e. the performance matches. Oh, well. I'm thus not sending the patch replacing [0-9] with [[:digit:]] because in terms of readability the intention is clear there, however replacing the hex regexes should still make code more readable. P.S.: I'm not sure if the commit message looks okay, comments are welcome. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: Acknowledgement ([PATCH] Replace manually crafted hex regexes with [[:xdigit:]]) References: <1560254386.25060.0@yandex.ru> In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602546311028 (code B ref 36167); Tue, 11 Jun 2019 12:04:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 12:03:51 +0000 Received: from localhost ([127.0.0.1]:58128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafVG-0000GW-V5 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 08:03:51 -0400 Received: from forward101o.mail.yandex.net ([37.140.190.181]:43032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafVE-0000GB-7A for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 08:03:49 -0400 Received: from mxback14o.mail.yandex.net (mxback14o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::65]) by forward101o.mail.yandex.net (Yandex) with ESMTP id 5D8F33C02235 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 15:03:41 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback14o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 1irMmzE04v-3eJ8mnZW; Tue, 11 Jun 2019 15:03:41 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560254621; bh=XDo96m5i/wTFIVZzmfO9ox3SqVR1N+5VLNHB1Y8r9iQ=; h=To:Subject:From:Date:Message-Id; b=XRoXqsEg7MmrTo5yD7NfgHWOdMr8MjWFUTmf/+J22wfIfyS16YnbCyt7jyRAlGhWw vjukt2y5r+4d5TrtaFSqThFQ2ie3XbwYjA1FXpG+EZB4uLIjIn2kHPAejY7CPQ6Eh/ 9vnhi2ee4iRccjtx7/8i2TsDtKoRelmdXOI/yK/A= Authentication-Results: mxback14o.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id kYjuVfHdyo-3ebOFvJk; Tue, 11 Jun 2019 15:03:40 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Tue, 11 Jun 2019 15:03:39 +0300 From: Konstantin Kharlamov Message-Id: <1560254619.25060.1@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eh, sorry, git send-email is broken, complains on something about perl SSL. This may take some time. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] References: <1560254386.25060.0@yandex.ru> In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602561863460 (code B ref 36167); Tue, 11 Jun 2019 12:30:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 12:29:46 +0000 Received: from localhost ([127.0.0.1]:58141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafuL-0000tj-5G for submit@debbugs.gnu.org; Tue, 11 Jun 2019 08:29:46 -0400 Received: from forward100j.mail.yandex.net ([5.45.198.240]:55023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafuH-0000tR-6x for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 08:29:43 -0400 Received: from mxback17j.mail.yandex.net (mxback17j.mail.yandex.net [IPv6:2a02:6b8:0:1619::93]) by forward100j.mail.yandex.net (Yandex) with ESMTP id 2677250E0326 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 15:29:34 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback17j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id tvNDHb2jgY-TYnW0NOE; Tue, 11 Jun 2019 15:29:34 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560256174; bh=IvuwKCsFl85t9gJNgfXn4rvR1LltTt/KnAF2sG8xwDQ=; h=Subject:To:From:Date:Message-Id; b=TcFRXArM5KcmmKCmzRZiWwsOWL3gUstWpdyJ8UWsvIx2gNyIqx6JV8eIAmuQreI+M aMjl8xTnVTinJMD/7WZOj1fWo7Cb1JmzR7HnCc398IqEkMLt6IGpB3/nk2IJmx5E5B Rtzz96/Q0DESGcOAbVRkHY+sZgaus+Ts0a38OI6g= Authentication-Results: mxback17j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id MBmdVOF0hS-TXxCC6P5; Tue, 11 Jun 2019 15:29:33 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Konstantin Kharlamov Date: Tue, 11 Jun 2019 15:29:25 +0300 Message-Id: <20190611122925.12809-1-Hi-Angel@yandex.ru> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * etc/schema/od-schema-v1.2-os.rnc: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/calc/calc-ext.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/calc/calc-lang.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/cedet/semantic/java.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/cedet/semantic/lex.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/emulation/cua-rect.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/gnus/gnus-art.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/gnus/mml-sec.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/gnus/nneething.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/international/mule-cmds.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/net/shr-color.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/nxml/rng-cmpct.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/nxml/rng-uri.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/nxml/rng-xsd.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/nxml/xmltok.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/org/org-mobile.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/ada-mode.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/cc-mode.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/cperl-mode.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/ebnf-dtd.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/hideif.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/progmodes/prolog.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/textmodes/css-mode.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/textmodes/sgml-mode.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/version.el: replace [0-9a-fA-F] with [[:xdigit:]] * lisp/xml.el: replace [0-9a-fA-F] with [[:xdigit:]] * test/src/emacs-module-tests.el: replace [0-9a-fA-F] with [[:xdigit:]] --- etc/schema/od-schema-v1.2-os.rnc | 2 +- lisp/calc/calc-aent.el | 2 +- lisp/calc/calc-ext.el | 4 ++-- lisp/calc/calc-lang.el | 2 +- lisp/cedet/semantic/java.el | 4 ++-- lisp/cedet/semantic/lex.el | 4 ++-- lisp/emulation/cua-rect.el | 2 +- lisp/gnus/gnus-art.el | 8 ++++---- lisp/gnus/mml-sec.el | 2 +- lisp/gnus/nneething.el | 2 +- lisp/international/mule-cmds.el | 2 +- lisp/net/shr-color.el | 2 +- lisp/nxml/rng-cmpct.el | 2 +- lisp/nxml/rng-uri.el | 10 +++++----- lisp/nxml/rng-xsd.el | 2 +- lisp/nxml/xmltok.el | 2 +- lisp/org/org-mobile.el | 2 +- lisp/progmodes/ada-mode.el | 2 +- lisp/progmodes/cc-mode.el | 16 ++++++++-------- lisp/progmodes/cperl-mode.el | 8 ++++---- lisp/progmodes/ebnf-dtd.el | 14 +++++++------- lisp/progmodes/hideif.el | 4 ++-- lisp/progmodes/prolog.el | 2 +- lisp/textmodes/css-mode.el | 6 +++--- lisp/textmodes/sgml-mode.el | 2 +- lisp/version.el | 2 +- lisp/xml.el | 8 ++++---- test/src/emacs-module-tests.el | 2 +- 28 files changed, 60 insertions(+), 60 deletions(-) diff --git a/etc/schema/od-schema-v1.2-os.rnc b/etc/schema/od-schema-v1.2-os.rnc index 8d679d62e4e..36e4645d7ee 100644 --- a/etc/schema/od-schema-v1.2-os.rnc +++ b/etc/schema/od-schema-v1.2-os.rnc @@ -6233,7 +6233,7 @@ signedZeroToHundredPercent = relativeLength = xsd:string { pattern = "[0-9]+\*" } coordinate = length distance = length -color = xsd:string { pattern = "#[0-9a-fA-F]{6}" } +color = xsd:string { pattern = "#[[:xdigit:]]{6}" } angle = xsd:string CURIE = xsd:string { pattern = "(([\i-[:]][\c-[:]]*)?:)?.+" minLength = "1" } diff --git a/lisp/calc/calc-aent.el b/lisp/calc/calc-aent.el index f16e665fc34..f1ef5c170bc 100644 --- a/lisp/calc/calc-aent.el +++ b/lisp/calc/calc-aent.el @@ -728,7 +728,7 @@ math-read-token math-exp-str (1- math-exp-pos)) (1- math-exp-pos)))))) (or (and (memq calc-language calc-lang-c-type-hex) - (eq (string-match "0[xX][0-9a-fA-F]+" math-exp-str + (eq (string-match "0[xX][[:xdigit:]]+" math-exp-str math-exp-pos) math-exp-pos)) (string-match "_?\\([0-9]+.?0*@ *\\)?\\([0-9]+.?0*' *\\)?\\(0*\\([2-9]\\|1[0-4]\\)\\(#[#]?\\|\\^\\^\\)[0-9a-dA-D.]+[eE][-+_]?[0-9]+\\|0*\\([2-9]\\|[0-2][0-9]\\|3[0-6]\\)\\(#[#]?\\|\\^\\^\\)[0-9a-zA-Zα-ωΑ-Ω:.]+\\|[0-9]+:[0-9:]+\\|[0-9.]+\\([eE][-+_]?[0-9]+\\)?\"?\\)?" diff --git a/lisp/calc/calc-ext.el b/lisp/calc/calc-ext.el index 1456fb28570..c7b4c3b091d 100644 --- a/lisp/calc/calc-ext.el +++ b/lisp/calc/calc-ext.el @@ -3019,13 +3019,13 @@ math-read-number-fancy ;; C language hexadecimal notation ((and (eq calc-language 'c) - (string-match "^0[xX]\\([0-9a-fA-F]+\\)$" s)) + (string-match "^0[xX]\\([[:xdigit:]]+\\)$" s)) (let ((digs (math-match-substring s 1))) (math-read-radix digs 16))) ;; Pascal language hexadecimal notation ((and (eq calc-language 'pascal) - (string-match "^\\$\\([0-9a-fA-F]+\\)$" s)) + (string-match "^\\$\\([[:xdigit:]]+\\)$" s)) (let ((digs (math-match-substring s 1))) (math-read-radix digs 16))) diff --git a/lisp/calc/calc-lang.el b/lisp/calc/calc-lang.el index ee107df39c1..4a9771d7438 100644 --- a/lisp/calc/calc-lang.el +++ b/lisp/calc/calc-lang.el @@ -243,7 +243,7 @@ calc-pascal-language (put 'pascal 'math-lang-read-symbol '((?\$ (eq (string-match - "\\(\\$[0-9a-fA-F]+\\)\\($\\|[^0-9a-zA-Zα-ωΑ-Ω]\\)" + "\\(\\$[[:xdigit:]]+\\)\\($\\|[^0-9a-zA-Zα-ωΑ-Ω]\\)" math-exp-str math-exp-pos) math-exp-pos) (setq math-exp-token 'number diff --git a/lisp/cedet/semantic/java.el b/lisp/cedet/semantic/java.el index 54cce965459..7f9c93b906f 100644 --- a/lisp/cedet/semantic/java.el +++ b/lisp/cedet/semantic/java.el @@ -51,7 +51,7 @@ semantic-java-number-regexp "\\|" "\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>" "\\|" - "\\<0[xX][0-9a-fA-F]+[lL]?\\>" + "\\<0[xX][[:xdigit:]]+[lL]?\\>" "\\|" "\\<[0-9]+[lLfFdD]?\\>" "\\)" @@ -63,7 +63,7 @@ semantic-java-number-regexp [1-9][0-9]* ; HEX_LITERAL: - 0[xX][0-9a-fA-F]+ + 0[xX][[:xdigit:]]+ ; OCTAL_LITERAL: 0[0-7]* diff --git a/lisp/cedet/semantic/lex.el b/lisp/cedet/semantic/lex.el index 2690122f067..f1c6b014182 100644 --- a/lisp/cedet/semantic/lex.el +++ b/lisp/cedet/semantic/lex.el @@ -596,7 +596,7 @@ semantic-lex-number-expression "\\|" "\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>" "\\|" - "\\<0[xX][0-9a-fA-F]+[lL]?\\>" + "\\<0[xX][[:xdigit:]]+[lL]?\\>" "\\|" "\\<[0-9]+[lLfFdD]?\\>" "\\)" @@ -609,7 +609,7 @@ semantic-lex-number-expression [1-9][0-9]* ; HEX_LITERAL: - 0[xX][0-9a-fA-F]+ + 0[xX][[:xdigit:]]+ ; OCTAL_LITERAL: 0[0-7]* diff --git a/lisp/emulation/cua-rect.el b/lisp/emulation/cua-rect.el index 706634a5017..1a19cc2910e 100644 --- a/lisp/emulation/cua-rect.el +++ b/lisp/emulation/cua-rect.el @@ -1127,7 +1127,7 @@ cua-incr-rectangle (cua--rectangle-operation 'keep nil t 1 nil (lambda (_s e _l _r) (cond - ((re-search-forward "0x\\([0-9a-fA-F]+\\)" e t) + ((re-search-forward "0x\\([[:xdigit:]]+\\)" e t) (let* ((txt (cua--filter-buffer-noprops (match-beginning 1) (match-end 1))) (n (string-to-number txt 16)) (fmt (format "0x%%0%dx" (length txt)))) diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index d826faca5bd..e6a75660fe8 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -7426,10 +7426,10 @@ gnus-button-mid-or-mail-heuristic-alist (-2.0 . "^[0-9]") (-1.0 . "^[0-9][0-9]") ;; - ;; -3.0 /^[0-9][0-9a-fA-F]{2,2}/; - (-3.0 . "^[0-9][0-9a-fA-F][0-9a-fA-F][^0-9a-fA-F]") - ;; -5.0 /^[0-9][0-9a-fA-F]{3,3}/; - (-5.0 . "^[0-9][0-9a-fA-F][0-9a-fA-F][0-9a-fA-F][^0-9a-fA-F]") + ;; -3.0 /^[0-9][[:xdigit:]]{2,2}/; + (-3.0 . "^[0-9][[:xdigit:]][[:xdigit:]][^0-9a-fA-F]") + ;; -5.0 /^[0-9][[:xdigit:]]{3,3}/; + (-5.0 . "^[0-9][[:xdigit:]][[:xdigit:]][[:xdigit:]][^0-9a-fA-F]") ;; (-3.0 . "[0-9][0-9][0-9][0-9][0-9][^0-9].*@") ;; "[0-9]{5,}.*\@" (-3.0 . "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][^0-9].*@") diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index db7489fbf1c..02a27b367cd 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -725,7 +725,7 @@ mml-secure-find-usable-keys is expired or revoked. If optional JUSTONE is not nil, return the first key instead of a list." (let* ((keys (epg-list-keys context name)) - (iskeyid (string-match "\\(0x\\)?\\([0-9a-fA-F]\\{8,\\}\\)" name)) + (iskeyid (string-match "\\(0x\\)?\\([[:xdigit:]]\\{8,\\}\\)" name)) (fingerprint (match-string 2 name)) result) (when (and iskeyid (>= (length keys) 2)) diff --git a/lisp/gnus/nneething.el b/lisp/gnus/nneething.el index f64007aaf79..c3d511bc6e0 100644 --- a/lisp/gnus/nneething.el +++ b/lisp/gnus/nneething.el @@ -297,7 +297,7 @@ nneething-encode-file-name (defun nneething-decode-file-name (file &optional coding-system) "Decode the name of the FILE is encoded in CODING-SYSTEM." (let ((pos 0) buf) - (while (string-match "%\\([0-9a-fA-F][0-9a-fA-F]\\)" file pos) + (while (string-match "%\\([[:xdigit:]][[:xdigit:]]\\)" file pos) (setq buf (cons (string (string-to-number (match-string 1 file) 16)) (cons (substring file pos (match-beginning 0)) buf)) pos (match-end 0))) diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el index 47b07479c3c..1edf80d14c8 100644 --- a/lisp/international/mule-cmds.el +++ b/lisp/international/mule-cmds.el @@ -3079,7 +3079,7 @@ read-char-by-name (char (cond ((char-from-name input t)) - ((string-match-p "\\`[0-9a-fA-F]+\\'" input) + ((string-match-p "\\`[[:xdigit:]]+\\'" input) (ignore-errors (string-to-number input 16))) ((string-match-p "\\`#\\([bBoOxX]\\|[0-9]+[rR]\\)[0-9a-zA-Z]+\\'" input) diff --git a/lisp/net/shr-color.el b/lisp/net/shr-color.el index 2d6cf68d8ff..af0b99c76f4 100644 --- a/lisp/net/shr-color.el +++ b/lisp/net/shr-color.el @@ -235,7 +235,7 @@ shr-color->hexadecimal (cond ;; Hexadecimal color: #abc or #aabbcc ((string-match - "\\(#[0-9a-fA-F]\\{3\\}[0-9a-fA-F]\\{3\\}?\\)" + "\\(#[[:xdigit:]]\\{3\\}[[:xdigit:]]\\{3\\}?\\)" color) (match-string 1 color)) ;; rgb() or rgba() colors diff --git a/lisp/nxml/rng-cmpct.el b/lisp/nxml/rng-cmpct.el index d36f9d92f26..60c871990e1 100644 --- a/lisp/nxml/rng-cmpct.el +++ b/lisp/nxml/rng-cmpct.el @@ -369,7 +369,7 @@ rng-c-process-escapes (and pos (rng-c-error "Nul character found (binary file?)"))) (let ((offset 0)) - (while (re-search-forward "\\\\x+{\\([0-9a-fA-F]+\\)}" + (while (re-search-forward "\\\\x+{\\([[:xdigit:]]+\\)}" (point-max) t) (let* ((ch (decode-char 'ucs (string-to-number (match-string 1) 16)))) diff --git a/lisp/nxml/rng-uri.el b/lisp/nxml/rng-uri.el index 798475bbc3d..5a67cc7f145 100644 --- a/lisp/nxml/rng-uri.el +++ b/lisp/nxml/rng-uri.el @@ -68,7 +68,7 @@ rng-uri-pattern-file-name-replace-match ;; pattern is either nil or match or replace (defun rng-uri-file-name-1 (uri pattern) - (unless (string-match "\\`\\(?:[^%]\\|%[0-9a-fA-F]{2}\\)*\\'" uri) + (unless (string-match "\\`\\(?:[^%]\\|%[[:xdigit:]]{2}\\)*\\'" uri) (rng-uri-error "Bad escapes in URI `%s'" uri)) (setq uri (rng-uri-unescape-multibyte uri)) (let* ((components @@ -299,7 +299,7 @@ rng-join-path (mapconcat 'identity segments "/"))) (defun rng-uri-unescape-multibyte (str) - (replace-regexp-in-string "\\(?:%[89a-fA-F][0-9a-fA-F]\\)+" + (replace-regexp-in-string "\\(?:%[89a-fA-F][[:xdigit:]]\\)+" 'rng-multibyte-percent-decode str)) @@ -310,7 +310,7 @@ rng-multibyte-percent-decode 'utf-8)) (defun rng-uri-unescape-unibyte (str) - (replace-regexp-in-string "%[0-7][0-9a-fA-F]" + (replace-regexp-in-string "%[0-7][[:xdigit:]]" (lambda (h) (string-to-number (substring h 1) 16)) str @@ -318,7 +318,7 @@ rng-uri-unescape-unibyte t)) (defun rng-uri-unescape-unibyte-match (str) - (replace-regexp-in-string "%[0-7][0-9a-fA-F]\\|[^%]" + (replace-regexp-in-string "%[0-7][[:xdigit:]]\\|[^%]" (lambda (match) (if (string= match "*") "\\([^/]*\\)" @@ -333,7 +333,7 @@ rng-uri-unescape-unibyte-match (defun rng-uri-unescape-unibyte-replace (str next-match-index) (replace-regexp-in-string - "%[0-7][0-9a-fA-F]\\|[^%]" + "%[0-7][[:xdigit:]]\\|[^%]" (lambda (match) (if (string= match "*") (let ((n next-match-index)) diff --git a/lisp/nxml/rng-xsd.el b/lisp/nxml/rng-xsd.el index f308b049f3b..c0c679532ac 100644 --- a/lisp/nxml/rng-xsd.el +++ b/lisp/nxml/rng-xsd.el @@ -360,7 +360,7 @@ rng-xsd-base64-binary-length n))) (defun rng-xsd-convert-any-uri (string) - (and (string-match "\\`\\(?:[^%]\\|%[0-9a-fA-F][0-9a-fA-F]\\)*\\'" string) + (and (string-match "\\`\\(?:[^%]\\|%[[:xdigit:]][[:xdigit:]]\\)*\\'" string) (string-match "\\`[^#]*\\(?:#[^#]*\\)?\\'" string) (string-match "\\`\\(?:[a-zA-Z][-+.A-Za-z0-9]*:.+\\|[^:]*\\(?:[#/?].*\\)?\\)\\'" string) string)) diff --git a/lisp/nxml/xmltok.el b/lisp/nxml/xmltok.el index afa33e064f3..3cab5ed9b7b 100644 --- a/lisp/nxml/xmltok.el +++ b/lisp/nxml/xmltok.el @@ -413,7 +413,7 @@ xmltok-forward (xmltok-g decimal-ref-close ";") opt)) (hex-ref (xmltok+ "x" open - (xmltok-g hex "[0-9a-fA-F]" +) + (xmltok-g hex "[[:xdigit:]]" +) (xmltok-g hex-ref-close ";") opt close opt)) (char-ref diff --git a/lisp/org/org-mobile.el b/lisp/org/org-mobile.el index 8b4e8953889..e24ee8ed7c5 100644 --- a/lisp/org/org-mobile.el +++ b/lisp/org/org-mobile.el @@ -761,7 +761,7 @@ org-mobile-update-checksum-for-capture-file (buffer (find-file-noselect file))) (when buffer (with-current-buffer buffer - (when (re-search-forward (concat "\\([0-9a-fA-F]\\{30,\\}\\).*?" + (when (re-search-forward (concat "\\([[:xdigit:]]\\{30,\\}\\).*?" (regexp-quote org-mobile-capture-file) "[ \t]*$") nil t) (goto-char (match-beginning 1)) diff --git a/lisp/progmodes/ada-mode.el b/lisp/progmodes/ada-mode.el index 77c1e5e2d87..ded9a08d0ee 100644 --- a/lisp/progmodes/ada-mode.el +++ b/lisp/progmodes/ada-mode.el @@ -909,7 +909,7 @@ ada-mode-symbol-syntax-table change)) (replace-match "'A'")) (goto-char from) - (while (re-search-forward "\\(#[0-9a-fA-F]*#\\)" to t) + (while (re-search-forward "\\(#[[:xdigit:]]*#\\)" to t) (setq change (cons (list (match-beginning 1) (length (match-string 1)) (match-string 1)) diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el index 6afcb08a7ca..6feb326cf16 100644 --- a/lisp/progmodes/cc-mode.el +++ b/lisp/progmodes/cc-mode.el @@ -1415,7 +1415,7 @@ c-after-change-mark-abnormal-strings (defconst c-maybe-quoted-number-head (concat "\\(0\\(" - "\\([Xx]\\([0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*'?\\)?\\)" + "\\([Xx]\\([[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*'?\\)?\\)" "\\|" "\\([Bb]\\([01]\\('[01]\\|[01]\\)*'?\\)?\\)" "\\|" @@ -1449,7 +1449,7 @@ c-quoted-number-head-before-point (defconst c-maybe-quoted-number-tail (concat "\\(" - "\\([xX']?[0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)" + "\\([xX']?[[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*\\)" "\\|" "\\([bB']?[01]\\('[01]\\|[01]\\)*\\)" "\\|" @@ -1469,7 +1469,7 @@ c-quoted-number-tail-after-point (defconst c-maybe-quoted-number (concat "\\(0\\(" - "\\([Xx][0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)" + "\\([Xx][[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*\\)" "\\|" "\\([Bb][01]\\('[01]\\|[01]\\)*\\)" "\\|" @@ -1530,7 +1530,7 @@ c-parse-quotes-before-change (if (>= (point) c-new-BEG) (setq c-new-BEG (match-beginning 0)))) ((looking-at - "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'") + "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)'") (goto-char (match-end 0)) (if (> (match-end 0) c-new-BEG) (setq c-new-BEG (1- (match-beginning 0))))) @@ -1559,7 +1559,7 @@ c-parse-quotes-before-change (if (> (match-end 0) c-new-END) (setq c-new-END (match-end 0)))) ((looking-at - "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'") + "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)'") (goto-char (match-end 0)) (if (> (match-end 0) c-new-END) (setq c-new-END (match-end 0)))) @@ -1579,8 +1579,8 @@ c-parse-quotes-before-change ((c-quoted-number-tail-after-point) (setq c-new-END (match-end 0))) ((looking-at - "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\|.\\)?\ -\\('\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)\\)*'") + "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\|.\\)?\ +\\('\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)\\)*'") (setq c-new-END (match-end 0)))) ;; Remove the '(1) syntax-table property from any "'"s within (c-new-BEG @@ -1632,7 +1632,7 @@ c-parse-quotes-after-change 'c-digit-separator t ?') (goto-char num-end)) ((looking-at - "\\([^\\']\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\ + "\\([^\\']\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\ \\)'") ; balanced quoted expression. (goto-char (match-end 0))) ((looking-at "\\\\'") ; Anomalous construct. diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index ba007d67c0d..c58acf0c2ff 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -3507,18 +3507,18 @@ cperl-look-at-leading-count (defsubst cperl-highlight-charclass (endbracket dashface bsface onec-space) (let ((l '(1 5 7)) ll lle lll ;; 2 groups, the first takes the whole match (include \[trnfabe]) - (singleChar (concat "\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)"))) + (singleChar (concat "\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)"))) (while ; look for unescaped - between non-classes (re-search-forward ;; On 19.33, certain simplifications lead ;; to bugs (as in [^a-z] \\| [trnfabe] ) (concat ; 1: SingleChar (include \[trnfabe]) singleChar - ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" + ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" "\\(" ; 3: DASH SingleChar (match optionally) "\\(-\\)" ; 4: DASH singleChar ; 5: SingleChar - ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" + ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" "\\)?" "\\|" "\\(" ; 7: other escapes @@ -4420,7 +4420,7 @@ cperl-find-pods-heres "\\=[0123456789]*" (1- e) 'to-end)) (and (eq qtag ?x) (re-search-forward - "\\=[0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}" + "\\=[[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}" (1- e) 'to-end)) (and (memq qtag (append "pPN" nil)) (re-search-forward "\\={[^{}]+}\\|." diff --git a/lisp/progmodes/ebnf-dtd.el b/lisp/progmodes/ebnf-dtd.el index 94d96432614..17c7aebf2a9 100644 --- a/lisp/progmodes/ebnf-dtd.el +++ b/lisp/progmodes/ebnf-dtd.el @@ -324,7 +324,7 @@ ;; /* Character Reference */ ;; ;; CharRef ::= '&#' [0-9]+ ';' -;; | '&#x' [0-9a-fA-F]+ ';' +;; | '&#x' [[:xdigit:]]+ ';' ;; [WFC: Legal Character] ;; ;; @@ -915,9 +915,9 @@ ebnf-dtd-operators ;;; EntityRef ::= '&' Name ';' ;;; ;;; CharRef ::= '&#' [0-9]+ ';' -;;; | '&#x' [0-9a-fA-F]+ ';' +;;; | '&#x' [[:xdigit:]]+ ';' -;;; "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" +;;; "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" (defun ebnf-dtd-attlistdecl () @@ -945,7 +945,7 @@ ebnf-dtd-attlistdecl (setq token (ebnf-dtd-lex))) (or (and (eq token 'string) (string-match - "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" + "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" ebnf-dtd-lex)) (error "Invalid default value in ATTLIST declaration")))) (or (eq token 'end-decl) @@ -986,9 +986,9 @@ ebnf-dtd-namelist ;;; EntityRef ::= '&' Name ';' ;;; ;;; CharRef ::= '&#' [0-9]+ ';' -;;; | '&#x' [0-9a-fA-F]+ ';' +;;; | '&#x' [[:xdigit:]]+ ';' -;;; "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" +;;; "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" (defun ebnf-dtd-entitydecl () @@ -1001,7 +1001,7 @@ ebnf-dtd-entitydecl (setq token (ebnf-dtd-lex)) (if (eq token 'string) (if (string-match - "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" + "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" ebnf-dtd-lex) (setq token (ebnf-dtd-lex)) (error "Invalid ENTITY definition")) diff --git a/lisp/progmodes/hideif.el b/lisp/progmodes/hideif.el index 32b0b7551f9..1b06077005c 100644 --- a/lisp/progmodes/hideif.el +++ b/lisp/progmodes/hideif.el @@ -540,7 +540,7 @@ hif-valid-token-list (defconst hif-token-regexp (concat (regexp-opt (mapcar 'car hif-token-alist)) - "\\|0x[0-9a-fA-F]+\\.?[0-9a-fA-F]*" + "\\|0x[[:xdigit:]]+\\.?[[:xdigit:]]*" "\\|[0-9]+\\.?[0-9]*" ;; decimal/octal "\\|\\w+")) @@ -595,7 +595,7 @@ hif-tokenize ;; 1. postfix 'l', 'll', 'ul' and 'ull' ;; 2. floating number formats (like 1.23e4) ;; 3. 098 is interpreted as octal conversion error - (if (string-match "0x\\([0-9a-fA-F]+\\.?[0-9a-fA-F]*\\)" + (if (string-match "0x\\([[:xdigit:]]+\\.?[[:xdigit:]]*\\)" token) (hif-string-to-number (match-string 1 token) 16)) ;; hex (if (string-match "\\`0[0-9]+\\(\\.[0-9]+\\)?\\'" token) diff --git a/lisp/progmodes/prolog.el b/lisp/progmodes/prolog.el index 296a7ac3c95..780eff2d8a0 100644 --- a/lisp/progmodes/prolog.el +++ b/lisp/progmodes/prolog.el @@ -1071,7 +1071,7 @@ prolog-syntax-propertize-function ;; Supposedly, ISO-Prolog wants \NNN\ for octal and \xNNN\ for hexadecimal ;; escape sequences in atoms, so be careful not to let the terminating \ ;; escape a subsequent quote. - ("\\\\[x0-7][0-9a-fA-F]*\\(\\\\\\)" (1 "_")) + ("\\\\[x0-7][[:xdigit:]]*\\(\\\\\\)" (1 "_")) ))) (defun prolog-mode-variables () diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5d5d787945d..b0653bce81c 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -873,7 +873,7 @@ css-syntax-propertize-function (css--uri-re (1 "|") (2 "|")))) (defconst css-escapes-re - "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[ \n\t\r\f]?\\)") + "\\\\\\(?:[^\000-\037\177]\\|[[:xdigit:]]+[ \n\t\r\f]?\\)") (defconst css-nmchar-re (concat "\\(?:[-[:alnum:]]\\|" css-escapes-re "\\)")) (defconst css-nmstart-re (concat "\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) (defconst css-ident-re ;; (concat css-nmstart-re css-nmchar-re "*") @@ -1079,10 +1079,10 @@ css--colors-regexp (regexp-opt (mapcar #'car css--color-map) 'symbols) "\\|" ;; Short hex. css-color-4 adds alpha. - "\\(#[0-9a-fA-F]\\{3,4\\}\\b\\)" + "\\(#[[:xdigit:]]\\{3,4\\}\\b\\)" "\\|" ;; Long hex. css-color-4 adds alpha. - "\\(#\\(?:[0-9a-fA-F][0-9a-fA-F]\\)\\{3,4\\}\\b\\)" + "\\(#\\(?:[[:xdigit:]][[:xdigit:]]\\)\\{3,4\\}\\b\\)" "\\|" ;; RGB. "\\(\\_&;\n\t \"%!'(),/=?]\\|$\\)" + "\\(&\\(amp\\|quot\\|lt\\|gt\\|#\\([0-9]+\\|[xX][[:xdigit:]]+\\)\\)\\)\\([][<>&;\n\t \"%!'(),/=?]\\|$\\)" nil t) (replace-match (string diff --git a/lisp/version.el b/lisp/version.el index d13d8c31e80..b9e2e50d1f7 100644 --- a/lisp/version.el +++ b/lisp/version.el @@ -120,7 +120,7 @@ emacs-repository-version-git (with-demoted-errors "Error running git rev-parse: %S" (call-process "git" nil '(t nil) nil "rev-parse" "HEAD"))) (progn (goto-char (point-min)) - (looking-at "[0-9a-fA-F]\\{40\\}")) + (looking-at "[[:xdigit:]]\\{40\\}")) (match-string 0))))) (defun emacs-repository-get-version (&optional dir external) diff --git a/lisp/xml.el b/lisp/xml.el index 09ec72f792f..833eb8aced2 100644 --- a/lisp/xml.el +++ b/lisp/xml.el @@ -194,13 +194,13 @@ xml-nmtoken-re ;; [8] Nmtokens ::= Nmtoken (#x20 Nmtoken)* (defconst xml-nmtokens-re (concat xml-nmtoken-re "\\(?: " xml-name-re "\\)*")) -;; [66] CharRef ::= '&#' [0-9]+ ';' | '&#x' [0-9a-fA-F]+ ';' -(defconst xml-char-ref-re "\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)") +;; [66] CharRef ::= '&#' [0-9]+ ';' | '&#x' [[:xdigit:]]+ ';' +(defconst xml-char-ref-re "\\(?:&#[0-9]+;\\|&#x[[:xdigit:]]+;\\)") ;; [68] EntityRef ::= '&' Name ';' (defconst xml-entity-ref (concat "&" xml-name-re ";")) -(defconst xml-entity-or-char-ref-re (concat "&\\(?:#\\(x\\)?\\([0-9a-fA-F]+\\)\\|\\(" +(defconst xml-entity-or-char-ref-re (concat "&\\(?:#\\(x\\)?\\([[:xdigit:]]+\\)\\|\\(" xml-name-re "\\)\\);")) ;; [69] PEReference ::= '%' Name ';' @@ -889,7 +889,7 @@ xml--entity-replacement-text The replacement text is obtained by replacing character references and parameter-entity references." (let ((ref-re (eval-when-compile - (concat "\\(?:&#\\([0-9]+\\)\\|&#x\\([0-9a-fA-F]+\\)\\|%\\(" + (concat "\\(?:&#\\([0-9]+\\)\\|&#x\\([[:xdigit:]]+\\)\\|%\\(" xml-name-re "\\)\\);"))) children) (while (string-match ref-re string) diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el index 5349de055ed..96a604f9824 100644 --- a/test/src/emacs-module-tests.el +++ b/test/src/emacs-module-tests.el @@ -60,7 +60,7 @@ mod-test-sum-test (should (eq 0 (string-match (concat "#") (prin1-to-string (nth 1 descr))))) (should (= (nth 2 descr) 3))) -- 2.22.0 From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602581946625 (code B ref 36167); Tue, 11 Jun 2019 13:04:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 13:03:14 +0000 Received: from localhost ([127.0.0.1]:58160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagQk-0001im-0D for submit@debbugs.gnu.org; Tue, 11 Jun 2019 09:03:14 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:36244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagQi-0001iY-26 for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 09:03:12 -0400 Received: by mail-ed1-f51.google.com with SMTP id k21so16644245edq.3 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 06:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=4/U6gTG1M1ajm8cZut0hge5KtniPJPGt2IZsd+o5kKE=; b=ggFFdvVEfbFGBVlJg4ImK3oIOVHmmtwqMQ4UstQozApX7DU3U2O+an0Il2y9uGK2Lc GVxY6GvdllKBQkjc5osYN4rqnWAd6+rWSoDShs1noxW3065gjrtqyzS0F7STFMBsFDaW PzMo31JyuDkn3QbzKl/Jc05LGLEaD8owKFFK7VEY1oiKNPKvO31QFR+U4ywwmJdC6Ie5 /NSC+iyFIDuTBPPBtI8aKbEpTUylzD5dHaK4qFGKY9aTJHuqQoggFpGKcSG/rqZkYgSn SSrBUITnMDpV7rYaIZAHgzFduzm/rNTn/5vigXAv98sibq1fYUzY4bwagoxlZGilWpnn KIZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=4/U6gTG1M1ajm8cZut0hge5KtniPJPGt2IZsd+o5kKE=; b=SHZBuKczZaGoSWqq81il6P52sGZP+Y1/xPi5rdeAHv3T4I8RxToVe7RCwP+HwIoZM6 HCfhJmuTtOepPBqsObLz8sYj9Kp8F4NhgpPDzKfjnl2VbjhJpOVPHzWAK27P2zX3HZoM qpFl5aUQeeyDt56xVhgvJ0TK89dH1vDBuC3Otc0sLrrA93PQZ/Aj9bSzO6kSWGr4Ns2H vYci+58wlaZl5wnK8FuqlRIGalSVbpRE1HCTzl9bVJxoHLyaM7V5WuFU4tf1xbdYJkJc cp5Vdt9pccSfKHfmTvau8Wzw4tODT1G8fehQIplMQFzzhVJ+wtRsbMYDSn6kKClnFPj2 3ORQ== X-Gm-Message-State: APjAAAVF2tmctIUt+Iv3cbYjczME3rlDt+WjLSbJZd+MJcrTW9P6GzqA I7FkAq5AayU4YREbTOwCOpgS8Mz6yv4= X-Google-Smtp-Source: APXvYqyqZXhi9FxGd5jfOLd/MCXe3XIw4QI7M/p70lRM8rJDDM02UT5CofwpjAP6ejZi7SWtzWrjbA== X-Received: by 2002:a17:906:470a:: with SMTP id y10mr9940508ejq.115.1560258185847; Tue, 11 Jun 2019 06:03:05 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f25sm1053170ejf.77.2019.06.11.06.03.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 06:03:05 -0700 (PDT) From: Robert Pluim References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 11 Jun 2019 15:03:04 +0200 In-Reply-To: <20190611122925.12809-1-Hi-Angel@yandex.ru> (Konstantin Kharlamov's message of "Tue, 11 Jun 2019 15:29:25 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 11 Jun 2019 15:29:25 +0300, Konstantin Kharlamov said: If this is fixing a bug, then please put '(Bug#36167)' somewhere in the commit message (I normally put it as the last thing in the preamble, before the detailed list of changes). See 'Commit messages' in CONTRIBUTE for extensive documentation. Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace Konstantin> [0-9a-fA-F] with [[:xdigit:]] =20=20=20=20 This is the org schema file for OpenDocument export, not emacs lisp. Does that support :xdigit: syntax? Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with Konstantin> [[:xdigit:]] =20=20=20=20 Normally, you'd mention the containing function in the ChangeLog entry. Using 'C-x 4 a' (ie 'add-change-log-entry-other-window') with point on the code you=CA=BCre changing does that for you. Konstantin> * lisp/calc/calc-ext.el: replace [0-9a-fA-F] with Konstantin> [[:xdigit:]] =20=20=20=20 And then on subsequent similar changes you can say 'Likewise.' (whilst still mentioning the enclosing function) Konstantin> * lisp/calc/calc-lang.el: replace [0-9a-fA-F] with [[:xdigi= t:]] Konstantin> * lisp/cedet/semantic/java.el: replace [0-9a-fA-F] with [[:= xdigit:]] Konstantin> * lisp/cedet/semantic/lex.el: replace [0-9a-fA-F] with [[:x= digit:]] Konstantin> * lisp/emulation/cua-rect.el: replace [0-9a-fA-F] with [[:x= digit:]] Konstantin> * lisp/gnus/gnus-art.el: replace [0-9a-fA-F] with [[:xdigit= :]] Konstantin> * lisp/gnus/mml-sec.el: replace [0-9a-fA-F] with [[:xdigit:= ]] Konstantin> * lisp/gnus/nneething.el: replace [0-9a-fA-F] with [[:xdigi= t:]] Konstantin> * lisp/international/mule-cmds.el: replace [0-9a-fA-F] with= [[:xdigit:]] Konstantin> * lisp/net/shr-color.el: replace [0-9a-fA-F] with [[:xdigit= :]] Konstantin> * lisp/nxml/rng-cmpct.el: replace [0-9a-fA-F] with [[:xdigi= t:]] Konstantin> * lisp/nxml/rng-uri.el: replace [0-9a-fA-F] with [[:xdigit:= ]] Konstantin> * lisp/nxml/rng-xsd.el: replace [0-9a-fA-F] with [[:xdigit:= ]] Konstantin> * lisp/nxml/xmltok.el: replace [0-9a-fA-F] with [[:xdigit:]] Konstantin> * lisp/org/org-mobile.el: replace [0-9a-fA-F] with [[:xdigi= t:]] Konstantin> * lisp/progmodes/ada-mode.el: replace [0-9a-fA-F] with [[:x= digit:]] Konstantin> * lisp/progmodes/cc-mode.el: replace [0-9a-fA-F] with [[:xd= igit:]] Konstantin> * lisp/progmodes/cperl-mode.el: replace [0-9a-fA-F] with [[= :xdigit:]] Konstantin> * lisp/progmodes/ebnf-dtd.el: replace [0-9a-fA-F] with [[:x= digit:]] Konstantin> * lisp/progmodes/hideif.el: replace [0-9a-fA-F] with [[:xdi= git:]] Konstantin> * lisp/progmodes/prolog.el: replace [0-9a-fA-F] with [[:xdi= git:]] Konstantin> * lisp/textmodes/css-mode.el: replace [0-9a-fA-F] with [[:x= digit:]] Konstantin> * lisp/textmodes/sgml-mode.el: replace [0-9a-fA-F] with [[:= xdigit:]] Konstantin> * lisp/version.el: replace [0-9a-fA-F] with [[:xdigit:]] Konstantin> * lisp/xml.el: replace [0-9a-fA-F] with [[:xdigit:]] Konstantin> * test/src/emacs-module-tests.el: replace [0-9a-fA-F] with = [[:xdigit:]] Robert From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602590437901 (code B ref 36167); Tue, 11 Jun 2019 13:18:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 13:17:23 +0000 Received: from localhost ([127.0.0.1]:58177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hageR-00023N-1S for submit@debbugs.gnu.org; Tue, 11 Jun 2019 09:17:23 -0400 Received: from forward105p.mail.yandex.net ([77.88.28.108]:46500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hageO-000238-1l for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 09:17:21 -0400 Received: from mxback13j.mail.yandex.net (mxback13j.mail.yandex.net [IPv6:2a02:6b8:0:1619::88]) by forward105p.mail.yandex.net (Yandex) with ESMTP id BA6084D41EEA; Tue, 11 Jun 2019 16:17:12 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback13j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Mn4DojUqe3-HCNW2Z4n; Tue, 11 Jun 2019 16:17:12 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560259032; bh=tbWUXd0CzVdHLRwKwS4AkZhVgyNHM765y5QnSeRYSEE=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=iJUVEmANDQ2BH8vrXxRvyeOMSM+U7UrgsR/X888UncE5Ax9hlvpmx+rrNywrO+Gzg /DHDGEsxEJ8P7weqX1Sv1J7vIJRa4hegiclzh6NqMbTvqyIQrX3BP8xWjHBuPDH0HD ooDVbH+YkfTEwf+ZF+60oluUTLNLjApmVaEmxfOc= Authentication-Results: mxback13j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id faWXY4HNGn-HBbqYc8N; Tue, 11 Jun 2019 16:17:12 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Tue, 11 Jun 2019 16:17:10 +0300 From: Konstantin Kharlamov Message-Id: <1560259030.21373.0@yandex.ru> In-Reply-To: References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On =D0=92=D1=82, =D0=B8=D1=8E=D0=BD 11, 2019 at 15:03, Robert Pluim =20 wrote: >>>>>> On Tue, 11 Jun 2019 15:29:25 +0300, Konstantin Kharlamov=20 >>>>>> said: >=20 > If this is fixing a bug, then please put '(Bug#36167)' somewhere in > the commit message (I normally put it as the last thing in the > preamble, before the detailed list of changes). See 'Commit messages' > in CONTRIBUTE for extensive documentation. >=20 > Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace > Konstantin> [0-9a-fA-F] with [[:xdigit:]] >=20 > This is the org schema file for OpenDocument export, not emacs > lisp. Does that support :xdigit: syntax? Oh, okay, thanks, I couldn't figure out what it is because Wikipedia=20 says that .rnc is just a variation of XML, and README just says it's=20 something to map some xml schemas to documents. So I deemed these=20 regexps are too used by ELisp. Can I test it somehow? Either way, not a big deal, I can just drop that=20 one. > Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with > Konstantin> [[:xdigit:]] >=20 > Normally, you'd mention the containing function in the ChangeLog > entry. Using 'C-x 4 a' (ie 'add-change-log-entry-other-window') with > point on the code you=CA=BCre changing does that for you. Ah, thanks. At this point I'll probably ask on emacs-devel about adding=20 to prepare-commit-msg a code to pre-format the changes, because clearly=20 that's a lot of manual work for something that should be automated. > Konstantin> * lisp/calc/calc-ext.el: replace [0-9a-fA-F] with > Konstantin> [[:xdigit:]] >=20 > And then on subsequent similar changes you can say 'Likewise.' (whilst > still mentioning the enclosing function) >=20 > Konstantin> * lisp/calc/calc-lang.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/cedet/semantic/java.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/cedet/semantic/lex.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/emulation/cua-rect.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/gnus/gnus-art.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/gnus/mml-sec.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/gnus/nneething.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/international/mule-cmds.el: replace=20 > [0-9a-fA-F] with [[:xdigit:]] > Konstantin> * lisp/net/shr-color.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/nxml/rng-cmpct.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/nxml/rng-uri.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/nxml/rng-xsd.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/nxml/xmltok.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/org/org-mobile.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/progmodes/ada-mode.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/progmodes/cc-mode.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/progmodes/cperl-mode.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/progmodes/ebnf-dtd.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/progmodes/hideif.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/progmodes/prolog.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/textmodes/css-mode.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/textmodes/sgml-mode.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] > Konstantin> * lisp/version.el: replace [0-9a-fA-F] with=20 > [[:xdigit:]] > Konstantin> * lisp/xml.el: replace [0-9a-fA-F] with [[:xdigit:]] > Konstantin> * test/src/emacs-module-tests.el: replace [0-9a-fA-F]=20 > with [[:xdigit:]] >=20 > Robert = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602598669158 (code B ref 36167); Tue, 11 Jun 2019 13:32:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 13:31:06 +0000 Received: from localhost ([127.0.0.1]:58193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagri-0002Ne-31 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 09:31:06 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:34477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagrd-0002N8-9A for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 09:31:04 -0400 Received: by mail-ed1-f46.google.com with SMTP id c26so20152175edt.1 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 06:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=5dD4YaWc3bJ7prcwi19N6D8Asil/Fx+rt4mQbg0Hrko=; b=bCXg2nlJq2YmdD1o/BykolsuainkZw+1ILSGCd55qqVShqiWkTF+MABshlRVQFdCKd ElegG9F0ovfXAxxsdniUdIFrnZRKOniHNgwsX2tLQxgS2DScQwG7miGVLJGEczAicV5M Q0fzRfxkrQ0Frd0J4PI12LcH5w766JnU+kMjEAhLnQydP2vcIxF20vOiZ2AEru8tr1WL 8/vBqQp8TH1I3LIDc+svq8fGX5M0aalBvAtvVYXXdC25A02a+hV9HRXS+Sfu5/1WU44S aBkMX19pM13wQTfd5XVwC7AYOJ3gm0RcJ2/Y4xURa/SSI2ZGSvU54aymEe47zOfmZVSN GYGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=5dD4YaWc3bJ7prcwi19N6D8Asil/Fx+rt4mQbg0Hrko=; b=RXYwz3vvoNPsv3Wt3uU1n/k8uM4MDsL1RaPsnImi6Sv5E9ZJUfs88zZqNORBRwEhDI 3+xmHefIS/qPOQcs/Jn0tUHXayzxXhpSe+8qZbxAhqexpyfeSklGWT+RAObplsh+U5wS CDjS+hkS8YcfFJR+A3sb+Fh1jTSXhLdJKDbblAmKg6IATJW3/LVJUpQ0XpiOfVECOyze ui0z/18A89vihwwlFrrZG+r7pDvyo40crJdLnAN7UV3j12e/XYZJovrUdn8D7+swCwcn 11Nz0fHwkMvSQBxJgX2qLmILuyI81IOXE6XkidYzY5cDonVUHCiN/2Yr19Een+Jdne0Y jmCA== X-Gm-Message-State: APjAAAW8qYlWPTo3ybrdsrSIWQkbFE61ND3y7UumMCNFAH/fFJ9gHu6H dx9Bk3PwCV5KoF5xSnXL8nFakEqiedg= X-Google-Smtp-Source: APXvYqyf8+UyOwGRvKN56ky0bGXMsu0Z3OuDV76s0mPlzyMktpOMHLiQrzh9uzx3MxoI19hQZcf9qw== X-Received: by 2002:a50:9871:: with SMTP id h46mr61628854edb.69.1560259854853; Tue, 11 Jun 2019 06:30:54 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id d44sm139467eda.75.2019.06.11.06.30.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 06:30:49 -0700 (PDT) From: Robert Pluim References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 11 Jun 2019 15:30:48 +0200 In-Reply-To: <1560259030.21373.0@yandex.ru> (Konstantin Kharlamov's message of "Tue, 11 Jun 2019 16:17:10 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 11 Jun 2019 16:17:10 +0300, Konstantin Kharlamov said: Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace Konstantin> [0-9a-fA-F] with [[:xdigit:]] >>=20 >> This is the org schema file for OpenDocument export, not emacs >> lisp. Does that support :xdigit: syntax? Konstantin> Oh, okay, thanks, I couldn't figure out what it is because = Wikipedia Konstantin> says that .rnc is just a variation of XML, and README just = says it's Konstantin> something to map some xml schemas to documents. So I deemed= these Konstantin> regexps are too used by ELisp. Konstantin> Can I test it somehow? Either way, not a big deal, I can ju= st drop Konstantin> that one. If I remember correctly, the schema is copied into the resulting OpenDocument file, so it=CA=BCs probably safest not to touch it. Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with Konstantin> [[:xdigit:]] >>=20 >> Normally, you'd mention the containing function in the ChangeLog >> entry. Using 'C-x 4 a' (ie 'add-change-log-entry-other-window') with >> point on the code you=CA=BCre changing does that for you. Konstantin> Ah, thanks. At this point I'll probably ask on emacs-devel = about Konstantin> adding to prepare-commit-msg a code to pre-format the chang= es, because Konstantin> clearly that's a lot of manual work for something that shou= ld be Konstantin> automated. It=CA=BCs pretty automated: - Do M-x vc-dir in your emacs repository to see which files are changed - Do C-x 4 a to prepare the ChangeLog entries - Mark the files you want you commit - Commit from the vc-dir buffer. This will copy the earlier ChangeLog entries into the commit message buffer Unless you meant completely automatically generating the ChangeLog entries, which is a wholly different can of worms. Robert From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: npostavs@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602599529290 (code B ref 36167); Tue, 11 Jun 2019 13:33:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 13:32:32 +0000 Received: from localhost ([127.0.0.1]:58200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagt6-0002Pm-H3 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 09:32:32 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:41754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hagt4-0002PY-3Z for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 09:32:30 -0400 Received: by mail-io1-f45.google.com with SMTP id w25so9869049ioc.8 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 06:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yGKQe2FAuzn28sbXweAPSfOYrroYQBe0e5vx39eXTOg=; b=Az2WTF85PIGz6c63kWk+ppOey3zEpANiW1gehUBjdksJcfbZFQlTBmncbhk5HugGeK pWpt7d9DXgPOSOXYmPqWhIHc6Oqe+Y+yn7X23KJjgfrvGkIlMZ8uN8RxCMDpwb5I+16u FMAMxkKUz4o/4J8QxIJlQI9HNJHdDCBwKpZGDfWsTLk/aF55YrKHUSAagbIRB8keK1A8 QLK/LW/UjPRDe3MkNxweh+3NUhPZrKnyTpa+6vvQqZXRzm96Fo8qx14QOwheRuJJQ+hu T+vCVKn1mi5Z6Yy5RCh6DgSLwNWV/6gUFoYkLy72a85KJeEyFNJZXBsy8J6oargoz/c8 xrjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yGKQe2FAuzn28sbXweAPSfOYrroYQBe0e5vx39eXTOg=; b=B/TssFS4KVjkVeADwiAa/3bM/rMErS04o2NXNPqUKhb7BMuCd7UGNPMRlGvvVDQXwm S5cAlfhD19JnG0/aUIILogwHALw7NpDPo7DFGnOcZWEkxNTDnUNvVbx/2qRh5Z9z6hGj bM63KVucl4b/0K/jqUW8U1sRX+/zpkXyFWrpmmeRZErOfdXPmShb4KfY34R5FsPl7Q6P zByIFWVGVf1aECusOajy+D9WaPnFpDSvGXskwASdjYzNupFLxV+kF8oZQDN0lrRxEWnZ oOhv/VVVH03XKECvGQZrlUVofFA7PwGlkQVGdiwaj1QNssGpTADr4UbAkDEn6Z4JbA7b RRTA== X-Gm-Message-State: APjAAAWFWvJqC3EAtvJcmMtjfPgyk9l7s/GWNu6eNodKAi2AlNkKUZz0 /S8RM3A6NzOo1i8NX73zxYg6qWzN X-Google-Smtp-Source: APXvYqx3/QWljKDRkmo619rzr1w+Wd7gfhE0qaDBRa4jZL19GL0QGxT4OtrMKsiLAWXPR24sIWNF2Q== X-Received: by 2002:a6b:e20a:: with SMTP id z10mr17651134ioc.76.1560259944223; Tue, 11 Jun 2019 06:32:24 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id r127sm1471935itr.7.2019.06.11.06.32.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 06:32:23 -0700 (PDT) From: npostavs@gmail.com References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> Date: Tue, 11 Jun 2019 09:32:23 -0400 In-Reply-To: (Robert Pluim's message of "Tue, 11 Jun 2019 15:03:04 +0200") Message-ID: <85a7eob63c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > And then on subsequent similar changes you can say 'Likewise.' (whilst > still mentioning the enclosing function) There's no need to say 'Likewise', just leave all but the last entry without a message, see CONTRIBUTE: - Preferred form for several entries with the same content: * lisp/menu-bar.el (clipboard-yank, clipboard-kill-ring-save) (clipboard-kill-region): * lisp/eshell/esh-io.el (eshell-virtual-targets) (eshell-clipboard-append): Replace option gui-select-enable-clipboard with select-enable-clipboard; renamed October 2014. (Bug#25145) (Rather than anything involving "ditto" and suchlike.) From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] References: <1560254386.25060.0@yandex.ru> In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156026317715870 (code B ref 36167); Tue, 11 Jun 2019 14:27:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 14:26:17 +0000 Received: from localhost ([127.0.0.1]:59907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahj6-00047t-Rc for submit@debbugs.gnu.org; Tue, 11 Jun 2019 10:26:17 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahj2-00047d-0N for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 10:26:15 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E50381617D1; Tue, 11 Jun 2019 07:26:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3UI0HHnk3f0u; Tue, 11 Jun 2019 07:26:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0CF8E1617D2; Tue, 11 Jun 2019 07:26:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7gNWKlbzbGx1; Tue, 11 Jun 2019 07:26:04 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E4708161125; Tue, 11 Jun 2019 07:26:04 -0700 (PDT) From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Tue, 11 Jun 2019 07:26:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If we're going to make such a change we should be systematic about it.=20 Unfortunately the currently-proposed patches don't handle examples like=20 these: [A-Fa-f0-9] (in dnd.el) [0-9a-fA-F.] (in org/org-table.el) [0-9a-fA-FxXzZ_] (in progmodes/vera-mode.el) (skip-chars-backward "0-9a-fA-F'") (in progmodes/cc-mode.el) I will cc this message to Mattias Engdeg=C3=A5rd, as he has a good scanne= r=20 for regular expressions and patterns. Mattias, the bug-report thread is=20 here: https://debbugs.gnu.org/36167 From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@gmail.com Cc: 36167@debbugs.gnu.org, Hi-Angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156026382625068 (code B ref 36167); Tue, 11 Jun 2019 14:38:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 14:37:06 +0000 Received: from localhost ([127.0.0.1]:59927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahtZ-0006WF-Om for submit@debbugs.gnu.org; Tue, 11 Jun 2019 10:37:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahtX-0006Vj-DO for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 10:37:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hahtM-00078p-1o; Tue, 11 Jun 2019 10:36:54 -0400 Received: from [176.228.60.248] (port=3445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hahtI-0001sa-2E; Tue, 11 Jun 2019 10:36:50 -0400 Date: Tue, 11 Jun 2019 17:36:46 +0300 Message-Id: <83ef409ojl.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <85a7eob63c.fsf@gmail.com> (npostavs@gmail.com) References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <85a7eob63c.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: npostavs@gmail.com > Date: Tue, 11 Jun 2019 09:32:23 -0400 > Cc: 36167@debbugs.gnu.org > > Robert Pluim writes: > > > And then on subsequent similar changes you can say 'Likewise.' (whilst > > still mentioning the enclosing function) > > There's no need to say 'Likewise', just leave all but the last entry > without a message, see CONTRIBUTE: > > - Preferred form for several entries with the same content: > > * lisp/menu-bar.el (clipboard-yank, clipboard-kill-ring-save) > (clipboard-kill-region): > * lisp/eshell/esh-io.el (eshell-virtual-targets) > (eshell-clipboard-append): > Replace option gui-select-enable-clipboard with > select-enable-clipboard; renamed October 2014. (Bug#25145) > > (Rather than anything involving "ditto" and suchlike.) Yes, the above is the preferred format. "Likewise", "ditto", etc. are just useless noise, since you have to go to the first entry anyway to understand what was done. Also, please note that typing "C-x 4 a" in several functions without adding any text after the colon will automatically extend the list of names in parentheses, so all you have to do is write the description of the change once after you type "C-x 4 a" in all the functions where you made the same change. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 14:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156026388925211 (code B ref 36167); Tue, 11 Jun 2019 14:39:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 14:38:09 +0000 Received: from localhost ([127.0.0.1]:59939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahub-0006YX-6D for submit@debbugs.gnu.org; Tue, 11 Jun 2019 10:38:09 -0400 Received: from forward105j.mail.yandex.net ([5.45.198.248]:35177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hahuW-0006Xl-V6 for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 10:38:06 -0400 Received: from mxback2j.mail.yandex.net (mxback2j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10b]) by forward105j.mail.yandex.net (Yandex) with ESMTP id 5BBFFB2189E; Tue, 11 Jun 2019 17:37:57 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback2j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id O7EQ88cvVH-bu6alv9M; Tue, 11 Jun 2019 17:37:57 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560263877; bh=0F229/LM0UwMP1j42y8UPwfa2uhLR9Rk+WhvSU9R9yQ=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=SIajH8KeuAJ3h9KEdvYPZpZUhyclF2WSKiHllg9AFhGHoDL3lH1kUfz7BxDjUGN+q Bx0DWBCdf/SwL1BcnQG2vbVfGg2iMiEGVMXpFfoL5Sv0nhDK7HeG2k5Zwr2uOENiVh KrCgtRDeLvH7tPs/RsKP8CNAc6NZTq5KkoshZcu4= Authentication-Results: mxback2j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id nbCD8vlSZp-buKidnxL; Tue, 11 Jun 2019 17:37:56 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Tue, 11 Jun 2019 17:37:54 +0300 From: Konstantin Kharlamov Message-Id: <1560263874.21373.1@yandex.ru> In-Reply-To: References: X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On =D0=92=D1=82, =D0=B8=D1=8E=D0=BD 11, 2019 at 07:26, Paul Eggert =20 wrote: > If we're going to make such a change we should be systematic about=20 > it. Unfortunately the currently-proposed patches don't handle=20 > examples like these: >=20 > [A-Fa-f0-9] (in dnd.el) >=20 > [0-9a-fA-F.] (in org/org-table.el) >=20 > [0-9a-fA-FxXzZ_] (in progmodes/vera-mode.el) This one doesn't look like hex. At least :xdigit: sure doesn't match X=20 and Z. Although this probably could be replaced with [[[:digit:]]xXzZ]=20 (didn't test this one). But I imagine such change may better be a=20 separate patch, as it's somewhat different from all the other changes. > (skip-chars-backward "0-9a-fA-F'") (in progmodes/cc-mode.el) Same here. > I will cc this message to Mattias Engdeg=C3=A5rd, as he has a good=20 > scanner for regular expressions and patterns. Mattias, the bug-report=20 > thread is here: >=20 > https://debbugs.gnu.org/36167 Either way, thanks, I already figured too that there are some regexes=20 in a different order. I'm using ack to find them, this should work: ack "\[[-09afAF]{9}\]" I'll post an updated patch later. = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156026747230681 (code B ref 36167); Tue, 11 Jun 2019 15:38:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 15:37:52 +0000 Received: from localhost ([127.0.0.1]:60034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haiqO-0007yn-Bb for submit@debbugs.gnu.org; Tue, 11 Jun 2019 11:37:52 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haiqM-0007yY-5c for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 11:37:51 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7DA911611D1; Tue, 11 Jun 2019 08:37:43 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fqyWbjR84xNe; Tue, 11 Jun 2019 08:37:42 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C6A051616DF; Tue, 11 Jun 2019 08:37:42 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id smTp2gwxL3by; Tue, 11 Jun 2019 08:37:42 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A8545161125; Tue, 11 Jun 2019 08:37:42 -0700 (PDT) References: <1560263874.21373.1@yandex.ru> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> Date: Tue, 11 Jun 2019 08:37:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1560263874.21373.1@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 6/11/19 7:37 AM, Konstantin Kharlamov wrote: > this probably could be replaced with [[[:digit:]]xXzZ] (didn't test > this one). That's right, though it should be [[:xdigit:]xXzZ]. > But I imagine such change may better be a separate patch, as it's > somewhat different from all the other changes. No, it's basically the same thing; we're looking for any place that [:xdigit:] would be useful in clarifying patterns intended to max hexadecimal digits (and perhaps some other things). Also, the skip-chars arguments are also the same thing. Let's do all these. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 36167@debbugs.gnu.org, Konstantin Kharlamov Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602707173240 (code B ref 36167); Tue, 11 Jun 2019 16:32:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 16:31:57 +0000 Received: from localhost ([127.0.0.1]:60069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hajgi-0000qC-SS for submit@debbugs.gnu.org; Tue, 11 Jun 2019 12:31:57 -0400 Received: from mail228c50.megamailservers.eu ([91.136.10.238]:38162 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hajgf-0000q2-LA for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 12:31:55 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1560270702; bh=4tiJxGoY7BzBEi718PD1+aQpjiEFlB8KIvpsJ/0AQ0M=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=TXCl94nV9Skxi9KvKksN8tBe6nkIx0zdBIvUKAPsaPNyoZu0IbFiJrCHXCN20S6kv Uj9Bx1JM1LA6auMA2MP/LjZZeLTW4GBSmZeOpzXwuTZ7IwikSs2A+xMBitv3T0vWcI Yf1f2P9ecfSWAU0qc0fzg6TT+w/BD06vZk8z8W8c= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x5BGVdpX014603; Tue, 11 Jun 2019 16:31:41 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_1DABCA9E-4D64-44D2-AF57-7855C09C0175" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Tue, 11 Jun 2019 18:31:38 +0200 In-Reply-To: <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020D.5CFFD76D.0061, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Y+3WTCWN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=BtfPWYx6ovlXIoLgl2MA:9 a=CjuIK1q_8ugA:10 a=gNqt1e6w93hIO3krYIUA:9 a=ITdVHhY7-e0A:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_1DABCA9E-4D64-44D2-AF57-7855C09C0175 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 11 juni 2019 kl. 17.37 skrev Paul Eggert : >=20 > No, it's basically the same thing; we're looking for any place that = [:xdigit:] would be useful in clarifying patterns intended to max = hexadecimal digits (and perhaps some other things). Also, the skip-chars = arguments are also the same thing. Let's do all these. Since you asked, I've attached a relint run with xr modified to find = parts of character alternatives and skip-sets that could be replaced = with [:xdigit:], on Emacs .el files in master; it was quick work. However, I'm not really convinced that the risks of making mistakes in = the translation would outweigh the benefits. We could make an automatic = verification, but [0-9A-Fa-f] still has one advantage: the reader, and = the writer, know exactly which characters are included without looking = it up. For example: - whether upper case, lower case, or both are accepted - whether non-ascii digits are accepted (included in [:digit:] on many = platforms) But it's not up to me; should your judgement tell you otherwise, go = ahead! I don't mind the use of [:xdigit:] at all, it's just the = wholesale replacement. --Apple-Mail=_1DABCA9E-4D64-44D2-AF57-7855C09C0175 Content-Disposition: attachment; filename=xdigit.log Content-Type: application/octet-stream; x-unix-mode=0644; name="xdigit.log" Content-Transfer-Encoding: quoted-printable ;=20-*-=20compilation=20-*-=0Alisp/calc/calc-aent.el:731:41:=20In=20call=20= to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=206)=0A=20=20"0[xX][0-9a-fA-F]+"=0A=20=20=20......^=0A= lisp/calc/calc-ext.el:3022:24:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 9)=0A=20=20"^0[xX]\\([0-9a-fA-F]+\\)$"=0A=20=20=20..........^=0A= lisp/calc/calc-ext.el:3028:24:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 6)=0A=20=20"^\\$\\([0-9a-fA-F]+\\)$"=0A=20=20=20........^=0A= lisp/calc/calc-lang.el:246:14:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 5)=0A=20=20"\\(\\$[0-9a-fA-F]+\\)\\($\\|[^0-9a-zA-Z=CE=B1-=CF=89=CE=91-=CE= =A9]\\)"=0A=20=20=20.......^=0Alisp/cedet/semantic/java.el:40:3:=20In=20= semantic-java-number-regexp:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=20203)=0A=20=20= "\\(\\<[0-9]+[.][0-9]+\\([eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[.][eE][= -+]?[0-9]+[fFdD]?\\>\\|\\<[0-9]+[.][fFdD]\\>\\|\\<[0-9]+[.]\\|[.][0-9]+\\(= [eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>\\|\\<0[= xX][0-9a-fA-F]+[lL]?\\>\\|\\<[0-9]+[lLfFdD]?\\>\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ...^=0Alisp/cedet/semantic/lex.el:1301:3:=20In=20call=20to=20= define-lex-simple-regex-analyzer:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=20203)=0A=20=20= "\\(\\<[0-9]+[.][0-9]+\\([eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[.][eE][= -+]?[0-9]+[fFdD]?\\>\\|\\<[0-9]+[.][fFdD]\\>\\|\\<[0-9]+[.]\\|[.][0-9]+\\(= [eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>\\|\\<0[= xX][0-9a-fA-F]+[lL]?\\>\\|\\<[0-9]+[lLfFdD]?\\>\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ...^=0Alisp/cedet/semantic/lex.el:1923:28:=20In=20call=20to=20= looking-at:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=20203)=0A=20=20= "\\(\\<[0-9]+[.][0-9]+\\([eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[.][eE][= -+]?[0-9]+[fFdD]?\\>\\|\\<[0-9]+[.][fFdD]\\>\\|\\<[0-9]+[.]\\|[.][0-9]+\\(= [eE][-+]?[0-9]+\\)?[fFdD]?\\>\\|\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>\\|\\<0[= xX][0-9a-fA-F]+[lL]?\\>\\|\\<[0-9]+[lLfFdD]?\\>\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ...^=0Alisp/emulation/cua-rect.el:1130:30:=20In=20call=20to=20= re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=205)=0A=20=20"0x\\([0-9a-fA-F]+\\)"=0A=20=20=20......^=0A= lisp/gnus/mml-sec.el:728:33:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 10)=0A=20=20"\\(0x\\)?\\([0-9a-fA-F]\\{8,\\}\\)"=0A=20=20=20= .............^=0Alisp/gnus/nneething.el:300:26:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=204)=0A=20=20"%\\([0-9a-fA-F][0-9a-fA-F]\\)"=0A=20=20=20= .....^=0Alisp/gnus/nneething.el:300:26:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 15)=0A=20=20"%\\([0-9a-fA-F][0-9a-fA-F]\\)"=0A=20=20=20................^=0A= lisp/international/mule-cmds.el:3082:29:=20In=20call=20to=20= string-match-p:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=203)=0A=20=20"\\`[0-9a-fA-F]+\\'"=0A=20=20=20....^=0A= lisp/mail/rfc2231.el:226:33:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 4)=0A=20=20"%\\([0-9A-Fa-f][0-9A-Fa-f]\\)"=0A=20=20=20.....^=0A= lisp/mail/rfc2231.el:226:33:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 15)=0A=20=20"%\\([0-9A-Fa-f][0-9A-Fa-f]\\)"=0A=20=20=20................^=0A= lisp/net/shr-color.el:238:8:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 4)=0A=20=20"\\(#[0-9a-fA-F]\\{3\\}[0-9a-fA-F]\\{3\\}?\\)"=0A=20=20=20= .....^=0Alisp/net/shr-color.el:238:8:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 20)=0A=20=20"\\(#[0-9a-fA-F]\\{3\\}[0-9a-fA-F]\\{3\\}?\\)"=0A=20=20=20= .......................^=0Alisp/nxml/nxml-maint.el:37:33:=20In=20call=20= to=20re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=206)=0A=20=20"^=20*\\([a-fA-F0-9]\\{2\\}\\)[=20= \t]+"=0A=20=20=20.......^=0Alisp/nxml/nxml-maint.el:40:37:=20In=20call=20= to=20re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=203)=0A=20=20= "\\([a-fA-F0-9]\\{2\\}\\)-\\([a-fA-F0-9]\\{2\\}\\)\\|\\([a-fA-F0-9]\\{2\\}= \\)"=0A=20=20=20....^=0Alisp/nxml/nxml-maint.el:40:37:=20In=20call=20to=20= re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2024)=0A=20=20= "\\([a-fA-F0-9]\\{2\\}\\)-\\([a-fA-F0-9]\\{2\\}\\)\\|\\([a-fA-F0-9]\\{2\\}= \\)"=0A=20=20=20.............................^=0A= lisp/nxml/nxml-maint.el:40:37:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 46)=0A=20=20= "\\([a-fA-F0-9]\\{2\\}\\)-\\([a-fA-F0-9]\\{2\\}\\)\\|\\([a-fA-F0-9]\\{2\\}= \\)"=0A=20=20=20= ........................................................^=0A= lisp/nxml/rng-cmpct.el:372:31:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 8)=0A=20=20"\\\\x+{\\([0-9a-fA-F]+\\)}"=0A=20=20=20...........^=0A= lisp/nxml/rng-uri.el:71:25:=20In=20call=20to=20string-match:=200-9A-Fa-f=20= in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=2014)=0A=20=20= "\\`\\(?:[^%]\\|%[0-9a-fA-F]{2}\\)*\\'"=0A=20=20=20.................^=0A= lisp/nxml/rng-uri.el:302:29:=20In=20call=20to=20= replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=2016)=0A=20=20"\\(?:%[89a-fA-F][0-9a-fA-F]\\)+"=0A= =20=20=20.................^=0Alisp/nxml/rng-uri.el:313:29:=20In=20call=20= to=20replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=207)=0A=20=20"%[0-7][0-9a-fA-F]"=0A=20=20=20= .......^=0Alisp/nxml/rng-uri.el:321:29:=20In=20call=20to=20= replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=207)=0A=20=20"%[0-7][0-9a-fA-F]\\|[^%]"=0A=20=20=20= .......^=0Alisp/nxml/rng-uri.el:336:4:=20In=20call=20to=20= replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=207)=0A=20=20"%[0-7][0-9a-fA-F]\\|[^%]"=0A=20=20=20= .......^=0Alisp/nxml/rng-xsd.el:333:22:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 16)=0A=20=20"\\`[=20\r\n\t]*\\(\\(?:[0-9A-Fa-f][0-9A-Fa-f]\\)*\\)[=20= \r\n\t]*\\'"=0A=20=20=20......................^=0A= lisp/nxml/rng-xsd.el:333:22:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 27)=0A=20=20"\\`[=20\r\n\t]*\\(\\(?:[0-9A-Fa-f][0-9A-Fa-f]\\)*\\)[=20= \r\n\t]*\\'"=0A=20=20=20.................................^=0A= lisp/nxml/rng-xsd.el:363:22:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 14)=0A=20=20"\\`\\(?:[^%]\\|%[0-9a-fA-F][0-9a-fA-F]\\)*\\'"=0A=20=20=20= .................^=0Alisp/nxml/rng-xsd.el:363:22:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2025)=0A=20=20= "\\`\\(?:[^%]\\|%[0-9a-fA-F][0-9a-fA-F]\\)*\\'"=0A=20=20=20= ............................^=0Alisp/nxml/xsd-regexp.el:705:31:=20In=20= call=20to=20re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=204)=0A=20=20= "^\\([0-9A-Fa-f]*\\);[^;]*;\\([A-Z][a-z]\\);"=0A=20=20=20.....^=0A= lisp/org/org-mobile.el:475:29:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 1)=0A=20=20"[a-fA-F0-9]\\{30,40\\}"=0A=20=20=20.^=0A= lisp/org/org-mobile.el:764:34:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 3)=0A=20=20"\\([0-9a-fA-F]\\{30,\\}\\).*?mobileorg\\.org[=20\t]*$"=0A=20=20= =20....^=0Alisp/org/org-table.el:158:3:=20In=20org-table-number-regexp:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 60)=0A=20=20= "^\\([<>]?[-+^.0-9]*[0-9][-+^.0-9eEdDx()%:]*\\|[<>]?[-+]?0[xX][0-9a-fA-F.]= +\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$"=0A=20=20=20= ..............................................................^=0A= lisp/progmodes/ada-mode.el:912:37:=20In=20call=20to=20re-search-forward:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 4)=0A=20=20"\\(#[0-9a-fA-F]*#\\)"=0A=20=20=20.....^=0A= lisp/progmodes/ada-mode.el:1016:17:=20In=20call=20to=20looking-back:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 10)=0A=20=20"\\([0-9]+#[0-9a-fA-F_]+\\)"=0A=20=20=20...........^=0A= lisp/progmodes/ada-mode.el:5139:3:=20In=20ada-font-lock-keywords:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 10)=0A=20=20"\\([0-9]+#[0-9a-fA-F_]+#\\)"=0A=20=20=20...........^=0A= lisp/progmodes/cc-mode.el:1416:3:=20In=20c-maybe-quoted-number-head:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 14)=0A=20=20= "\\(0\\(\\([Xx]\\([0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*'?\\)?\\)\\|= \\([Bb]\\([01]\\('[01]\\|[01]\\)*'?\\)?\\)\\|\\('[0-7]\\|[0-7]\\)*'?\\)\\|= [1-9]\\('[0-9]\\|[0-9]\\)*'?\\)"=0A=20=20=20..................^=0A= lisp/progmodes/cc-mode.el:1416:3:=20In=20c-maybe-quoted-number-head:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 28)=0A=20=20= "\\(0\\(\\([Xx]\\([0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*'?\\)?\\)\\|= \\([Bb]\\([01]\\('[01]\\|[01]\\)*'?\\)?\\)\\|\\('[0-7]\\|[0-7]\\)*'?\\)\\|= [1-9]\\('[0-9]\\|[0-9]\\)*'?\\)"=0A=20=20=20= .................................^=0Alisp/progmodes/cc-mode.el:1416:3:=20= In=20c-maybe-quoted-number-head:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2041)=0A=20=20= "\\(0\\(\\([Xx]\\([0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*'?\\)?\\)\\|= \\([Bb]\\([01]\\('[01]\\|[01]\\)*'?\\)?\\)\\|\\('[0-7]\\|[0-7]\\)*'?\\)\\|= [1-9]\\('[0-9]\\|[0-9]\\)*'?\\)"=0A=20=20=20= ...............................................^=0A= lisp/progmodes/cc-mode.el:1438:30:=20In=20call=20to=20= skip-chars-backward:=200-9A-Fa-f=20in=20skip=20set=20could=20be=20= [:xdigit:]=20(pos=200)=0A=20=20"0-9a-fA-F'"=0A=20=20=20^=0A= lisp/progmodes/cc-mode.el:1450:3:=20In=20c-maybe-quoted-number-tail:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 11)=0A=20=20= "\\(\\([xX']?[0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([bB']?[0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('?[0-9]\\('[0-9]\\|[0-9]\\)*\\)\\)"=0A=20=20= =20.............^=0Alisp/progmodes/cc-mode.el:1450:3:=20In=20= c-maybe-quoted-number-tail:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2025)=0A=20=20= "\\(\\([xX']?[0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([bB']?[0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('?[0-9]\\('[0-9]\\|[0-9]\\)*\\)\\)"=0A=20=20= =20............................^=0Alisp/progmodes/cc-mode.el:1450:3:=20= In=20c-maybe-quoted-number-tail:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2038)=0A=20=20= "\\(\\([xX']?[0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([bB']?[0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('?[0-9]\\('[0-9]\\|[0-9]\\)*\\)\\)"=0A=20=20= =20..........................................^=0A= lisp/progmodes/cc-mode.el:1470:3:=20In=20c-maybe-quoted-number:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 12)=0A=20=20= "\\(0\\(\\([Xx][0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([Bb][0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('[0-7]\\|[0-7]\\)*\\)\\|[1-9]\\('[0-9]\\|[0-= 9]\\)*\\)"=0A=20=20=20...............^=0A= lisp/progmodes/cc-mode.el:1470:3:=20In=20c-maybe-quoted-number:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 26)=0A=20=20= "\\(0\\(\\([Xx][0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([Bb][0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('[0-7]\\|[0-7]\\)*\\)\\|[1-9]\\('[0-9]\\|[0-= 9]\\)*\\)"=0A=20=20=20..............................^=0A= lisp/progmodes/cc-mode.el:1470:3:=20In=20c-maybe-quoted-number:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 39)=0A=20=20= "\\(0\\(\\([Xx][0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)\\|\\([Bb][0= 1]\\('[01]\\|[01]\\)*\\)\\|\\('[0-7]\\|[0-7]\\)*\\)\\|[1-9]\\('[0-9]\\|[0-= 9]\\)*\\)"=0A=20=20=20............................................^=0A= lisp/progmodes/cc-mode.el:1490:47:=20In=20call=20to=20= skip-chars-forward:=200-9A-Fa-f=20in=20skip=20set=20could=20be=20= [:xdigit:]=20(pos=200)=0A=20=20"0-9a-fA-F'"=0A=20=20=20^=0A= lisp/progmodes/cc-mode.el:1492:39:=20In=20call=20to=20= skip-chars-backward:=200-9A-Fa-f=20in=20skip=20set=20could=20be=20= [:xdigit:]=20(pos=200)=0A=20=20"0-9a-fA-F'"=0A=20=20=20^=0A= lisp/progmodes/cc-mode.el:1533:10:=20In=20call=20to=20looking-at:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 33)=0A=20=20= "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'"=0A=20=20= =20..........................................^=0A= lisp/progmodes/cc-mode.el:1562:10:=20In=20call=20to=20looking-at:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 33)=0A=20=20= "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'"=0A=20=20= =20..........................................^=0A= lisp/progmodes/cc-mode.el:1582:8:=20In=20call=20to=20looking-at:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 26)=0A=20=20= "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\|.\\)?\\('\\([^'\\]\= \|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)\\)*'"=0A=20=20=20= .................................^=0Alisp/progmodes/cc-mode.el:1582:8:=20= In=20call=20to=20looking-at:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2084)=0A=20=20= "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\|.\\)?\\('\\([^'\\]\= \|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)\\)*'"=0A=20=20=20= ..........................................................................= ...............................^=0Alisp/progmodes/cc-mode.el:1635:17:=20= In=20call=20to=20looking-at:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2033)=0A=20=20= "\\([^\\']\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'"=0A=20=20= =20..........................................^=0A= lisp/progmodes/cperl-mode.el:4423:45:=20In=20call=20to=20= re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=203)=0A=20=20= "\\=3D[0-9a-fA-F][0-9a-fA-F]?\\|\\=3D{[0-9a-fA-F]+}"=0A=20=20=20....^=0A= lisp/progmodes/cperl-mode.el:4423:45:=20In=20call=20to=20= re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2014)=0A=20=20= "\\=3D[0-9a-fA-F][0-9a-fA-F]?\\|\\=3D{[0-9a-fA-F]+}"=0A=20=20=20= ...............^=0Alisp/progmodes/cperl-mode.el:4423:45:=20In=20call=20= to=20re-search-forward:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=2031)=0A=20=20= "\\=3D[0-9a-fA-F][0-9a-fA-F]?\\|\\=3D{[0-9a-fA-F]+}"=0A=20=20=20= ..................................^=0Alisp/progmodes/ebnf-dtd.el:948:19:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2039)=0A=20=20= "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|= [^<&]\\)*$"=0A=20=20=20...........................................^=0A= lisp/progmodes/ebnf-dtd.el:1004:14:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 69)=0A=20=20= "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x= [0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$"=0A=20=20=20= ..........................................................................= ^=0Alisp/progmodes/ebnf-ebx.el:661:32:=20In=20call=20to=20= skip-chars-forward:=200-9A-Fa-f=20in=20skip=20set=20could=20be=20= [:xdigit:]=20(pos=200)=0A=20=20"0-9A-Fa-f"=0A=20=20=20^=0A= lisp/progmodes/hideif.el:542:3:=20In=20hif-token-regexp:=200-9A-Fa-f=20= in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=2071)=0A=20=20= "\\(?:!=3D\\|##\\|&&\\|\\.\\.\\.\\|<[<=3D]\\|=3D=3D\\|>[=3D>]\\|||\\|[!#%&= (-,/:<-?|~^-]\\)\\|0x[0-9a-fA-F]+\\.?[0-9a-fA-F]*\\|[0-9]+\\.?[0-9]*\\|\\w= +"=0A=20=20=20= ..........................................................................= ...........^=0Alisp/progmodes/hideif.el:542:3:=20In=20hif-token-regexp:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 86)=0A=20=20= "\\(?:!=3D\\|##\\|&&\\|\\.\\.\\.\\|<[<=3D]\\|=3D=3D\\|>[=3D>]\\|||\\|[!#%&= (-,/:<-?|~^-]\\)\\|0x[0-9a-fA-F]+\\.?[0-9a-fA-F]*\\|[0-9]+\\.?[0-9]*\\|\\w= +"=0A=20=20=20= ..........................................................................= ...........................^=0Alisp/progmodes/hideif.el:598:38:=20In=20= call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=205)=0A=20=20= "0x\\([0-9a-fA-F]+\\.?[0-9a-fA-F]*\\)"=0A=20=20=20......^=0A= lisp/progmodes/hideif.el:598:38:=20In=20call=20to=20string-match:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 20)=0A=20=20"0x\\([0-9a-fA-F]+\\.?[0-9a-fA-F]*\\)"=0A=20=20=20= ......................^=0Alisp/progmodes/vera-mode.el:605:3:=20In=20= vera-font-lock-keywords:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=2016)=0A=20=20= "\\([0-9]*'[bdoh][0-9a-fA-FxXzZ_]+\\)"=0A=20=20=20.................^=0A= lisp/progmodes/verilog-mode.el:2760:28:=20In=20verilog-delay-re:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 29)=0A=20=20= "#\\s-*\\(\\([0-9_]+\\('s?[hdxbo][0-9a-fA-F_xz]+\\)?\\)\\|\\(([^()]*)\\)\\= |\\(\\sw+\\)\\)"=0A=20=20=20.................................^=0A= lisp/progmodes/verilog-mode.el:9180:32:=20In=20call=20to=20looking-at:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 25)=0A=20=20"'[sS]?[hdxboHDXBO]?[=20\t]*[0-9a-fA-F_xzXZ?]+"=0A=20=20=20= ..........................^=0Alisp/progmodes/verilog-mode.el:9870:21:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2020)=0A=20=20"^[0-9=20= \t]+'s?[hdxbo][0-9a-fA-F_xz?=20\t]*$"=0A=20=20=20.....................^=0A= lisp/textmodes/css-mode.el:876:3:=20In=20css-escapes-re:=200-9A-Fa-f=20= in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=2016)=0A=20=20= "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[=20\n\t\r\f]?\\)"=0A=20=20=20= .............................^=0Alisp/textmodes/css-mode.el:877:25:=20In=20= css-nmchar-re:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2034)=0A=20=20= "\\(?:[-[:alnum:]]\\|\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[=20= \n\t\r\f]?\\)\\)"=0A=20=20=20= .................................................^=0A= lisp/textmodes/css-mode.el:878:26:=20In=20css-nmstart-re:=200-9A-Fa-f=20= in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=2033)=0A=20=20= "\\(?:[[:alpha:]]\\|\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[=20= \n\t\r\f]?\\)\\)"=0A=20=20=20= ................................................^=0A= lisp/textmodes/css-mode.el:881:3:=20In=20css-ident-re:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2034)=0A=20=20= "\\(?:[-[:alnum:]]\\|\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[=20= \n\t\r\f]?\\)\\)+"=0A=20=20=20= .................................................^=0A= lisp/textmodes/css-mode.el:884:23:=20In=20css-name-re:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2034)=0A=20=20= "\\(?:[-[:alnum:]]\\|\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[=20= \n\t\r\f]?\\)\\)+"=0A=20=20=20= .................................................^=0A= lisp/textmodes/css-mode.el:1077:3:=20In=20css--colors-regexp:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 1644)=0A=20=20= "\\_<\\(a\\(?:liceblue\\|ntiquewhite\\|qua\\(?:marine\\)?\\|zure\\)\\|b\\(= ?:eige\\|isque\\|l\\(?:a\\(?:ck\\|nchedalmond\\)\\|ue\\(?:violet\\)?\\)\\|= rown\\|urlywood\\)\\|c\\(?:adetblue\\|h\\(?:\\(?:artreus\\|ocolat\\)e\\)\\= |or\\(?:al\\|n\\(?:flowerblue\\|silk\\)\\)\\|\\(?:rimso\\|ya\\)n\\)\\|d\\(= ?:ark\\(?:blue\\|cyan\\|g\\(?:oldenrod\\|r\\(?:ay\\|e\\(?:en\\|y\\)\\)\\)\= \|khaki\\|magenta\\|o\\(?:livegreen\\|r\\(?:ange\\|chid\\)\\)\\|red\\|s\\(= ?:almon\\|eagreen\\|late\\(?:blue\\|gr\\(?:[ae]y\\)\\)\\)\\|turquoise\\|vi= olet\\)\\|eep\\(?:pink\\|skyblue\\)\\|imgr\\(?:[ae]y\\)\\|odgerblue\\)\\|f= \\(?:irebrick\\|loralwhite\\|orestgreen\\|uchsia\\)\\|g\\(?:ainsboro\\|hos= twhite\\|old\\(?:enrod\\)?\\|r\\(?:ay\\|e\\(?:en\\(?:yellow\\)?\\|y\\)\\)\= \)\\|ho\\(?:neydew\\|tpink\\)\\|i\\(?:ndi\\(?:anred\\|go\\)\\|vory\\)\\|kh= aki\\|l\\(?:a\\(?:vender\\(?:blush\\)?\\|wngreen\\)\\|emonchiffon\\|i\\(?:= ght\\(?:blue\\|c\\(?:oral\\|yan\\)\\|g\\(?:oldenrodyellow\\|r\\(?:ay\\|e\\= (?:en\\|y\\)\\)\\)\\|pink\\|s\\(?:almon\\|eagreen\\|kyblue\\|lategr\\(?:[a= e]y\\)\\|teelblue\\)\\|yellow\\)\\|me\\(?:green\\)?\\|nen\\)\\)\\|m\\(?:a\= \(?:genta\\|roon\\)\\|edium\\(?:aquamarine\\|blue\\|orchid\\|purple\\|s\\(= ?:eagreen\\|lateblue\\|pringgreen\\)\\|turquoise\\|violetred\\)\\|i\\(?:dn= ightblue\\|ntcream\\|styrose\\)\\|occasin\\)\\|nav\\(?:ajowhite\\|y\\)\\|o= \\(?:l\\(?:dlace\\|ive\\(?:drab\\)?\\)\\|r\\(?:ange\\(?:red\\)?\\|chid\\)\= \)\\|p\\(?:a\\(?:le\\(?:g\\(?:oldenrod\\|reen\\)\\|turquoise\\|violetred\\= )\\|payawhip\\)\\|e\\(?:achpuff\\|ru\\)\\|ink\\|lum\\|\\(?:owderblu\\|urpl= \\)e\\)\\|r\\(?:e\\(?:beccapurple\\|d\\)\\|o\\(?:sybrown\\|yalblue\\)\\)\\= |s\\(?:a\\(?:\\(?:ddlebrow\\|lmo\\|ndybrow\\)n\\)\\|ea\\(?:green\\|shell\\= )\\|i\\(?:enna\\|lver\\)\\|kyblue\\|late\\(?:blue\\|gr\\(?:[ae]y\\)\\)\\|n= ow\\|pringgreen\\|teelblue\\)\\|t\\(?:an\\|eal\\|histle\\|omato\\|urquoise= \\)\\|violet\\|wh\\(?:eat\\|ite\\(?:smoke\\)?\\)\\|yellow\\(?:green\\)?\\)= \\_>\\|\\(#[0-9a-fA-F]\\{3,4\\}\\b\\)\\|\\(#\\(?:[0-9a-fA-F][0-9a-fA-F]\\)= \\{3,4\\}\\b\\)\\|\\(\\_\\|\\(#[0-9a-fA-F]\\{3,4\\}\\b\\)\\|\\(#\\(?:[0-9a-fA-F][0-9a-fA-F]\\)= \\{3,4\\}\\b\\)\\|\\(\\_\\|\\(#[0-9a-fA-F]\\{3,4\\}\\b\\)\\|\\(#\\(?:[0-9a-fA-F][0-9a-fA-F]\\)= \\{3,4\\}\\b\\)\\|\\(\\_&;\n\t=20\"%!'(),/=3D?]\\|$\\)"=0A=20=20=20= ................................................^=0Alisp/dnd.el:141:4:=20= In=20call=20to=20replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=202)=0A=20=20= "%[A-Fa-f0-9][A-Fa-f0-9]"=0A=20=20=20..^=0Alisp/dnd.el:141:4:=20In=20= call=20to=20replace-regexp-in-string:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=2013)=0A=20=20= "%[A-Fa-f0-9][A-Fa-f0-9]"=0A=20=20=20.............^=0A= lisp/epg.el:952:21:=20In=20call=20to=20string-match:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2037)=0A=20=20= "\\`\\([^=20]+\\)=20\\([0-9]+\\)=20\\([0-9]+\\)=20= \\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\([^=20]+\\)=20\\([0-9]+\\)"=0A=20=20=20= .............................................^=0Alisp/epg.el:952:21:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2048)=0A=20=20"\\`\\([^=20]+\\)=20= \\([0-9]+\\)=20\\([0-9]+\\)=20\\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\([^=20= ]+\\)=20\\([0-9]+\\)"=0A=20=20=20= ........................................................^=0A= lisp/epg.el:976:30:=20In=20call=20to=20string-match:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2080)=0A=20=20= "\\`\\([^=20]+\\)=20[^=20]+=20\\([^=20]+\\)=20\\([^=20]+\\)=20= \\([0-9]+\\)=20[^=20]+=20\\([0-9]+\\)=20\\([0-9]+\\)=20= \\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\(.*\\)"=0A=20=20=20= ..........................................................................= ....................^=0Alisp/epg.el:976:30:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2091)=0A=20=20"\\`\\([^=20]+\\)=20[^=20]+=20\\([^=20= ]+\\)=20\\([^=20]+\\)=20\\([0-9]+\\)=20[^=20]+=20\\([0-9]+\\)=20= \\([0-9]+\\)=20\\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\(.*\\)"=0A=20=20=20= ..........................................................................= ...............................^=0Alisp/epg.el:1146:21:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2037)=0A=20=20"\\`\\([DCS]\\)=20\\([0-9]+\\)=20= \\([0-9]+\\)=20\\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\(.*\\)=20"=0A=20=20=20= .............................................^=0Alisp/epg.el:1146:21:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2048)=0A=20=20"\\`\\([DCS]\\)=20= \\([0-9]+\\)=20\\([0-9]+\\)=20\\([0-9A-Fa-f][0-9A-Fa-f]\\)=20\\(.*\\)=20= "=0A=20=20=20........................................................^=0A= lisp/epg.el:2024:26:=20In=20call=20to=20string-match:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2013)=0A=20=20= "%\\(\\(%\\)\\|\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)"=0A=20=20=20= ..................^=0Alisp/epg.el:2024:26:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2024)=0A=20=20= "%\\(\\(%\\)\\|\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)"=0A=20=20=20= .............................^=0Alisp/epg.el:2037:36:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=201)=0A=20=20"[0-9A-Fa-f][0-9A-Fa-f]"=0A=20=20=20.^=0A= lisp/epg.el:2037:36:=20In=20call=20to=20string-match:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2012)=0A=20=20= "[0-9A-Fa-f][0-9A-Fa-f]"=0A=20=20=20............^=0Alisp/epg.el:2046:26:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=2024)=0A=20=20= "\\\\\\(\\([,=3D+<>#;\\\"]\\)\\|\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)"=0A=20=20= =20.................................^=0Alisp/epg.el:2046:26:=20In=20call=20= to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2035)=0A=20=20= "\\\\\\(\\([,=3D+<>#;\\\"]\\)\\|\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)"=0A=20=20= =20............................................^=0Alisp/epg.el:2084:37:=20= In=20call=20to=20string-match:=200-9A-Fa-f=20in=20char=20alternative=20= could=20be=20[:xdigit:]=20(pos=204)=0A=20=20"#\\([0-9A-Fa-f]+\\)"=0A=20=20= =20.....^=0Alisp/faces.el:2000:35:=20In=20call=20to=20string-match-p:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 7)=0A=20=20"^#\\(?:[a-fA-F0-9][a-fA-F0-9][a-fA-F0-9]\\)+$"=0A=20=20=20= ........^=0Alisp/faces.el:2000:35:=20In=20call=20to=20string-match-p:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 18)=0A=20=20"^#\\(?:[a-fA-F0-9][a-fA-F0-9][a-fA-F0-9]\\)+$"=0A=20=20=20= ...................^=0Alisp/faces.el:2000:35:=20In=20call=20to=20= string-match-p:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2029)=0A=20=20= "^#\\(?:[a-fA-F0-9][a-fA-F0-9][a-fA-F0-9]\\)+$"=0A=20=20=20= ..............................^=0Alisp/htmlfontify.el:569:25:=20In=20= hfy-hex-regex:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=201)=0A=20=20"[0-9A-Fa-f]"=0A=20=20=20.^=0A= lisp/htmlfontify.el:572:3:=20In=20hfy-triplet-regex:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=203)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20....^=0Alisp/htmlfontify.el:572:3:=20In=20= hfy-triplet-regex:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2014)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20...............^=0Alisp/htmlfontify.el:572:3:=20= In=20hfy-triplet-regex:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=2029)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20................................^=0A= lisp/htmlfontify.el:572:3:=20In=20hfy-triplet-regex:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2040)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20...........................................^=0A= lisp/htmlfontify.el:572:3:=20In=20hfy-triplet-regex:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2055)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20= ............................................................^=0A= lisp/htmlfontify.el:572:3:=20In=20hfy-triplet-regex:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=2066)=0A=20=20= "\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\([0-9A-Fa-f][0-= 9A-Fa-f]\\)"=0A=20=20=20= .......................................................................^=0A= lisp/version.el:123:31:=20In=20call=20to=20looking-at:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=201)=0A=20=20= "[0-9a-fA-F]\\{40\\}"=0A=20=20=20.^=0Alisp/xml.el:198:28:=20In=20= xml-char-ref-re:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2019)=0A=20=20"\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)"=0A= =20=20=20.....................^=0Alisp/xml.el:203:37:=20In=20= xml-entity-or-char-ref-re:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=2015)=0A=20=20= "&\\(?:#\\(x\\)?\\([0-9a-fA-F]+\\)\\|\\([[:word:]:_][[:word:]:_.0-9=C2=B7=CC= =80-=CD=AF=E2=80=BF=E2=81=80-]*\\)\\);"=0A=20=20=20...................^=0A= lisp/xml.el:210:28:=20In=20xml-reference-re:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=2063)=0A=20=20= "\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*= ;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)"=0A=20=20=20= ...................................................................^=0A= lisp/xml.el:214:28:=20In=20xml-att-value-re:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=2079)=0A=20=20= "\\(?:\"\\(?:[^&\"]\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF= =E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'= \\(?:[^&']\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF= =E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)"=0A=20=20= =20= ..........................................................................= ..............^=0Alisp/xml.el:214:28:=20In=20xml-att-value-re:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 176)=0A=20=20= "\\(?:\"\\(?:[^&\"]\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF= =E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'= \\(?:[^&']\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF= =E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)"=0A=20=20= =20= ..........................................................................= ..........................................................................= ................................................^=0Alisp/xml.el:251:31:=20= In=20xml-default-decl-re:=200-9A-Fa-f=20in=20char=20alternative=20could=20= be=20[:xdigit:]=20(pos=20121)=0A=20=20= "\\(?:#REQUIRED\\|#IMPLIED\\|\\(?:#FIXED\\s-+\\)*\\(?:\"\\(?:[^&\"]\\|\\(?= :&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\= \(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'\\(?:[^&']\\|\\(?:&[[:word= :]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-= 9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)\\)"=0A=20=20=20= ..........................................................................= ..............................................................^=0A= lisp/xml.el:251:31:=20In=20xml-default-decl-re:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=20218)=0A=20=20= "\\(?:#REQUIRED\\|#IMPLIED\\|\\(?:#FIXED\\s-+\\)*\\(?:\"\\(?:[^&\"]\\|\\(?= :&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\= \(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'\\(?:[^&']\\|\\(?:&[[:word= :]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-= 9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ......................^=0Alisp/xml.el:256:26:=20In=20xml-att-def-re:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 452)=0A=20=20= "\\(?:\\s-*[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80= -]*\\s-*\\(?:CDATA\\|\\(?:ID\\|IDREF\\|IDREFS\\|ENTITY\\|ENTITIES\\|NMTOKE= N\\|NMTOKENS\\)\\|\\(?:\\(?:NOTATION\\s-+(\\s-*[[:word:]:_][[:word:]:_.0-9= =C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*\\(?:\\s-*|\\s-*[[:word:]:_][[:wor= d:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*\\)*\\s-*)\\)\\|\\(?:(\\s= -*[[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]+\\(?:\\s-*|\\s-*[= [:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]+\\)*\\s-+)\\)\\)\\)\= \s-*\\(?:#REQUIRED\\|#IMPLIED\\|\\(?:#FIXED\\s-+\\)*\\(?:\"\\(?:[^&\"]\\|\= \(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\= \|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'\\(?:[^&']\\|\\(?:&[[:w= ord:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#= [0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)\\)\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ...........................................................^=0A= lisp/xml.el:256:26:=20In=20xml-att-def-re:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=20549)=0A=20=20= "\\(?:\\s-*[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80= -]*\\s-*\\(?:CDATA\\|\\(?:ID\\|IDREF\\|IDREFS\\|ENTITY\\|ENTITIES\\|NMTOKE= N\\|NMTOKENS\\)\\|\\(?:\\(?:NOTATION\\s-+(\\s-*[[:word:]:_][[:word:]:_.0-9= =C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*\\(?:\\s-*|\\s-*[[:word:]:_][[:wor= d:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*\\)*\\s-*)\\)\\|\\(?:(\\s= -*[[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]+\\(?:\\s-*|\\s-*[= [:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]+\\)*\\s-+)\\)\\)\\)\= \s-*\\(?:#REQUIRED\\|#IMPLIED\\|\\(?:#FIXED\\s-+\\)*\\(?:\"\\(?:[^&\"]\\|\= \(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\= \|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\\|'\\(?:[^&']\\|\\(?:&[[:w= ord:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#= [0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)\\)\\)"=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ...................^=0Alisp/xml.el:262:31:=20In=20xml-entity-value-re:=20= 0-9A-Fa-f=20in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20= 124)=0A=20=20= "\\(?:\"\\(?:[^%&\"]\\|%\\([[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2= =80=BF=E2=81=80-]*\\);\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD= =AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\= \|'\\(?:[^%&']\\|%\\([[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF= =E2=81=80-]*\\);\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2= =80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)"=0A= =20=20=20= ..........................................................................= ..............................................................^=0A= lisp/xml.el:262:31:=20In=20xml-entity-value-re:=200-9A-Fa-f=20in=20char=20= alternative=20could=20be=20[:xdigit:]=20(pos=20266)=0A=20=20= "\\(?:\"\\(?:[^%&\"]\\|%\\([[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2= =80=BF=E2=81=80-]*\\);\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD= =AF=E2=80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*\"\= \|'\\(?:[^%&']\\|%\\([[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2=80=BF= =E2=81=80-]*\\);\\|\\(?:&[[:word:]:_][[:word:]:_.0-9=C2=B7=CC=80-=CD=AF=E2= =80=BF=E2=81=80-]*;\\|\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)\\)\\)*'\\)"=0A= =20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ......................................................................^=0A= lisp/xml.el:804:28:=20In=20call=20to=20looking-at:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=20517)=0A=20=20= ""=0A= =20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ...........................................................^=0A= lisp/xml.el:804:28:=20In=20call=20to=20looking-at:=200-9A-Fa-f=20in=20= char=20alternative=20could=20be=20[:xdigit:]=20(pos=20614)=0A=20=20= ""=0A= =20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ...................^=0Alisp/xml.el:823:28:=20In=20call=20to=20= looking-at:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=20201)=0A=20=20""=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= .....^=0Alisp/xml.el:823:28:=20In=20call=20to=20looking-at:=200-9A-Fa-f=20= in=20char=20alternative=20could=20be=20[:xdigit:]=20(pos=20343)=0A=20=20= ""=0A=20=20=20= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= ..........................................................................= .............^=0Atest/src/emacs-module-tests.el:62:18:=20In=20call=20to=20= string-match:=200-9A-Fa-f=20in=20char=20alternative=20could=20be=20= [:xdigit:]=20(pos=2031)=0A=20=20"#"=0A=20=20=20..................................^=0A= --Apple-Mail=_1DABCA9E-4D64-44D2-AF57-7855C09C0175-- From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Paul Eggert Cc: 36167@debbugs.gnu.org, Konstantin Kharlamov Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602718544941 (code B ref 36167); Tue, 11 Jun 2019 16:51:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 16:50:54 +0000 Received: from localhost ([127.0.0.1]:60084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hajz4-0001Hd-64 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 12:50:54 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:32910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hajz0-0001HN-2x for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 12:50:52 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BGldTK017530; Tue, 11 Jun 2019 16:50:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=JdSjzAcx82XLuhIfb4EJ2XVqPeq2nTALXa53VXqCCX0=; b=cvNTj2DVE9qGcSQlXBFOuNtSIs8Zpk3AyIcOByIOY8sKvRoLVIUCXEMmln/VqUZ7cWN/ bc5kbyLzf7NFW1G+PbTzqOwAmRKqpDK2GYW9oZgsrcuygOMCMxCaqkiopkfJ91Gb+P78 nSEKAEmuWmT/HVsXzqvxyzL/1UqQpLCSRWZEoGYFjQtwzMhQxCQJ+3Mey1qvX7dHNMGu 6TReU9rMcDDga18NDAdhZt40w1/ZDEioWO3AXdK809Ho/Fz0Y/jpPHYTOU4n5n8uLutN 7OhIkENODk8tpLnRVmVR9722RvkWgnzKrNlH5Jo7/rZteVlB96pUf15ie5ve40S0Ej9E xA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2t02hepm62-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 16:50:31 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BGo9x0122900; Tue, 11 Jun 2019 16:50:31 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2t0p9rdbnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 16:50:30 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5BGoPUX030425; Tue, 11 Jun 2019 16:50:25 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 11 Jun 2019 09:50:24 -0700 (PDT) From: Drew Adams References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> In-Reply-To: <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=682 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110107 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=18 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=748 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110107 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > [0-9A-Fa-f] still has one advantage: the reader, and the > writer, know exactly which characters are included without looking it up.= For > example: >=20 > - whether upper case, lower case, or both are accepted > - whether non-ascii digits are accepted (included in [:digit:] on many > platforms) +1. At least the doc for [:digit:] should say exactly what it matches. Then it'll be clear for readers and writers. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602727016252 (code B ref 36167); Tue, 11 Jun 2019 17:06:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:05:01 +0000 Received: from localhost ([127.0.0.1]:60096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakCj-0001cj-79 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:05:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakCe-0001cM-Rd for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:04:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hakCY-0004a2-Fu; Tue, 11 Jun 2019 13:04:50 -0400 Received: from [176.228.60.248] (port=4793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hakCN-0005cS-IQ; Tue, 11 Jun 2019 13:04:43 -0400 Date: Tue, 11 Jun 2019 20:04:38 +0300 Message-Id: <83zhmo834p.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Drew Adams on Tue, 11 Jun 2019 09:50:24 -0700 (PDT)) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 11 Jun 2019 09:50:24 -0700 (PDT) > From: Drew Adams > Cc: 36167@debbugs.gnu.org, Konstantin Kharlamov > > > [0-9A-Fa-f] still has one advantage: the reader, and the > > writer, know exactly which characters are included without looking it up. For > > example: > > > > - whether upper case, lower case, or both are accepted > > - whether non-ascii digits are accepted (included in [:digit:] on many > > platforms) > > +1. At least the doc for [:digit:] should say exactly > what it matches. Then it'll be clear for readers and > writers. Isn't it clear already? Here's what the documentation says now: ‘[:digit:]’ This matches ‘0’ through ‘9’. Thus, ‘[-+[:digit:]]’ matches any digit, as well as ‘+’ and ‘-’. Is anything missing here? Where did the question about non-ASCII digits come from, given this text? From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Drew Adams Cc: mattiase@acm.org, 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602735347445 (code B ref 36167); Tue, 11 Jun 2019 17:19:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:18:54 +0000 Received: from localhost ([127.0.0.1]:60102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQA-0001w0-JQ for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:18:54 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQ8-0001vm-36 for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:18:53 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8E7B01617D4; Tue, 11 Jun 2019 10:18:45 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bsZInYiMW_PV; Tue, 11 Jun 2019 10:18:44 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D03CB1617D5; Tue, 11 Jun 2019 10:18:44 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yyqILVJT-RHd; Tue, 11 Jun 2019 10:18:44 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AF52A1617CC; Tue, 11 Jun 2019 10:18:44 -0700 (PDT) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <12942077-ba92-0959-bc02-ba7ad1897b12@cs.ucla.edu> Date: Tue, 11 Jun 2019 10:18:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <83zhmo834p.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 6/11/19 10:04 AM, Eli Zaretskii wrote: > Where did the question about non-ASCII > digits come from, given this text? It came from POSIX, where [:xdigit:] and [:digit:] might match other characters. Similarly, in POSIX [a-f] might match characters other than 'a', 'b', 'c', 'd', 'e', 'f'. We don't need to worry about this in Emacs, since Emacs regexps don't have that particular misfeature of POSIX. I'm on the fence about replacing 0-9A-Fa-f with [:xdigit:], as I can see both sides of the argument. If Mattias is dubious, then perhaps we should leave the regexps alone - he's had more experience than the rest of us when it comes to scanning for dubious regexp constructions. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602735727523 (code B ref 36167); Tue, 11 Jun 2019 17:20:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:19:32 +0000 Received: from localhost ([127.0.0.1]:60107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQl-0001xH-Se for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:19:32 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:37404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQk-0001x3-Ji for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:19:31 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BHIugc046639; Tue, 11 Jun 2019 17:19:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ESP7FaV3GfplC4iORY4QHFIAvmRClXPjEyU4sKW9wL0=; b=Xab6+DN/+zGEH4Gt6L8CsdR+Fk+AcvZO6ntck6vCYCGUY/VQ4yA0+ZmWcko88nMUP/aF 8813J8dZ5Dtot3FT9KPEDoE0lW1iuzByLxAEnXVuMh3ip81w9Oj3KHTlxZhgQEO5k01N gJDRIi9caRsIbfQ2txG9Y6EvDNqskP0TiMo+UO1bqnpFKwjvRa4ZLDAy++t4nQ5Cu1Tw XPioi+dKcbEbzpGrYokozDlCnfYdSSPU3GV3Qi4NNbOrYmpnqWpozP3JCGh/NsP3hLBb N0lfVaxfaVrMD2AAXSlGOo7q8IpMTTzIcvgBMHgh6lTqei/6Ez+R4ZDQS0DHDjrTykGq nw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 2t02heps3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 17:19:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BHIn7A076748; Tue, 11 Jun 2019 17:19:19 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2t1jphjkrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 17:19:19 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5BHJHjD029150; Tue, 11 Jun 2019 17:19:17 GMT MIME-Version: 1.0 Message-ID: <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> Date: Tue, 11 Jun 2019 10:19:17 -0700 (PDT) From: Drew Adams References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> In-Reply-To: <83zhmo834p.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=715 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110111 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=18 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=767 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110111 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > > [0-9A-Fa-f] still has one advantage: the reader, and the > > > writer, know exactly which characters are included without looking it= up. > For > > > example: > > > > > > - whether upper case, lower case, or both are accepted > > > - whether non-ascii digits are accepted (included in [:digit:] on man= y > > > platforms) > > > > +1. At least the doc for [:digit:] should say exactly > > what it matches. Then it'll be clear for readers and > > writers. >=20 > Isn't it clear already? I meant [:xdigit:], not [:digit:], in my reply. Sorry for the typo. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: mattiase@acm.org, 36167@debbugs.gnu.org, drew.adams@oracle.com, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602744158832 (code B ref 36167); Tue, 11 Jun 2019 17:34:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:33:35 +0000 Received: from localhost ([127.0.0.1]:60120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakeN-0002IO-5l for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:33:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakeK-0002I8-PW for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:33:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hakeA-00041y-2T; Tue, 11 Jun 2019 13:33:22 -0400 Received: from [176.228.60.248] (port=2515 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hakdz-00025D-Ok; Tue, 11 Jun 2019 13:33:20 -0400 Date: Tue, 11 Jun 2019 20:32:38 +0300 Message-Id: <83y32881u1.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <12942077-ba92-0959-bc02-ba7ad1897b12@cs.ucla.edu> (message from Paul Eggert on Tue, 11 Jun 2019 10:18:44 -0700) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <12942077-ba92-0959-bc02-ba7ad1897b12@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: mattiase@acm.org, 36167@debbugs.gnu.org, hi-angel@yandex.ru > From: Paul Eggert > Date: Tue, 11 Jun 2019 10:18:44 -0700 > > On 6/11/19 10:04 AM, Eli Zaretskii wrote: > > Where did the question about non-ASCII > > digits come from, given this text? > > It came from POSIX, where [:xdigit:] and [:digit:] might match other > characters. Yes, but when using Emacs and coding for Emacs, one must read the Emacs documentation, which clearly says what these do in Emacs. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602744978954 (code B ref 36167); Tue, 11 Jun 2019 17:35:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:34:57 +0000 Received: from localhost ([127.0.0.1]:60124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakfg-0002KL-Ia for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:34:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakfe-0002K9-Lc for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:34:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hakfY-0004x7-5E; Tue, 11 Jun 2019 13:34:49 -0400 Received: from [176.228.60.248] (port=2643 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hakfV-0002sh-1B; Tue, 11 Jun 2019 13:34:46 -0400 Date: Tue, 11 Jun 2019 20:34:44 +0300 Message-Id: <83wohs81qj.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> (message from Drew Adams on Tue, 11 Jun 2019 10:19:17 -0700 (PDT)) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 11 Jun 2019 10:19:17 -0700 (PDT) > From: Drew Adams > Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, > hi-angel@yandex.ru > > > Isn't it clear already? > > I meant [:xdigit:], not [:digit:], in my reply. Sorry for > the typo. :xdigit: is also clearly documented: ‘[:xdigit:]’ This matches the hexadecimal digits: ‘0’ through ‘9’, ‘a’ through ‘f’ and ‘A’ through ‘F’. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: npostavs@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, Drew Adams , hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156027545810472 (code B ref 36167); Tue, 11 Jun 2019 17:51:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:50:58 +0000 Received: from localhost ([127.0.0.1]:60150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakvC-0002iq-8r for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:50:58 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:37862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakvA-0002id-4v for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:50:56 -0400 Received: by mail-io1-f50.google.com with SMTP id e5so10653402iok.4 for <36167@debbugs.gnu.org>; Tue, 11 Jun 2019 10:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hdSECgdfh6U1KP8fcrv7Kx/KK6B7W1Dc+5P2OIs3sVI=; b=EaKrAWcWzmihzG7ZcFndDvSOs4Ju/XBJffZUtSAZQ5+3zA8pd6OQv8ISU/r5AKwe+l ZfTyYgucuiHBauFYmLb2JdmPJLw/mYh5VyWMOwo8dEfa/89KF1LyJFs+hsI92GWsIVjS r38M1nacTAsyLG68gRaDW2+LnKaFN4KtKqrwDh4aTpgOieyqLri6WlOXocJeLTdCTzbm Qsj48bL9RalLbYjQboYckV56p+rpvh1daBgl2t7ezk49yQWA3U2KZoo77ASXnyH73i7w RdxfN+Ls7CSg82iicTESMhexpgNi42WYjagI5bBzL5erfEJE4ZF1JPd2CivCx7/LrRMl wkQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hdSECgdfh6U1KP8fcrv7Kx/KK6B7W1Dc+5P2OIs3sVI=; b=eHaQw137FwbBsi5wYEiNggZIynzG+CkeQkiriYCl5HB0dt0fSN8V2iWPiIlkFGvh4F S5wFaMOaJkIbf8iLEOf1tt4R1KQm1TG/hoSwGMNMtE1WhMZ6qgbMJq6YTEPeU1sb1S1G zCIa6Jlx5S+EU972T7SRlF6+sefzIrLfPXFiR4kTqKPBDoS40/2g/NB2tY021QB85st8 dhG/rz4fzihDhhwkfS56ieloyRzznRuv37XaNq+Lzg3qOC9oGPf6WhxllS33mIIS7Ub+ Qg1SgVcRsnv8eh1dIX1MLgH6GLsCDh0R1EgidqHs/AiVVNOPHr2qM0dZHziPw+hCfDue BQqA== X-Gm-Message-State: APjAAAVI/FEIeSbD0WlZ2ifjKhzI6S1c8YvVb0WbuUZk40HQfSiAZKCP DNSnFA/4unHufWPNjDrSKqY= X-Google-Smtp-Source: APXvYqzYrJTrmdFLM1oWHLCPtFlHEQOjd2F1cMCOlOfyq1zhwTFRqQXmKnRsribg2F4etpxxfAsgJg== X-Received: by 2002:a5e:8f42:: with SMTP id x2mr32011103iop.35.1560275450494; Tue, 11 Jun 2019 10:50:50 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id x22sm4780162ioh.87.2019.06.11.10.50.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 10:50:49 -0700 (PDT) From: npostavs@gmail.com References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> Date: Tue, 11 Jun 2019 13:50:49 -0400 In-Reply-To: <83zhmo834p.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2019 20:04:38 +0300") Message-ID: <85zhmo9fk6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> > [0-9A-Fa-f] still has one advantage: the reader, and the >> > writer, know exactly which characters are included without looking it = up. ^^^^^^^^^^^^^^^^^^^= ^^ >> > - whether non-ascii digits are accepted > =A1=AE[:digit:]=A1=AF > This matches =A1=AE0=A1=AF through =A1=AE9=A1=AF. Thus, =A1=AE[-+[= :digit:]]=A1=AF matches any > digit, as well as =A1=AE+=A1=AF and =A1=AE-=A1=AF. > Is anything missing here? Where did the question about non-ASCII > digits come from, given this text? It came from (a hypothetical) user who doesn't remember (or hasn't read) the documentation. The advantage of [0-9A-Fa-f] vs [[:xdigit:]] here is similar to explicit comparison against (point-min) vs (bobp) that you pointed out in #35967. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@gmail.com Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, drew.adams@oracle.com, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156027566510787 (code B ref 36167); Tue, 11 Jun 2019 17:55:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:54:25 +0000 Received: from localhost ([127.0.0.1]:60154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakyW-0002nv-Rk for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:54:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakyR-0002nd-K8 for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:54:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hakyJ-0007xB-7l; Tue, 11 Jun 2019 13:54:13 -0400 Received: from [176.228.60.248] (port=3808 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hakyB-0003lB-C3; Tue, 11 Jun 2019 13:54:07 -0400 Date: Tue, 11 Jun 2019 20:53:44 +0300 Message-Id: <83v9xc80uv.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <85zhmo9fk6.fsf@gmail.com> (npostavs@gmail.com) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <85zhmo9fk6.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: npostavs@gmail.com > Cc: Drew Adams , mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, hi-angel@yandex.ru > Date: Tue, 11 Jun 2019 13:50:49 -0400 > > The advantage of [0-9A-Fa-f] vs [[:xdigit:]] here is similar to > explicit comparison against (point-min) vs (bobp) that you pointed > out in #35967. I'm not against the replacement, I responded to the request to have a clear documentation of these character classes. Which we do have, so I was puzzled why people pretend we don't. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu Cc: 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156027694412951 (code B ref 36167); Tue, 11 Jun 2019 18:16:02 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 18:15:44 +0000 Received: from localhost ([127.0.0.1]:60166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1halJA-0003Mp-2U for submit@debbugs.gnu.org; Tue, 11 Jun 2019 14:15:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1halJ8-0003Mc-SO for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 14:15:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1halIz-0006qQ-PP; Tue, 11 Jun 2019 14:15:34 -0400 Received: from [176.228.60.248] (port=1116 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1halIc-0005cB-SW; Tue, 11 Jun 2019 14:15:28 -0400 Date: Tue, 11 Jun 2019 21:14:49 +0300 Message-Id: <83tvcw7zvq.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83v9xc80uv.fsf@gnu.org> (message from Eli Zaretskii on Tue, 11 Jun 2019 20:53:44 +0300) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <85zhmo9fk6.fsf@gmail.com> <83v9xc80uv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eli Zaretskii > Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, > hi-angel@yandex.ru > > I'm not against the replacement, I responded to the request to have a > clear documentation of these character classes. Specifically, this: > > [0-9A-Fa-f] still has one advantage: the reader, and the > > writer, know exactly which characters are included without looking it up. For > > example: > > > > - whether upper case, lower case, or both are accepted > > - whether non-ascii digits are accepted (included in [:digit:] on many > > platforms) > > +1. At least the doc for [:digit:] should say exactly > what it matches. Then it'll be clear for readers and > writers. The last part says "the doc should say" as if the doc doesn't already say. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , npostavs@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu Cc: 36167@debbugs.gnu.org, hi-angel@yandex.ru Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156027972417322 (code B ref 36167); Tue, 11 Jun 2019 19:03:01 +0000 Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 19:02:04 +0000 Received: from localhost ([127.0.0.1]:60198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ham20-0004VK-81 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 15:02:04 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:55144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ham1w-0004Un-Pv for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 15:02:02 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BIxUsL135336; Tue, 11 Jun 2019 19:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=tKrd9zSuYPRKvm+F0rmqveCfVwJewEYBn8nALIYmWZk=; b=RsLznRjBftnG9NVp9D+aoakU4qNTUuCk3uY82zZdqrjaEte+B+sKyLhiwQpjz7Zgz9ib XikvZ0i/5Hy7P7gS+y2BKxtl+IG4y4H0M7i3LiYLxnjTy1uOQ7BWq0C4mfypyI9I3I5g WTmEHpsGFsDmDsbEvMgrNjJdfy+F2iQQ8QJYVOnCf0Gp41BCtngs+pOWEEHE1XFArteS aUQjV4PEAZ7csIPH6IQLMxYKe8jalFron/qZP9Vq7HlEShULC41uiIolqgJ2iS7r81tj aXqN73FjQhkMyzBdL/a3/+wFxKumxdjVu0R3uAGBI/PumGobT5JCim06iOibksyq0L0n MA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2t02heqa9m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 19:01:51 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BJ1IgT050295; Tue, 11 Jun 2019 19:01:50 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2t024ujrud-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 19:01:50 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5BJ1jb8012572; Tue, 11 Jun 2019 19:01:46 GMT MIME-Version: 1.0 Message-ID: <777723d3-2452-4d43-9222-4df06dd8f6a4@default> Date: Tue, 11 Jun 2019 12:01:45 -0700 (PDT) From: Drew Adams References: <> <<1560263874.21373.1@yandex.ru>> <<5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu>> <<85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org>> <> <<83zhmo834p.fsf@gnu.org>> <<85zhmo9fk6.fsf@gmail.com>> <<83v9xc80uv.fsf@gnu.org>> <<83tvcw7zvq.fsf@gnu.org>> In-Reply-To: <<83tvcw7zvq.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=588 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=18 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=654 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110121 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > +1. At least the doc for [:digit:] should say exactly > > what it matches. Then it'll be clear for readers and > > writers. >=20 > The last part says "the doc should say" as if the doc doesn't already > say. Yes, my bad. Forgot that it exists, and misread the proposal as including its creation. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 19:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156028299522155 (code B ref -1); Tue, 11 Jun 2019 19:57:03 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2019 19:56:35 +0000 Received: from localhost ([127.0.0.1]:60227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hamsl-0005lH-Hd for submit@debbugs.gnu.org; Tue, 11 Jun 2019 15:56:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:46689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hamsi-0005l8-JI for submit@debbugs.gnu.org; Tue, 11 Jun 2019 15:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40507) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hamsg-0007n3-4l for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 15:56:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FREEMAIL_REPLY,RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hamsf-0007mL-3l for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 15:56:30 -0400 Received: from [195.159.176.226] (port=33018 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hamsd-0007iF-NW for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 15:56:28 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hamsT-0007Rj-V2 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 21:56:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Andy Moreton Date: Tue, 11 Jun 2019 20:56:09 +0100 Message-ID: References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> <83wohs81qj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:ZsZQ2HCBSOYsjjOlxJmsintCYZw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On Tue 11 Jun 2019, Eli Zaretskii wrote: >> Date: Tue, 11 Jun 2019 10:19:17 -0700 (PDT) >> From: Drew Adams >> Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, >> hi-angel@yandex.ru >> >> > Isn't it clear already? >> >> I meant [:xdigit:], not [:digit:], in my reply. Sorry for >> the typo. > > :xdigit: is also clearly documented: > > ‘[:xdigit:]’ > This matches the hexadecimal digits: ‘0’ through ‘9’, ‘a’ through > ‘f’ and ‘A’ through ‘F’. The docs for [:digit:] and [:xdigit:] seem clear enough, but there is one other minor point that could be clarified. The [:alnum:] and [:alpha:] are based on (unspecified values of) the Unicode general-category property, but [:digit:] is not. Thus [:alnum:] includes other numeric characters that are not matched by [:digit:]. AndyM From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 00:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156029958123259 (code B ref 36167); Wed, 12 Jun 2019 00:33:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 00:33:01 +0000 Received: from localhost ([127.0.0.1]:60390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1harCH-000635-1M for submit@debbugs.gnu.org; Tue, 11 Jun 2019 20:33:01 -0400 Received: from forward100o.mail.yandex.net ([37.140.190.180]:42204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1harCB-00062l-B2 for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 20:32:59 -0400 Received: from mxback7g.mail.yandex.net (mxback7g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:168]) by forward100o.mail.yandex.net (Yandex) with ESMTP id C251F4AC00D7; Wed, 12 Jun 2019 03:32:41 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback7g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id gCGLlox7jC-WfQWOY50; Wed, 12 Jun 2019 03:32:41 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560299561; bh=1nMa78q1O8qTMkziMmyXt6yuAxiuV2bvL+4rhHz4/V8=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=HyROP1RvCrX3OgSTIBmR4nnCopIgq6x9TT3nLdV6/0s6DMVWMhk0x0NYbHHzsG8+/ aLvdm4KBGPQerWBkELGrEoXS5bVrxP/gJftmlsCuAsibD/JVn0Y6u9Go4I2tu9ZN7I HbUzWZsnkHgFYHZ32WvFoUGgdK1wUa5Ft58+cQQs= Authentication-Results: mxback7g.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id bYmuoZpzkQ-WfE0k5AV; Wed, 12 Jun 2019 03:32:41 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Wed, 12 Jun 2019 03:29:29 +0300 From: Konstantin Kharlamov Message-Id: <1560299369.31875.0@yandex.ru> In-Reply-To: References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =D0=92 =D0=92=D1=82, =D0=B8=D1=8E=D0=BD 11, 2019 at 15:30, Robert Pluim =20 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: >>>>>> On Tue, 11 Jun 2019 16:17:10 +0300, Konstantin Kharlamov=20 >>>>>> said: >=20 > Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace > Konstantin> [0-9a-fA-F] with [[:xdigit:]] > >> > >> This is the org schema file for OpenDocument export, not emacs > >> lisp. Does that support :xdigit: syntax? >=20 > Konstantin> Oh, okay, thanks, I couldn't figure out what it is=20 > because Wikipedia > Konstantin> says that .rnc is just a variation of XML, and README=20 > just says it's > Konstantin> something to map some xml schemas to documents. So I=20 > deemed these > Konstantin> regexps are too used by ELisp. >=20 > Konstantin> Can I test it somehow? Either way, not a big deal, I=20 > can just drop > Konstantin> that one. >=20 > If I remember correctly, the schema is copied into the resulting > OpenDocument file, so it=CA=BCs probably safest not to touch it. >=20 > Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with > Konstantin> [[:xdigit:]] > >> > >> Normally, you'd mention the containing function in the=20 > ChangeLog > >> entry. Using 'C-x 4 a' (ie=20 > 'add-change-log-entry-other-window') with > >> point on the code you=CA=BCre changing does that for you. >=20 > Konstantin> Ah, thanks. At this point I'll probably ask on=20 > emacs-devel about > Konstantin> adding to prepare-commit-msg a code to pre-format the=20 > changes, because > Konstantin> clearly that's a lot of manual work for something=20 > that should be > Konstantin> automated. >=20 > It=CA=BCs pretty automated: >=20 > - Do M-x vc-dir in your emacs repository to see which files are=20 > changed > - Do C-x 4 a to prepare the ChangeLog entries > - Mark the files you want you commit > - Commit from the vc-dir buffer. This will copy the earlier ChangeLog > entries into the commit message buffer Okay, so, after I do the first 2 points, I end up in a buffer with the=20 following content > 2019-06-12 > > * (Stash): I am not sure what to do next, because I guess this buffer supposed to=20 have changed function names? I also tried first marking files in vc-dir=20 with "m" key, and then doing the 2nd point, to no avail. > Unless you meant completely automatically generating the ChangeLog > entries, which is a wholly different can of worms. Yeah. It would be very useful, because had you not write that this=20 could be automated, I'd never guessed. And even now that you wrote=20 about it, I still don't understand how to make it work. I guess I'm not=20 an unique contributor in such position. But I think possibility of such change may be better to discuss in a=20 separate thread. = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andy Moreton Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15603066191786 (code B ref 36167); Wed, 12 Jun 2019 02:31:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 02:30:19 +0000 Received: from localhost ([127.0.0.1]:60457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hat1n-0000Sj-0t for submit@debbugs.gnu.org; Tue, 11 Jun 2019 22:30:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hat1k-0000SQ-IS for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 22:30:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hat1f-00042T-EE; Tue, 11 Jun 2019 22:30:11 -0400 Received: from [176.228.60.248] (port=3416 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hat1e-0006na-GB; Tue, 11 Jun 2019 22:30:11 -0400 Date: Wed, 12 Jun 2019 05:30:08 +0300 Message-Id: <83pnnj8rin.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Andy Moreton on Tue, 11 Jun 2019 20:56:09 +0100) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> <83wohs81qj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andy Moreton > Date: Tue, 11 Jun 2019 20:56:09 +0100 > > The docs for [:digit:] and [:xdigit:] seem clear enough, but there is > one other minor point that could be clarified. > > The [:alnum:] and [:alpha:] are based on (unspecified values of) the Unicode > general-category property, but [:digit:] is not. Thus [:alnum:] includes > other numeric characters that are not matched by [:digit:]. It's true that [:alnum:] includes more numerical characters that [:digit:], but what exactly needs to be clarified here? Assuming you mean clarified in the manual, that is. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15603073392986 (code B ref 36167); Wed, 12 Jun 2019 02:43:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 02:42:19 +0000 Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hatDP-0000m5-B9 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 22:42:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hatDL-0000lp-NR for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 22:42:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hatDE-0001ck-KX; Tue, 11 Jun 2019 22:42:09 -0400 Received: from [176.228.60.248] (port=4144 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hatDC-0001OV-Vo; Tue, 11 Jun 2019 22:42:07 -0400 Date: Wed, 12 Jun 2019 05:42:04 +0300 Message-Id: <83muin8qyr.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1560299369.31875.0@yandex.ru> (message from Konstantin Kharlamov on Wed, 12 Jun 2019 03:29:29 +0300) References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2019 03:29:29 +0300 > From: Konstantin Kharlamov > Cc: 36167@debbugs.gnu.org > > > Unless you meant completely automatically generating the ChangeLog > > entries, which is a wholly different can of worms. > > Yeah. It would be very useful, because had you not write that this > could be automated, I'd never guessed. It's in CONTRIBUTE, btw. > And even now that you wrote about it, I still don't understand how > to make it work. I guess I'm not an unique contributor in such > position. If you have never used "C-x 4 a", you should indeed learn how to use it efficiently. > But I think possibility of such change may be better to discuss in a > separate thread. I very much doubt that log-message creation could be automated. For starters, there's a human decision how to group the entries and what to write as the description of the changes themselves. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15603277147407 (code B ref 36167); Wed, 12 Jun 2019 08:22:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 08:21:54 +0000 Received: from localhost ([127.0.0.1]:60629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hayW1-0001vO-Gu for submit@debbugs.gnu.org; Wed, 12 Jun 2019 04:21:53 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:37233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hayVz-0001vA-0C for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 04:21:52 -0400 Received: by mail-ed1-f49.google.com with SMTP id w13so24399264eds.4 for <36167@debbugs.gnu.org>; Wed, 12 Jun 2019 01:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=it+C1fETvDI9eXgh7CfHSqOgARfv7+qvNwrLwQn95sk=; b=RlYj81v7rxgc7GmEhSfCDLshLi9/aHoigYfgI8wPpq7DwWX/zgwD4ZOiMcu193w7gV 8Z9Sm07xC84Xu8kUdeaqfZ9lmoQ44ZSWCEeXOyO4TPNgi/NTXhQMd9NeNUrQ0eVVmkYd ahzy/cJ45icFixmSjKNxOU2bdeFE361zBQ+7/f7wO5UIaBX74POrebHuE5D/x5JXUqlD SGgNfnihMnJh7SqGxECoMvr1XwEm4P0RSngxEYwM8SuKqd+n20veiz9IdVYDH/XUTtB6 PJxs0B9YW69HmezQMY9bTUaJSuFZmaS+AVzGUXSz/bfA53ESrcYCLDb7KzBEliBx28SH mWSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=it+C1fETvDI9eXgh7CfHSqOgARfv7+qvNwrLwQn95sk=; b=oc1DNro40zO3yKPYA8BjYXhoMBISukIK5DlubyWKD2DGlrBr5D9C4YDru7DTBi8p8Q 9Nu7RACn6//z1xqb4h9YFVxDlxWGeHPTw92kvuYbE2lkJReNV9hdka1TM+mE+W7HpxSZ jTlHfb2VIkRpskQxZPPErF5E5bmTiTHLlpusIxcOb6LXTspCPwiHTxL3CM52jSDU0sN1 GQo8UKtHTTKLWNTExHQ/c0N4gxNIoY/+ITCk2yrciFwH/+UakT8n4PSuzYku8s8+bGZS 5soMvs5f4/lOwWWQ8YSqHdsUlKO6eWJQIlAG9tKcDgmBU/+J/WnBwM98Lc0DM78LyHke 77Vw== X-Gm-Message-State: APjAAAXl0p9KVPmw46Y/5uuB7WaGRlJDGCTY3SuKpipxd7CYuNoaaDVR 6IXw3d9yx8WLnEcQklVqyVtKBE1HudY= X-Google-Smtp-Source: APXvYqxOhYMD17bT7WqUCBzvIoXdi4HKlsETUyg74I/AMvM9kOMOBsyLZdMwtg1LWSbRcPxbm1UEVA== X-Received: by 2002:a50:fb0a:: with SMTP id d10mr5698672edq.124.1560327703971; Wed, 12 Jun 2019 01:21:43 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id o31sm4438353edb.66.2019.06.12.01.21.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 12 Jun 2019 01:21:42 -0700 (PDT) From: Robert Pluim References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 12 Jun 2019 10:21:41 +0200 In-Reply-To: <1560299369.31875.0@yandex.ru> (Konstantin Kharlamov's message of "Wed, 12 Jun 2019 03:29:29 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 12 Jun 2019 03:29:29 +0300, Konstantin Kharlamov said: >> - Do M-x vc-dir in your emacs repository to see which files are >> changed >> - Do C-x 4 a to prepare the ChangeLog entries >> - Mark the files you want you commit >> - Commit from the vc-dir buffer. This will copy the earlier ChangeLog >> entries into the commit message buffer Konstantin> Okay, so, after I do the first 2 points, I end up in a buffer with the Konstantin> following content >> 2019-06-12 >> >> * (Stash): Konstantin> I am not sure what to do next, because I guess this buffer supposed to Konstantin> have changed function names? I also tried first marking files in Konstantin> vc-dir with "m" key, and then doing the 2nd point, to no avail. Sorry, I forgot a step: you have to visit the file you changed, and make sure point is near where you made changes (C-x v = will show you a *vc-diff* buffer containing the changes), and then do C-x 4 a (possibly multiple times if you changed multiple things). Robert From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156033835630947 (code B ref 36167); Wed, 12 Jun 2019 11:20:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 11:19:16 +0000 Received: from localhost ([127.0.0.1]:60790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb1Hf-000834-Td for submit@debbugs.gnu.org; Wed, 12 Jun 2019 07:19:16 -0400 Received: from forward104j.mail.yandex.net ([5.45.198.247]:38536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb1Hd-00082g-DN for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 07:19:15 -0400 Received: from mxback1j.mail.yandex.net (mxback1j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10a]) by forward104j.mail.yandex.net (Yandex) with ESMTP id E7D724A1840; Wed, 12 Jun 2019 14:19:05 +0300 (MSK) Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [2a02:6b8:0:1a2d::25]) by mxback1j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id JUiEyMY0D7-J53mXKQf; Wed, 12 Jun 2019 14:19:05 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560338345; bh=+RigkXvL/a0rywWiVSzqHzVjafqIq8sNp/C9cqbizDE=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=vLTyP1930ebQ/DZ0BHMBNbvJKgNiAN7ysUjAv/Yvf5Ij3xgpCGeZZoLED0Sz0Pxht QZvhM4BkgHqO6F9gP/ofkVVSYpfFYG2B6yrW0WF8F7rLiD2x5Rq4u7FFYeR5q2HWff iGp7eZQqocjlOXd6j2QF6z581poO4tSHJTsN9kCc= Authentication-Results: mxback1j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ZGvK6Abjc3-J5r80rk3; Wed, 12 Jun 2019 14:19:05 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Wed, 12 Jun 2019 14:19:04 +0300 From: Konstantin Kharlamov Message-Id: <1560338344.12980.0@yandex.ru> In-Reply-To: References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =F7 =F3=D2, =C9=C0=CE 12, 2019 at 10:21, Robert Pluim =20 =CE=C1=D0=C9=D3=C1=CC: >>>>>> On Wed, 12 Jun 2019 03:29:29 +0300, Konstantin Kharlamov=20 >>>>>> said: > >> - Do M-x vc-dir in your emacs repository to see which files are > >> changed > >> - Do C-x 4 a to prepare the ChangeLog entries > >> - Mark the files you want you commit > >> - Commit from the vc-dir buffer. This will copy the earlier=20 > ChangeLog > >> entries into the commit message buffer >=20 > Konstantin> Okay, so, after I do the first 2 points, I end up in=20 > a buffer with the > Konstantin> following content >=20 > >> 2019-06-12 > >> > >> * (Stash): >=20 > Konstantin> I am not sure what to do next, because I guess this=20 > buffer supposed to > Konstantin> have changed function names? I also tried first=20 > marking files in > Konstantin> vc-dir with "m" key, and then doing the 2nd point, to=20 > no avail. >=20 > Sorry, I forgot a step: you have to visit the file you changed, and > make sure point is near where you made changes (C-x v =3D will show you > a *vc-diff* buffer containing the changes), and then do C-x 4 a > (possibly multiple times if you changed multiple things). Oh, that doesn't sound automated, it's a lot of work. I had 28 files in=20 the outdated patch, and there will be more, as noted Paul. And in the=20 other patch, which I did not send as it turned out to be obsolete=20 (which was replacing [0-9] with [[:digit:]]) I had around 4xx changed=20 files. No way one could manually go through 400 files, stop by each=20 change, and press a hotkey. = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156033986910018 (code B ref -1); Wed, 12 Jun 2019 11:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jun 2019 11:44:29 +0000 Received: from localhost ([127.0.0.1]:60805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb1g5-0002bV-2P for submit@debbugs.gnu.org; Wed, 12 Jun 2019 07:44:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:40955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb1g3-0002bN-1u for submit@debbugs.gnu.org; Wed, 12 Jun 2019 07:44:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42258) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb1g1-0002Ef-Ek for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 07:44:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb1fz-0001h9-74 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 07:44:25 -0400 Received: from [195.159.176.226] (port=52208 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hb1fy-0001gQ-Uy for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 07:44:23 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hb1ft-000ARx-HQ for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 13:44:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Andy Moreton Date: Wed, 12 Jun 2019 12:44:12 +0100 Message-ID: References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> <83wohs81qj.fsf@gnu.org> <83pnnj8rin.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:4O8t2hSMwqhcPyBEOoxOsx2bNLc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On Wed 12 Jun 2019, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Tue, 11 Jun 2019 20:56:09 +0100 >> >> The docs for [:digit:] and [:xdigit:] seem clear enough, but there is >> one other minor point that could be clarified. >> >> The [:alnum:] and [:alpha:] are based on (unspecified values of) the Unicode >> general-category property, but [:digit:] is not. Thus [:alnum:] includes >> other numeric characters that are not matched by [:digit:]. > > It's true that [:alnum:] includes more numerical characters that > [:digit:], but what exactly needs to be clarified here? Assuming you > mean clarified in the manual, that is. As noted by Paul Eggert, the POSIX behaviour is different. It may be worth a note in the manual to draw attention to this difference. AndyM From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035135914486 (code B ref 36167); Wed, 12 Jun 2019 14:56:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 14:55:59 +0000 Received: from localhost ([127.0.0.1]:33818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4fM-0003lY-QU for submit@debbugs.gnu.org; Wed, 12 Jun 2019 10:55:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb4fK-0003lI-HA for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 10:55:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hb4fF-0007QU-2e; Wed, 12 Jun 2019 10:55:49 -0400 Received: from [176.228.60.248] (port=4935 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hb4fD-0006kX-B3; Wed, 12 Jun 2019 10:55:48 -0400 Date: Wed, 12 Jun 2019 17:55:45 +0300 Message-Id: <83lfy697ke.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1560338344.12980.0@yandex.ru> (message from Konstantin Kharlamov on Wed, 12 Jun 2019 14:19:04 +0300) References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560338344.12980.0@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2019 14:19:04 +0300 > From: Konstantin Kharlamov > Cc: 36167@debbugs.gnu.org > > > Sorry, I forgot a step: you have to visit the file you changed, and > > make sure point is near where you made changes (C-x v = will show you > > a *vc-diff* buffer containing the changes), and then do C-x 4 a > > (possibly multiple times if you changed multiple things). > > Oh, that doesn't sound automated, it's a lot of work. I had 28 files in > the outdated patch, and there will be more, as noted Paul. The idea is to type "C-x 4 a" right after making each change, or set up a keyboard macro that does this for you. > And in the other patch, which I did not send as it turned out to be > obsolete (which was replacing [0-9] with [[:digit:]]) I had around > 4xx changed files. No way one could manually go through 400 files, > stop by each change, and press a hotkey. When you change 400 files, no one will expect you to mention each instance, it's enough to describe the change itself and say "in all files" or somesuch. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andy Moreton Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035566114259 (code B ref 36167); Wed, 12 Jun 2019 16:08:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 16:07:41 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5mn-0003hv-Hv for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:07:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5mk-0003he-AI for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 12:07:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hb5me-0002xD-LS; Wed, 12 Jun 2019 12:07:32 -0400 Received: from [176.228.60.248] (port=1460 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hb5md-0002zj-RX; Wed, 12 Jun 2019 12:07:32 -0400 Date: Wed, 12 Jun 2019 19:07:29 +0300 Message-Id: <83ftoe948u.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Andy Moreton on Wed, 12 Jun 2019 12:44:12 +0100) References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> <83wohs81qj.fsf@gnu.org> <83pnnj8rin.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andy Moreton > Date: Wed, 12 Jun 2019 12:44:12 +0100 > > >> The [:alnum:] and [:alpha:] are based on (unspecified values of) the Unicode > >> general-category property, but [:digit:] is not. Thus [:alnum:] includes > >> other numeric characters that are not matched by [:digit:]. > > > > It's true that [:alnum:] includes more numerical characters that > > [:digit:], but what exactly needs to be clarified here? Assuming you > > mean clarified in the manual, that is. > > As noted by Paul Eggert, the POSIX behaviour is different. It may be > worth a note in the manual to draw attention to this difference. It's strange to say in the manual what we do NOT do. The current text says: ‘[:digit:]’ This matches ‘0’ through ‘9’. Thus, ‘[-+[:digit:]]’ matches any digit, as well as ‘+’ and ‘-’. I believe you suggest to add to this something like "Note that Posix interpretation of '[:digit:]' is different"? Given the crystal clarity of the current text, wouldn't such addition confuse the reader? Btw, where's the reference for a different interpretation by Posix? I cannot find anything to that effect; even the Unicode UTS18 (http://www.unicode.org/reports/tr18/) says, while describing the Posix equivalent of the Unicode regexp notations: "Non-decimal numbers (like Roman numerals) are normally excluded". What am I missing? From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035791918093 (code B ref 36167); Wed, 12 Jun 2019 16:46:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 16:45:19 +0000 Received: from localhost ([127.0.0.1]:33975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6ND-0004hl-69 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:45:19 -0400 Received: from forward101j.mail.yandex.net ([5.45.198.241]:38831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6N8-0004hL-Fy for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 12:45:16 -0400 Received: from mxback14o.mail.yandex.net (mxback14o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::65]) by forward101j.mail.yandex.net (Yandex) with ESMTP id 17E921BE0B6A; Wed, 12 Jun 2019 19:39:29 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback14o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 3XFjgTN5b6-dRc8hO8Q; Wed, 12 Jun 2019 19:39:29 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560357569; bh=697RyuLxlHTvv7wNmYW9dY/Q9YLwmywyS/a6clXYmwg=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=CIdfzf57okNMjPyRmKsznvJjTXma+KWpIRTsDMkMGrGZ1GkdgXapflJc/1SnBCjkU M5FxhcoepODNc1UM+mw6HfsbN66aP5M91oh9b0a1TYH9D1sR6xzNqaxVYroM/9hIjj 89/zkmRsQbUnt3b+COqMvxgCc0984OVyFb1Xs+wU= Authentication-Results: mxback14o.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id wjLFY94LE1-dRECmQr3; Wed, 12 Jun 2019 19:39:27 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Wed, 12 Jun 2019 19:39:26 +0300 From: Konstantin Kharlamov Message-Id: <1560357566.5452.0@yandex.ru> In-Reply-To: <83lfy697ke.fsf@gnu.org> References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =D0=92 =D0=A1=D1=80, =D0=B8=D1=8E=D0=BD 12, 2019 at 17:55, Eli Zaretskii =20 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: >> Date: Wed, 12 Jun 2019 14:19:04 +0300 >> From: Konstantin Kharlamov >> Cc: 36167@debbugs.gnu.org >>=20 >> > Sorry, I forgot a step: you have to visit the file you changed,=20 >> and >> > make sure point is near where you made changes (C-x v =3D will show=20 >> you >> > a *vc-diff* buffer containing the changes), and then do C-x 4 a >> > (possibly multiple times if you changed multiple things). >>=20 >> Oh, that doesn't sound automated, it's a lot of work. I had 28=20 >> files in >> the outdated patch, and there will be more, as noted Paul. >=20 > The idea is to type "C-x 4 a" right after making each change, or set > up a keyboard macro that does this for you. This indeed sounds somewhat easier, have I been making each xdigit=20 replacement manually. But I'm a fan of automation, this reduces a "human factor" and is=20 faster. So the original xdigit patch was a matter of a single command: sp "\[0-9a-fA-F\]" "[[:xdigit:]]" where "sp" is a "sed" replacement in perl=C2=B9. (okay, maybe then also to=20 review and "git checkout" irrelevant files, like changelogs) Having to do all 20 files manually would be a lot of work. >> And in the other patch, which I did not send as it turned out to be >> obsolete (which was replacing [0-9] with [[:digit:]]) I had around >> 4xx changed files. No way one could manually go through 400 files, >> stop by each change, and press a hotkey. >=20 > When you change 400 files, no one will expect you to mention each > instance, it's enough to describe the change itself and say "in all > files" or somesuch. Can I do that for 20 files? 1:=20 https://github.com/Hi-Angel/dotfiles/blob/33eab4cc99ad06dbfa71fa0cf9c2822e5= d824f24/.zshrc#L122 = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035829818730 (code B ref 36167); Wed, 12 Jun 2019 16:52:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 16:51:38 +0000 Received: from localhost ([127.0.0.1]:33984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6TJ-0004s2-P2 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:51:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6TH-0004rk-Vw for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 12:51:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hb6TC-0005UL-IB; Wed, 12 Jun 2019 12:51:30 -0400 Received: from [176.228.60.248] (port=4459 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hb6TB-0006DW-Sm; Wed, 12 Jun 2019 12:51:30 -0400 Date: Wed, 12 Jun 2019 19:51:29 +0300 Message-Id: <83blz2927i.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1560357566.5452.0@yandex.ru> (message from Konstantin Kharlamov on Wed, 12 Jun 2019 19:39:26 +0300) References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560357566.5452.0@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2019 19:39:26 +0300 > From: Konstantin Kharlamov > Cc: rpluim@gmail.com, 36167@debbugs.gnu.org > > > When you change 400 files, no one will expect you to mention each > > instance, it's enough to describe the change itself and say "in all > > files" or somesuch. > > Can I do that for 20 files? Borderline, IMO. Can't the command you use output the list of functions or at least files where it made the changes? Then you could massage that list into a log message. From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156035936320702 (code B ref 36167); Wed, 12 Jun 2019 17:10:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 17:09:23 +0000 Received: from localhost ([127.0.0.1]:33994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6kU-0005No-Ps for submit@debbugs.gnu.org; Wed, 12 Jun 2019 13:09:23 -0400 Received: from forward104o.mail.yandex.net ([37.140.190.179]:48300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6kQ-0005NS-Pi for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 13:09:20 -0400 Received: from mxback14j.mail.yandex.net (mxback14j.mail.yandex.net [IPv6:2a02:6b8:0:1619::90]) by forward104o.mail.yandex.net (Yandex) with ESMTP id A8F46941E55; Wed, 12 Jun 2019 20:09:11 +0300 (MSK) Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback14j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id byo7OH6Mr4-9BS4edZ7; Wed, 12 Jun 2019 20:09:11 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560359351; bh=V6ZmC9295D8yVAgChR58kUSoePQqgJLauSp4RIDNIdE=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=o0r7DMq+HtAR1CAc6alGOusblUtLQ8fBEVtpsuDyhKE3A12Pb0LdsangmYk+Xe2hT WKHfqSz8DZdPbMTAg4QMamVYoIx+AsJ8n2gA/AXOF28xnrrv6awZpAL6f/rkkYpYPM eYBo897rEjOz9o9L6If+eL3DyAyzDSMzkfszvojM= Authentication-Results: mxback14j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ODcOHT7af4-9AYemeGd; Wed, 12 Jun 2019 20:09:10 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Wed, 12 Jun 2019 20:09:09 +0300 From: Konstantin Kharlamov Message-Id: <1560359349.5452.1@yandex.ru> In-Reply-To: <83blz2927i.fsf@gnu.org> References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =F7 =F3=D2, =C9=C0=CE 12, 2019 at 19:51, Eli Zaretskii =20 =CE=C1=D0=C9=D3=C1=CC: >> Date: Wed, 12 Jun 2019 19:39:26 +0300 >> From: Konstantin Kharlamov >> Cc: rpluim@gmail.com, 36167@debbugs.gnu.org >>=20 >> > When you change 400 files, no one will expect you to mention each >> > instance, it's enough to describe the change itself and say "in=20 >> all >> > files" or somesuch. >>=20 >> Can I do that for 20 files? >=20 > Borderline, IMO. >=20 > Can't the command you use output the list of functions or at least > files where it made the changes? Then you could massage that list > into a log message. Getting the list of files is trivial, I can just copy them from a `git=20 diff --name-only` or some such. Getting the list of modified functions=20 in code is harder. Anyway, I'll try making some function later to apply recursively the=20 (add-change-log-entry-other-window), that sounds good to have in=20 general. = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: Eli Zaretskii , rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15603752049585 (code B ref 36167); Wed, 12 Jun 2019 21:34:01 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 21:33:24 +0000 Received: from localhost ([127.0.0.1]:34208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbAs0-0002UX-41 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 17:33:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbAry-0002UM-7S for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 17:33:22 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbArs-0001dz-RW; Wed, 12 Jun 2019 23:33:19 +0200 From: Lars Ingebrigtsen References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560359349.5452.1@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEUPEhtPTGpqZpEwM0QO DhISFR4ZHSgHAwKkoLaAfqMLCAjm6vmaT5VbAAACVElEQVQ4jV2TMYvbQBCFp7DSy4IjKbWdSiOi 2sU6xVaCeFWkOrC1vyAgUJdLihWuTpW3jkCwZSof/nN5syv7nMyBfXrfzHuzi0zX/+piUYMd6EE6 Xa/2fD5b55wdH4E9XZy17uyG8yAeACyCjx2cfXkA3G2vNqLxAQzO3gr6O3gbC4TCnq2cewdOBOBG Z8P3DVyKADCWR34Db0KMoxidGPNP/4AXkQoUgzXr94wxT9cAWCflj/tWF5Fu8FSIey3gj0jTdVE4 KHE0Jz5QiFhjrWJEQywGpxCBiZCQs5yVEVzyPC03awbQSy4awuWIYCHiF+sHiucMoeniArkyC8hj YhltSgOrcG9oj0pZGdYXAJuy0k1QjNH8ETKQWBmtdaMT1psG/xoAITLWE10T0Qdub2sQSmFj0KQp VsMEM8SrsVG9gCTR7GeoCsN0LwDN+RGwj6TVdsVEB0LBsqaEVlJu40SSYGeARrccICMgHmgRHgcY KC/vm7UNtbwSJfUKYCLzDDPeuKFlUc1z2zppw40gnfhkMJcKGdhB8kY1+hhI6VEz/jwo9t7Fi9D1 SgF0fQfgJ95utU2Ib7QGmFmW3CG5Ej6gMc8KYNrto6nnvAjMkTt37W6vOt/7CZYAfFutkrDQipt9 iMIllkd5KI97tZMyLBBqos8d9tm8Pu3UJH3X4SkS+oWHzUc7HNWk5q6f5j4ein7O3Xf86l+f9hKb zVHliR+d+u1GvIBHGc8IDENP+ZdsAzkrq+UQHNT1nrKvAPy+ltL3Nx2EskMV3kzTfvO98v0cgf8L /7W8ha02atoAAAAASUVORK5CYII= Date: Wed, 12 Jun 2019 23:33:16 +0200 In-Reply-To: <1560359349.5452.1@yandex.ru> (Konstantin Kharlamov's message of "Wed, 12 Jun 2019 20:09:09 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Konstantin Kharlamov writes: > Anyway, I'll try making some function later to apply recursively the > (add-change-log-entry-other-window), that sounds good to have in > general. If it helps, I've got this that emulates hitting `C-x 4 a' on all changes in a diff-mode (in probably the least efficient way possible) which is handy if you're doing a lot of semi-automatic changes t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Konstantin Kharlamov writes: > Anyway, I'll try making some function later to apply recursively the > (add-change-log-entry-other-window), that sounds good to have in > general. If it helps, I've got this that emulates hitting `C-x 4 a' on all changes in a diff-mode (in probably the least efficient way possible) which is handy if you're doing a lot of semi-automatic changes to many functions. (defun lars-gather-changelog () (interactive) (let* ((buf-file-name (funcall add-log-buffer-file-name-function)) (buffer-file (if buf-file-name (expand-file-name buf-file-name))) (change-buffer (add-log-find-changelog-buffer (expand-file-name (find-change-log nil buffer-file))))) (with-current-buffer change-buffer (erase-buffer)) (save-excursion (goto-char (point-min)) (while (re-search-forward "^[-+] " nil t) (save-window-excursion (diff-goto-source) (add-change-log-entry-other-window)))) (switch-to-buffer-other-window change-buffer))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 21:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: rpluim@gmail.com, 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156037560310263 (code B ref 36167); Wed, 12 Jun 2019 21:41:01 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 21:40:03 +0000 Received: from localhost ([127.0.0.1]:34216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbAyQ-0002fK-CX for submit@debbugs.gnu.org; Wed, 12 Jun 2019 17:40:03 -0400 Received: from quimby.gnus.org ([80.91.231.51]:60142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbAyO-0002ev-Ux for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 17:40:01 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbAyJ-0001in-PE; Wed, 12 Jun 2019 23:39:59 +0200 From: Lars Ingebrigtsen References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560359349.5452.1@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEX482f+/567kxfn2EL+ /53+/pODvXi6AAACfElEQVQ4jU1UQY6kMAw0HXInanIfgfZuxct90MA9Efj/X9mqMDNa1GrRqbhc Ltsth0tMeERa+vI8pOeZxWuIDS/2N6Vpl/QLNNf9s82XGQKH+T8gxuMao9nH1hmTtHdLkwsCsrpp 0U6T05Mli97prbaaymvkSbCB8Cm491qW1SRK54ICfp8QmRc8BnnSj5LyywG8CaiIhCdkyD3iSO+y gguA9Lvpa4OADOAiYMj+E5KGqWW5c1mM2YHc34ZUFnRPyzcAYX73UnqlHn6AoArTUksCY0ZxW9ay PEmMxZ9pAniJlLCWwggkv0jSspNqtGKFAQQQkXPueeQ2GAVhOBULpnnoAiJyFMNHO2AammeHhkli sHhW61T4yPB2GXqrg4VPUftAhNJij4xIeA3BqwpdtLBhAtyJ0FSVS7UDtopu1Zuj5+K4GEw0aKAD eI/7QSpn5qJQxHpWkNrIKQHCu0a1tGYNaltOO6gcNFREJobATa+RVBAMKPSA7uaeWwWAI1QHdFlK 737EpGYCAkcUDCGw+cpRBSC1xtdqC7I/eqWewzQA8FOuIisbKGDTiFGI6VPGObusQo9Z/II9uXNL FQHHWQs45JktwzjWNmPa/fBLtCyPNNkA3MytMFOrsusrZ258lsBZuWtYIdnghsAnjML7BhUqQa8F tX04nUXmt2KoY634jSa8Vvcr3hydWNNBJiygObpYycvdbjtHFEfgj4frFmt8BjdHAFf0UuzPsdPq oz3rhgj6C0FjPiGjTX11a+yt9fZS7NI8y82rTJ4yxfquslUs6c//CIY9zwQOtCO1WtP3dWZHzyEd k7EfeXwEPX8lSdAA7M62T5EUPHqQf/zSl4jGU6oxAAAAAElFTkSuQmCC Date: Wed, 12 Jun 2019 23:39:55 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 12 Jun 2019 23:33:16 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > (while (re-search-forward "^[-+] " nil t) Should be Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > (while (re-search-forward "^[-+] " nil t) Should be (while (re-search-forward "^[-+][ \t]" nil t) I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: rpluim@gmail.com, 36167@debbugs.gnu.org, Konstantin Kharlamov Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156037786714031 (code B ref 36167); Wed, 12 Jun 2019 22:18:01 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 22:17:47 +0000 Received: from localhost ([127.0.0.1]:34244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbBYw-0003eF-Tv for submit@debbugs.gnu.org; Wed, 12 Jun 2019 18:17:47 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:40864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbBYt-0003e3-L1 for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 18:17:44 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 45PLpZ2BZzz1rXtr; Thu, 13 Jun 2019 00:17:41 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 45PLpY68Gnz1qqkv; Thu, 13 Jun 2019 00:17:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ipde832BkC1d; Thu, 13 Jun 2019 00:17:39 +0200 (CEST) X-Auth-Info: IfS0mi0eOQ6ZB7M3EChjGqI/aYhTnZLbBQndbHfrWyDflgei8kHfhJH66vEsdn4Z Received: from igel.home (ppp-46-244-186-219.dynamic.mnet-online.de [46.244.186.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 13 Jun 2019 00:17:39 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 0FF0D2C10C3; Thu, 13 Jun 2019 00:17:20 +0200 (CEST) From: Andreas Schwab References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560359349.5452.1@yandex.ru> X-Yow: How do you explain Wayne Newton's POWER over millions? It's th' MOUSTACHE... Have you ever noticed th' way it radiates SINCERITY, HONESTY & WARMTH? It's a MOUSTACHE you want to take HOME and introduce to NANCY SINATRA! Date: Thu, 13 Jun 2019 00:17:20 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 12 Jun 2019 23:33:16 +0200") Message-ID: <87r27ybg9b.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jun 12 2019, Lars Ingebrigtsen wrote: > Konstantin Kharlamov writes: > >> Anyway, I'll try making some function later to apply recursively the >> (add-change-log-entry-other-window), that sounds good to have in >> general. > > If it helps, I've got this that emulates hitting `C-x 4 a' on all > changes in a diff-mode Isn't that what C-x 4 A (diff-add-change-log-entries-other-window) does? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: rpluim@gmail.com, 36167@debbugs.gnu.org, Konstantin Kharlamov Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156037814914516 (code B ref 36167); Wed, 12 Jun 2019 22:23:02 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 22:22:29 +0000 Received: from localhost ([127.0.0.1]:34248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbBdV-0003m4-HZ for submit@debbugs.gnu.org; Wed, 12 Jun 2019 18:22:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:60582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbBdT-0003lt-M4 for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 18:22:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbBdP-0001z5-BO; Thu, 13 Jun 2019 00:22:25 +0200 From: Lars Ingebrigtsen References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560359349.5452.1@yandex.ru> <87r27ybg9b.fsf@igel.home> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUZEA4lFxFtVjkQCAcO BgUTCwneuvf6AAACWElEQVQ4jU1UQZIbIQwUzs4d4fhupip3ewX33YDvYKz/fyUtGG+FcrkGtdTd gtFQLVltCVZNj5FqSSnVSmWIDM1DitSaBx6wJpDENlokS9JXUnkhJwlZRhYVS85DJ2HBlkQHBD7j vu9B4x7in2SpSmOWdLoQdSXadBPNWQdllJmrYTsZorpcksHHypNDx5hAhvJa8ABrKDgA/VkjyWrV YjTavl9hKX7jj3d7YoZb0ice8fswYF/ARXSbwAm71zefDiD+zt6AyCiJH08O7wptBigbV/QnPqiY 1HtojCkS+fP0A0AaQDOFsFwdQG8GyP4/gFow3agtAA3Ev0cPvF3cHiGeLY336+kAfPdPlJHekR84 XKdZZre5FgyQO6wyh0s4mJzrYb+ios8te6QF9sjhvk/gOePs3fpzuMlZMboJInhfgPf+TTULHN86 LARDyQUAua84E+8cUdCNwL8B5niZbpkab7g/ovLllvBvF3m4y/jmhntvJLnx+W4Vjs/atnH3lBAn KTfjB/GXH1I103lUO3fJbolsRe3ly/2cB15Iktvqz7ea1W2ZNmRPV5kJ8rjl0RzjDXa2AIw2+7a+ kECm52le7Z0PEWy2CbAVkHTrws3TI+8WwNMVTP/STltrCtqNFhOJYDzLGrg1KQ0ppmHvuA1qwUNe IwMMwEsqYsWmWN4z0XCKmmyea5E54DZGNiR2VlKN/oFugsD0GYJzcJKxjPTA3S2gzLEyKtCUeiyT qjMOV/blwHekIJqr4ANjnU0A4VKB2ifhMXAb6APnMJCcjEbM2gMNQ5vcP8qSwn1r7SlHAAAAAElF TkSuQmCC Date: Thu, 13 Jun 2019 00:22:23 +0200 In-Reply-To: <87r27ybg9b.fsf@igel.home> (Andreas Schwab's message of "Thu, 13 Jun 2019 00:17:20 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andreas Schwab writes: > Isn't that what C-x 4 A (diff-add-change-log-entries-other-window) does? Indeed it is -- I wasn't aware of that command. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Schwab writes: > Isn't that what C-x 4 A (diff-add-change-log-entries-other-window) does? Indeed it is -- I wasn't aware of that command. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: rpluim@gmail.com, Andreas Schwab , 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156037974117298 (code B ref 36167); Wed, 12 Jun 2019 22:49:01 +0000 Received: (at 36167) by debbugs.gnu.org; 12 Jun 2019 22:49:01 +0000 Received: from localhost ([127.0.0.1]:34260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbC3A-0004Ut-R3 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 18:49:01 -0400 Received: from forward102j.mail.yandex.net ([5.45.198.243]:41902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbC36-0004UZ-PF for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 18:49:00 -0400 Received: from mxback20j.mail.yandex.net (mxback20j.mail.yandex.net [IPv6:2a02:6b8:0:1619::114]) by forward102j.mail.yandex.net (Yandex) with ESMTP id A92D2F205ED; Thu, 13 Jun 2019 01:48:47 +0300 (MSK) Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [2a02:6b8:0:1a2d::26]) by mxback20j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 8q0tO1NRZt-mlfC1M4l; Thu, 13 Jun 2019 01:48:47 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560379727; bh=hS9nvnQGW+MWZai+g9q3C3Hp4W+s/GuHRU8YzEU1AE4=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=IDXga+/ogKj3sM1RRqw/YnZL6Xa2wjPmHNlaBOK5i3718+5Qw4M/tDnApajuZz919 kzGgcidT/S9M86WYeWjtnkWTUpzIsBQIwh0cHGsxnShv0j+JiNHfIfdVZ7mPPMTnQi YI7hUEPBYKY6/NX6vAZvCsGqk49mdjzBGrgLGK2o= Authentication-Results: mxback20j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id kRrbBBog9E-mkDCpkSQ; Thu, 13 Jun 2019 01:48:46 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Thu, 13 Jun 2019 01:48:45 +0300 From: Konstantin Kharlamov Message-Id: <1560379725.5452.3@yandex.ru> In-Reply-To: References: <1560254386.25060.0@yandex.ru> <20190611122925.12809-1-Hi-Angel@yandex.ru> <1560259030.21373.0@yandex.ru> <1560299369.31875.0@yandex.ru> <1560359349.5452.1@yandex.ru> <87r27ybg9b.fsf@igel.home> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is great, thanks everyone! =F7 =FE=D4, =C9=C0=CE 13, 2019 at 00:22, Lars Ingebrigtsen = =20 =CE=C1=D0=C9=D3=C1=CC: > Andreas Schwab writes: >=20 >> Isn't that what C-x 4 A (diff-add-change-log-entries-other-window)=20 >> does? >=20 > Indeed it is -- I wasn't aware of that command. >=20 > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]] References: <1560254386.25060.0@yandex.ru> In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2019 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156038514927421 (code B ref 36167); Thu, 13 Jun 2019 00:20:01 +0000 Received: (at 36167) by debbugs.gnu.org; 13 Jun 2019 00:19:09 +0000 Received: from localhost ([127.0.0.1]:34287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbDSL-00077u-Az for submit@debbugs.gnu.org; Wed, 12 Jun 2019 20:19:09 -0400 Received: from forward102j.mail.yandex.net ([5.45.198.243]:35336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbDSF-000778-CM for 36167@debbugs.gnu.org; Wed, 12 Jun 2019 20:19:03 -0400 Received: from mxback6o.mail.yandex.net (mxback6o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::20]) by forward102j.mail.yandex.net (Yandex) with ESMTP id 6A5F4F202EC for <36167@debbugs.gnu.org>; Thu, 13 Jun 2019 03:18:51 +0300 (MSK) Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [2a02:6b8:0:1a2d::25]) by mxback6o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id yEXoMx00jI-Io2CDC9h; Thu, 13 Jun 2019 03:18:51 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560385131; bh=PsQb6kvL1Ii3QNeshxEgwGPBDbK0NtVahZuanBvPlSw=; h=Subject:To:From:Date:Message-Id; b=LwdsEF52I+FzUrr3XlJamgMLhUxU+Is9n/3omtJIyEa8fqJh+VDM8/1wGJuQJA00/ v9MKEvcNtzcs81hiGpxKuk/Ip5sNLvOftG12oEMkGtl9FnhBRHglM/zkqkmqFAKV6T kIelWnaG7/RNSUhowLQoWp5ii6XvFYw7p+7fu7UI= Authentication-Results: mxback6o.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id S1Hk54gZGi-InrKQf7R; Thu, 13 Jun 2019 03:18:49 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Konstantin Kharlamov Date: Thu, 13 Jun 2019 03:18:43 +0300 Message-Id: <20190613001843.4743-1-Hi-Angel@yandex.ru> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * admin/charsets/mapconv: * build-aux/gitlog-to-changelog (parse_amend_file) (git_dir_option): * lisp/progmodes/verilog-mode.el (verilog-delay-re): (verilog-type-font-keywords) (verilog-read-always-signals-recurse): (verilog-is-number): * lisp/progmodes/vera-mode.el (vera-font-lock-keywords): * test/src/emacs-module-tests.el (mod-test-sum-test): * lisp/xml.el: (xml--entity-replacement-text): * lisp/version.el (emacs-repository-version-git): * lisp/textmodes/sgml-mode.el (sgml-quote): * lisp/textmodes/css-mode.el (css-escapes-re) (css--colors-regexp): * lisp/progmodes/prolog.el (prolog-syntax-propertize-function): * lisp/progmodes/hideif.el (hif-token-regexp) (hif-tokenize): * lisp/progmodes/ebnf-dtd.el: (ebnf-dtd-attlistdecl) (ebnf-dtd-entitydecl) (ebnf-dtd-lex) * lisp/progmodes/ebnf-ebx.el (ebnf-ebx-hex-character): * lisp/progmodes/ebnf-abn.el (ebnf-abn-character): * lisp/progmodes/cperl-mode.el (cperl-highlight-charclass) (cperl-find-pods-heres): * lisp/progmodes/cc-mode.el (c-maybe-quoted-number-head) (c-maybe-quoted-number) (c-parse-quotes-before-change) (c-parse-quotes-after-change) (c-quoted-number-head-before-point) (c-quoted-number-straddling-point) * lisp/progmodes/ada-mode.el (featurep) (ada-in-numeric-literal-p) (ada-font-lock-keywords): * lisp/org/org-mobile.el (org-mobile-copy-agenda-files) * lisp/org/org-table.el (org-table-number-regexp): (org-mobile-update-checksum-for-capture-file): * lisp/nxml/xsd-regexp.el (xsdre-gen-categories): * lisp/nxml/xmltok.el (let*): * lisp/nxml/rng-xsd.el (rng-xsd-convert-hex-binary) (rng-xsd-convert-any-uri): * lisp/nxml/rng-uri.el (rng-uri-file-name-1) (rng-uri-unescape-multibyte) (rng-uri-unescape-unibyte) (rng-uri-unescape-unibyte-match) (rng-uri-unescape-unibyte-replace): * lisp/nxml/rng-cmpct.el (rng-c-process-escapes): * lisp/nxml/nxml-maint.el (nxml-insert-target-repertoire-glyph-set): * lisp/net/shr-color.el (shr-color->hexadecimal): * lisp/mail/rfc2231.el (rfc2231-decode-encoded-string): * lisp/international/mule-cmds.el (read-char-by-name): * lisp/htmlfontify.el (hfy-hex-regex): * lisp/gnus/nneething.el (nneething-decode-file-name): * lisp/gnus/mml-sec.el (mml-secure-find-usable-keys): * lisp/gnus/gnus-art.el (gnus-button-mid-or-mail-heuristic-alist): * lisp/faces.el (read-color): * lisp/epg.el (epg--status-ERRSIG) (epg--status-VALIDSIG) (epg--status-SIG_CREATED) (epg--decode-percent-escape) (epg--decode-hexstring) (epg--decode-quotedstring) (epg-dn-from-string): * lisp/emulation/cua-rect.el (cua-incr-rectangle): * lisp/dnd.el (dnd-unescape-uri): * lisp/cedet/semantic/lex.el (semantic-lex-number-expression): * lisp/cedet/semantic/java.el (semantic-java-number-regexp): * lisp/calc/calc-lang.el (pascal): * lisp/calc/calc-ext.el (math-read-number-fancy): * lisp/calc/calc-aent.el (math-read-token): replace various combinations of [0-9a-fA-F] with [[:xdigit:]] (Bug#36167) --- v2: * add changed function names. * more files changed. I'm changing here 2 non-lisp files: 1. mapconv — here I change "sed", sed supports xdigit 2. gitlog-to-changelog: this one is perl. Perl supports xdigit too. I compared whether I changed all files from Mattias's log, and turned out I changed even more of them :) A regex I noted that logger didn't catch was the change in lisp/progmodes/ebnf-abn.el file: the regex was assigned there through let before being used with (skip-chars-forward) admin/charsets/mapconv | 2 +- build-aux/gitlog-to-changelog | 6 +++--- lisp/calc/calc-aent.el | 2 +- lisp/calc/calc-ext.el | 4 ++-- lisp/calc/calc-lang.el | 2 +- lisp/cedet/semantic/java.el | 4 ++-- lisp/cedet/semantic/lex.el | 4 ++-- lisp/dnd.el | 2 +- lisp/emulation/cua-rect.el | 2 +- lisp/epg.el | 14 +++++++------- lisp/faces.el | 2 +- lisp/gnus/gnus-art.el | 8 ++++---- lisp/gnus/mml-sec.el | 2 +- lisp/gnus/nneething.el | 2 +- lisp/htmlfontify.el | 2 +- lisp/international/mule-cmds.el | 2 +- lisp/mail/rfc2231.el | 2 +- lisp/net/shr-color.el | 2 +- lisp/nxml/nxml-maint.el | 4 ++-- lisp/nxml/rng-cmpct.el | 2 +- lisp/nxml/rng-uri.el | 10 +++++----- lisp/nxml/rng-xsd.el | 4 ++-- lisp/nxml/xmltok.el | 2 +- lisp/nxml/xsd-regexp.el | 2 +- lisp/org/org-mobile.el | 4 ++-- lisp/org/org-table.el | 6 +++--- lisp/progmodes/ada-mode.el | 6 +++--- lisp/progmodes/cc-mode.el | 22 +++++++++++----------- lisp/progmodes/cperl-mode.el | 8 ++++---- lisp/progmodes/ebnf-abn.el | 2 +- lisp/progmodes/ebnf-dtd.el | 16 ++++++++-------- lisp/progmodes/ebnf-ebx.el | 2 +- lisp/progmodes/hideif.el | 4 ++-- lisp/progmodes/prolog.el | 2 +- lisp/progmodes/vera-mode.el | 2 +- lisp/progmodes/verilog-mode.el | 8 ++++---- lisp/textmodes/css-mode.el | 6 +++--- lisp/textmodes/sgml-mode.el | 2 +- lisp/version.el | 2 +- lisp/xml.el | 8 ++++---- test/src/emacs-module-tests.el | 2 +- 41 files changed, 95 insertions(+), 95 deletions(-) diff --git a/admin/charsets/mapconv b/admin/charsets/mapconv index 8e19972f3d..2696b13a52 100755 --- a/admin/charsets/mapconv +++ b/admin/charsets/mapconv @@ -118,7 +118,7 @@ AWK= # Source format is: # 0xXX 0xYYYY sed -n -e "${2}p" < $1 \ - | sed -e 's/\(0x[0-9A-Fa-f]*\)[^0]*\(0x[0-9A-Fa-f]*\).*/\1 \2/' \ + | sed -e 's/\(0x[[:xdigit:]]*\)[^0]*\(0x[[:xdigit:]]*\).*/\1 \2/' \ | sort | ${AWKPROG} elif [ "$3" = "UNICODE" ] ; then # Source format is: diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog index deddef2446..ebbcb522e8 100755 --- a/build-aux/gitlog-to-changelog +++ b/build-aux/gitlog-to-changelog @@ -174,7 +174,7 @@ sub parse_amend_file($) if (!$in_code) { - $line =~ /^([0-9a-fA-F]{40})$/ + $line =~ /^([[:xdigit:]]{40})$/ or (warn "$ME: $f:$.: invalid line; expected an SHA1\n"), $fail = 1, next; $sha = lc $1; @@ -288,7 +288,7 @@ sub git_dir_option($) my ($sha, $rest) = split ':', $log, 2; defined $sha or die "$ME:$.: malformed log entry\n"; - $sha =~ /^[0-9a-fA-F]{40}$/ + $sha =~ /^[[:xdigit:]]{40}$/ or die "$ME:$.: invalid SHA1: $sha\n"; my $skipflag = 0; @@ -376,7 +376,7 @@ sub git_dir_option($) @skipshas = (); next; } - if ($found && $_ =~ /^([0-9a-fA-F]{7,}) [^ ]/) + if ($found && $_ =~ /^([[:xdigit:]]{7,}) [^ ]/) { push ( @skipshas, $1 ); } diff --git a/lisp/calc/calc-aent.el b/lisp/calc/calc-aent.el index f16e665fc3..f1ef5c170b 100644 --- a/lisp/calc/calc-aent.el +++ b/lisp/calc/calc-aent.el @@ -728,7 +728,7 @@ math-read-token math-exp-str (1- math-exp-pos)) (1- math-exp-pos)))))) (or (and (memq calc-language calc-lang-c-type-hex) - (eq (string-match "0[xX][0-9a-fA-F]+" math-exp-str + (eq (string-match "0[xX][[:xdigit:]]+" math-exp-str math-exp-pos) math-exp-pos)) (string-match "_?\\([0-9]+.?0*@ *\\)?\\([0-9]+.?0*' *\\)?\\(0*\\([2-9]\\|1[0-4]\\)\\(#[#]?\\|\\^\\^\\)[0-9a-dA-D.]+[eE][-+_]?[0-9]+\\|0*\\([2-9]\\|[0-2][0-9]\\|3[0-6]\\)\\(#[#]?\\|\\^\\^\\)[0-9a-zA-Zα-ωΑ-Ω:.]+\\|[0-9]+:[0-9:]+\\|[0-9.]+\\([eE][-+_]?[0-9]+\\)?\"?\\)?" diff --git a/lisp/calc/calc-ext.el b/lisp/calc/calc-ext.el index 1456fb2857..c7b4c3b091 100644 --- a/lisp/calc/calc-ext.el +++ b/lisp/calc/calc-ext.el @@ -3019,13 +3019,13 @@ math-read-number-fancy ;; C language hexadecimal notation ((and (eq calc-language 'c) - (string-match "^0[xX]\\([0-9a-fA-F]+\\)$" s)) + (string-match "^0[xX]\\([[:xdigit:]]+\\)$" s)) (let ((digs (math-match-substring s 1))) (math-read-radix digs 16))) ;; Pascal language hexadecimal notation ((and (eq calc-language 'pascal) - (string-match "^\\$\\([0-9a-fA-F]+\\)$" s)) + (string-match "^\\$\\([[:xdigit:]]+\\)$" s)) (let ((digs (math-match-substring s 1))) (math-read-radix digs 16))) diff --git a/lisp/calc/calc-lang.el b/lisp/calc/calc-lang.el index ee107df39c..4a9771d743 100644 --- a/lisp/calc/calc-lang.el +++ b/lisp/calc/calc-lang.el @@ -243,7 +243,7 @@ calc-pascal-language (put 'pascal 'math-lang-read-symbol '((?\$ (eq (string-match - "\\(\\$[0-9a-fA-F]+\\)\\($\\|[^0-9a-zA-Zα-ωΑ-Ω]\\)" + "\\(\\$[[:xdigit:]]+\\)\\($\\|[^0-9a-zA-Zα-ωΑ-Ω]\\)" math-exp-str math-exp-pos) math-exp-pos) (setq math-exp-token 'number diff --git a/lisp/cedet/semantic/java.el b/lisp/cedet/semantic/java.el index 54cce96545..7f9c93b906 100644 --- a/lisp/cedet/semantic/java.el +++ b/lisp/cedet/semantic/java.el @@ -51,7 +51,7 @@ semantic-java-number-regexp "\\|" "\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>" "\\|" - "\\<0[xX][0-9a-fA-F]+[lL]?\\>" + "\\<0[xX][[:xdigit:]]+[lL]?\\>" "\\|" "\\<[0-9]+[lLfFdD]?\\>" "\\)" @@ -63,7 +63,7 @@ semantic-java-number-regexp [1-9][0-9]* ; HEX_LITERAL: - 0[xX][0-9a-fA-F]+ + 0[xX][[:xdigit:]]+ ; OCTAL_LITERAL: 0[0-7]* diff --git a/lisp/cedet/semantic/lex.el b/lisp/cedet/semantic/lex.el index 2690122f06..f1c6b01418 100644 --- a/lisp/cedet/semantic/lex.el +++ b/lisp/cedet/semantic/lex.el @@ -596,7 +596,7 @@ semantic-lex-number-expression "\\|" "\\<[0-9]+[eE][-+]?[0-9]+[fFdD]?\\>" "\\|" - "\\<0[xX][0-9a-fA-F]+[lL]?\\>" + "\\<0[xX][[:xdigit:]]+[lL]?\\>" "\\|" "\\<[0-9]+[lLfFdD]?\\>" "\\)" @@ -609,7 +609,7 @@ semantic-lex-number-expression [1-9][0-9]* ; HEX_LITERAL: - 0[xX][0-9a-fA-F]+ + 0[xX][[:xdigit:]]+ ; OCTAL_LITERAL: 0[0-7]* diff --git a/lisp/dnd.el b/lisp/dnd.el index 459a7238dc..973af7e518 100644 --- a/lisp/dnd.el +++ b/lisp/dnd.el @@ -138,7 +138,7 @@ dnd-get-local-file-uri (defsubst dnd-unescape-uri (uri) (replace-regexp-in-string - "%[A-Fa-f0-9][A-Fa-f0-9]" + "%[[:xdigit:]][[:xdigit:]]" (lambda (arg) (let ((str (make-string 1 0))) (aset str 0 (string-to-number (substring arg 1) 16)) diff --git a/lisp/emulation/cua-rect.el b/lisp/emulation/cua-rect.el index 706634a501..1a19cc2910 100644 --- a/lisp/emulation/cua-rect.el +++ b/lisp/emulation/cua-rect.el @@ -1127,7 +1127,7 @@ cua-incr-rectangle (cua--rectangle-operation 'keep nil t 1 nil (lambda (_s e _l _r) (cond - ((re-search-forward "0x\\([0-9a-fA-F]+\\)" e t) + ((re-search-forward "0x\\([[:xdigit:]]+\\)" e t) (let* ((txt (cua--filter-buffer-noprops (match-beginning 1) (match-end 1))) (n (string-to-number txt 16)) (fmt (format "0x%%0%dx" (length txt)))) diff --git a/lisp/epg.el b/lisp/epg.el index 0400716845..1d2f5be818 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -950,7 +950,7 @@ 'epg--time-from-seconds (defun epg--status-ERRSIG (context string) (if (string-match "\\`\\([^ ]+\\) \\([0-9]+\\) \\([0-9]+\\) \ -\\([0-9A-Fa-f][0-9A-Fa-f]\\) \\([^ ]+\\) \\([0-9]+\\)" +\\([[:xdigit:]][[:xdigit:]]\\) \\([^ ]+\\) \\([0-9]+\\)" string) (let ((signature (epg-make-signature 'error))) (epg-context-set-result-for @@ -974,7 +974,7 @@ epg--status-VALIDSIG (when (and signature (eq (epg-signature-status signature) 'good) (string-match "\\`\\([^ ]+\\) [^ ]+ \\([^ ]+\\) \\([^ ]+\\) \ -\\([0-9]+\\) [^ ]+ \\([0-9]+\\) \\([0-9]+\\) \\([0-9A-Fa-f][0-9A-Fa-f]\\) \ +\\([0-9]+\\) [^ ]+ \\([0-9]+\\) \\([0-9]+\\) \\([[:xdigit:]][[:xdigit:]]\\) \ \\(.*\\)" string)) (setf (epg-signature-fingerprint signature) @@ -1144,7 +1144,7 @@ epg--status-DELETE_PROBLEM (defun epg--status-SIG_CREATED (context string) (if (string-match "\\`\\([DCS]\\) \\([0-9]+\\) \\([0-9]+\\) \ -\\([0-9A-Fa-f][0-9A-Fa-f]\\) \\(.*\\) " string) +\\([[:xdigit:]][[:xdigit:]]\\) \\(.*\\) " string) (epg-context-set-result-for context 'sign (cons (epg-make-new-signature @@ -2021,7 +2021,7 @@ epg-edit-key (defun epg--decode-percent-escape (string) (let ((index 0)) - (while (string-match "%\\(\\(%\\)\\|\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)" + (while (string-match "%\\(\\(%\\)\\|\\([[:xdigit:]][[:xdigit:]]\\)\\)" string index) (if (match-beginning 2) (setq string (replace-match "%" t t string) @@ -2034,7 +2034,7 @@ epg--decode-percent-escape (defun epg--decode-hexstring (string) (let ((index 0)) - (while (eq index (string-match "[0-9A-Fa-f][0-9A-Fa-f]" string index)) + (while (eq index (string-match "[[:xdigit:]][[:xdigit:]]" string index)) (setq string (replace-match (string (string-to-number (match-string 0 string) 16)) t t string) @@ -2044,7 +2044,7 @@ epg--decode-hexstring (defun epg--decode-quotedstring (string) (let ((index 0)) (while (string-match "\\\\\\(\\([,=+<>#;\\\"]\\)\\|\ -\\([0-9A-Fa-f][0-9A-Fa-f]\\)\\)" +\\([[:xdigit:]][[:xdigit:]]\\)\\)" string index) (if (match-beginning 2) (setq string (replace-match "\\2" t nil string) @@ -2081,7 +2081,7 @@ epg-dn-from-string string index)) (setq index (match-end 0) value (epg--decode-quotedstring (match-string 0 string))) - (if (eq index (string-match "#\\([0-9A-Fa-f]+\\)" string index)) + (if (eq index (string-match "#\\([[:xdigit:]]+\\)" string index)) (setq index (match-end 0) value (epg--decode-hexstring (match-string 1 string))) (if (eq index (string-match "\"\\([^\\\"]\\|\\\\.\\)*\"" diff --git a/lisp/faces.el b/lisp/faces.el index 89b598669c..f9e8c6c58b 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1997,7 +1997,7 @@ read-color (when (and convert-to-RGB (not (string-equal color ""))) (let ((components (x-color-values color))) - (unless (string-match-p "^#\\(?:[a-fA-F0-9][a-fA-F0-9][a-fA-F0-9]\\)+$" color) + (unless (string-match-p "^#\\(?:[[:xdigit:]][[:xdigit:]][[:xdigit:]]\\)+$" color) (setq color (format "#%04X%04X%04X" (logand 65535 (nth 0 components)) (logand 65535 (nth 1 components)) diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index d826faca5b..11782998f5 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -7426,10 +7426,10 @@ gnus-button-mid-or-mail-heuristic-alist (-2.0 . "^[0-9]") (-1.0 . "^[0-9][0-9]") ;; - ;; -3.0 /^[0-9][0-9a-fA-F]{2,2}/; - (-3.0 . "^[0-9][0-9a-fA-F][0-9a-fA-F][^0-9a-fA-F]") - ;; -5.0 /^[0-9][0-9a-fA-F]{3,3}/; - (-5.0 . "^[0-9][0-9a-fA-F][0-9a-fA-F][0-9a-fA-F][^0-9a-fA-F]") + ;; -3.0 /^[0-9][[:xdigit:]]{2,2}/; + (-3.0 . "^[0-9][[:xdigit:]][[:xdigit:]][^[:xdigit:]]") + ;; -5.0 /^[0-9][[:xdigit:]]{3,3}/; + (-5.0 . "^[0-9][[:xdigit:]][[:xdigit:]][[:xdigit:]][^[:xdigit:]]") ;; (-3.0 . "[0-9][0-9][0-9][0-9][0-9][^0-9].*@") ;; "[0-9]{5,}.*\@" (-3.0 . "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][^0-9].*@") diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index db7489fbf1..02a27b367c 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -725,7 +725,7 @@ mml-secure-find-usable-keys is expired or revoked. If optional JUSTONE is not nil, return the first key instead of a list." (let* ((keys (epg-list-keys context name)) - (iskeyid (string-match "\\(0x\\)?\\([0-9a-fA-F]\\{8,\\}\\)" name)) + (iskeyid (string-match "\\(0x\\)?\\([[:xdigit:]]\\{8,\\}\\)" name)) (fingerprint (match-string 2 name)) result) (when (and iskeyid (>= (length keys) 2)) diff --git a/lisp/gnus/nneething.el b/lisp/gnus/nneething.el index f64007aaf7..c3d511bc6e 100644 --- a/lisp/gnus/nneething.el +++ b/lisp/gnus/nneething.el @@ -297,7 +297,7 @@ nneething-encode-file-name (defun nneething-decode-file-name (file &optional coding-system) "Decode the name of the FILE is encoded in CODING-SYSTEM." (let ((pos 0) buf) - (while (string-match "%\\([0-9a-fA-F][0-9a-fA-F]\\)" file pos) + (while (string-match "%\\([[:xdigit:]][[:xdigit:]]\\)" file pos) (setq buf (cons (string (string-to-number (match-string 1 file) 16)) (cons (substring file pos (match-beginning 0)) buf)) pos (match-end 0))) diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el index f37a76cd7b..0466e7c024 100644 --- a/lisp/htmlfontify.el +++ b/lisp/htmlfontify.el @@ -566,7 +566,7 @@ hfy-facemap-assoc (defvar hfy-tmpfont-stack nil "An alist of derived fonts resulting from overlays.") -(defconst hfy-hex-regex "[0-9A-Fa-f]") +(defconst hfy-hex-regex "[[:xdigit:]]") (defconst hfy-triplet-regex (concat diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el index 47b07479c3..1edf80d14c 100644 --- a/lisp/international/mule-cmds.el +++ b/lisp/international/mule-cmds.el @@ -3079,7 +3079,7 @@ read-char-by-name (char (cond ((char-from-name input t)) - ((string-match-p "\\`[0-9a-fA-F]+\\'" input) + ((string-match-p "\\`[[:xdigit:]]+\\'" input) (ignore-errors (string-to-number input 16))) ((string-match-p "\\`#\\([bBoOxX]\\|[0-9]+[rR]\\)[0-9a-zA-Z]+\\'" input) diff --git a/lisp/mail/rfc2231.el b/lisp/mail/rfc2231.el index 0a0983c25f..6ddb2964e5 100644 --- a/lisp/mail/rfc2231.el +++ b/lisp/mail/rfc2231.el @@ -223,7 +223,7 @@ rfc2231-decode-encoded-string (mm-with-unibyte-buffer (insert value) (goto-char (point-min)) - (while (re-search-forward "%\\([0-9A-Fa-f][0-9A-Fa-f]\\)" nil t) + (while (re-search-forward "%\\([[:xdigit:]][[:xdigit:]]\\)" nil t) (insert (prog1 (string-to-number (match-string 1) 16) diff --git a/lisp/net/shr-color.el b/lisp/net/shr-color.el index 2d6cf68d8f..af0b99c76f 100644 --- a/lisp/net/shr-color.el +++ b/lisp/net/shr-color.el @@ -235,7 +235,7 @@ shr-color->hexadecimal (cond ;; Hexadecimal color: #abc or #aabbcc ((string-match - "\\(#[0-9a-fA-F]\\{3\\}[0-9a-fA-F]\\{3\\}?\\)" + "\\(#[[:xdigit:]]\\{3\\}[[:xdigit:]]\\{3\\}?\\)" color) (match-string 1 color)) ;; rgb() or rgba() colors diff --git a/lisp/nxml/nxml-maint.el b/lisp/nxml/nxml-maint.el index 2956efb736..c524567a5b 100644 --- a/lisp/nxml/nxml-maint.el +++ b/lisp/nxml/nxml-maint.el @@ -34,10 +34,10 @@ nxml-insert-target-repertoire-glyph-set (let (lst head) (with-current-buffer (find-file-noselect file) (goto-char (point-min)) - (while (re-search-forward "^ *\\([a-fA-F0-9]\\{2\\}\\)[ \t]+" nil t) + (while (re-search-forward "^ *\\([[:xdigit:]]\\{2\\}\\)[ \t]+" nil t) (let ((row (match-string 1)) (eol (line-end-position))) - (while (re-search-forward "\\([a-fA-F0-9]\\{2\\}\\)-\\([a-fA-F0-9]\\{2\\}\\)\\|\\([a-fA-F0-9]\\{2\\}\\)" eol t) + (while (re-search-forward "\\([[:xdigit:]]\\{2\\}\\)-\\([[:xdigit:]]\\{2\\}\\)\\|\\([[:xdigit:]]\\{2\\}\\)" eol t) (setq lst (cons (if (match-beginning 3) (concat "#x" row (match-string 3)) diff --git a/lisp/nxml/rng-cmpct.el b/lisp/nxml/rng-cmpct.el index d36f9d92f2..60c871990e 100644 --- a/lisp/nxml/rng-cmpct.el +++ b/lisp/nxml/rng-cmpct.el @@ -369,7 +369,7 @@ rng-c-process-escapes (and pos (rng-c-error "Nul character found (binary file?)"))) (let ((offset 0)) - (while (re-search-forward "\\\\x+{\\([0-9a-fA-F]+\\)}" + (while (re-search-forward "\\\\x+{\\([[:xdigit:]]+\\)}" (point-max) t) (let* ((ch (decode-char 'ucs (string-to-number (match-string 1) 16)))) diff --git a/lisp/nxml/rng-uri.el b/lisp/nxml/rng-uri.el index 798475bbc3..5a67cc7f14 100644 --- a/lisp/nxml/rng-uri.el +++ b/lisp/nxml/rng-uri.el @@ -68,7 +68,7 @@ rng-uri-pattern-file-name-replace-match ;; pattern is either nil or match or replace (defun rng-uri-file-name-1 (uri pattern) - (unless (string-match "\\`\\(?:[^%]\\|%[0-9a-fA-F]{2}\\)*\\'" uri) + (unless (string-match "\\`\\(?:[^%]\\|%[[:xdigit:]]{2}\\)*\\'" uri) (rng-uri-error "Bad escapes in URI `%s'" uri)) (setq uri (rng-uri-unescape-multibyte uri)) (let* ((components @@ -299,7 +299,7 @@ rng-join-path (mapconcat 'identity segments "/"))) (defun rng-uri-unescape-multibyte (str) - (replace-regexp-in-string "\\(?:%[89a-fA-F][0-9a-fA-F]\\)+" + (replace-regexp-in-string "\\(?:%[89a-fA-F][[:xdigit:]]\\)+" 'rng-multibyte-percent-decode str)) @@ -310,7 +310,7 @@ rng-multibyte-percent-decode 'utf-8)) (defun rng-uri-unescape-unibyte (str) - (replace-regexp-in-string "%[0-7][0-9a-fA-F]" + (replace-regexp-in-string "%[0-7][[:xdigit:]]" (lambda (h) (string-to-number (substring h 1) 16)) str @@ -318,7 +318,7 @@ rng-uri-unescape-unibyte t)) (defun rng-uri-unescape-unibyte-match (str) - (replace-regexp-in-string "%[0-7][0-9a-fA-F]\\|[^%]" + (replace-regexp-in-string "%[0-7][[:xdigit:]]\\|[^%]" (lambda (match) (if (string= match "*") "\\([^/]*\\)" @@ -333,7 +333,7 @@ rng-uri-unescape-unibyte-match (defun rng-uri-unescape-unibyte-replace (str next-match-index) (replace-regexp-in-string - "%[0-7][0-9a-fA-F]\\|[^%]" + "%[0-7][[:xdigit:]]\\|[^%]" (lambda (match) (if (string= match "*") (let ((n next-match-index)) diff --git a/lisp/nxml/rng-xsd.el b/lisp/nxml/rng-xsd.el index f308b049f3..582d08e149 100644 --- a/lisp/nxml/rng-xsd.el +++ b/lisp/nxml/rng-xsd.el @@ -330,7 +330,7 @@ rng-xsd-convert-token (match-string 1 string))) (defun rng-xsd-convert-hex-binary (string) - (and (string-match "\\`[ \r\n\t]*\\(\\(?:[0-9A-Fa-f][0-9A-Fa-f]\\)*\\)[ \r\n\t]*\\'" + (and (string-match "\\`[ \r\n\t]*\\(\\(?:[[:xdigit:]][[:xdigit:]]\\)*\\)[ \r\n\t]*\\'" string) (downcase (match-string 1 string)))) @@ -360,7 +360,7 @@ rng-xsd-base64-binary-length n))) (defun rng-xsd-convert-any-uri (string) - (and (string-match "\\`\\(?:[^%]\\|%[0-9a-fA-F][0-9a-fA-F]\\)*\\'" string) + (and (string-match "\\`\\(?:[^%]\\|%[[:xdigit:]][[:xdigit:]]\\)*\\'" string) (string-match "\\`[^#]*\\(?:#[^#]*\\)?\\'" string) (string-match "\\`\\(?:[a-zA-Z][-+.A-Za-z0-9]*:.+\\|[^:]*\\(?:[#/?].*\\)?\\)\\'" string) string)) diff --git a/lisp/nxml/xmltok.el b/lisp/nxml/xmltok.el index afa33e064f..3cab5ed9b7 100644 --- a/lisp/nxml/xmltok.el +++ b/lisp/nxml/xmltok.el @@ -413,7 +413,7 @@ xmltok-forward (xmltok-g decimal-ref-close ";") opt)) (hex-ref (xmltok+ "x" open - (xmltok-g hex "[0-9a-fA-F]" +) + (xmltok-g hex "[[:xdigit:]]" +) (xmltok-g hex-ref-close ";") opt close opt)) (char-ref diff --git a/lisp/nxml/xsd-regexp.el b/lisp/nxml/xsd-regexp.el index 7ae169c19c..c002e6fd9f 100644 --- a/lisp/nxml/xsd-regexp.el +++ b/lisp/nxml/xsd-regexp.el @@ -702,7 +702,7 @@ xsdre-gen-categories (with-current-buffer (find-file-noselect file) (goto-char (point-min)) (mapc (lambda (x) (put x 'xsdre-ranges nil)) xsdre-gen-categories) - (while (re-search-forward "^\\([0-9A-Fa-f]*\\);[^;]*;\\([A-Z][a-z]\\);" + (while (re-search-forward "^\\([[:xdigit:]]*\\);[^;]*;\\([A-Z][a-z]\\);" nil t) (let* ((sym (intern (match-string-no-properties 2))) diff --git a/lisp/org/org-mobile.el b/lisp/org/org-mobile.el index 8b4e895388..a1552606eb 100644 --- a/lisp/org/org-mobile.el +++ b/lisp/org/org-mobile.el @@ -472,7 +472,7 @@ org-mobile-copy-agenda-files (concat (shell-quote-argument org-mobile-checksum-binary) " " (shell-quote-argument (expand-file-name file))))) - (when (string-match "[a-fA-F0-9]\\{30,40\\}" check) + (when (string-match "[[:xdigit:]]\\{30,40\\}" check) (push (cons link-name (match-string 0 check)) org-mobile-checksum-files)))) @@ -761,7 +761,7 @@ org-mobile-update-checksum-for-capture-file (buffer (find-file-noselect file))) (when buffer (with-current-buffer buffer - (when (re-search-forward (concat "\\([0-9a-fA-F]\\{30,\\}\\).*?" + (when (re-search-forward (concat "\\([[:xdigit:]]\\{30,\\}\\).*?" (regexp-quote org-mobile-capture-file) "[ \t]*$") nil t) (goto-char (match-beginning 1)) diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el index 147527da1d..513a534d9b 100644 --- a/lisp/org/org-table.el +++ b/lisp/org/org-table.el @@ -155,7 +155,7 @@ org-table-default-size :type 'string) (defcustom org-table-number-regexp - "^\\([<>]?[-+^.0-9]*[0-9][-+^.0-9eEdDx()%:]*\\|[<>]?[-+]?0[xX][0-9a-fA-F.]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$" + "^\\([<>]?[-+^.0-9]*[0-9][-+^.0-9eEdDx()%:]*\\|[<>]?[-+]?0[xX][[:xdigit:].]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$" "Regular expression for recognizing numbers in table columns. If a table column contains mostly numbers, it will be aligned to the right. If not, it will be aligned to the left. @@ -180,9 +180,9 @@ org-table-number-regexp (const :tag "Exponential, Floating point, Integer" "^[-+]?[0-9.]+\\([eEdD][-+0-9]+\\)?$") (const :tag "Very General Number-Like, including hex and Calc radix" - "^\\([<>]?[-+^.0-9]*[0-9][-+^.0-9eEdDx()%]*\\|[<>]?[-+]?0[xX][0-9a-fA-F.]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$") + "^\\([<>]?[-+^.0-9]*[0-9][-+^.0-9eEdDx()%]*\\|[<>]?[-+]?0[xX][[:xdigit:].]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$") (const :tag "Very General Number-Like, including hex and Calc radix, allows comma as decimal mark" - "^\\([<>]?[-+^.,0-9]*[0-9][-+^.0-9eEdDx()%]*\\|[<>]?[-+]?0[xX][0-9a-fA-F.]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$") + "^\\([<>]?[-+^.,0-9]*[0-9][-+^.0-9eEdDx()%]*\\|[<>]?[-+]?0[xX][[:xdigit:].]+\\|[<>]?[-+]?[0-9]+#[0-9a-zA-Z.]+\\|nan\\|[-+u]?inf\\)$") (string :tag "Regexp:"))) (defcustom org-table-number-fraction 0.5 diff --git a/lisp/progmodes/ada-mode.el b/lisp/progmodes/ada-mode.el index 77c1e5e2d8..404e704373 100644 --- a/lisp/progmodes/ada-mode.el +++ b/lisp/progmodes/ada-mode.el @@ -909,7 +909,7 @@ ada-mode-symbol-syntax-table change)) (replace-match "'A'")) (goto-char from) - (while (re-search-forward "\\(#[0-9a-fA-F]*#\\)" to t) + (while (re-search-forward "\\(#[[:xdigit:]]*#\\)" to t) (setq change (cons (list (match-beginning 1) (length (match-string 1)) (match-string 1)) @@ -1013,7 +1013,7 @@ ada-in-string-or-comment-p (defsubst ada-in-numeric-literal-p () "Return t if point is after a prefix of a numeric literal." - (looking-back "\\([0-9]+#[0-9a-fA-F_]+\\)" (line-beginning-position))) + (looking-back "\\([0-9]+#[[:xdigit:]_]+\\)" (line-beginning-position))) ;;------------------------------------------------------------------ ;; Contextual menus @@ -5213,7 +5213,7 @@ ada-font-lock-keywords '("<<\\(\\sw+\\)>>" 1 font-lock-constant-face) ;; Highlight based-numbers (R. Reagan ) - (list "\\([0-9]+#[0-9a-fA-F_]+#\\)" '(1 font-lock-constant-face t)) + (list "\\([0-9]+#[[:xdigit:]_]+#\\)" '(1 font-lock-constant-face t)) ;; Ada unnamed numerical constants (list "\\W\\([-+]?[0-9._]+\\)\\>" '(1 font-lock-constant-face)) diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el index 6afcb08a7c..6370c9c3a4 100644 --- a/lisp/progmodes/cc-mode.el +++ b/lisp/progmodes/cc-mode.el @@ -1415,7 +1415,7 @@ c-after-change-mark-abnormal-strings (defconst c-maybe-quoted-number-head (concat "\\(0\\(" - "\\([Xx]\\([0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*'?\\)?\\)" + "\\([Xx]\\([[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*'?\\)?\\)" "\\|" "\\([Bb]\\([01]\\('[01]\\|[01]\\)*'?\\)?\\)" "\\|" @@ -1435,7 +1435,7 @@ c-quoted-number-head-before-point (save-excursion (let ((here (point)) found) - (skip-chars-backward "0-9a-fA-F'") + (skip-chars-backward "[:xdigit:]'") (if (and (memq (char-before) '(?x ?X)) (eq (char-before (1- (point))) ?0)) (backward-char 2)) @@ -1449,7 +1449,7 @@ c-quoted-number-head-before-point (defconst c-maybe-quoted-number-tail (concat "\\(" - "\\([xX']?[0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)" + "\\([xX']?[[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*\\)" "\\|" "\\([bB']?[01]\\('[01]\\|[01]\\)*\\)" "\\|" @@ -1469,7 +1469,7 @@ c-quoted-number-tail-after-point (defconst c-maybe-quoted-number (concat "\\(0\\(" - "\\([Xx][0-9a-fA-F]\\('[0-9a-fA-F]\\|[0-9a-fA-F]\\)*\\)" + "\\([Xx][[:xdigit:]]\\('[[:xdigit:]]\\|[[:xdigit:]]\\)*\\)" "\\|" "\\([Bb][01]\\('[01]\\|[01]\\)*\\)" "\\|" @@ -1487,9 +1487,9 @@ c-quoted-number-straddling-point (when c-has-quoted-numbers (save-excursion (let ((here (point)) - (bound (progn (skip-chars-forward "0-9a-fA-F'") (point)))) + (bound (progn (skip-chars-forward "[:xdigit:]'") (point)))) (goto-char here) - (when (< (skip-chars-backward "0-9a-fA-F'") 0) + (when (< (skip-chars-backward "[:xdigit:]'") 0) (if (and (memq (char-before) '(?x ?X)) (eq (char-before (1- (point))) ?0)) (backward-char 2)) @@ -1530,7 +1530,7 @@ c-parse-quotes-before-change (if (>= (point) c-new-BEG) (setq c-new-BEG (match-beginning 0)))) ((looking-at - "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'") + "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)'") (goto-char (match-end 0)) (if (> (match-end 0) c-new-BEG) (setq c-new-BEG (1- (match-beginning 0))))) @@ -1559,7 +1559,7 @@ c-parse-quotes-before-change (if (> (match-end 0) c-new-END) (setq c-new-END (match-end 0)))) ((looking-at - "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)'") + "\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)'") (goto-char (match-end 0)) (if (> (match-end 0) c-new-END) (setq c-new-END (match-end 0)))) @@ -1579,8 +1579,8 @@ c-parse-quotes-before-change ((c-quoted-number-tail-after-point) (setq c-new-END (match-end 0))) ((looking-at - "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\|.\\)?\ -\\('\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\\)\\)*'") + "\\(\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\|.\\)?\ +\\('\\([^'\\]\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\\)\\)*'") (setq c-new-END (match-end 0)))) ;; Remove the '(1) syntax-table property from any "'"s within (c-new-BEG @@ -1632,7 +1632,7 @@ c-parse-quotes-after-change 'c-digit-separator t ?') (goto-char num-end)) ((looking-at - "\\([^\\']\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][0-9a-fA-F]+\\|.\\)\ + "\\([^\\']\\|\\\\\\([0-7]\\{1,3\\}\\|[xuU][[:xdigit:]]+\\|.\\)\ \\)'") ; balanced quoted expression. (goto-char (match-end 0))) ((looking-at "\\\\'") ; Anomalous construct. diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index ba007d67c0..c58acf0c2f 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -3507,18 +3507,18 @@ cperl-look-at-leading-count (defsubst cperl-highlight-charclass (endbracket dashface bsface onec-space) (let ((l '(1 5 7)) ll lle lll ;; 2 groups, the first takes the whole match (include \[trnfabe]) - (singleChar (concat "\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)"))) + (singleChar (concat "\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)"))) (while ; look for unescaped - between non-classes (re-search-forward ;; On 19.33, certain simplifications lead ;; to bugs (as in [^a-z] \\| [trnfabe] ) (concat ; 1: SingleChar (include \[trnfabe]) singleChar - ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" + ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" "\\(" ; 3: DASH SingleChar (match optionally) "\\(-\\)" ; 4: DASH singleChar ; 5: SingleChar - ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" + ;;"\\(" "[^\\]" "\\|" "\\\\[^cdg-mo-qsu-zA-Z0-9_]" "\\|" "\\\\c." "\\|" "\\\\x" "\\([[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}\\)" "\\|" "\\\\0?[0-7][0-7]?[0-7]?" "\\|" "\\\\N{[^{}]*}" "\\)" "\\)?" "\\|" "\\(" ; 7: other escapes @@ -4420,7 +4420,7 @@ cperl-find-pods-heres "\\=[0123456789]*" (1- e) 'to-end)) (and (eq qtag ?x) (re-search-forward - "\\=[0-9a-fA-F][0-9a-fA-F]?\\|\\={[0-9a-fA-F]+}" + "\\=[[:xdigit:]][[:xdigit:]]?\\|\\={[[:xdigit:]]+}" (1- e) 'to-end)) (and (memq qtag (append "pPN" nil)) (re-search-forward "\\={[^{}]+}\\|." diff --git a/lisp/progmodes/ebnf-abn.el b/lisp/progmodes/ebnf-abn.el index 53d37b689f..b00308591f 100644 --- a/lisp/progmodes/ebnf-abn.el +++ b/lisp/progmodes/ebnf-abn.el @@ -640,7 +640,7 @@ ebnf-abn-character (let* ((char (following-char)) (chars (cond ((or (= char ?B) (= char ?b)) "01") ((or (= char ?D) (= char ?d)) "0-9") - ((or (= char ?X) (= char ?x)) "0-9A-Fa-f") + ((or (= char ?X) (= char ?x)) "[:xdigit:]") (t (error "Invalid terminal value"))))) (forward-char) (or (> (skip-chars-forward chars ebnf-limit) 0) diff --git a/lisp/progmodes/ebnf-dtd.el b/lisp/progmodes/ebnf-dtd.el index 94d9643261..74ff1f47d1 100644 --- a/lisp/progmodes/ebnf-dtd.el +++ b/lisp/progmodes/ebnf-dtd.el @@ -324,7 +324,7 @@ ;; /* Character Reference */ ;; ;; CharRef ::= '&#' [0-9]+ ';' -;; | '&#x' [0-9a-fA-F]+ ';' +;; | '&#x' [[:xdigit:]]+ ';' ;; [WFC: Legal Character] ;; ;; @@ -915,9 +915,9 @@ ebnf-dtd-operators ;;; EntityRef ::= '&' Name ';' ;;; ;;; CharRef ::= '&#' [0-9]+ ';' -;;; | '&#x' [0-9a-fA-F]+ ';' +;;; | '&#x' [[:xdigit:]]+ ';' -;;; "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" +;;; "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" (defun ebnf-dtd-attlistdecl () @@ -945,7 +945,7 @@ ebnf-dtd-attlistdecl (setq token (ebnf-dtd-lex))) (or (and (eq token 'string) (string-match - "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" + "^\\(&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^<&]\\)*$" ebnf-dtd-lex)) (error "Invalid default value in ATTLIST declaration")))) (or (eq token 'end-decl) @@ -986,9 +986,9 @@ ebnf-dtd-namelist ;;; EntityRef ::= '&' Name ';' ;;; ;;; CharRef ::= '&#' [0-9]+ ';' -;;; | '&#x' [0-9a-fA-F]+ ';' +;;; | '&#x' [[:xdigit:]]+ ';' -;;; "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" +;;; "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" (defun ebnf-dtd-entitydecl () @@ -1001,7 +1001,7 @@ ebnf-dtd-entitydecl (setq token (ebnf-dtd-lex)) (if (eq token 'string) (if (string-match - "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[0-9a-fA-F]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" + "^\\(%[A-Za-z_:][-A-Za-z0-9._:]*;\\|&\\([A-Za-z_:][-A-Za-z0-9._:]*\\|#\\(x[[:xdigit:]]+\\|[0-9]+\\)\\);\\|[^%&]\\)*$" ebnf-dtd-lex) (setq token (ebnf-dtd-lex)) (error "Invalid ENTITY definition")) @@ -1242,7 +1242,7 @@ ebnf-dtd-lex (setq ebnf-dtd-lex (if (/= (following-char) ?x) (ebnf-dtd-char-ref "&#" "0-9") (forward-char) - (ebnf-dtd-char-ref "&#x" "0-9a-fA-F"))) + (ebnf-dtd-char-ref "&#x" "[:xdigit:]"))) 'char-ref)) ;; miscellaneous: (, ), [, ], =, |, *, +, >, `,' (t diff --git a/lisp/progmodes/ebnf-ebx.el b/lisp/progmodes/ebnf-ebx.el index 25500f1618..dc1a60f374 100644 --- a/lisp/progmodes/ebnf-ebx.el +++ b/lisp/progmodes/ebnf-ebx.el @@ -658,7 +658,7 @@ ebnf-ebx-hex-character (or no-error (error "Invalid hexadecimal character")) (forward-char) - (or (> (skip-chars-forward "0-9A-Fa-f" ebnf-limit) 0) + (or (> (skip-chars-forward "[:xdigit:]" ebnf-limit) 0) (error "Invalid hexadecimal character")))) diff --git a/lisp/progmodes/hideif.el b/lisp/progmodes/hideif.el index 32b0b7551f..1b06077005 100644 --- a/lisp/progmodes/hideif.el +++ b/lisp/progmodes/hideif.el @@ -540,7 +540,7 @@ hif-valid-token-list (defconst hif-token-regexp (concat (regexp-opt (mapcar 'car hif-token-alist)) - "\\|0x[0-9a-fA-F]+\\.?[0-9a-fA-F]*" + "\\|0x[[:xdigit:]]+\\.?[[:xdigit:]]*" "\\|[0-9]+\\.?[0-9]*" ;; decimal/octal "\\|\\w+")) @@ -595,7 +595,7 @@ hif-tokenize ;; 1. postfix 'l', 'll', 'ul' and 'ull' ;; 2. floating number formats (like 1.23e4) ;; 3. 098 is interpreted as octal conversion error - (if (string-match "0x\\([0-9a-fA-F]+\\.?[0-9a-fA-F]*\\)" + (if (string-match "0x\\([[:xdigit:]]+\\.?[[:xdigit:]]*\\)" token) (hif-string-to-number (match-string 1 token) 16)) ;; hex (if (string-match "\\`0[0-9]+\\(\\.[0-9]+\\)?\\'" token) diff --git a/lisp/progmodes/prolog.el b/lisp/progmodes/prolog.el index 296a7ac3c9..780eff2d8a 100644 --- a/lisp/progmodes/prolog.el +++ b/lisp/progmodes/prolog.el @@ -1071,7 +1071,7 @@ prolog-syntax-propertize-function ;; Supposedly, ISO-Prolog wants \NNN\ for octal and \xNNN\ for hexadecimal ;; escape sequences in atoms, so be careful not to let the terminating \ ;; escape a subsequent quote. - ("\\\\[x0-7][0-9a-fA-F]*\\(\\\\\\)" (1 "_")) + ("\\\\[x0-7][[:xdigit:]]*\\(\\\\\\)" (1 "_")) ))) (defun prolog-mode-variables () diff --git a/lisp/progmodes/vera-mode.el b/lisp/progmodes/vera-mode.el index f34b21e4cf..21d3db91ad 100644 --- a/lisp/progmodes/vera-mode.el +++ b/lisp/progmodes/vera-mode.el @@ -635,7 +635,7 @@ vera-font-lock-keywords (list (concat "^\\s-*" vera-rvm-types-regexp "\\s-*\\(\\[[^]]+\\]\\s-+\\)?") '(vera-font-lock-match-item nil nil (1 font-lock-variable-name-face))) ;; highlight numbers - '("\\([0-9]*'[bdoh][0-9a-fA-FxXzZ_]+\\)" 1 vera-font-lock-number) + '("\\([0-9]*'[bdoh][[:xdigit:]xXzZ_]+\\)" 1 vera-font-lock-number) ;; highlight filenames in #include directives '("^#\\s-*include\\s-*\\(<[^>\"\n]*>?\\)" 1 font-lock-string-face) diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el index eeed4c0d7c..12b7257ac2 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -2757,7 +2757,7 @@ verilog-optional-signed-range-re "\\s-*\\(\\<\\(reg\\|wire\\)\\>\\s-*\\)?\\(\\<\\(un\\)?signed\\>\\s-*\\)?\\(" verilog-range-re "\\)?")) (defconst verilog-macroexp-re "`\\sw+") -(defconst verilog-delay-re "#\\s-*\\(\\([0-9_]+\\('s?[hdxbo][0-9a-fA-F_xz]+\\)?\\)\\|\\(([^()]*)\\)\\|\\(\\sw+\\)\\)") +(defconst verilog-delay-re "#\\s-*\\(\\([0-9_]+\\('s?[hdxbo][[:xdigit:]_xz]+\\)?\\)\\|\\(([^()]*)\\)\\|\\(\\sw+\\)\\)") (defconst verilog-declaration-re-2-no-macro (concat "\\s-*" verilog-declaration-re "\\s-*\\(\\(" verilog-optional-signed-range-re "\\)\\|\\(" verilog-delay-re "\\)" @@ -3287,7 +3287,7 @@ verilog-font-lock-grouping-keywords-face 'font-lock-preprocessor-face 'font-lock-type-face)) ;; Fontify delays/numbers - '("\\(@\\)\\|\\([ \t\n\f\r]#\\s-*\\(\\([0-9_.]+\\('s?[hdxbo][0-9a-fA-F_xz]*\\)?\\)\\|\\(([^()]+)\\|\\sw+\\)\\)\\)" + '("\\(@\\)\\|\\([ \t\n\f\r]#\\s-*\\(\\([0-9_.]+\\('s?[hdxbo][[:xdigit:]_xz]*\\)?\\)\\|\\(([^()]+)\\|\\sw+\\)\\)\\)" 0 font-lock-type-face append) ;; Fontify property/sequence cycle delays - these start with '##' '("\\(##\\(\\sw+\\|\\[[^]]+\\]\\)\\)" @@ -9177,7 +9177,7 @@ verilog-read-always-signals-recurse (setq end-else-check t)) (forward-char 1)) ((equal keywd "'") - (cond ((looking-at "'[sS]?[hdxboHDXBO]?[ \t]*[0-9a-fA-F_xzXZ?]+") + (cond ((looking-at "'[sS]?[hdxboHDXBO]?[ \t]*[[:xdigit:]_xzXZ?]+") (goto-char (match-end 0))) ((looking-at "'{") (forward-char 2) @@ -9867,7 +9867,7 @@ verilog-is-number "Return true if SYMBOL is number-like." (or (string-match "^[0-9 \t:]+$" symbol) (string-match "^[---]*[0-9]+$" symbol) - (string-match "^[0-9 \t]+'s?[hdxbo][0-9a-fA-F_xz? \t]*$" symbol))) + (string-match "^[0-9 \t]+'s?[hdxbo][[:xdigit:]_xz? \t]*$" symbol))) (defun verilog-symbol-detick (symbol wing-it) "Return an expanded SYMBOL name without any defines. diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5d5d787945..b0653bce81 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -873,7 +873,7 @@ css-syntax-propertize-function (css--uri-re (1 "|") (2 "|")))) (defconst css-escapes-re - "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[ \n\t\r\f]?\\)") + "\\\\\\(?:[^\000-\037\177]\\|[[:xdigit:]]+[ \n\t\r\f]?\\)") (defconst css-nmchar-re (concat "\\(?:[-[:alnum:]]\\|" css-escapes-re "\\)")) (defconst css-nmstart-re (concat "\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) (defconst css-ident-re ;; (concat css-nmstart-re css-nmchar-re "*") @@ -1079,10 +1079,10 @@ css--colors-regexp (regexp-opt (mapcar #'car css--color-map) 'symbols) "\\|" ;; Short hex. css-color-4 adds alpha. - "\\(#[0-9a-fA-F]\\{3,4\\}\\b\\)" + "\\(#[[:xdigit:]]\\{3,4\\}\\b\\)" "\\|" ;; Long hex. css-color-4 adds alpha. - "\\(#\\(?:[0-9a-fA-F][0-9a-fA-F]\\)\\{3,4\\}\\b\\)" + "\\(#\\(?:[[:xdigit:]][[:xdigit:]]\\)\\{3,4\\}\\b\\)" "\\|" ;; RGB. "\\(\\_&;\n\t \"%!'(),/=?]\\|$\\)" + "\\(&\\(amp\\|quot\\|lt\\|gt\\|#\\([0-9]+\\|[xX][[:xdigit:]]+\\)\\)\\)\\([][<>&;\n\t \"%!'(),/=?]\\|$\\)" nil t) (replace-match (string diff --git a/lisp/version.el b/lisp/version.el index d13d8c31e8..b9e2e50d1f 100644 --- a/lisp/version.el +++ b/lisp/version.el @@ -120,7 +120,7 @@ emacs-repository-version-git (with-demoted-errors "Error running git rev-parse: %S" (call-process "git" nil '(t nil) nil "rev-parse" "HEAD"))) (progn (goto-char (point-min)) - (looking-at "[0-9a-fA-F]\\{40\\}")) + (looking-at "[[:xdigit:]]\\{40\\}")) (match-string 0))))) (defun emacs-repository-get-version (&optional dir external) diff --git a/lisp/xml.el b/lisp/xml.el index 09ec72f792..833eb8aced 100644 --- a/lisp/xml.el +++ b/lisp/xml.el @@ -194,13 +194,13 @@ xml-nmtoken-re ;; [8] Nmtokens ::= Nmtoken (#x20 Nmtoken)* (defconst xml-nmtokens-re (concat xml-nmtoken-re "\\(?: " xml-name-re "\\)*")) -;; [66] CharRef ::= '&#' [0-9]+ ';' | '&#x' [0-9a-fA-F]+ ';' -(defconst xml-char-ref-re "\\(?:&#[0-9]+;\\|&#x[0-9a-fA-F]+;\\)") +;; [66] CharRef ::= '&#' [0-9]+ ';' | '&#x' [[:xdigit:]]+ ';' +(defconst xml-char-ref-re "\\(?:&#[0-9]+;\\|&#x[[:xdigit:]]+;\\)") ;; [68] EntityRef ::= '&' Name ';' (defconst xml-entity-ref (concat "&" xml-name-re ";")) -(defconst xml-entity-or-char-ref-re (concat "&\\(?:#\\(x\\)?\\([0-9a-fA-F]+\\)\\|\\(" +(defconst xml-entity-or-char-ref-re (concat "&\\(?:#\\(x\\)?\\([[:xdigit:]]+\\)\\|\\(" xml-name-re "\\)\\);")) ;; [69] PEReference ::= '%' Name ';' @@ -889,7 +889,7 @@ xml--entity-replacement-text The replacement text is obtained by replacing character references and parameter-entity references." (let ((ref-re (eval-when-compile - (concat "\\(?:&#\\([0-9]+\\)\\|&#x\\([0-9a-fA-F]+\\)\\|%\\(" + (concat "\\(?:&#\\([0-9]+\\)\\|&#x\\([[:xdigit:]]+\\)\\|%\\(" xml-name-re "\\)\\);"))) children) (while (string-match ref-re string) diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el index 5349de055e..96a604f982 100644 --- a/test/src/emacs-module-tests.el +++ b/test/src/emacs-module-tests.el @@ -60,7 +60,7 @@ mod-test-emacs (should (eq 0 (string-match (concat "#") (prin1-to-string (nth 1 descr))))) (should (= (nth 2 descr) 3))) -- 2.21.0 From unknown Sun Jun 22 04:00:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Konstantin Kharlamov Subject: bug#36167: closed (Re: bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]]) Message-ID: References: <834l3za8s3.fsf@gnu.org> <1560254386.25060.0@yandex.ru> X-Gnu-PR-Message: they-closed 36167 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 36167@debbugs.gnu.org Date: Sat, 06 Jul 2019 08:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1562400302-11421-1" This is a multi-part message in MIME format... ------------=_1562400302-11421-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36167@debbugs.gnu.org. --=20 36167: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36167 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1562400302-11421-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36167-done) by debbugs.gnu.org; 6 Jul 2019 08:04:44 +0000 Received: from localhost ([127.0.0.1]:54154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjfgZ-0002xf-Nf for submit@debbugs.gnu.org; Sat, 06 Jul 2019 04:04:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjfgW-0002xS-V6 for 36167-done@debbugs.gnu.org; Sat, 06 Jul 2019 04:04:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjfgR-00044f-2z; Sat, 06 Jul 2019 04:04:35 -0400 Received: from [176.228.60.248] (port=1419 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjfgQ-0007HC-JU; Sat, 06 Jul 2019 04:04:34 -0400 Date: Sat, 06 Jul 2019 11:04:28 +0300 Message-Id: <834l3za8s3.fsf@gnu.org> From: Eli Zaretskii To: Konstantin Kharlamov In-reply-to: <20190613001843.4743-1-Hi-Angel@yandex.ru> (message from Konstantin Kharlamov on Thu, 13 Jun 2019 03:18:43 +0300) Subject: Re: bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]] References: <1560254386.25060.0@yandex.ru> <20190613001843.4743-1-Hi-Angel@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36167-done Cc: 36167-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Konstantin Kharlamov > Date: Thu, 13 Jun 2019 03:18:43 +0300 > > * admin/charsets/mapconv: > * build-aux/gitlog-to-changelog (parse_amend_file) (git_dir_option): > * lisp/progmodes/verilog-mode.el (verilog-delay-re): > (verilog-type-font-keywords) (verilog-read-always-signals-recurse): > (verilog-is-number): Thanks, I pushed this. The log message was mis-formatted, which required me to tediously fix it by hand. Please in the future format the entries using "C-x 4 a" or similar commands, to avoid that, okay? In particular, lines longer than 78 characters abort "git am", so please verify this doesn't happen in the patches you submit. "C-x 4 a" and friends format the entries with leading TABs which you can later remove with "C-x TAB", and that produces the optimal results, including when the log messages are later used to generate ChangeLog files in the release tarballs. ------------=_1562400302-11421-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jun 2019 11:59:59 +0000 Received: from localhost ([127.0.0.1]:58118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafRX-00008N-6y for submit@debbugs.gnu.org; Tue, 11 Jun 2019 07:59:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:47824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hafRU-00008C-Vj for submit@debbugs.gnu.org; Tue, 11 Jun 2019 07:59:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58432) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hafRT-00007e-G0 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hafRS-0007ee-5Q for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:55 -0400 Received: from forward104p.mail.yandex.net ([77.88.28.107]:55551) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hafRR-0007c3-HD for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:59:54 -0400 Received: from mxback17j.mail.yandex.net (mxback17j.mail.yandex.net [IPv6:2a02:6b8:0:1619::93]) by forward104p.mail.yandex.net (Yandex) with ESMTP id A68C94B00CCF for ; Tue, 11 Jun 2019 14:59:47 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback17j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id aqUPP7iBc4-xlnG2Td8; Tue, 11 Jun 2019 14:59:47 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1560254387; bh=bgn7opccRo184EZWlaHZfWnlOSG0sXsEgedW0+p7Xjk=; h=To:Subject:From:Date:Message-Id; b=igjK8EkYrk29NELMNQ1NnAEKSS6TS0wd4UsU/OdeWpDasn4cGu9xeWOcNKDaKzhCa 0ctCe+9z0QY08OTe98vaJQY3cKt1Ec+oYrH1YRDEIIuncO/WE5diQLyK+h9yG9oRKs zi0MgGyvvApV2lWzZg3DNKBv9Php0T4lJkGr/9XA= Authentication-Results: mxback17j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id AeQQGHSO3B-xkxatwXk; Tue, 11 Jun 2019 14:59:47 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Tue, 11 Jun 2019 14:59:46 +0300 From: Konstantin Kharlamov Subject: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] To: bug-gnu-emacs@gnu.org Message-Id: <1560254386.25060.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 77.88.28.107 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hopefully, this is more readable compared to older "[0-9a-fA-F]", because the intention is immediately obvious. Fun fact: initially I started it because on my older Emacs this resulted in better performance; the difference was about 10x times. But I can't reproduce this on the current master anymore, i.e. the performance matches. Oh, well. I'm thus not sending the patch replacing [0-9] with [[:digit:]] because in terms of readability the intention is clear there, however replacing the hex regexes should still make code more readable. P.S.: I'm not sure if the commit message looks okay, comments are welcome. ------------=_1562400302-11421-1-- From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] References: <1560254386.25060.0@yandex.ru> In-Reply-To: <1560254386.25060.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36167@debbugs.gnu.org Cc: Eli Zaretskii Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156257848616051 (code B ref 36167); Mon, 08 Jul 2019 09:35:02 +0000 Received: (at 36167) by debbugs.gnu.org; 8 Jul 2019 09:34:46 +0000 Received: from localhost ([127.0.0.1]:57739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkQ2n-0004Ap-Os for submit@debbugs.gnu.org; Mon, 08 Jul 2019 05:34:45 -0400 Received: from forward105j.mail.yandex.net ([5.45.198.248]:55619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkQ2k-0004AU-8C for 36167@debbugs.gnu.org; Mon, 08 Jul 2019 05:34:44 -0400 Received: from mxback13j.mail.yandex.net (mxback13j.mail.yandex.net [IPv6:2a02:6b8:0:1619::88]) by forward105j.mail.yandex.net (Yandex) with ESMTP id 68EB6B214C7; Mon, 8 Jul 2019 12:34:35 +0300 (MSK) Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [2a02:6b8:0:1a2d::26]) by mxback13j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id oNBJoUajKA-YZs0YPVL; Mon, 08 Jul 2019 12:34:35 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1562578475; bh=T9a1orEV6EVIcFDbi0XFy2NiQMAFtCveLiUeMVn8/cY=; h=Cc:To:Subject:From:Date:Message-Id; b=INucFYRKy2OFzS1oHMJ8QtU0RFwrCw2qKzNFqWITWuZvXawSpRtHVRCl1qOmExa/h 1PXSJRCB7FnUGjDSYmvjyFydkrLeZPuHqULZQfrln6hYbN8P/okNH0pwQZDUmS6ubF pPsS1DoenVwISvY5N6rF55JlKdT5kKuh4VV8zdII= Authentication-Results: mxback13j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id UQM3h4ayQX-YY4ehqO1; Mon, 08 Jul 2019 12:34:34 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Mon, 08 Jul 2019 12:34:32 +0300 From: Konstantin Kharlamov Message-Id: <1562578472.8519.0@yandex.ru> X-Mailer: geary/3.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks, I pushed this. >=20 > The log message was mis-formatted, which required me to tediously fix > it by hand. Please in the future format the entries using "C-x 4 a" > or similar commands, to avoid that, okay? In particular, lines longer > than 78 characters abort "git am", so please verify this doesn't > happen in the patches you submit. "C-x 4 a" and friends format the > entries with leading TABs which you can later remove with "C-x TAB", > and that produces the optimal results, including when the log messages > are later used to generate ChangeLog files in the release tarballs. Thank you! And sorry about that. I wanted to take a look this weekend=20 for problems you mentioned, but haven't got time. Anyway, IIRC I have=20 used "C-x 4 a" to create the commit message, but then I re-formatted it=20 to look more similar to other commits I've seen. Probably I shouldn't=20 have touched it=85 About git-am: this is unfortunate, I think I haven't seen this problem=20 because apparently "git" refuses to execute local hooks if one have set=20 global hooks with "hooksPath" variable (which since recently I use to=20 pre-format commit message based on modified paths, etc). I'll see what=20 can be done with it. P.S.: I replied on top level since for some reason my email client=20 (Geary) refused to reply the last message directly. = From unknown Sun Jun 22 04:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Konstantin Kharlamov Cc: 36167@debbugs.gnu.org Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156258794715607 (code B ref 36167); Mon, 08 Jul 2019 12:13:01 +0000 Received: (at 36167) by debbugs.gnu.org; 8 Jul 2019 12:12:27 +0000 Received: from localhost ([127.0.0.1]:57999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkSVO-00043f-K8 for submit@debbugs.gnu.org; Mon, 08 Jul 2019 08:12:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkSVL-00043L-V0 for 36167@debbugs.gnu.org; Mon, 08 Jul 2019 08:12:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hkSVE-0002Q3-HS; Mon, 08 Jul 2019 08:12:18 -0400 Received: from [176.228.60.248] (port=3993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hkSV9-0000qc-RY; Mon, 08 Jul 2019 08:12:14 -0400 Date: Mon, 08 Jul 2019 15:11:54 +0300 Message-Id: <83ef307mk5.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1562578472.8519.0@yandex.ru> (message from Konstantin Kharlamov on Mon, 08 Jul 2019 12:34:32 +0300) References: <1562578472.8519.0@yandex.ru> MIME-version: 1.0 Content-type: text/plain; charset=windows-1251 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 08 Jul 2019 12:34:32 +0300 > From: Konstantin Kharlamov > Cc: Eli Zaretskii > > > The log message was mis-formatted, which required me to tediously fix > > it by hand. Please in the future format the entries using "C-x 4 a" > > or similar commands, to avoid that, okay? In particular, lines longer > > than 78 characters abort "git am", so please verify this doesn't > > happen in the patches you submit. "C-x 4 a" and friends format the > > entries with leading TABs which you can later remove with "C-x TAB", > > and that produces the optimal results, including when the log messages > > are later used to generate ChangeLog files in the release tarballs. > > Thank you! And sorry about that. No sweat, mistakes do happen. > Anyway, IIRC I have used "C-x 4 a" to create the commit message, but > then I re-formatted it to look more similar to other commits I've > seen. Probably I shouldn't have touched it… Yes, my recommendation is to do only "C-u -8 C-x TAB" and nothing else to reformat the entries into commit log messages. This just removes the leading whitespace. Also, I recommend to have auto-fill-mode enabled in the buffer where you edit the log messages. > About git-am: this is unfortunate It isn't git-am per se, it's our hooks.