GNU bug report logs - #36166
27.0.50; Crash visiting HELLO when fringe-mode is disabled

Previous Next

Package: emacs;

Reported by: Robert Pluim <rpluim <at> gmail.com>

Date: Tue, 11 Jun 2019 08:17:01 UTC

Severity: normal

Found in version 27.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #21 received at 36166 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36166 <at> debbugs.gnu.org
Subject: Re: bug#36166: 27.0.50;
 Crash visiting HELLO when fringe-mode is disabled
Date: Tue, 11 Jun 2019 17:32:50 +0200

>>>>> On Tue, 11 Jun 2019 18:26:31 +0300, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Cc: 36166 <at> debbugs.gnu.org
    >> Date: Tue, 11 Jun 2019 17:17:40 +0200
    >> 
    Eli> I think the important part is the test of s->font_not_found_p.  Can
    Eli> you see whether it's zero in the crash case?
    >> 
    >> Yes, itʼs 0.

    Eli> Thanks.  So I think this:

    Eli>       if (EQ (font->driver->type, Qns))

    Eli> should be amended like this:

    Eli>       if (!s->font_not_found_p && EQ (font->driver->type, Qns))

Are you sure? if font_not_found_p == 0, then this condition will be
true, and font == NULL here, so we get a crash.

Robert
This bug report was last modified 3 years and 115 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.