GNU bug report logs - #36157
27.0.50; ediff-files does not work after lexical-binding was enabled for ediff

Previous Next

Full log

Message #8 received at 36157 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: 36157 <at> debbugs.gnu.org
Cc: alex.branham <at> gmail.com
Subject: 27.0.50; ediff-files does not work after lexical-binding was enabled
 for ediff
Date: Sun, 9 Jun 2019 23:21:20 -0400

[Message part 1 (text/plain, inline)]

It seems like properly enabling lexical binding in ediff will be a bit
tricky.

If you look at the code of ediff-find-file, you will see the use of
`symbol-value' everywhere.

This line is the source of the error in the bug report:

(defun ediff-find-file (file-var buffer-name &optional last-dir hooks-var)
  "Visit FILE and arrange its buffer to Ediff's liking.
...

deleted."
  (let* ((file (symbol-value file-var))  ;<------------------

I see symbol-value used at 4 places in ediff.el. So all of those will need
replaced with variable access in lexical scope.

--
Kaushal Modi

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.