GNU bug report logs - #36157
27.0.50; ediff-files does not work after lexical-binding was enabled for ediff

Previous Next

Full log

View this message in rfc822 format

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 36157 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff
Date: Mon, 10 Jun 2019 09:45:57 -0400

[Message part 1 (text/plain, inline)]

Hi Alex,

I have reverted that patch in my local emacs build.

But I am copying Stefan and Eli here for ideas so that it doesn't need to
be reverted on master.

--
Kaushal Modi


On Mon, Jun 10, 2019 at 9:41 AM Alex Branham <alex.branham <at> gmail.com> wrote:

>
> On Sun 09 Jun 2019 at 22:21, Kaushal Modi <kaushal.modi <at> gmail.com> wrote:
>
> > It seems like properly enabling lexical binding in ediff will be a bit
> > tricky.
> >
> > If you look at the code of ediff-find-file, you will see the use of
> > `symbol-value' everywhere.
>
> Indeed, it looks like portions of ediff expect symbols like file-A and
> file-B to be dynamically bound, but also passes them through as
> arguments to functions. I'm not sure what the best way to deal with this
> is, since if we just mark them as special the lexical binding will
> shadow the global binding anyway.
>
> In the meantime, feel free to revert that patch if its causing issues.
>
> Alex
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.