From unknown Sun Jun 22 17:13:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36157 <36157@debbugs.gnu.org> To: bug#36157 <36157@debbugs.gnu.org> Subject: Status: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Reply-To: bug#36157 <36157@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:13:16 +0000 retitle 36157 27.0.50; ediff-files does not work after lexical-binding was = enabled for ediff reassign 36157 emacs submitter 36157 Kaushal Modi severity 36157 important thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 23:12:34 2019 Received: (at submit) by debbugs.gnu.org; 10 Jun 2019 03:12:34 +0000 Received: from localhost ([127.0.0.1]:55753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAjY-0005zg-M3 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 23:12:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAjW-0005zY-9y for submit@debbugs.gnu.org; Sun, 09 Jun 2019 23:12:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39647) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haAjU-00074X-VZ for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:12:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FREEMAIL_REPLY,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haAjT-0007A3-Mi for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:12:28 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:46878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haAjT-00079K-EB for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:12:27 -0400 Received: by mail-lj1-x236.google.com with SMTP id v24so2170566ljg.13 for ; Sun, 09 Jun 2019 20:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=g6MNfsyzR4FdsvFKa5bhmLpCwKEeku6kuedIEj+lpUM=; b=cDW+ufShX+OUjS3jmmvdb2+bB4h6+icvyR5mJvwv5fu+7EQ/PR5M+8Q56Mq8c6hGnq xXtHH6t3xDKinHq8NqzGIQNyYo0GMgk2D0JI/a8zx0nlM3C/AWlpliaGSeqPDs+6UT6t /OEQAKy2ZyJ4Y427WTqFHa8D4qfZ8HrvQWw25pyDdOc2OaVem/FdAEk+OZDgZ6VOhxUE q4OwQrDTJkXAHA2D6Nk5ACgVCPkR4yaZV/WAH+iF2zEmEdZK9e2NFUHLN6DP6YgiyhrS r15RE1XAWOoY6mfMYYtWbqUUeAz/UeW/UwuS/LcfvHf6i0WrLqyk6sM3I1pby2oW0BLd j+Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=g6MNfsyzR4FdsvFKa5bhmLpCwKEeku6kuedIEj+lpUM=; b=R7yyzaC/sXk56YpmISi4TlTu9Ejy1Pngvo2pN9KeKv48DfyKUabdJgEB1qRb6SoAE4 FV9gApV0v/+nwFKOXI5FTG8a2m+QzCxTN95P9Fykos7kqMo/lJac0sqgtAO0cyFBx5Nv D99e9HbrVbui5meBe68yhct0K66oL+niItjK4tebWiZPYo2ofVQZUBNEiz9UQpbYO0uq sl7PiZ02lSBbi+yIo9F5H4RYdbATTGwNVwJkHFIim3W3gNAY5Yex9EbjmOTb/S9sLKPk +MtpoaZK20U/61A4/J87ftV7kOEfOC137paDdopBIXvABZWOBOp5lqjmxzgRKFVn1thb dxtw== X-Gm-Message-State: APjAAAUmH+4jxleUTEu9ocsfHQHzHLW5XKgVCN9QXAMSLeeqC4KhqhZi ClUKdVFto66zIo1m3l1wLPIw6yY3+l416fCQXg7UgdZv X-Google-Smtp-Source: APXvYqw1CyNTjRsWyNuMb0Vh74XN62E6gC9SAHd9tSk6/zQo28K2SIeixTU2L76QRbMvwcOS5mO72vkAth36Cg+JlM0= X-Received: by 2002:a2e:9e1a:: with SMTP id e26mr19190812ljk.158.1560136345501; Sun, 09 Jun 2019 20:12:25 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Sun, 9 Jun 2019 23:11:48 -0400 Message-ID: Subject: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000acc51b058aef8c55" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::236 X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000acc51b058aef8c55 Content-Type: text/plain; charset="UTF-8" X-Debbugs-CC: alex.branham@gmail.com Hello, After lexical-binding was enabled in ediff, doing ediff-files gives this error: Debugger entered--Lisp error: (void-variable file-A) ediff-find-file(file-A buf-A ediff-last-dir-A startup-hooks) ediff-files-internal("~/temp/d" "~/temp/a" nil nil ediff-files) ediff-files("~/temp/d" "~/temp/a") eval((ediff-files "~/temp/d" "~/temp/a") t) eval-expression((ediff-files "~/temp/d" "~/temp/a") nil nil 127) funcall-interactively(eval-expression (ediff-files "~/temp/d" "~/temp/a") nil nil 127) call-interactively(eval-expression nil nil) command-execute(eval-expression) Recipe: Take any 2 files and do M-: (ediff-files "file1" "file2") Commit: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=963d4e24263b0ff2add1a223f00387ca53d0658f In GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 2.24.23) of 2019-06-09 Repository revision: e4f12a1b1ffba07cc7d6f6e1aec5de9f09af616f Repository branch: master Windowing system distributor 'Open Text', version 11.0.11505 System Description: Red Hat Enterprise Linux Workstation release 6.8 (Santiago) Configured using: 'configure --with-modules --with-imagemagick --prefix=/home/kmodi/usr_local/apps/6/emacs/master '--program-transform-name=s/^ctags$/ctags_emacs/' --with-harfbuzz --enable-checking=yes,glyphs --enable-check-lisp-object-type 'CPPFLAGS=-I/home/kmodi/stowed/include -I/cad/adi/apps/gnu/linux/x86_64/6/include/ -I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=-ggdb3 -Og' 'CXXFLAGS=-ggdb3 -Og' 'LDFLAGS=-L/home/kmodi/stowed/lib -L/home/kmodi/stowed/lib64 -L/cad/adi/apps/gnu/linux/x86_64/6/lib/ -L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 XDBE XIM MODULES THREADS PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix -- Kaushal Modi --000000000000acc51b058aef8c55 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
X-Debbugs-CC:=C2=A0 alex.branham@gmail.com

Hello,

<= div>After lexical-binding was enabled in ediff, doing ediff-files gives thi= s error:

Debugger entered--Lisp error: (void-varia= ble file-A)
=C2=A0 ediff-find-file(file-A buf-A ediff-last-dir-A startup= -hooks)
=C2=A0 ediff-files-internal("~/temp/d" "~/temp/a&= quot; nil nil ediff-files)
=C2=A0 ediff-files("~/temp/d" "= ;~/temp/a")
=C2=A0 eval((ediff-files "~/temp/d" "~/t= emp/a") t)
=C2=A0 eval-expression((ediff-files "~/temp/d"= "~/temp/a") nil nil 127)
=C2=A0 funcall-interactively(eval-ex= pression (ediff-files "~/temp/d" "~/temp/a") nil nil 12= 7)
=C2=A0 call-interactively(eval-expression nil nil)
=C2=A0 command-= execute(eval-expression)

Recipe:

Take any 2 files and do M-: (ediff-files "file1" "fi= le2")



In G= NU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 2.24.23)
= =C2=A0of 2019-06-09
Repository revision: e4f12a1b1ffba07cc7d6f6e1aec5de9= f09af616f
Repository branch: master
Windowing system distributor '= ;Open Text', version 11.0.11505
System Description: Red Hat Enterpri= se Linux Workstation release 6.8 (Santiago)

Configured using:
=C2= =A0'configure --with-modules --with-imagemagick
=C2=A0--prefix=3D/ho= me/kmodi/usr_local/apps/6/emacs/master
=C2=A0'--program-transform-na= me=3Ds/^ctags$/ctags_emacs/' --with-harfbuzz
=C2=A0--enable-checking= =3Dyes,glyphs --enable-check-lisp-object-type
=C2=A0'CPPFLAGS=3D-I/h= ome/kmodi/stowed/include
=C2=A0-I/cad/adi/apps/gnu/linux/x86_64/6/includ= e/
=C2=A0-I/home/kmodi/usr_local/6/include -I/usr/include/freetype2
= =C2=A0-I/usr/include' 'CFLAGS=3D-ggdb3 -Og' 'CXXFLAGS=3D-gg= db3 -Og'
=C2=A0'LDFLAGS=3D-L/home/kmodi/stowed/lib -L/home/kmodi= /stowed/lib64
=C2=A0-L/cad/adi/apps/gnu/linux/x86_64/6/lib/ -L/home/kmod= i/usr_local/6/lib
=C2=A0-L/home/kmodi/usr_local/6/lib64 -ggdb3''=

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUN= D GPM DBUS GSETTINGS GLIB
NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 F= REETYPE HARFBUZZ M17N_FLT
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 X= DBE XIM MODULES THREADS
PDUMPER GMP

Important settings:
=C2=A0= value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-system: utf-8-unix
=

--
Kaushal Modi
=
--000000000000acc51b058aef8c55-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 23:22:06 2019 Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 03:22:06 +0000 Received: from localhost ([127.0.0.1]:55762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAsm-0006Dy-EX for submit@debbugs.gnu.org; Sun, 09 Jun 2019 23:22:06 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:45145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAsk-0006DS-LU for 36157@debbugs.gnu.org; Sun, 09 Jun 2019 23:22:03 -0400 Received: by mail-lf1-f41.google.com with SMTP id u10so5513465lfm.12 for <36157@debbugs.gnu.org>; Sun, 09 Jun 2019 20:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=vDLpKc+hd+x0UrswcyQzUbpHJ6g41+35Q+1AM1GXFUM=; b=M24Dh1fWgWqeZNpF6pIZA+ihBgqQenRjbCiVE4oVkerbqKpHM3z5PnM4Ih8ENIkDWZ y1ET9iAe6B6/Br1Shhac2RrjkNxx2G3hYTpbhExB2OTGX8ZaBaDOcWN+UzP2hCZUMTqN CWuecrQWM3dDfNZzSfgZ06OXTxWeWiIImO5FMPfso3dpCa8lBvpRCtfkhtjBOWYd5KLR +6yNemqmwsaDSGN3rTb7rdr7bSXGWJwVD72XajQlkOZlJ2dPlMV2mzkp1dqLt7zdrxfz 1qilSjDXAXGYXTmVyiF1DRfIukoZsqksn12Jy6LbhKdiybrueiqLPKBxUpt+PwRWOt2a 1nHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=vDLpKc+hd+x0UrswcyQzUbpHJ6g41+35Q+1AM1GXFUM=; b=ZgbVNO5S1erlmJP7BLgOnSrKb/20jD228zbmCS/TWWa7POtRY6ZpiQbHiq95wz6eDf jnMqRcJaJI+wOXLpKU4FFYl52kOy6QyM0rV1w2yYjKu9BFgs832c4VPhNxkhIHjmC6Sx R5bMykqCt7wvaYpPBkpAVI2hiwqBQ8+bQzxXarI16TwWiSBmW4yMg7hRcrSB59j7rsTZ aqMRJQ1+cQITNoh0VLkA08Xj/uWzteIdLRMJWxPq3uJzeTGSc2Dch6b8HzDb/6ZH2Plu Ar+5RMUTRkghzwmmsU4gfBT0mt+FlHlFJrvd3fIPQL4erTBQvHp9qyj2tvwfV+wO0xYq mocA== X-Gm-Message-State: APjAAAUc9NeZbtGK+w5SGvjSzv8FE/AIDTZd/TUeXeEIsvh/eBekbqaj rNrqalYdjTy1kpRxsPqSRCMSdkdvOVQIV7nAw7xzD1y3 X-Google-Smtp-Source: APXvYqx1puAHLQzsp6l1fb3Rq5AMXsyOuyx491tgKJoa4l07Y8sG2nnRX0V9USGAxLDtHmG4dGFZILWfkqMISJYug6A= X-Received: by 2002:a19:2d41:: with SMTP id t1mr33125126lft.79.1560136916349; Sun, 09 Jun 2019 20:21:56 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Sun, 9 Jun 2019 23:21:20 -0400 Message-ID: Subject: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff To: 36157@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000b33bc1058aefae69" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36157 Cc: alex.branham@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b33bc1058aefae69 Content-Type: text/plain; charset="UTF-8" It seems like properly enabling lexical binding in ediff will be a bit tricky. If you look at the code of ediff-find-file, you will see the use of `symbol-value' everywhere. This line is the source of the error in the bug report: (defun ediff-find-file (file-var buffer-name &optional last-dir hooks-var) "Visit FILE and arrange its buffer to Ediff's liking. ... deleted." (let* ((file (symbol-value file-var)) ;<------------------ I see symbol-value used at 4 places in ediff.el. So all of those will need replaced with variable access in lexical scope. -- Kaushal Modi --000000000000b33bc1058aefae69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems like properly enabling lexical binding in ed= iff will be a bit tricky.

If you look at the code = of ediff-find-file, you will see the use of `symbol-value' everywhere.<= /div>

This line is the source of the error in the bug re= port:

(defun ediff-find-file (file-var buffer-name= &optional last-dir hooks-var)
=C2=A0 "Visit FILE and arrange i= ts buffer to Ediff's liking.
...

deleted."
=C2=A0 (let* ((file (symbol-value file-var))=C2=A0 ;<= ------------------

I see symbol-value used at 4 pl= aces in ediff.el. So all of those will need replaced with variable access i= n lexical scope.

--=
Kaushal Modi
--000000000000b33bc1058aefae69-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 09:42:02 2019 Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 13:42:02 +0000 Received: from localhost ([127.0.0.1]:56173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKYk-0002L1-A5 for submit@debbugs.gnu.org; Mon, 10 Jun 2019 09:42:02 -0400 Received: from mail-ot1-f42.google.com ([209.85.210.42]:33668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKYi-0002KY-Ax for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 09:42:00 -0400 Received: by mail-ot1-f42.google.com with SMTP id p4so5098867oti.0 for <36157@debbugs.gnu.org>; Mon, 10 Jun 2019 06:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Z/GqGbAObdR18Sa1MbAKt4cNkjtKGWYtbkDdVncuLDY=; b=l98X5GMd59ppik0m3e5e7pzEDLdyoSUvXRoO8pdhcZwAxnSeKd+d0afhY62JDb5fIf hT31Bg3hg9gTlf2OjNwfcNRtA1H8Hh9cXxlYsUJDLNKomtd63Lo8mC40EIkl7NYHYmg/ fQm2e5McNQMswR0iHJID/kqy+OLc8DPiHZJm8UccqZHMFJ6zdhDm2YhAN2J0Znsj3E49 1qSnRLHnrGmYv5qGrx/KbBQVZvE8cryMZFZLmPI+SQPgnB2UMJKMwlbNG+f+H7mD6t33 a7GT+mUdqVe/Jlmg5Ltx68YP7Wv3ww8MmZ8MyOgs2aN/jgbWqSjXiP2LH6BF0hV4Y4hZ aNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Z/GqGbAObdR18Sa1MbAKt4cNkjtKGWYtbkDdVncuLDY=; b=jXAICGYixMC3Tg/J+TClavziFiLXdVtz2FymsNPhlQIrUag5xWI2ii+0qV1gKww81W oXySN2WYICi/WrBbbcidiTzsFbOAs6NRv9oPK+PuoMa7Zo1UAWxXfKWBaH1KbzjCLDyE CnGtkLJf2oNuAAYBigpSSxfcA3IhcyKhjVdYq5thJxJfSE67DP0zlNbojYH7lrM3vwus qHyREHIgAkBT4qDnJNwa13ZhuWYRjOWbIzUW7vkpnx9SxDIyjpVtqoxk5gF+T4jJsXsH L2bCr75yF5BaaAVqUeXocAWE1mh3W9J/5R7RL7gpj3oOOiCsromrpCy7GKKlrA6Aa5pT zu8w== X-Gm-Message-State: APjAAAXcXxsxOmqDB/TkzZzAF5GruLVPvU7VGoJ0Kk4X69m+vxkmEDjK cVq6KQ4IUJPYFNImsZFWs6cNmzGE X-Google-Smtp-Source: APXvYqxiBH60OXBBJKuzbAUeDEdlKtYhryrjlujyPcuCVqHpksAJoPqjg57eh8Lw+O86Pd1398RZfg== X-Received: by 2002:a9d:6443:: with SMTP id m3mr8857186otl.207.1560174114022; Mon, 10 Jun 2019 06:41:54 -0700 (PDT) Received: from mars (c-75-66-168-160.hsd1.tn.comcast.net. [75.66.168.160]) by smtp.gmail.com with ESMTPSA id p131sm2705284oig.31.2019.06.10.06.41.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 06:41:52 -0700 (PDT) References: User-agent: mu4e 1.2.0; emacs 27.0.50 From: Alex Branham To: Kaushal Modi Subject: Re: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff In-reply-to: Date: Mon, 10 Jun 2019 08:41:50 -0500 Message-ID: <878su9tv4x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36157 Cc: 36157@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun 09 Jun 2019 at 22:21, Kaushal Modi wrote: > It seems like properly enabling lexical binding in ediff will be a bit > tricky. > > If you look at the code of ediff-find-file, you will see the use of > `symbol-value' everywhere. Indeed, it looks like portions of ediff expect symbols like file-A and file-B to be dynamically bound, but also passes them through as arguments to functions. I'm not sure what the best way to deal with this is, since if we just mark them as special the lexical binding will shadow the global binding anyway. In the meantime, feel free to revert that patch if its causing issues. Alex From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 09:46:45 2019 Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 13:46:45 +0000 Received: from localhost ([127.0.0.1]:56182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKdI-0002Ru-UA for submit@debbugs.gnu.org; Mon, 10 Jun 2019 09:46:45 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:44832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKdE-0002Rf-HJ for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 09:46:43 -0400 Received: by mail-lj1-f172.google.com with SMTP id k18so7983652ljc.11 for <36157@debbugs.gnu.org>; Mon, 10 Jun 2019 06:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mF7LG755Kzq1HmKbDzTYvdECqcoB0leASc0ur53jQpo=; b=I6vzAZnIUqIf76Mdiy3RpsVrvsqIcMfZ9yqPWKAn0/0UmHVeXK7coo9VEhQKjldt9R FggCxMEKdSZigZD1VbOljR+f0xKWkoHkeoB7ioPsEtU9gJyqAkqtgLaHx13yhDEDTC6i PC2T9BSXZ5aSF0IqOXfMn2fEpgnD3fPEgOoTsdUbFWoK2zr9/93IDM++BzmBGJnnyzQZ mMLXQxLCiOJ120+i7lhf+S0wOOIlx17cQPTPYLpAo4M28RVEZA1m3JxXSWjzoA32xCd4 7vylvVfjJUDV/EjhptVFTqAVlT/3KpWxnOxWp/f6Dh2J9dvf54jAJBXcXPwlIX45F5Ex mQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mF7LG755Kzq1HmKbDzTYvdECqcoB0leASc0ur53jQpo=; b=npPj90DObkZ7h9QXsGCfY/W8HPmXwsIjcKNlhDw7lLvstWuTuQ0pWmdYLc0sV12O38 B4QxDE/N9/MPB3K0W3mpw0sd5p+Bq4dEVP/M2KazFZGk2EKoGQEbbKN/3S3a+rro5Gfj 93U85WhuTYmQA4/vyTRtq+ru+RojbZTjpy6uAQjcKapvyn6Q3JvXB73V6xbiIf7oXpPn dIm2E2C0nZnegfpc2eEM7Quc7jkunvwZsIN4v4hBEjJ2Mssv/eGaO7WTdWjWZeefDSRg jQ+nUt82Dor4XCvbv4KedzS44oxl2+EwkgWIQ5ahG7Y0H1X3WkuqUr1ffOusaiT8dm5I 3FgA== X-Gm-Message-State: APjAAAXpzvqdjcWaeTEhxDlsumivm1xK68h2zMNpI82oFirJ8VHAJTo0 d0zocCbM8eFRtaicb0pkLS5Gdl5KVLAo4PRk34M= X-Google-Smtp-Source: APXvYqzBRT+/yqwZ08eY4MJ3ZrKlvgW4SNy82DfVA7V91KXbH6bFu8j8UWacmGxC251QqMYmIqjkRyfYUOo27X/obHo= X-Received: by 2002:a2e:9dc1:: with SMTP id x1mr10994424ljj.0.1560174394197; Mon, 10 Jun 2019 06:46:34 -0700 (PDT) MIME-Version: 1.0 References: <878su9tv4x.fsf@gmail.com> In-Reply-To: <878su9tv4x.fsf@gmail.com> From: Kaushal Modi Date: Mon, 10 Jun 2019 09:45:57 -0400 Message-ID: Subject: Re: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff To: Alex Branham Content-Type: multipart/alternative; boundary="0000000000008dcc4a058af8680d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36157 Cc: Eli Zaretskii , 36157@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008dcc4a058af8680d Content-Type: text/plain; charset="UTF-8" Hi Alex, I have reverted that patch in my local emacs build. But I am copying Stefan and Eli here for ideas so that it doesn't need to be reverted on master. -- Kaushal Modi On Mon, Jun 10, 2019 at 9:41 AM Alex Branham wrote: > > On Sun 09 Jun 2019 at 22:21, Kaushal Modi wrote: > > > It seems like properly enabling lexical binding in ediff will be a bit > > tricky. > > > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Indeed, it looks like portions of ediff expect symbols like file-A and > file-B to be dynamically bound, but also passes them through as > arguments to functions. I'm not sure what the best way to deal with this > is, since if we just mark them as special the lexical binding will > shadow the global binding anyway. > > In the meantime, feel free to revert that patch if its causing issues. > > Alex > --0000000000008dcc4a058af8680d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Alex,

I have reverted tha= t patch in my local emacs build.

But I am copying = Stefan and Eli here for ideas so that it doesn't need to be reverted on= master.
<= br>--
Kaushal Modi


On Mon, Jun 10, 2019 at 9:41 AM = Alex Branham <alex.branham@gma= il.com> wrote:

On Sun 09 Jun 2019 at 22:21, Kaushal Modi <kaushal.modi@gmail.com> wrote:

> It seems like properly enabling lexical binding in ediff will be a bit=
> tricky.
>
> If you look at the code of ediff-find-file, you will see the use of > `symbol-value' everywhere.

Indeed, it looks like portions of ediff expect symbols like file-A and
file-B to be dynamically bound, but also passes them through as
arguments to functions. I'm not sure what the best way to deal with thi= s
is, since if we just mark them as special the lexical binding will
shadow the global binding anyway.

In the meantime, feel free to revert that patch if its causing issues.

Alex
--0000000000008dcc4a058af8680d-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 11:37:17 2019 Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 15:37:18 +0000 Received: from localhost ([127.0.0.1]:57360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haMMH-0005MY-KC for submit@debbugs.gnu.org; Mon, 10 Jun 2019 11:37:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haMMG-0005MO-3H for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 11:37:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haMMA-0005V5-TK; Mon, 10 Jun 2019 11:37:10 -0400 Received: from [176.228.60.248] (port=2784 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1haMM9-0007oe-VX; Mon, 10 Jun 2019 11:37:10 -0400 Date: Mon, 10 Jun 2019 18:37:07 +0300 Message-Id: <837e9tbgf0.fsf@gnu.org> From: Eli Zaretskii To: Alex Branham In-reply-to: <878su9tv4x.fsf@gmail.com> (message from Alex Branham on Mon, 10 Jun 2019 08:41:50 -0500) Subject: Re: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff References: <878su9tv4x.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36157 Cc: 36157@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alex Branham > Date: Mon, 10 Jun 2019 08:41:50 -0500 > Cc: 36157@debbugs.gnu.org > > > It seems like properly enabling lexical binding in ediff will be a bit > > tricky. > > > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Indeed, it looks like portions of ediff expect symbols like file-A and > file-B to be dynamically bound, but also passes them through as > arguments to functions. I'm not sure what the best way to deal with this > is, since if we just mark them as special the lexical binding will > shadow the global binding anyway. > > In the meantime, feel free to revert that patch if its causing issues. If there are no ideas how to fix this in a week or so, I suggest to revert the changeset while we consider the possible solutions, and add a comment that converting these files to lexical-binding is hairy. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 22:26:57 2019 Received: (at 36157) by debbugs.gnu.org; 11 Jun 2019 02:26:57 +0000 Received: from localhost ([127.0.0.1]:57747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haWUz-0000PG-9i for submit@debbugs.gnu.org; Mon, 10 Jun 2019 22:26:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haWUx-0000P2-K0 for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 22:26:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haWUs-0002TJ-8C; Mon, 10 Jun 2019 22:26:50 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1haWUk-0006Ia-CF; Mon, 10 Jun 2019 22:26:44 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Kaushal Modi In-Reply-To: (message from Kaushal Modi on Sun, 9 Jun 2019 23:21:20 -0400) Subject: Re: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff References: Message-Id: Date: Mon, 10 Jun 2019 22:26:42 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36157 Cc: alex.branham@gmail.com, 36157@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > If you look at the code of ediff-find-file, you will see the use of > `symbol-value' everywhere. Which variables would this operate on? If they are file-local variables, won't they have to be dynamic? Perhaps that code need not be concerned about lexical bindings. (Someone should check this for security too.) -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 14 14:37:07 2019 Received: (at 36157) by debbugs.gnu.org; 14 Jun 2019 18:37:07 +0000 Received: from localhost ([127.0.0.1]:37786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbr4U-0005tk-RL for submit@debbugs.gnu.org; Fri, 14 Jun 2019 14:37:07 -0400 Received: from mail-ot1-f47.google.com ([209.85.210.47]:43231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbr4S-0005tC-S9 for 36157@debbugs.gnu.org; Fri, 14 Jun 2019 14:37:05 -0400 Received: by mail-ot1-f47.google.com with SMTP id i8so3538488oth.10 for <36157@debbugs.gnu.org>; Fri, 14 Jun 2019 11:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=bSBbrr/kdptUJOWgJkpTHvg1t5SKSRzQUfiPsZ1jazw=; b=H/1hvtgg/Ua8QCvwjp30ArjnYxjPPNngoLQJsVYIyr3pQ9r/adZlAPP1KXxI0oaR4I wW/2TvhKNSwyo/ZiGvuPzH/C+VElHQw9BB7j3LUwVojS3ABFiHKH7faU7/OhFDnqZmax iHDdi5V3OepfMKdO+f9z9N/NcZJwu8IAIiMuDjCFOxa8T/nAeJZFiCTR6YdzQOTLuFOy 7qOBxGFncDIL4jOx+rhTARK5V6sCOt/VIgP1591aElYHEoBn4AJjcZj44ItmO54UbARy sKOhA4xVnZWYkqbwsrYrR0uTbxX/Gup+Zq0Leq3wCg/gmLjGkYNCzdcv4veuxTO2VgzM ItKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=bSBbrr/kdptUJOWgJkpTHvg1t5SKSRzQUfiPsZ1jazw=; b=OZH8yfVk8Mwsf4IN1bhfuBkMbTq35Ebfhv2kKQpzEhjjhLNeUgxV2eYVoo7egeq+il WIWam7NmKkNr7Ao892MiDgILjOTL/t6vLe4o1uOewXkHx9K+re2UI6pj2OCMJPu8PdWy xzbH3c03ThKLwk9vqzPzXMpMl11ZrgYeSUxGR81YVIzn4dB7d8MGjB3NkNPHwi/qgQ3p 7SKm8uERx0n0kT5A91xdmAlk0tJ5EbqZr+aBkGBt54XiOFiHX/8SbD24cXnBwziFBirN 3Ft8h7TVbWSpjBFBV9e9BzHF7Q4HNaXI4rmFtIGZq+Wl5RqHQo3W4lETJyQNTeRnsiga qmow== X-Gm-Message-State: APjAAAX+lTiL+fQSP6TKahmKvc/S5JHYScUt88Rr5XO+nNJg1OlV2eoI vLgWimopE3PukZsk4Lpjphpiycty X-Google-Smtp-Source: APXvYqxSBN8casXs4jOwRK2o2YE9OGfHoW1qj0yp3hva0owhajufh/MLYPqz+hTyYgcj4Rgrmbs/XQ== X-Received: by 2002:a9d:5d10:: with SMTP id b16mr19187726oti.35.1560537418743; Fri, 14 Jun 2019 11:36:58 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id d17sm1419133otl.52.2019.06.14.11.36.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 11:36:57 -0700 (PDT) References: User-agent: mu4e 1.2.0; emacs 27.0.50 From: Alex Branham To: rms@gnu.org Subject: Re: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff In-reply-to: Date: Fri, 14 Jun 2019 13:36:57 -0500 Message-ID: <87r27wqaie.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36157 Cc: 36157@debbugs.gnu.org, Kaushal Modi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon 10 Jun 2019 at 21:26, Richard Stallman wrote: > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Which variables would this operate on? I'm not 100% sure what you're asking here, but ediff uses variables to store information and then passes those to functions. So in one function it'll do something like this: (setq file-A "/path/to/foo.el") (setq buff-A (get-buffer-create "foo.el")) (ediff-find-file file-A buff-A) And then ediff-find-file uses (symbol-value 'file-A) to get the string back. This breaks under lexical binding since the file-A argument shadows the file-A global value. I think it would be relatively easy to fix by just passing the values themselves, but that'll break backwards compatibility if people outside Emacs are relying on calling ediff functions this way. Hope that clears things up, Alex From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 22:35:50 2019 Received: (at 36157) by debbugs.gnu.org; 16 Jun 2019 02:35:50 +0000 Received: from localhost ([127.0.0.1]:39493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcL1K-0006Mf-GV for submit@debbugs.gnu.org; Sat, 15 Jun 2019 22:35:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcL1I-0006MS-DW for 36157@debbugs.gnu.org; Sat, 15 Jun 2019 22:35:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hcL1D-0002jA-7x; Sat, 15 Jun 2019 22:35:43 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hcL0r-0001dZ-G6; Sat, 15 Jun 2019 22:35:22 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Alex Branham In-Reply-To: <87r27wqaie.fsf@gmail.com> (message from Alex Branham on Fri, 14 Jun 2019 13:36:57 -0500) Subject: Re: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff References: <87r27wqaie.fsf@gmail.com> Message-Id: Date: Sat, 15 Jun 2019 22:35:21 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36157 Cc: 36157@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > I'm not 100% sure what you're asking here, but ediff uses variables to > store information and then passes those to functions. So in one function > it'll do something like this: > (setq file-A "/path/to/foo.el") > (setq buff-A (get-buffer-create "foo.el")) > (ediff-find-file file-A buff-A) It should add prefixes to those variable names, to avoid conflict. Then it could defvar those variables to make them always-dynamic. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 12:36:10 2019 Received: (at control) by debbugs.gnu.org; 18 Jun 2019 16:36:10 +0000 Received: from localhost ([127.0.0.1]:45497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdH5e-0007k0-Iz for submit@debbugs.gnu.org; Tue, 18 Jun 2019 12:36:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdH5c-0007ji-3h for control@debbugs.gnu.org; Tue, 18 Jun 2019 12:36:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdH5O-0002SK-RV for control@debbugs.gnu.org; Tue, 18 Jun 2019 12:35:56 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hdH5I-0005bz-Nh for control@debbugs.gnu.org; Tue, 18 Jun 2019 12:35:52 -0400 Subject: control message for bug 36281 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 18 Jun 2019 12:35:48 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 36157 36281 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 19:05:35 2019 Received: (at 36157-done) by debbugs.gnu.org; 18 Jun 2019 23:05:35 +0000 Received: from localhost ([127.0.0.1]:45709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdNAV-0003Ms-DW for submit@debbugs.gnu.org; Tue, 18 Jun 2019 19:05:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdNAU-0003Mg-2l for 36157-done@debbugs.gnu.org; Tue, 18 Jun 2019 19:05:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdNAP-00076P-0q for 36157-done@debbugs.gnu.org; Tue, 18 Jun 2019 19:05:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hdNAM-0006cb-3T; Tue, 18 Jun 2019 19:05:26 -0400 From: Glenn Morris To: 36157-done@debbugs.gnu.org Subject: Re: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff References: <878su9tv4x.fsf@gmail.com> <837e9tbgf0.fsf@gnu.org> X-Spook: Leuken-Baden Palestine Liberation Front Taliban smuggle X-Ran: zu&JBp:uV8{LTpDFg5g\lNc?xvq6rr^|}{#!eIXT"E5+_2HOLq5>+~pGB0}'#:3pZ7teu2 X-Hue: green X-Attribution: GM Date: Tue, 18 Jun 2019 19:05:25 -0400 In-Reply-To: <837e9tbgf0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 Jun 2019 18:37:07 +0300") Message-ID: <5na7eeo5oq.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36157-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii wrote: > If there are no ideas how to fix this in a week or so, I suggest to > revert the changeset while we consider the possible solutions, Done in ef23c8b. From unknown Sun Jun 22 17:13:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Jul 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator