GNU bug report logs - #36156
[PATCH] Make toolbar show keyboard equivalents in its tooltips

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36156 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips
Date: Sun, 25 Aug 2019 14:58:42 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable
> text?

I think so, because we do this above (quoted to avoid gmail mangling the code):

>  /* Get the caption of the item.  If the caption is not a string,
>     evaluate it to get a string.  If we don't get a string, skip this
>     item.  */
>  caption = XCAR (item);
>  if (!STRINGP (caption))
>    {
>      caption = menu_item_eval_property (caption);
>      if (!STRINGP (caption))
>    return 0;
>    }
>  set_prop (TOOL_BAR_ITEM_CAPTION, caption);

When this function returns 0, we don't append this item to the items
that will be displayed.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.