Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips

From: Noam Postavsky <[email-masked]>
Date: Sun, 09 Jun 2019 22:06:31 -0400

Stefan Kangas <[email-masked]> writes:

> I have implemented the following item from etc/TODO:
>
> ** The toolbar should show keyboard equivalents in its tooltips.
>
> I'm an absolute beginner to Emacs internals and had a lot of fun
> solving this.  Please let me know what you think.

> +      set_prop (TOOL_BAR_ITEM_HELP, concat4 (orig, beg, desc, end));

Instead of introducing concat4, you should be able to use

    CALLN (Fconcat, orig, beg, desc, end)