From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 21:14:29 2019 Received: (at submit) by debbugs.gnu.org; 10 Jun 2019 01:14:29 +0000 Received: from localhost ([127.0.0.1]:55674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8tI-00016D-V5 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 21:14:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8tH-000165-0E for submit@debbugs.gnu.org; Sun, 09 Jun 2019 21:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45269) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha8tG-00055u-4Y for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ha8tF-00030E-7p for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:26 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ha8tF-0002zr-0q for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:25 -0400 Received: by mail-wr1-f43.google.com with SMTP id d18so7416241wrs.5 for ; Sun, 09 Jun 2019 18:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=wPZWvbnloGcsftahcEuY4zeIT4QqgQR53rXScUEzu34=; b=Dg871TcQ+94ZvXuAocRWdBcjwOsIqwMBVfssK1UMAWqHwM99KneJUNbkvsVfYtdKU3 2e3w4AOYqkGt+e57gQiZDWCXgVdf0SfFSaVCukpCMbwvOIXg/vV1z+HfbGrBP7hD6/BX s6Rk8AEDzUx11mm1I43NNkghX3LZ0A87UTsKv7GaOvjnsVtN4DkkWoXwmC1oQCdKGaJp nqKBCKWGne0eAzw6dmOGLiqt2Poyp4MknvPJaH3huueF32qCBrwnYsUkqTYCA8j0tFPc smqELGWWyBqlmSOE3SYuPO8/LAa+VznTJMDFWfT+Zqc6sVbnRse962phJJlxUg32JdZf 2J6Q== X-Gm-Message-State: APjAAAUSLcZAQwXVKZ5ccPfDE7FhGHxLTXBEI2ruCSj7tCSH169tgu4H X9vqoIfPJuItOgJcNlmWRnAb4Zu3t63f6gBPwwyLYA== X-Google-Smtp-Source: APXvYqx99tTX+qrgbwhDTvOKSFUHsko28MXn1bTc56hf2nTrD8odGRTCUchL087xXINv1KRxuL/fMOFttzYDFFZwwYM= X-Received: by 2002:adf:90c3:: with SMTP id i61mr26921765wri.48.1560129263513; Sun, 09 Jun 2019 18:14:23 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Mon, 10 Jun 2019 03:14:12 +0200 Message-ID: Subject: [PATCH] Make toolbar show keyboard equivalents in its tooltips To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000008e4e1f058aede687" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.43 X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --0000000000008e4e1f058aede687 Content-Type: text/plain; charset="UTF-8" I have implemented the following item from etc/TODO: ** The toolbar should show keyboard equivalents in its tooltips. I'm an absolute beginner to Emacs internals and had a lot of fun solving this. Please let me know what you think. Thanks, Stefan Kangas --0000000000008e4e1f058aede687 Content-Type: application/octet-stream; name="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Disposition: attachment; filename="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwpon4pi0 RnJvbSAwODJmNjQwNTMzNGQ0Y2ZmYWE3N2NmMTdkY2NiM2U2NGU5MjNjZGZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDQ6Mjc6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIHRvb2xiYXIgc2hvdyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMKCiog c3JjL2tleWJvYXJkLmMgKHBhcnNlX3Rvb2xfYmFyX2l0ZW0pOiBBZGQgZXF1aXZhbGVudCBrZXkg YmluZGluZyB0bwp0aGUgdG9vbHRpcCBzdHJpbmcgb2YgdG9vbGJhciBidXR0b25zLgoqIGV0Yy9O RVdTOiBBbm5vdW5jZSBpdC4KKiBldGMvVE9ETzogUmVtb3ZlIGl0cyBlbnRyeS4KKiBzcmMvZm5z LmMgKGNvbmNhdDQpOiBOZXcgZnVuY3Rpb24uCiogc3JjL2xpc3AuaCAoY29uY2F0NCk6IERlY2xh cmUuCi0tLQogZXRjL05FV1MgICAgICAgfCAgMyArKysKIGV0Yy9UT0RPICAgICAgIHwgIDIgLS0K IHNyYy9mbnMuYyAgICAgIHwgIDcgKysrKysrKwogc3JjL2tleWJvYXJkLmMgfCAxMyArKysrKysr KysrKysrCiBzcmMvbGlzcC5oICAgICB8ICAxICsKIDUgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT CmluZGV4IGM5ZGE5OGIwYWQuLjc3MjY0NDM1NTEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBi L2V0Yy9ORVdTCkBAIC0xMjEsNiArMTIxLDkgQEAgVGhpcyBpcyBpbnRlbmRlZCBtb3N0bHkgdG8g aGVscCBkZXZlbG9wZXJzLgogKiogRW1hY3Mgbm93IHJlcXVpcmVzIEdUSyAyLjI0IGFuZCBHVEsg My4xMCBmb3IgdGhlIEdUSyAyIGFuZCBHVEsgMwogYnVpbGRzIHJlc3BlY3RpdmVseS4KIAorLS0t CisqKiBUaGUgdG9vbGJhciBub3cgc2hvd3MgdGhlIGVxdWl2YWxlbnQga2V5IGJpbmRpbmcgaW4g aXRzIHRvb2x0aXBzLgorCiAMCiAqIFN0YXJ0dXAgQ2hhbmdlcyBpbiBFbWFjcyAyNy4xCiAKZGlm ZiAtLWdpdCBhL2V0Yy9UT0RPIGIvZXRjL1RPRE8KaW5kZXggZjhjMmQyODVlZS4uYjljOGMwYWFl OSAxMDA2NDQKLS0tIGEvZXRjL1RPRE8KKysrIGIvZXRjL1RPRE8KQEAgLTE3Niw4ICsxNzYsNiBA QCBTZWUgdGhlICd0ZXN0JyBkaXJlY3RvcnkgZm9yIGV4YW1wbGVzLgogKiogSW4gRW1hY3MgSW5m bywgZXhhbXBsZXMgb2YgdXNpbmcgQ3VzdG9taXplIHNob3VsZCBiZSBjbGlja2FibGUKICAgIGFu ZCB0aGV5IHNob3VsZCBjcmVhdGUgQ3VzdG9tIGJ1ZmZlcnMuCiAKLSoqIFRoZSB0b29sYmFyIHNo b3VsZCBzaG93IGtleWJvYXJkIGVxdWl2YWxlbnRzIGluIGl0cyB0b29sdGlwcy4KLQogKiogQWRk IGZ1bmN0aW9uIHRvIHJlZHJhdyB0aGUgdG9vbCBiYXIuCiAKICoqIFJlZGVzaWduIHRoZSBsb2Fk LWhpc3RvcnkgZGF0YSBzdHJ1Y3R1cmUgc28gaXQgY2FuIGNvcGUgYmV0dGVyCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggZWFhMmMwN2ZiZS4uZjA4OTUwMzkzOSAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNTM2LDYgKzUzNiwxMyBAQCBj b25jYXQzIChMaXNwX09iamVjdCBzMSwgTGlzcF9PYmplY3QgczIsIExpc3BfT2JqZWN0IHMzKQog ICByZXR1cm4gY29uY2F0ICgzLCAoKExpc3BfT2JqZWN0IFtdKSB7czEsIHMyLCBzM30pLCBMaXNw X1N0cmluZywgMCk7CiB9CiAKKy8qIEFSR1NVU0VEICovCitMaXNwX09iamVjdAorY29uY2F0NCAo TGlzcF9PYmplY3QgczEsIExpc3BfT2JqZWN0IHMyLCBMaXNwX09iamVjdCBzMywgTGlzcF9PYmpl Y3QgczQpCit7CisgIHJldHVybiBjb25jYXQgKDQsICgoTGlzcF9PYmplY3QgW10pIHtzMSwgczIs IHMzLCBzNH0pLCBMaXNwX1N0cmluZywgMCk7Cit9CisKIERFRlVOICgiYXBwZW5kIiwgRmFwcGVu ZCwgU2FwcGVuZCwgMCwgTUFOWSwgMCwKICAgICAgICBkb2M6IC8qIENvbmNhdGVuYXRlIGFsbCB0 aGUgYXJndW1lbnRzIGFuZCBtYWtlIHRoZSByZXN1bHQgYSBsaXN0LgogVGhlIHJlc3VsdCBpcyBh IGxpc3Qgd2hvc2UgZWxlbWVudHMgYXJlIHRoZSBlbGVtZW50cyBvZiBhbGwgdGhlIGFyZ3VtZW50 cy4KZGlmZiAtLWdpdCBhL3NyYy9rZXlib2FyZC5jIGIvc3JjL2tleWJvYXJkLmMKaW5kZXggYmI0 ZDE4NWM5MS4uMDJhZTA1ZTA4ZCAxMDA2NDQKLS0tIGEvc3JjL2tleWJvYXJkLmMKKysrIGIvc3Jj L2tleWJvYXJkLmMKQEAgLTgyOTcsNiArODI5NywxOSBAQCBwYXJzZV90b29sX2Jhcl9pdGVtIChM aXNwX09iamVjdCBrZXksIExpc3BfT2JqZWN0IGl0ZW0pCiAgIGlmIChDT05TUCAoZ2V0X2tleW1h cCAoUFJPUCAoVE9PTF9CQVJfSVRFTV9CSU5ESU5HKSwgMCwgMSkpKQogICAgIHJldHVybiAwOwog CisgIC8qIElmIHRoZXJlIGlzIGEga2V5IGJpbmRpbmcsIGFkZCBpdCB0byB0aGUgaGVscCwgd2hp Y2ggd2lsbCBiZQorICAgICBkaXNwbGF5ZWQgYXMgYSB0b29sdGlwIGZvciB0aGlzIGVudHJ5LiAq LworICBMaXNwX09iamVjdCBiaW5kaW5nID0gUFJPUCAoVE9PTF9CQVJfSVRFTV9CSU5ESU5HKTsK KyAgTGlzcF9PYmplY3Qga2V5cyA9IEZ3aGVyZV9pc19pbnRlcm5hbCAoYmluZGluZywgUW5pbCwg UXQsIFFuaWwsIFFuaWwpOworICBpZiAoIU5JTFAgKGtleXMpKQorICAgIHsKKyAgICAgIEFVVE9f U1RSSU5HIChiZWcsICIgIFsiKTsKKyAgICAgIEFVVE9fU1RSSU5HIChlbmQsICJdIik7CisgICAg ICBMaXNwX09iamVjdCBvcmlnID0gUFJPUCAoVE9PTF9CQVJfSVRFTV9IRUxQKTsKKyAgICAgIExp c3BfT2JqZWN0IGRlc2MgPSBGa2V5X2Rlc2NyaXB0aW9uIChrZXlzLCBRbmlsKTsKKyAgICAgIHNl dF9wcm9wIChUT09MX0JBUl9JVEVNX0hFTFAsIGNvbmNhdDQgKG9yaWcsIGJlZywgZGVzYywgZW5k KSk7CisgICAgfQorCiAgIC8qIEVuYWJsZSBvciBkaXNhYmxlIHNlbGVjdGlvbiBvZiBpdGVtLiAg Ki8KICAgaWYgKCFFUSAoUFJPUCAoVE9PTF9CQVJfSVRFTV9FTkFCTEVEX1ApLCBRdCkpCiAgICAg c2V0X3Byb3AgKFRPT0xfQkFSX0lURU1fRU5BQkxFRF9QLApkaWZmIC0tZ2l0IGEvc3JjL2xpc3Au aCBiL3NyYy9saXNwLmgKaW5kZXggNzdmYzIyZDExOC4uNGZhZjlkMGJmMSAxMDA2NDQKLS0tIGEv c3JjL2xpc3AuaAorKysgYi9zcmMvbGlzcC5oCkBAIC0zNjEzLDYgKzM2MTMsNyBAQCAjZGVmaW5l IENPTlNfVE9fSU5URUdFUihjb25zLCB0eXBlLCB2YXIpCQkJCVwKIGV4dGVybiBMaXNwX09iamVj dCBkb195ZXNfb3Jfbm9fcCAoTGlzcF9PYmplY3QpOwogZXh0ZXJuIExpc3BfT2JqZWN0IGNvbmNh dDIgKExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCk7CiBleHRlcm4gTGlzcF9PYmplY3QgY29uY2F0 MyAoTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCk7CitleHRlcm4gTGlzcF9P YmplY3QgY29uY2F0NCAoTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwogZXh0ZXJuIGJvb2wgZXF1YWxfbm9fcXVpdCAoTGlzcF9PYmplY3QsIExpc3Bf T2JqZWN0KTsKIGV4dGVybiBMaXNwX09iamVjdCBuY29uYzIgKExpc3BfT2JqZWN0LCBMaXNwX09i amVjdCk7CiBleHRlcm4gTGlzcF9PYmplY3QgYXNzcV9ub19xdWl0IChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwotLSAKMi4yMS4wCgo= --0000000000008e4e1f058aede687-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 22:06:41 2019 Received: (at 36156) by debbugs.gnu.org; 10 Jun 2019 02:06:42 +0000 Received: from localhost ([127.0.0.1]:55705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha9hp-0002K1-LH for submit@debbugs.gnu.org; Sun, 09 Jun 2019 22:06:41 -0400 Received: from mail-it1-f174.google.com ([209.85.166.174]:51916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha9hm-0002Jn-Sb for 36156@debbugs.gnu.org; Sun, 09 Jun 2019 22:06:39 -0400 Received: by mail-it1-f174.google.com with SMTP id m3so10954496itl.1 for <36156@debbugs.gnu.org>; Sun, 09 Jun 2019 19:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5YAw1ACtBw1oYH0f10x8GyTqe9l9JmDmPntwKSIqcuQ=; b=Sg7aA3WX3QkehylwhV75wI32ysbF2m16CwGPyljQf1RFEIEIQW87yFWi/FyEclxcP2 0cpwlF5DcMS+eLxHzPHqN4SldWsYkao9F4fbyNpl1AelAOQQkv5B77IwnscbmiHTBVAu LaBN6a95nI/VfRM/NnXy0l5o0SATfP7pIW9dANur2uElXXkAUmSq8Eb+bu0SY7jJuFmk Sr8hCrFK2JQ2PGX3MpEKaQiAY7tdIlLqEiDoh5DCFsyD9RLnsRz5EtEQxiwBqti8GI3o wEzfDQfBqUUzKFinmZCBmjuIo5Qb6pFbVl/P20br8XCOuiymPrJviKR1xnoY7CMVAjSz u6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5YAw1ACtBw1oYH0f10x8GyTqe9l9JmDmPntwKSIqcuQ=; b=oSim0aMb3c2cQKEPVFHR7SeHTHA0klx0IiBHUl8YtmV2GktVg/hT2NLRJs1anDUb83 GUZO8wiYE8JYm2Fb0Lw12EwTdczd/IRs0ZxwQNyUEPCIgiDMWGa3XotKUvp5PJYimbw6 tZWPAAm7bylCSEcd2qYLTjI99mU1cjQZCG8y2OmiFlQFCzh8a3BZcV7+qhmaQGiAlnTa LMKI/C2FaunP76uDxsLhYLfQ3USnwutWxW76suvpE/UEso8HNV1g+t+wtoXhKcYCFFkD lUtwAa9Oa78nS7xavTdf05JlkMlmnMaF6OpCaAAABjMB5hJQNxCzt4m0v06ZiuSbgwHO UEdQ== X-Gm-Message-State: APjAAAXnd0KXwmOHv01aVPDWrCvkWLBYNVlfInLoGuWK/CobG/dYG8P3 FrBx2SIGufIPgQnQ01njdcZW9LeG X-Google-Smtp-Source: APXvYqzNadO6nD9f6nWI6QfbI1MFkiLtVzFBFC5+O5dvYnZcYLPEa43kB+ag9Y23AMWJgwo7rUXn4w== X-Received: by 2002:a24:610d:: with SMTP id s13mr12231525itc.156.1560132392709; Sun, 09 Jun 2019 19:06:32 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id 203sm4615578ite.4.2019.06.09.19.06.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jun 2019 19:06:32 -0700 (PDT) From: Noam Postavsky To: Stefan Kangas Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: Date: Sun, 09 Jun 2019 22:06:31 -0400 In-Reply-To: (Stefan Kangas's message of "Mon, 10 Jun 2019 03:14:12 +0200") Message-ID: <874l4y19eg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I have implemented the following item from etc/TODO: > > ** The toolbar should show keyboard equivalents in its tooltips. > > I'm an absolute beginner to Emacs internals and had a lot of fun > solving this. Please let me know what you think. > + set_prop (TOOL_BAR_ITEM_HELP, concat4 (orig, beg, desc, end)); Instead of introducing concat4, you should be able to use CALLN (Fconcat, orig, beg, desc, end) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 23:30:40 2019 Received: (at 36156) by debbugs.gnu.org; 10 Jun 2019 03:30:40 +0000 Received: from localhost ([127.0.0.1]:55779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haB15-0006RY-Qz for submit@debbugs.gnu.org; Sun, 09 Jun 2019 23:30:40 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:45064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haB14-0006RL-A2 for 36156@debbugs.gnu.org; Sun, 09 Jun 2019 23:30:38 -0400 Received: by mail-wr1-f45.google.com with SMTP id f9so7569373wre.12 for <36156@debbugs.gnu.org>; Sun, 09 Jun 2019 20:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXxKRIPcjepda9Kl9YsFfmhy3OvRYbn62TsyKDzVHSc=; b=tXt7YMmLTIjarb7VJjVYicvd2gsT7XM/FwrYK5NiGhQA5mk4dIgnhzRhUuVTv4L3i3 STFFI+WB9TNZMpmsZ60Q+jCmNyGrxR5sVgWEtkwUD5gOxJfrZ2c1dv2btiosCIEXguOY ornfvvMVZZvodBiTLEcmcK5SsMOwaNypOgKEByzvxHjts7sYpY07OVSlo4pci+obQ5Mn CASc6bbLK91ztdp8Q8GHp1GgvpZ2phChk6OAmTfUip8WiqIgImyYx7U5SSS/PlNUvbOl IZxow3QF56bW9vMUFuGraQiqNTtezskio2IFu2T1ZQ/LX/PrAMT6HKczV1rdEvfaFmGB w/cw== X-Gm-Message-State: APjAAAW0XGqGF2zuleXQjPLcQrNmZU+vz6w+eWQnn1NNnIv/aq+DsCs9 osMC/1NsFVzJZcWVtNyradBJ5ooztADQv1D3Huo= X-Google-Smtp-Source: APXvYqwbmpuAMFUFFkdkj+WJaQIy29Ne5KJ3+v9/d7meI/GOTxmWbcSW5nwPeKlArXEagOuwz1yNuZZCqPwp08qvcQE= X-Received: by 2002:adf:90c3:: with SMTP id i61mr27206739wri.48.1560137432446; Sun, 09 Jun 2019 20:30:32 -0700 (PDT) MIME-Version: 1.0 References: <874l4y19eg.fsf@gmail.com> In-Reply-To: <874l4y19eg.fsf@gmail.com> From: Stefan Kangas Date: Mon, 10 Jun 2019 05:30:20 +0200 Message-ID: Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000765b1f058aefcd86" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000765b1f058aefcd86 Content-Type: text/plain; charset="UTF-8" Noam Postavsky writes: > > + set_prop (TOOL_BAR_ITEM_HELP, concat4 (orig, beg, desc, end)); > > Instead of introducing concat4, you should be able to use > > CALLN (Fconcat, orig, beg, desc, end) That worked, thanks. I've attached an updated patch. Best regards, Stefan Kangas --000000000000765b1f058aefcd86 Content-Type: application/octet-stream; name="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Disposition: attachment; filename="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwptj0b80 RnJvbSBjYTk2NWRlY2MyNWE1ZDdhNjY4ZmEzNWMxOTEwZmIzNTNlM2M5Y2Q1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDQ6Mjc6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIHRvb2xiYXIgc2hvdyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMKCiog c3JjL2tleWJvYXJkLmMgKHBhcnNlX3Rvb2xfYmFyX2l0ZW0pOiBBZGQgZXF1aXZhbGVudCBrZXkg YmluZGluZyB0bwp0aGUgdG9vbHRpcCBzdHJpbmcgb2YgdG9vbGJhciBidXR0b25zLgoqIGV0Yy9O RVdTOiBBbm5vdW5jZSBpdC4KKiBldGMvVE9ETzogUmVtb3ZlIGl0cyBlbnRyeS4KLS0tCiBldGMv TkVXUyAgICAgICB8ICAzICsrKwogZXRjL1RPRE8gICAgICAgfCAgMiAtLQogc3JjL2tleWJvYXJk LmMgfCAxMyArKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBj OWRhOThiMGFkLi43NzI2NDQzNTUxIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVX UwpAQCAtMTIxLDYgKzEyMSw5IEBAIFRoaXMgaXMgaW50ZW5kZWQgbW9zdGx5IHRvIGhlbHAgZGV2 ZWxvcGVycy4KICoqIEVtYWNzIG5vdyByZXF1aXJlcyBHVEsgMi4yNCBhbmQgR1RLIDMuMTAgZm9y IHRoZSBHVEsgMiBhbmQgR1RLIDMKIGJ1aWxkcyByZXNwZWN0aXZlbHkuCiAKKy0tLQorKiogVGhl IHRvb2xiYXIgbm93IHNob3dzIHRoZSBlcXVpdmFsZW50IGtleSBiaW5kaW5nIGluIGl0cyB0b29s dGlwcy4KKwogDAogKiBTdGFydHVwIENoYW5nZXMgaW4gRW1hY3MgMjcuMQogCmRpZmYgLS1naXQg YS9ldGMvVE9ETyBiL2V0Yy9UT0RPCmluZGV4IGY4YzJkMjg1ZWUuLmI5YzhjMGFhZTkgMTAwNjQ0 Ci0tLSBhL2V0Yy9UT0RPCisrKyBiL2V0Yy9UT0RPCkBAIC0xNzYsOCArMTc2LDYgQEAgU2VlIHRo ZSAndGVzdCcgZGlyZWN0b3J5IGZvciBleGFtcGxlcy4KICoqIEluIEVtYWNzIEluZm8sIGV4YW1w bGVzIG9mIHVzaW5nIEN1c3RvbWl6ZSBzaG91bGQgYmUgY2xpY2thYmxlCiAgICBhbmQgdGhleSBz aG91bGQgY3JlYXRlIEN1c3RvbSBidWZmZXJzLgogCi0qKiBUaGUgdG9vbGJhciBzaG91bGQgc2hv dyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMuCi0KICoqIEFkZCBmdW5jdGlv biB0byByZWRyYXcgdGhlIHRvb2wgYmFyLgogCiAqKiBSZWRlc2lnbiB0aGUgbG9hZC1oaXN0b3J5 IGRhdGEgc3RydWN0dXJlIHNvIGl0IGNhbiBjb3BlIGJldHRlcgpkaWZmIC0tZ2l0IGEvc3JjL2tl eWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRleCBiYjRkMTg1YzkxLi43MDdjNDAwYjdkIDEw MDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMva2V5Ym9hcmQuYwpAQCAtODI5Nyw2 ICs4Mjk3LDE5IEBAIHBhcnNlX3Rvb2xfYmFyX2l0ZW0gKExpc3BfT2JqZWN0IGtleSwgTGlzcF9P YmplY3QgaXRlbSkKICAgaWYgKENPTlNQIChnZXRfa2V5bWFwIChQUk9QIChUT09MX0JBUl9JVEVN X0JJTkRJTkcpLCAwLCAxKSkpCiAgICAgcmV0dXJuIDA7CiAKKyAgLyogSWYgdGhlcmUgaXMgYSBr ZXkgYmluZGluZywgYWRkIGl0IHRvIHRoZSBoZWxwLCB3aGljaCB3aWxsIGJlCisgICAgIGRpc3Bs YXllZCBhcyBhIHRvb2x0aXAgZm9yIHRoaXMgZW50cnkuICovCisgIExpc3BfT2JqZWN0IGJpbmRp bmcgPSBQUk9QIChUT09MX0JBUl9JVEVNX0JJTkRJTkcpOworICBMaXNwX09iamVjdCBrZXlzID0g RndoZXJlX2lzX2ludGVybmFsIChiaW5kaW5nLCBRbmlsLCBRdCwgUW5pbCwgUW5pbCk7CisgIGlm ICghTklMUCAoa2V5cykpCisgICAgeworICAgICAgQVVUT19TVFJJTkcgKGJlZywgIiAgWyIpOwor ICAgICAgQVVUT19TVFJJTkcgKGVuZCwgIl0iKTsKKyAgICAgIExpc3BfT2JqZWN0IG9yaWcgPSBQ Uk9QIChUT09MX0JBUl9JVEVNX0hFTFApOworICAgICAgTGlzcF9PYmplY3QgZGVzYyA9IEZrZXlf ZGVzY3JpcHRpb24gKGtleXMsIFFuaWwpOworICAgICAgc2V0X3Byb3AgKFRPT0xfQkFSX0lURU1f SEVMUCwgQ0FMTE4gKEZjb25jYXQsIG9yaWcsIGJlZywgZGVzYywgZW5kKSk7CisgICAgfQorCiAg IC8qIEVuYWJsZSBvciBkaXNhYmxlIHNlbGVjdGlvbiBvZiBpdGVtLiAgKi8KICAgaWYgKCFFUSAo UFJPUCAoVE9PTF9CQVJfSVRFTV9FTkFCTEVEX1ApLCBRdCkpCiAgICAgc2V0X3Byb3AgKFRPT0xf QkFSX0lURU1fRU5BQkxFRF9QLAotLSAKMi4yMS4wCgo= --000000000000765b1f058aefcd86-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 12:54:58 2019 Received: (at 36156) by debbugs.gnu.org; 10 Jun 2019 16:54:58 +0000 Received: from localhost ([127.0.0.1]:57430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haNZR-0007Di-RQ for submit@debbugs.gnu.org; Mon, 10 Jun 2019 12:54:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haNZQ-0007DX-IP for 36156@debbugs.gnu.org; Mon, 10 Jun 2019 12:54:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haNZL-0003u8-73; Mon, 10 Jun 2019 12:54:51 -0400 Received: from [176.228.60.248] (port=3535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1haNZK-0005vX-K4; Mon, 10 Jun 2019 12:54:51 -0400 Date: Mon, 10 Jun 2019 19:54:47 +0300 Message-Id: <83v9xd9y94.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Mon, 10 Jun 2019 05:30:20 +0200) Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: <874l4y19eg.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 10 Jun 2019 05:30:20 +0200 > Cc: 36156@debbugs.gnu.org > > + Lisp_Object binding = PROP (TOOL_BAR_ITEM_BINDING); > + Lisp_Object keys = Fwhere_is_internal (binding, Qnil, Qt, Qnil, Qnil); > + if (!NILP (keys)) > + { > + AUTO_STRING (beg, " ["); > + AUTO_STRING (end, "]"); This is going to start a bikeshedding, but I'm not sure I like the [FOO] format. It's different from what we use in menus, for example. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 17:29:11 2019 Received: (at 36156) by debbugs.gnu.org; 11 Jun 2019 21:29:11 +0000 Received: from localhost ([127.0.0.1]:60295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haoKN-0007yr-1Z for submit@debbugs.gnu.org; Tue, 11 Jun 2019 17:29:11 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:34039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haoKJ-0007yd-W8 for 36156@debbugs.gnu.org; Tue, 11 Jun 2019 17:29:08 -0400 Received: by mail-wr1-f45.google.com with SMTP id e16so14638570wrn.1 for <36156@debbugs.gnu.org>; Tue, 11 Jun 2019 14:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHu8W3tSUVkOrGjLRD36MGuXw1Q819poVGk2izDu91A=; b=Yh643USX2DMhbh/oB7j6b3T9fmfqGQUltx+jpaPfoHi94MJWJlNf9Dz+gV9aTzCVrL adKMKTOaxKeRR8pbG5e2XT2Qyh547yNL0KnEJLbRn9of+nVHkwA61YKyecHeOgPtzqUR SzFz3HwgussP0gWFrdWLuf6UAPCPAvzR9SLh+nII6jHTUhifK4imkfvSS54wur0ySOE8 avvtFjsYMm6oW/9SzqbZgDDPSaLkWBJgO1afBSw1S9i7s4+A6JHqRGfhL1Sq8OujgBoZ nccu0BctD+dNE0EO07uCNSPB5Gj3T/4Qi86175kVreqAnjJ0nHFbGNYSn0indyRs+yBu 398w== X-Gm-Message-State: APjAAAUQFBC02DBB+hNJkk4Qa+pKSNs1rbDrmxyRY8WCI8QMhSI1s9hy ziiMJ7gBT6SuXuCtjFrF56/aHGzNHr+nRRmUlL8= X-Google-Smtp-Source: APXvYqwysSNV34qpl8TsWYWI0FyCvWFF83vkVFA5r+nOjMKRmAAz+hE39eDi5eXeDG7N/JXW3Bb8DRFPRnRMLyp9RoY= X-Received: by 2002:a05:6000:1285:: with SMTP id f5mr11009886wrx.85.1560288542203; Tue, 11 Jun 2019 14:29:02 -0700 (PDT) MIME-Version: 1.0 References: <874l4y19eg.fsf@gmail.com> <83v9xd9y94.fsf@gnu.org> In-Reply-To: <83v9xd9y94.fsf@gnu.org> From: Stefan Kangas Date: Tue, 11 Jun 2019 23:28:50 +0200 Message-ID: Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000004e4edd058b12fced" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000004e4edd058b12fced Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > This is going to start a bikeshedding, but I'm not sure I like the > [FOO] format. It's different from what we use in menus, for example. FWIW, I tried both with brackets and parentheses and concluded that the former is more readable, especially in cases where we also use parentheses in the tooltip string. Also, I'm not sure how important consistency with menus are here, since the parentheses are not shown on my GTK Emacs -- the key binding is displayed to the right. On macOS, the key binding is indeed shown in parentheses (but it would be better, IMO, if it was also here displayed to the right with no parentheses). Not sure what happens in other toolkits. That said, I'm fine either way. I have attached a patch which uses parentheses instead of brackets. Please feel free too install whichever version you prefer more. And do it quick before anyone has time to start bikeshedding... ;) Thanks, Stefan Kangas --0000000000004e4edd058b12fced Content-Type: application/octet-stream; name="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti-3.patch" Content-Disposition: attachment; filename="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti-3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwsbexe80 RnJvbSBkMTIzOWMyNmE5MDNkMzY1NGM2NDkwYjUyZDBkZWZiYzM5NjYxNWJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDQ6Mjc6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIHRvb2xiYXIgc2hvdyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMKCiog c3JjL2tleWJvYXJkLmMgKHBhcnNlX3Rvb2xfYmFyX2l0ZW0pOiBBZGQgZXF1aXZhbGVudCBrZXkg YmluZGluZyB0bwp0aGUgdG9vbHRpcCBzdHJpbmcgb2YgdG9vbGJhciBidXR0b25zLgoqIGV0Yy9O RVdTOiBBbm5vdW5jZSBpdC4KKiBldGMvVE9ETzogUmVtb3ZlIGl0cyBlbnRyeS4KLS0tCiBldGMv TkVXUyAgICAgICB8ICAzICsrKwogZXRjL1RPRE8gICAgICAgfCAgMiAtLQogc3JjL2tleWJvYXJk LmMgfCAxMyArKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBj OWRhOThiMGFkLi43NzI2NDQzNTUxIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVX UwpAQCAtMTIxLDYgKzEyMSw5IEBAIFRoaXMgaXMgaW50ZW5kZWQgbW9zdGx5IHRvIGhlbHAgZGV2 ZWxvcGVycy4KICoqIEVtYWNzIG5vdyByZXF1aXJlcyBHVEsgMi4yNCBhbmQgR1RLIDMuMTAgZm9y IHRoZSBHVEsgMiBhbmQgR1RLIDMKIGJ1aWxkcyByZXNwZWN0aXZlbHkuCiAKKy0tLQorKiogVGhl IHRvb2xiYXIgbm93IHNob3dzIHRoZSBlcXVpdmFsZW50IGtleSBiaW5kaW5nIGluIGl0cyB0b29s dGlwcy4KKwogDAogKiBTdGFydHVwIENoYW5nZXMgaW4gRW1hY3MgMjcuMQogCmRpZmYgLS1naXQg YS9ldGMvVE9ETyBiL2V0Yy9UT0RPCmluZGV4IGY4YzJkMjg1ZWUuLmI5YzhjMGFhZTkgMTAwNjQ0 Ci0tLSBhL2V0Yy9UT0RPCisrKyBiL2V0Yy9UT0RPCkBAIC0xNzYsOCArMTc2LDYgQEAgU2VlIHRo ZSAndGVzdCcgZGlyZWN0b3J5IGZvciBleGFtcGxlcy4KICoqIEluIEVtYWNzIEluZm8sIGV4YW1w bGVzIG9mIHVzaW5nIEN1c3RvbWl6ZSBzaG91bGQgYmUgY2xpY2thYmxlCiAgICBhbmQgdGhleSBz aG91bGQgY3JlYXRlIEN1c3RvbSBidWZmZXJzLgogCi0qKiBUaGUgdG9vbGJhciBzaG91bGQgc2hv dyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMuCi0KICoqIEFkZCBmdW5jdGlv biB0byByZWRyYXcgdGhlIHRvb2wgYmFyLgogCiAqKiBSZWRlc2lnbiB0aGUgbG9hZC1oaXN0b3J5 IGRhdGEgc3RydWN0dXJlIHNvIGl0IGNhbiBjb3BlIGJldHRlcgpkaWZmIC0tZ2l0IGEvc3JjL2tl eWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRleCBiYjRkMTg1YzkxLi42YTYyOTU3ZjNlIDEw MDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMva2V5Ym9hcmQuYwpAQCAtODI5Nyw2 ICs4Mjk3LDE5IEBAIHBhcnNlX3Rvb2xfYmFyX2l0ZW0gKExpc3BfT2JqZWN0IGtleSwgTGlzcF9P YmplY3QgaXRlbSkKICAgaWYgKENPTlNQIChnZXRfa2V5bWFwIChQUk9QIChUT09MX0JBUl9JVEVN X0JJTkRJTkcpLCAwLCAxKSkpCiAgICAgcmV0dXJuIDA7CiAKKyAgLyogSWYgdGhlcmUgaXMgYSBr ZXkgYmluZGluZywgYWRkIGl0IHRvIHRoZSBoZWxwLCB3aGljaCB3aWxsIGJlCisgICAgIGRpc3Bs YXllZCBhcyBhIHRvb2x0aXAgZm9yIHRoaXMgZW50cnkuICovCisgIExpc3BfT2JqZWN0IGJpbmRp bmcgPSBQUk9QIChUT09MX0JBUl9JVEVNX0JJTkRJTkcpOworICBMaXNwX09iamVjdCBrZXlzID0g RndoZXJlX2lzX2ludGVybmFsIChiaW5kaW5nLCBRbmlsLCBRdCwgUW5pbCwgUW5pbCk7CisgIGlm ICghTklMUCAoa2V5cykpCisgICAgeworICAgICAgQVVUT19TVFJJTkcgKGJlZywgIiAgKCIpOwor ICAgICAgQVVUT19TVFJJTkcgKGVuZCwgIikiKTsKKyAgICAgIExpc3BfT2JqZWN0IG9yaWcgPSBQ Uk9QIChUT09MX0JBUl9JVEVNX0hFTFApOworICAgICAgTGlzcF9PYmplY3QgZGVzYyA9IEZrZXlf ZGVzY3JpcHRpb24gKGtleXMsIFFuaWwpOworICAgICAgc2V0X3Byb3AgKFRPT0xfQkFSX0lURU1f SEVMUCwgQ0FMTE4gKEZjb25jYXQsIG9yaWcsIGJlZywgZGVzYywgZW5kKSk7CisgICAgfQorCiAg IC8qIEVuYWJsZSBvciBkaXNhYmxlIHNlbGVjdGlvbiBvZiBpdGVtLiAgKi8KICAgaWYgKCFFUSAo UFJPUCAoVE9PTF9CQVJfSVRFTV9FTkFCTEVEX1ApLCBRdCkpCiAgICAgc2V0X3Byb3AgKFRPT0xf QkFSX0lURU1fRU5BQkxFRF9QLAotLSAKMi4yMS4wCgo= --0000000000004e4edd058b12fced-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 05:13:43 2019 Received: (at 36156-done) by debbugs.gnu.org; 22 Jun 2019 09:13:43 +0000 Received: from localhost ([127.0.0.1]:50958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hec5e-0004Gy-So for submit@debbugs.gnu.org; Sat, 22 Jun 2019 05:13:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hec5d-0004Gk-Gl for 36156-done@debbugs.gnu.org; Sat, 22 Jun 2019 05:13:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hec5Y-0001Xx-Af; Sat, 22 Jun 2019 05:13:36 -0400 Received: from [176.228.60.248] (port=2793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hec5X-0007OK-CG; Sat, 22 Jun 2019 05:13:36 -0400 Date: Sat, 22 Jun 2019 12:13:29 +0300 Message-Id: <83muianft2.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 11 Jun 2019 23:28:50 +0200) Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: <874l4y19eg.fsf@gmail.com> <83v9xd9y94.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36156-done Cc: 36156-done@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 11 Jun 2019 23:28:50 +0200 > Cc: Noam Postavsky , 36156@debbugs.gnu.org > > Eli Zaretskii writes: > > This is going to start a bikeshedding, but I'm not sure I like the > > [FOO] format. It's different from what we use in menus, for example. > > FWIW, I tried both with brackets and parentheses and concluded > that the former is more readable, especially in cases where we > also use parentheses in the tooltip string. > > Also, I'm not sure how important consistency with menus are here, > since the parentheses are not shown on my GTK Emacs -- the key > binding is displayed to the right. On macOS, the key binding is > indeed shown in parentheses (but it would be better, IMO, if it > was also here displayed to the right with no parentheses). Not > sure what happens in other toolkits. > > That said, I'm fine either way. I have attached a patch which > uses parentheses instead of brackets. Please feel free too > install whichever version you prefer more. > > And do it quick before anyone has time to start bikeshedding... ;) Thanks, pushed. From unknown Sun Jun 22 11:43:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 24 16:40:16 2019 Received: (at control) by debbugs.gnu.org; 24 Aug 2019 20:40:17 +0000 Received: from localhost ([127.0.0.1]:43329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1cpc-0002TP-Lz for submit@debbugs.gnu.org; Sat, 24 Aug 2019 16:40:16 -0400 Received: from crocodile.birch.relay.mailchannels.net ([23.83.209.45]:22612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1cpa-0002TE-7d for control@debbugs.gnu.org; Sat, 24 Aug 2019 16:40:16 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BF3DE341A08 for ; Sat, 24 Aug 2019 20:40:12 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-4-105.trex.outbound.svc.cluster.local [100.96.4.105]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 83E193418D7 for ; Sat, 24 Aug 2019 20:40:08 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sat, 24 Aug 2019 20:40:12 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Tart-Slimy: 4353a7a57752a551_1566679208567_1758303190 X-MC-Loop-Signature: 1566679208567:1483540438 X-MC-Ingress-Time: 1566679208567 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 6104D83ABD for ; Sat, 24 Aug 2019 13:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=wo6jAm4uEa4gxNfgheAGTq7Keuw=; b= R3eIzEiPRBE+xpEqbW0mGBh+B0TZIlLOFd++8toOKjc/B2ciPC+L/IudVVks7xz5 g4NQMHyNLqcSRswqAkAJp9Eb9mR7H1i38lfAuU5UORFDkDS7sOLbxJoIn511A6v/ uiFC6sWE7CScIzCgQNp1JgsMSWHLZ4BcigUgaMpdg/U= Received: from mail.jurta.org (m91-129-109-163.cust.tele2.ee [91.129.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 0D6BD83ABE for ; Sat, 24 Aug 2019 13:40:00 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: Date: Sat, 24 Aug 2019 23:28:12 +0300 In-Reply-To: (Stefan Kangas's message of "Mon, 10 Jun 2019 03:14:12 +0200") Message-ID: <87ftlqgvfn.fsf@linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudehtddgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrudeifeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdduieefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 36156 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 24 16:42:26 2019 Received: (at 36156) by debbugs.gnu.org; 24 Aug 2019 20:42:26 +0000 Received: from localhost ([127.0.0.1]:43334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1cri-0002XH-30 for submit@debbugs.gnu.org; Sat, 24 Aug 2019 16:42:26 -0400 Received: from brown.birch.relay.mailchannels.net ([23.83.209.23]:50058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1crg-0002X7-Dk for 36156@debbugs.gnu.org; Sat, 24 Aug 2019 16:42:24 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5EA321A191E; Sat, 24 Aug 2019 20:42:23 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-114-132.trex.outbound.svc.cluster.local [100.96.114.132]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BD4C51A1A3F; Sat, 24 Aug 2019 20:42:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sat, 24 Aug 2019 20:42:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Left-Hysterical: 49a6d5bd06210f31_1566679342995_2759194586 X-MC-Loop-Signature: 1566679342995:1535732270 X-MC-Ingress-Time: 1566679342995 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 7585C83ABD; Sat, 24 Aug 2019 13:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=/JqluKfYcOnmcAp15OVTsv3komQ=; b= Bn9u8GDJyBaoSat3AIw53gmYzAKv/vNsXn7Ryo7yy/zKmmthFKtbNNrBcI/8Ok38 +/zNQj6hAi6Jljz7q1nvsFx+XKGyIDjU2akrtJJJqvomKLK46a4UilISFpdy8qdd FKQbR6j1qTzg/DaFt+Vq2xKJyCVjvM5ezzZdELpI0Ls= Received: from mail.jurta.org (m91-129-109-163.cust.tele2.ee [91.129.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 9AE1F83AB7; Sat, 24 Aug 2019 13:42:14 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 From: Juri Linkov To: Stefan Kangas Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: Date: Sat, 24 Aug 2019 23:40:10 +0300 In-Reply-To: (Stefan Kangas's message of "Mon, 10 Jun 2019 03:14:12 +0200") Message-ID: <871rxagv91.fsf@linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudehtddgudehiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdelrdduieefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtledrudeifedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehsthgvfhgrnhesmhgrrhigihhsthdrshgvnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Please let me know what you think. Today I found a regression in this change: when a tool-bar item doesn't use a :help keyword (like e.g. in gud-menu-map) then the tooltip displays just keyboard equivalents in its tooltip. It used to display the caption in previous Emacs versions. I believe it could be fixed by this patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=36156_1.patch diff --git a/src/keyboard.c b/src/keyboard.c index 30686a2589..1b9a603ca1 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -8304,6 +8304,10 @@ parse_tool_bar_item (Lisp_Object key, Lisp_Object item) AUTO_STRING (end, ")"); Lisp_Object orig = PROP (TOOL_BAR_ITEM_HELP); Lisp_Object desc = Fkey_description (keys, Qnil); + + if (NILP (orig)) + orig = PROP (TOOL_BAR_ITEM_CAPTION); + set_prop (TOOL_BAR_ITEM_HELP, CALLN (Fconcat, orig, beg, desc, end)); } --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 07:03:25 2019 Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 11:03:25 +0000 Received: from localhost ([127.0.0.1]:43660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qIv-0001TI-1k for submit@debbugs.gnu.org; Sun, 25 Aug 2019 07:03:25 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qIt-0001T5-Ll for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 07:03:24 -0400 Received: by mail-pg1-f194.google.com with SMTP id n9so8651067pgc.1 for <36156@debbugs.gnu.org>; Sun, 25 Aug 2019 04:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xV2IRoPxNvkZGQUntg/hDQdbJ1eRO/zCvz//wh0vFfE=; b=Qq4xQy+uLfHi2n52pDYd30+SJM7vjo/7L16/ChhcTarKUmjrCwY0IASrDLiwR/DBFZ AnKjGpfwqDhDauC7DYTYk3f0HX0vzCMf5P9DFUOCfyOX8UE06y/Ad743ZMlhMGjcBRUO ugIsKiSV9Wr7IAuuhU99TuRRfzI2D4FZgn2ZptpygpZL+z8F67unnUmCRKSx9k1uJiUZ W8qkLAGQhKLFduJc7IfNNtvxFyfBC8/DIZgIuI0cauedINMQW8Emh0ADyI5BSwovXVgc jyE1XWF6Hl9wvrf8rMffLu8/kzsnsFi4YUZi9jE2ugsKday52nWEws10eCd7iu0spNmC 8Fxw== X-Gm-Message-State: APjAAAWTlIOibyILKCu+OQ9IGMt4c3kX9O+2DPV3B2xENsoFjZA8gISJ IK6jGchV/CLHMIgOdlTRV1rEekAEZ25l/kDYt34= X-Google-Smtp-Source: APXvYqxinMkyfpUZLcEbDYtPM1je/BaVRMhDGQIHOIZHXoh03mZpvxoL9OU0nNBJBtv8H+U/ScjpSZ01xkjY48Q+C94= X-Received: by 2002:a63:69c1:: with SMTP id e184mr11211855pgc.198.1566730997808; Sun, 25 Aug 2019 04:03:17 -0700 (PDT) MIME-Version: 1.0 References: <871rxagv91.fsf@linkov.net> In-Reply-To: <871rxagv91.fsf@linkov.net> From: Stefan Kangas Date: Sun, 25 Aug 2019 13:03:06 +0200 Message-ID: Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: > Today I found a regression in this change: when a tool-bar item > doesn't use a :help keyword (like e.g. in gud-menu-map) then > the tooltip displays just keyboard equivalents in its tooltip. > It used to display the caption in previous Emacs versions. > I believe it could be fixed by this patch: I can reproduce this regression in the gud toolbar on current master. Your patch fixes it and looks good to me. Thanks for finding and resolving this. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 07:46:31 2019 Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 11:46:32 +0000 Received: from localhost ([127.0.0.1]:43687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qyd-0004at-KP for submit@debbugs.gnu.org; Sun, 25 Aug 2019 07:46:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qyc-0004aO-HN for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 07:46:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1qyW-0008Nx-US; Sun, 25 Aug 2019 07:46:24 -0400 Received: from [176.228.60.248] (port=2244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1qyU-0000Pr-HW; Sun, 25 Aug 2019 07:46:24 -0400 Date: Sun, 25 Aug 2019 14:46:22 +0300 Message-Id: <83h865h3ht.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sun, 25 Aug 2019 13:03:06 +0200) Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: <871rxagv91.fsf@linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 25 Aug 2019 13:03:06 +0200 > Cc: 36156@debbugs.gnu.org > > Juri Linkov writes: > > > Today I found a regression in this change: when a tool-bar item > > doesn't use a :help keyword (like e.g. in gud-menu-map) then > > the tooltip displays just keyboard equivalents in its tooltip. > > It used to display the caption in previous Emacs versions. > > I believe it could be fixed by this patch: > > I can reproduce this regression in the gud toolbar on current master. > Your patch fixes it and looks good to me. Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable text? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 08:59:02 2019 Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 12:59:02 +0000 Received: from localhost ([127.0.0.1]:43732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1s6o-0006Iq-GF for submit@debbugs.gnu.org; Sun, 25 Aug 2019 08:59:02 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1s6m-0006IM-LJ for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 08:59:01 -0400 Received: by mail-pl1-f193.google.com with SMTP id y8so8458692plr.12 for <36156@debbugs.gnu.org>; Sun, 25 Aug 2019 05:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y1T/2LmGjMDHswyfMwaJas4j3ELZNvt4UWRAmeXvA7s=; b=gK77WiRTqkjM7JetSRZzmhnjOq/jKOxcmmWRMErWha5PEU9wm5/ASrPURN8Z6rG3tR uHBjuf9r6luBUImfp5JW1RQgtz5+J+t0w80XTpOd+LJL6ku4Y+kzuvx5JEnZ3+pI6aQI /nw9AI98Bfhbo5wF0MtEaIFSQfo78ggdwjjFn37KIjsZdqxPzoEyq5CY6Jh7NkLdMkkK KY+nj/v/Q9mWy0HI2yzcr9pkx0okkGeOLeCKaT2HoGWuzjmhwpJot+BzRdsJH9wZWEp2 n2rTpGew6DtVJdvjnO4vOwwwysznHdnQA6cPJtllvR1TV33JVI0P0LjCPHlHJT4htA+r Xn2w== X-Gm-Message-State: APjAAAWVLXvhZG/cHGiEIO3LJY4HF7tAEwqedRNQ9TfnucNfWdtfMaiH 8R/wpDh4RvgyiC66pIMQ5PthkHX2BBSVRUBJafM= X-Google-Smtp-Source: APXvYqxXCNJMwjX5156E4ldyvEeUSHxpFi15y8W5anj0Bug2LkxZyW+4SM9o+vudZNLdALw8MRfhfj88vMZ3CslKenY= X-Received: by 2002:a17:902:b702:: with SMTP id d2mr2127457pls.259.1566737934854; Sun, 25 Aug 2019 05:58:54 -0700 (PDT) MIME-Version: 1.0 References: <871rxagv91.fsf@linkov.net> <83h865h3ht.fsf@gnu.org> In-Reply-To: <83h865h3ht.fsf@gnu.org> From: Stefan Kangas Date: Sun, 25 Aug 2019 14:58:42 +0200 Message-ID: Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable > text? I think so, because we do this above (quoted to avoid gmail mangling the code): > /* Get the caption of the item. If the caption is not a string, > evaluate it to get a string. If we don't get a string, skip this > item. */ > caption = XCAR (item); > if (!STRINGP (caption)) > { > caption = menu_item_eval_property (caption); > if (!STRINGP (caption)) > return 0; > } > set_prop (TOOL_BAR_ITEM_CAPTION, caption); When this function returns 0, we don't append this item to the items that will be displayed. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 09:10:24 2019 Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 13:10:24 +0000 Received: from localhost ([127.0.0.1]:43736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1sHn-0006Zn-MA for submit@debbugs.gnu.org; Sun, 25 Aug 2019 09:10:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1sHl-0006ZY-JR for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 09:10:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1sHf-0005xW-NU; Sun, 25 Aug 2019 09:10:15 -0400 Received: from [176.228.60.248] (port=3377 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1sHe-0004JN-Vy; Sun, 25 Aug 2019 09:10:15 -0400 Date: Sun, 25 Aug 2019 16:10:14 +0300 Message-Id: <83ef19gzm1.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sun, 25 Aug 2019 14:58:42 +0200) Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: <871rxagv91.fsf@linkov.net> <83h865h3ht.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 25 Aug 2019 14:58:42 +0200 > Cc: Juri Linkov , 36156@debbugs.gnu.org > > Eli Zaretskii writes: > > > Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable > > text? > > I think so, because we do this above (quoted to avoid gmail mangling the code): > > > /* Get the caption of the item. If the caption is not a string, > > evaluate it to get a string. If we don't get a string, skip this > > item. */ > > caption = XCAR (item); > > if (!STRINGP (caption)) > > { > > caption = menu_item_eval_property (caption); > > if (!STRINGP (caption)) > > return 0; > > } > > set_prop (TOOL_BAR_ITEM_CAPTION, caption); > > When this function returns 0, we don't append this item to the items > that will be displayed. That just makes sure it's a string, but what kind of string is that? A caption can be something unpalatable, like "OpNuFil". From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 16:45:49 2019 Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 20:45:49 +0000 Received: from localhost ([127.0.0.1]:45154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1zOV-0002mm-Tr for submit@debbugs.gnu.org; Sun, 25 Aug 2019 16:45:49 -0400 Received: from brown.birch.relay.mailchannels.net ([23.83.209.23]:62218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1zOS-0002md-Ui for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 16:45:45 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D320D341C47; Sun, 25 Aug 2019 20:45:43 +0000 (UTC) Received: from pdx1-sub0-mail-a15.g.dreamhost.com (100-96-29-227.trex.outbound.svc.cluster.local [100.96.29.227]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5173F341D0B; Sun, 25 Aug 2019 20:45:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a15.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 25 Aug 2019 20:45:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Tank-Exultant: 753e43b1288b469e_1566765943588_3409692043 X-MC-Loop-Signature: 1566765943587:775492344 X-MC-Ingress-Time: 1566765943587 Received: from pdx1-sub0-mail-a15.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a15.g.dreamhost.com (Postfix) with ESMTP id 860B2831F9; Sun, 25 Aug 2019 13:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=EumWTUYUIkSHtEKy8HjXO1j6SDA=; b= uSbN2QAwRCiM9ZWG2Swn9uUK9Wtuc93O2DR/4VvKE2R8GZTzJpq3vlz1uCMZL/zJ UKDz4etaRwJq63Px7Yh6Ivb/i24QynkdTW2TcjwBdeHFSfI5F1pwv/rxNQOfBA7l XYrM4MVKpJYkELHhw2HmYX3tLaFOwSibeQFTtKSfdRw= Received: from mail.jurta.org (m91-129-109-163.cust.tele2.ee [91.129.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a15.g.dreamhost.com (Postfix) with ESMTPSA id 6CFA8831F4; Sun, 25 Aug 2019 13:45:35 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a15 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips Organization: LINKOV.NET References: <871rxagv91.fsf@linkov.net> <83h865h3ht.fsf@gnu.org> <83ef19gzm1.fsf@gnu.org> Date: Sun, 25 Aug 2019 23:18:20 +0300 In-Reply-To: <83ef19gzm1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Aug 2019 16:10:14 +0300") Message-ID: <87v9ulm2dz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudehvddgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrudeifeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdduieefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgepvd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable >> > text? >> >> I think so, because we do this above (quoted to avoid gmail mangling the code): > > That just makes sure it's a string, but what kind of string is that? > A caption can be something unpalatable, like "OpNuFil". Currently HELP's fallback to CAPTION is a standard way to handle absence of HELP: note_tool_bar_highlight has this code: help_echo_string = AREF (f->tool_bar_items, prop_idx + TOOL_BAR_ITEM_HELP); if (NILP (help_echo_string)) help_echo_string = AREF (f->tool_bar_items, prop_idx + TOOL_BAR_ITEM_CAPTION); xg_tool_bar_help_callback has this code: help = AREF (f->tool_bar_items, idx + TOOL_BAR_ITEM_HELP); if (NILP (help)) help = AREF (f->tool_bar_items, idx + TOOL_BAR_ITEM_CAPTION); The patch added the same handling to parse_tool_bar_item: Lisp_Object orig = PROP (TOOL_BAR_ITEM_HELP); + if (NILP (orig)) + orig = PROP (TOOL_BAR_ITEM_CAPTION); From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 26 02:26:41 2019 Received: (at 36156) by debbugs.gnu.org; 26 Aug 2019 06:26:41 +0000 Received: from localhost ([127.0.0.1]:45481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i28Sf-000164-Gi for submit@debbugs.gnu.org; Mon, 26 Aug 2019 02:26:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i28Sd-00015q-Kx for 36156@debbugs.gnu.org; Mon, 26 Aug 2019 02:26:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i28SY-0004wU-HD; Mon, 26 Aug 2019 02:26:34 -0400 Received: from [176.228.60.248] (port=2878 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i28SX-0000oI-Fu; Mon, 26 Aug 2019 02:26:34 -0400 Date: Mon, 26 Aug 2019 09:26:35 +0300 Message-Id: <835zmkh278.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87v9ulm2dz.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 25 Aug 2019 23:18:20 +0300) Subject: Re: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips References: <871rxagv91.fsf@linkov.net> <83h865h3ht.fsf@gnu.org> <83ef19gzm1.fsf@gnu.org> <87v9ulm2dz.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36156 Cc: 36156@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Stefan Kangas , 36156@debbugs.gnu.org > Date: Sun, 25 Aug 2019 23:18:20 +0300 > > > That just makes sure it's a string, but what kind of string is that? > > A caption can be something unpalatable, like "OpNuFil". > > Currently HELP's fallback to CAPTION is a standard way > to handle absence of HELP: Then I guess we are OK here. From unknown Sun Jun 22 11:43:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator