From unknown Sat Jun 14 19:20:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 03:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36143@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156005020523297 (code B ref -1); Sun, 09 Jun 2019 03:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jun 2019 03:16:45 +0000 Received: from localhost ([127.0.0.1]:54023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZoK5-00063h-HV for submit@debbugs.gnu.org; Sat, 08 Jun 2019 23:16:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:51989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZoK3-00063Y-Jj for submit@debbugs.gnu.org; Sat, 08 Jun 2019 23:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38717) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZoK2-0008K6-MW for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZoK1-0005Be-Qo for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:42 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:34649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZoK1-0005Ao-KH for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:41 -0400 Received: by mail-wr1-f46.google.com with SMTP id e16so5822485wrn.1 for ; Sat, 08 Jun 2019 20:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dHjNN02VMQWjdc83Jx0CvSj/4z93Zba4OJ3TYw5m36o=; b=sI3bs0cVsQqpMQttyT483ww0DU3O7pAhRKRcYwuyJFzr4lZPgtokkzJzz8sVrBw/F0 lRODXW0+A/2cl5IXl7Cnb2cv6iTmesLTRzckGSWMcdKr2tg05a16nOffo4YjO1AjSvxi toOk6TtkFAfFTGpjh6fT395zlJiUTJPNfYbq4xpluEJ/lUPFvQQyvEfrEBjO2syKr6bz qxPFcrevNHL6SKSRik8UqME0ZfltCvbUiU929LgTpvVJw9+Pc0GoLqp+UnxpzybHrSCp pc7DSVCVZn9/TY6mIgqli6LaI4j5MUvOFJrUN7XzEVPxuAZ2vY+D7UOQabBPurve+beG kUlA== X-Gm-Message-State: APjAAAW252inubEuwlGMzck6vwN0WNWvuEvAww743qG9VycUj1nKDk62 GhkDawug2vfebyeoe5781QQA4+pmkyhRn6lIj3ckOg== X-Google-Smtp-Source: APXvYqxNjfVWb7uY7avP0WkuHmJ0FD7lGV4R57L2OfgVtYsKJ0USn2pceAa19W8y2w6MT0uiSmEXoWNiV90Mbi5+Jq0= X-Received: by 2002:a5d:5390:: with SMTP id d16mr30658968wrv.85.1560050200190; Sat, 08 Jun 2019 20:16:40 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 9 Jun 2019 05:16:28 +0200 Message-ID: Content-Type: multipart/mixed; boundary="00000000000003c673058adb7e94" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.46 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000003c673058adb7e94 Content-Type: text/plain; charset="UTF-8" Please see attached patch. Thanks, Stefan Kangas --00000000000003c673058adb7e94 Content-Type: application/octet-stream; name="0001-src-keyboard.c-tool_bar_items-Fix-typo.patch" Content-Disposition: attachment; filename="0001-src-keyboard.c-tool_bar_items-Fix-typo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwodli570 RnJvbSA5NGRiOGYzOTkwNTZmNzU4NDM4Y2I2ODYxOTEzMTZiMzJiYzAxMTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDU6MDI6MzkgKzAyMDAKU3ViamVjdDogW1BBVENIXSA7 ICogc3JjL2tleWJvYXJkLmMgKHRvb2xfYmFyX2l0ZW1zKTogRml4IHR5cG8uCgotLS0KIHNyYy9r ZXlib2FyZC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRl eCAwYzI2OWQ2NDIyLi4zOWQ4MWRhYWMwIDEwMDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysg Yi9zcmMva2V5Ym9hcmQuYwpAQCAtNzk2OSw3ICs3OTY5LDcgQEAgdG9vbF9iYXJfaXRlbXMgKExp c3BfT2JqZWN0IHJldXNlLCBpbnQgKm5pdGVtcykKICAgICB7CiAgICAgICAvKiBObywgc28gdXNl IG1ham9yIGFuZCBtaW5vciBtb2RlIGtleW1hcHMgYW5kIGtleW1hcCBwcm9wZXJ0eS4KIAkgTm90 ZSB0aGF0IHRvb2wtYmFyIGJpbmRpbmdzIGluIHRoZSBsb2NhbC1tYXAgYW5kIGtleW1hcAotCSBw cm9wZXJ0aWVzIG1heSBub3Qgd29yayByZWxpYWJsZSwgYXMgdGhleSBhcmUgb25seQorICAgICAg ICAgcHJvcGVydGllcyBtYXkgbm90IHdvcmsgcmVsaWFibHksIGFzIHRoZXkgYXJlIG9ubHkKIAkg cmVjb2duaXplZCB3aGVuIHRoZSB0b29sLWJhciAob3IgbW9kZS1saW5lKSBpcyB1cGRhdGVkLAog CSB3aGljaCBkb2VzIG5vdCBub3JtYWxseSBoYXBwZW4gYWZ0ZXIgZXZlcnkgY29tbWFuZC4gICov CiAgICAgICBwdHJkaWZmX3Qgbm1pbm9yID0gY3VycmVudF9taW5vcl9tYXBzIChOVUxMLCAmdG1h cHMpOwotLSAKMi4yMS4wCgo= --00000000000003c673058adb7e94-- From unknown Sat Jun 14 19:20:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Kangas Subject: bug#36143: closed (Re: bug#36143: [PATCH] Fix typo in src/keyboard.c) Message-ID: References: <837e9vclzj.fsf@gnu.org> X-Gnu-PR-Message: they-closed 36143 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 36143@debbugs.gnu.org Date: Sun, 09 Jun 2019 06:28:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1560061681-11828-1" This is a multi-part message in MIME format... ------------=_1560061681-11828-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36143: [PATCH] Fix typo in src/keyboard.c which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36143@debbugs.gnu.org. --=20 36143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36143 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1560061681-11828-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36143-done) by debbugs.gnu.org; 9 Jun 2019 06:27:12 +0000 Received: from localhost ([127.0.0.1]:54111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZrIN-00033m-Uz for submit@debbugs.gnu.org; Sun, 09 Jun 2019 02:27:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZrIM-00033Y-2I for 36143-done@debbugs.gnu.org; Sun, 09 Jun 2019 02:27:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZrIG-0003rk-Rl; Sun, 09 Jun 2019 02:27:04 -0400 Received: from [176.228.60.248] (port=4335 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZrID-0002hf-QA; Sun, 09 Jun 2019 02:27:04 -0400 Date: Sun, 09 Jun 2019 09:26:56 +0300 Message-Id: <837e9vclzj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sun, 9 Jun 2019 05:16:28 +0200) Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36143-done Cc: 36143-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 9 Jun 2019 05:16:28 +0200 > > Please see attached patch. Thanks, I pushed it. However, it looks like your local settings make Emacs untabify C sources, so in your patch as posted a TAB was converted into spaces, unlike the indentation around the line you changed (I fixed that before committing). Please in the future be sure to edit the Emacs sources without such local settings; we only prefer spaces to TABs in Lisp sources, see .dir-locals.el in the repository. ------------=_1560061681-11828-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Jun 2019 03:16:45 +0000 Received: from localhost ([127.0.0.1]:54023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZoK5-00063h-HV for submit@debbugs.gnu.org; Sat, 08 Jun 2019 23:16:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:51989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZoK3-00063Y-Jj for submit@debbugs.gnu.org; Sat, 08 Jun 2019 23:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38717) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZoK2-0008K6-MW for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZoK1-0005Be-Qo for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:42 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:34649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZoK1-0005Ao-KH for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 23:16:41 -0400 Received: by mail-wr1-f46.google.com with SMTP id e16so5822485wrn.1 for ; Sat, 08 Jun 2019 20:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dHjNN02VMQWjdc83Jx0CvSj/4z93Zba4OJ3TYw5m36o=; b=sI3bs0cVsQqpMQttyT483ww0DU3O7pAhRKRcYwuyJFzr4lZPgtokkzJzz8sVrBw/F0 lRODXW0+A/2cl5IXl7Cnb2cv6iTmesLTRzckGSWMcdKr2tg05a16nOffo4YjO1AjSvxi toOk6TtkFAfFTGpjh6fT395zlJiUTJPNfYbq4xpluEJ/lUPFvQQyvEfrEBjO2syKr6bz qxPFcrevNHL6SKSRik8UqME0ZfltCvbUiU929LgTpvVJw9+Pc0GoLqp+UnxpzybHrSCp pc7DSVCVZn9/TY6mIgqli6LaI4j5MUvOFJrUN7XzEVPxuAZ2vY+D7UOQabBPurve+beG kUlA== X-Gm-Message-State: APjAAAW252inubEuwlGMzck6vwN0WNWvuEvAww743qG9VycUj1nKDk62 GhkDawug2vfebyeoe5781QQA4+pmkyhRn6lIj3ckOg== X-Google-Smtp-Source: APXvYqxNjfVWb7uY7avP0WkuHmJ0FD7lGV4R57L2OfgVtYsKJ0USn2pceAa19W8y2w6MT0uiSmEXoWNiV90Mbi5+Jq0= X-Received: by 2002:a5d:5390:: with SMTP id d16mr30658968wrv.85.1560050200190; Sat, 08 Jun 2019 20:16:40 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 9 Jun 2019 05:16:28 +0200 Message-ID: Subject: [PATCH] Fix typo in src/keyboard.c To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000003c673058adb7e94" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.46 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000003c673058adb7e94 Content-Type: text/plain; charset="UTF-8" Please see attached patch. Thanks, Stefan Kangas --00000000000003c673058adb7e94 Content-Type: application/octet-stream; name="0001-src-keyboard.c-tool_bar_items-Fix-typo.patch" Content-Disposition: attachment; filename="0001-src-keyboard.c-tool_bar_items-Fix-typo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwodli570 RnJvbSA5NGRiOGYzOTkwNTZmNzU4NDM4Y2I2ODYxOTEzMTZiMzJiYzAxMTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDU6MDI6MzkgKzAyMDAKU3ViamVjdDogW1BBVENIXSA7 ICogc3JjL2tleWJvYXJkLmMgKHRvb2xfYmFyX2l0ZW1zKTogRml4IHR5cG8uCgotLS0KIHNyYy9r ZXlib2FyZC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRl eCAwYzI2OWQ2NDIyLi4zOWQ4MWRhYWMwIDEwMDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysg Yi9zcmMva2V5Ym9hcmQuYwpAQCAtNzk2OSw3ICs3OTY5LDcgQEAgdG9vbF9iYXJfaXRlbXMgKExp c3BfT2JqZWN0IHJldXNlLCBpbnQgKm5pdGVtcykKICAgICB7CiAgICAgICAvKiBObywgc28gdXNl IG1ham9yIGFuZCBtaW5vciBtb2RlIGtleW1hcHMgYW5kIGtleW1hcCBwcm9wZXJ0eS4KIAkgTm90 ZSB0aGF0IHRvb2wtYmFyIGJpbmRpbmdzIGluIHRoZSBsb2NhbC1tYXAgYW5kIGtleW1hcAotCSBw cm9wZXJ0aWVzIG1heSBub3Qgd29yayByZWxpYWJsZSwgYXMgdGhleSBhcmUgb25seQorICAgICAg ICAgcHJvcGVydGllcyBtYXkgbm90IHdvcmsgcmVsaWFibHksIGFzIHRoZXkgYXJlIG9ubHkKIAkg cmVjb2duaXplZCB3aGVuIHRoZSB0b29sLWJhciAob3IgbW9kZS1saW5lKSBpcyB1cGRhdGVkLAog CSB3aGljaCBkb2VzIG5vdCBub3JtYWxseSBoYXBwZW4gYWZ0ZXIgZXZlcnkgY29tbWFuZC4gICov CiAgICAgICBwdHJkaWZmX3Qgbm1pbm9yID0gY3VycmVudF9taW5vcl9tYXBzIChOVUxMLCAmdG1h cHMpOwotLSAKMi4yMS4wCgo= --00000000000003c673058adb7e94-- ------------=_1560061681-11828-1-- From unknown Sat Jun 14 19:20:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 08:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 36143-done@debbugs.gnu.org Received: via spool by 36143-done@debbugs.gnu.org id=D36143.156006726020664 (code D ref 36143); Sun, 09 Jun 2019 08:01:01 +0000 Received: (at 36143-done) by debbugs.gnu.org; 9 Jun 2019 08:01:00 +0000 Received: from localhost ([127.0.0.1]:54187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZslA-0005NE-97 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 04:01:00 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:40317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZsl8-0005Mu-9E for 36143-done@debbugs.gnu.org; Sun, 09 Jun 2019 04:00:58 -0400 Received: by mail-wr1-f46.google.com with SMTP id p11so6065016wre.7 for <36143-done@debbugs.gnu.org>; Sun, 09 Jun 2019 01:00:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w0ojY0R2ADlYELUzqRhNulNMNtkEZJYOD3lGA34ucto=; b=pdQOSUwe4UiRQRQWqlODMLQf4ifEVX9lPw2HLG+c9gXxUO+qxo7WqADKmyPY1IHJH1 oSH4fVSw8P4oxDB25LlwpZeH9dbiiqW1qvMKtvhoFBWrwKMw1ZOT16mEITwdBH3gvGEf nLluBeLlyDkFuJLhZED/7k2NORjDxB3NMFj8f4PUd6UKyXU7pONON/tfelc5nAuGhs2h /3uHLAJkFVdrc9kwOGcxSbyUPY+SRH8X5FOB1Eyuigsr3jyKCHrFyF95hqA8Ewkde8pv +ZebhaSi7TW4Mc/+/a/qAZkGwas6HgrzE9V+cIFF4sUFlxg2mcEB5iiddoSxZDAqkn1L EP4Q== X-Gm-Message-State: APjAAAWFuW6LI0g0PbyqAc0GD4g/mtchPek1LCa8vvQID/XtnjBURlxN mYjQ3J+xDdGk3iFzRXNn0JmQaFWlO7uah2efQqY= X-Google-Smtp-Source: APXvYqyqUxxnz+JxgIu2x9qEwQqYY0BV6uOSda0675FNMmnj+87ZIg1YT0rrP7cL1sUnRbv5/DU7QwLqj7W9bhOKtLQ= X-Received: by 2002:a05:6000:1285:: with SMTP id f5mr637202wrx.85.1560067252392; Sun, 09 Jun 2019 01:00:52 -0700 (PDT) MIME-Version: 1.0 References: <837e9vclzj.fsf@gnu.org> In-Reply-To: <837e9vclzj.fsf@gnu.org> From: Stefan Kangas Date: Sun, 9 Jun 2019 10:00:41 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, I pushed it. > > [...] Please in the future be sure to edit the Emacs > sources without such local settings; we only prefer spaces to TABs in > Lisp sources, see .dir-locals.el in the repository. Got it, thank you for taking care of it and installing it. Best regards, Stefan Kangas From unknown Sat Jun 14 19:20:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c) Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36143@debbugs.gnu.org Cc: , Stefan Kangas Received: via spool by 36143-submit@debbugs.gnu.org id=B36143.156008646226956 (code B ref 36143); Sun, 09 Jun 2019 13:22:02 +0000 Received: (at 36143) by debbugs.gnu.org; 9 Jun 2019 13:21:02 +0000 Received: from localhost ([127.0.0.1]:54471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZxks-00070X-60 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 09:21:02 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:33784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZxkq-000700-Kv for 36143@debbugs.gnu.org; Sun, 09 Jun 2019 09:21:01 -0400 Received: by mail-it1-f182.google.com with SMTP id v193so8366154itc.0 for <36143@debbugs.gnu.org>; Sun, 09 Jun 2019 06:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pevu73orfknSTXNiPFDkN+JH0oiXVFR9DGt8FHTmqwo=; b=EqHM92JJF9HtoieYt7ATR2u4h8oV3qXeXKFGxHfTPWgc4LZBNGP7z4mvvangKGoF7Y s7z/Izs8f3YCMBWW2+8F3xlTnUIrVckfMRxseE2fpLTX4CydJ0ZqLxez8UiXj7C4zDJC hTftga4wVTsNV6qmr4+rSyaIEdtF/WIHaM64ZY/Glo2AhGm7kBaVdixFyQc1cmCDTmos GSc+Wu8zVt0rUEhOj4YgI4QedjRrraOPlyy8gKY7TzcoR9JJiTGclXl0iD/W1LsUR3cL HL4fX9yxfk2k2wxXboGycuFSRQiRxwjnyL5o34rDkYJrFm4gum+tj/sjyJr32YQnEgXl qvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pevu73orfknSTXNiPFDkN+JH0oiXVFR9DGt8FHTmqwo=; b=joAEe9zwb+h9lxopT1UGSinmeZFJs2xJdQkn3SEhHQwXRGWAvWeQq8qS/Tt3D7Juts A5TMlNuS+d2APvlMii0G57PQ4xnu6unPJJ1gOKXN+XVIMZj3By8SMw7IgGixHoQKNEGw a7tfUd2pvhumCpN1eFhR+vAe1DUDpbYHxu5qf2/1CEvtFqO3C3maScsn6ytVlmYFskUH pCuRC3wzr2fSCHeQv4ola9yQxT5Msl6rxJl0wiRlzzE3hF4Cd2XiJwNi9oMXbp8RnW3p AvanICGtte99JVk/ttIEBl2HwBlqnfNcLwalYNJTSAiZE8ixhI94pOUq5wrOAcXk1MRq XKsg== X-Gm-Message-State: APjAAAVVeropRFHnao64h6mrwvWLTbuC6Ck1MohsF8pbyU8Tr/y00oo1 Rf7p6BK/xXS0zNf0/D4pQmk= X-Google-Smtp-Source: APXvYqw52dEzU3Z31eUn6kpveRFmJaWruqvciEGj0W7acT5CHJUjc8CorT5QzK3JtN+FmM7JZfF6eg== X-Received: by 2002:a24:9f07:: with SMTP id c7mr10114301ite.61.1560086454642; Sun, 09 Jun 2019 06:20:54 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id z202sm4024228itb.2.2019.06.09.06.20.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jun 2019 06:20:53 -0700 (PDT) From: Noam Postavsky References: <837e9vclzj.fsf@gnu.org> Date: Sun, 09 Jun 2019 09:20:52 -0400 In-Reply-To: (GNU bug Tracking System's message of "Sun, 09 Jun 2019 06:28:01 +0000") Message-ID: <87lfya28uj.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > However, it looks like your local settings make Emacs untabify C > sources, so in your patch as posted a TAB was converted into spaces, > unlike the indentation around the line you changed (I fixed that > before committing). Please in the future be sure to edit the Emacs > sources without such local settings; we only prefer spaces to TABs in > Lisp sources, see .dir-locals.el in the repository. Oh, I also didn't realize C sources were supposed to be TABified. Maybe .dir-locals.el should have an explicit (indent-tabs-mode . t) setting under c-mode? Especially since with GNU indent style, indent-tabs-mode=t results in a file which mixes tabs and spaces, so it's not obvious that the tabs are really intentional. From unknown Sat Jun 14 19:20:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: , stefan@marxist.se, 36143@debbugs.gnu.org Received: via spool by 36143-submit@debbugs.gnu.org id=B36143.156008861830534 (code B ref 36143); Sun, 09 Jun 2019 13:57:02 +0000 Received: (at 36143) by debbugs.gnu.org; 9 Jun 2019 13:56:58 +0000 Received: from localhost ([127.0.0.1]:55114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyJe-0007wO-4A for submit@debbugs.gnu.org; Sun, 09 Jun 2019 09:56:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyJa-0007w9-6I for 36143@debbugs.gnu.org; Sun, 09 Jun 2019 09:56:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZyJU-000563-Py; Sun, 09 Jun 2019 09:56:48 -0400 Received: from [176.228.60.248] (port=4626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZyJU-0005vB-7U; Sun, 09 Jun 2019 09:56:48 -0400 Date: Sun, 09 Jun 2019 16:56:41 +0300 Message-Id: <83imtec15y.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87lfya28uj.fsf_-_@gmail.com> (message from Noam Postavsky on Sun, 09 Jun 2019 09:20:52 -0400) References: <837e9vclzj.fsf@gnu.org> <87lfya28uj.fsf_-_@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Date: Sun, 09 Jun 2019 09:20:52 -0400 > Cc: , Stefan Kangas > > Oh, I also didn't realize C sources were supposed to be TABified. Maybe > .dir-locals.el should have an explicit (indent-tabs-mode . t) setting > under c-mode? It'd be fine with me, but maybe others will object. I think it's okay to indent new C code with spaces, but when a few lines are modified in an otherwise TAB-indented block, that makes the source unaligned when reindented, so IMO should be avoided. And in this case, it was even more extreme: a line was modified only very slightly, so changing whitespace for only that single line was IMO gross. From unknown Sat Jun 14 19:20:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c) Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 14:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 36143@debbugs.gnu.org, stefan@marxist.se Received: via spool by 36143-submit@debbugs.gnu.org id=B36143.156008925831493 (code B ref 36143); Sun, 09 Jun 2019 14:08:03 +0000 Received: (at 36143) by debbugs.gnu.org; 9 Jun 2019 14:07:38 +0000 Received: from localhost ([127.0.0.1]:55121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyTy-0008Bt-HE for submit@debbugs.gnu.org; Sun, 09 Jun 2019 10:07:38 -0400 Received: from mail-io1-f41.google.com ([209.85.166.41]:42095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyTw-0008Bf-0H for 36143@debbugs.gnu.org; Sun, 09 Jun 2019 10:07:36 -0400 Received: by mail-io1-f41.google.com with SMTP id u19so4919479ior.9 for <36143@debbugs.gnu.org>; Sun, 09 Jun 2019 07:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xmpz4Xe/HG04VBzFObLl7/m4axl/pEkE0NHs8NYusPE=; b=fpHgAjZ6gsnjjUBaepqXubfqBySnrNBBe3VizSEABQDRZmPZK3gUbXs8DutXFXORzA FVtounHfbkWOCmEBvnGzGuTRK7eO/C7AG+8SRjuhbnGMDG6oZ6Jgzo0AC1eHyzuZhaCn d9/UeqnJ96V5pvAD3XgXyxQSGXRF+CRqJTzOOpiChIGRLQJOf5nHSxTn6+CyGNvu7rht for5xI4RZsPcOWbhWRPilGAuidbtu4Ihn9qCa2kLx0J53WAKqI0z3zIu1PpHOF4VU6Rj dH+iPShAf8PkL1FzV7O0shsEEoJzHkOE/TyNO1uWq6hs4l5jQ5NOd5LknOYL45R8BUCp yEsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xmpz4Xe/HG04VBzFObLl7/m4axl/pEkE0NHs8NYusPE=; b=LZwixL2sVHg8+tf8Wwf8fStNZlYmRXI7yt0xbQU91GXFKASOFOSj6KdcL0zRo6Aw9Y pU8uL8QJebKa8v0qKPu4epW2GF1TMgZgSDH/VAU+jfUq3TgtkQceIVj4AHa+A8YfB7yB qbb7x5uR5yyvGbgkgMNRvH7ieD0vSk4xG5x4PlgjyEwVEO7nqeO4rcheIyPpdKnInkJD ywz6wzC0an4/LJ1ps1O66Eobwba2AEfQVsosaCtLhNDQ0pLrwen1DYxl8qIP+gdZ3XXI W0kvRLC/yH7LkzVdVB7JAf2shv4397ghZ88t/KoRLL7S72c0V+60Nsgwsjuy/0lkJwBA kXag== X-Gm-Message-State: APjAAAW84DopJmVEgc8d2IwOZ6TNLjIeUbn4DfVRYT/wTlmVLUrmTfMN Lw2Qp/WwpEXYhExczLzVplukx8zV X-Google-Smtp-Source: APXvYqyRPSVS99EQrKvnz0ibNGbeHSvfCXAdzNTRpi64OsOjYH3B3Y/uqAqs4KCd1zpz48eGnlraRg== X-Received: by 2002:a6b:f910:: with SMTP id j16mr15176463iog.256.1560089250282; Sun, 09 Jun 2019 07:07:30 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p4sm2817775iod.68.2019.06.09.07.07.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jun 2019 07:07:29 -0700 (PDT) From: Noam Postavsky References: <837e9vclzj.fsf@gnu.org> <87lfya28uj.fsf_-_@gmail.com> <83imtec15y.fsf@gnu.org> Date: Sun, 09 Jun 2019 10:07:28 -0400 In-Reply-To: <83imtec15y.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jun 2019 16:56:41 +0300") Message-ID: <87imte26ov.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sun, 09 Jun 2019 09:20:52 -0400 >> Cc: , Stefan Kangas >> >> Oh, I also didn't realize C sources were supposed to be TABified. Maybe >> .dir-locals.el should have an explicit (indent-tabs-mode . t) setting >> under c-mode? > I think it's okay to indent new C code with spaces, Oh, in that case the current .dir-locals.el (i.e., no explicit indent-tabs-mode setting for c-mode) is okay. And I don't really want to open up the TABs vs spaces debate, so let's leave it as is.