From unknown Thu Jun 19 14:17:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36132 <36132@debbugs.gnu.org> To: bug#36132 <36132@debbugs.gnu.org> Subject: Status: Two installer UX tweaks Reply-To: bug#36132 <36132@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:17:28 +0000 retitle 36132 Two installer UX tweaks reassign 36132 guix-patches submitter 36132 Tobias Geerinckx-Rice severity 36132 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:42:34 2019 Received: (at submit) by debbugs.gnu.org; 8 Jun 2019 04:42:34 +0000 Received: from localhost ([127.0.0.1]:52704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTBZ-0000ah-N7 for submit@debbugs.gnu.org; Sat, 08 Jun 2019 00:42:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:44841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTBT-0000aV-5f for submit@debbugs.gnu.org; Sat, 08 Jun 2019 00:42:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47713) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZTBS-0002qX-BY for guix-patches@gnu.org; Sat, 08 Jun 2019 00:42:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZTBQ-0004qs-GV for guix-patches@gnu.org; Sat, 08 Jun 2019 00:42:26 -0400 Received: from tobias.gr ([2001:470:7405::1]:53674) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZTBP-0004nZ-QD for guix-patches@gnu.org; Sat, 08 Jun 2019 00:42:24 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 882946e9 for ; Sat, 8 Jun 2019 04:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-type; s=2018; i= me@tobias.gr; bh=lXRV/Pr+i63YbclEji6dKbaSuVXRO/FWjCwNaPq49AE=; b= bjV+mH7E2FeW3eNsn3c0w1WqJFwxMFmrijkTEBe89NE0ex+euOpDLMKNzrfuxFAM 5wH85/6M3YZiV9BkHcHF2O0k3Ptw1mRQP+5tvxS+T+q2PaO7m4jGgpv+MmcoDoxX xDSQj7krUZ7MIGZK1FLgmjgicokSW4zb8IdXPNj9flR6wVb0zSGktoTp699C8wJT jwUTug+vPpGdVaRaJZ6PoVcKjjQl58NpP+mBeveNXo6YYZLHk2gqGmeE2OmQ3WNS 1L6esdEf6tmyQ+Gl+A6c2p8+uFkp7Q4ZvxtEKCdU8W6s4fWQWwI3ilARGy4RMpw0 EXll+6Z8PvngXnXUZ4IiyA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 533ecd6d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Sat, 8 Jun 2019 04:42:16 +0000 (UTC) From: Tobias Geerinckx-Rice To: Guix-patches Subject: Two installer UX tweaks Date: Sat, 08 Jun 2019 06:42:14 +0200 Message-ID: <87y32c663d.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:7405::1 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; format=flowed Good morning, Guix is already exceptional; let's adhere to common UI conventions where it helps. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXPs8pgAKCRANsP+IT1Vt eZwiAQC/mWePSJZgYJTRmy59FlYXyuRPc/7U9A5C8lrSRy/y0wD/VHDs86In2y8S DuLSJSy/wkXrVt3SCexy3vaDWSgndgI= =0m1J -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:47:47 2019 Received: (at 36132) by debbugs.gnu.org; 8 Jun 2019 04:47:48 +0000 Received: from localhost ([127.0.0.1]:52712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTGd-0000ic-KR for submit@debbugs.gnu.org; Sat, 08 Jun 2019 00:47:47 -0400 Received: from tobias.gr ([80.241.217.52]:45456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTGc-0000iU-18 for 36132@debbugs.gnu.org; Sat, 08 Jun 2019 00:47:46 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 4197d695 for <36132@debbugs.gnu.org>; Sat, 8 Jun 2019 04:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=2018; i=me@tobias.gr; bh=+wixusxayAUUcNiCG5AIgLiufmf5zUTrv3OOjP6mjLs=; b=hiaRp9EeYkcv ybTRYEQ3Y48wVBoSKlELTWfcejMnXefWOxgSgFt+yOSyyPUC5xMbf91nF+fiGYeq jdUfhIpq334msSZQbsvlvjmyKqE3u9ndpC/7Z0oNU5Cv8P1MDhsQAWGdAiV09v4w TVpCN+ttPJhxczkDevwgZZYkL1toS5DHN7F+ZOM2jFXEaFP8FduuFntPNRALq0zM raOfpTVbn7smimQPAeiVgtt4LtMAoM6SqpPYlZVAJD3oyuX4qKr4PJq7QUji9XLg OdS6noMC/WC8AAahAhcG7CY1hsPdj7CvomVJMncWobmdF8klcxXvugwJMZYoSPfk 9mRfiowk7w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 75ab985f (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <36132@debbugs.gnu.org>; Sat, 8 Jun 2019 04:47:42 +0000 (UTC) From: Tobias Geerinckx-Rice To: 36132@debbugs.gnu.org Subject: [PATCH 1/2] installer: Partition as the last step. Date: Sat, 8 Jun 2019 06:47:28 +0200 Message-Id: <20190608044729.14700-1-me@tobias.gr> X-Mailer: git-send-email 2.21.0 In-Reply-To: <87y32c663d.fsf@nckx> References: <87y32c663d.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Multiple users have been understandably displeased after finding out that their network card was unsupported, and Internet access mandatory, after having already formatted their partitions. * gnu/installer.scm (installer-steps): Run the ‘partition’ step just before the ‘final’ one. --- gnu/installer.scm | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/gnu/installer.scm b/gnu/installer.scm index 1452c4dc7e..860c5a9a83 100644 --- a/gnu/installer.scm +++ b/gnu/installer.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Ludovic Courtès +;;; Copyright © 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -226,15 +227,6 @@ selected keymap." (#$keymap-step current-installer))) (configuration-formatter keyboard-layout->configuration)) - ;; Run a partitioning tool allowing the user to modify - ;; partition tables, partitions and their mount points. - (installer-step - (id 'partition) - (description (G_ "Partitioning")) - (compute (lambda _ - ((installer-partition-page current-installer)))) - (configuration-formatter user-partitions->configuration)) - ;; Ask the user to input a hostname for the system. (installer-step (id 'hostname) @@ -267,6 +259,17 @@ selected keymap." ((installer-services-page current-installer)))) (configuration-formatter system-services->configuration)) + ;; Run a partitioning tool allowing the user to modify + ;; partition tables, partitions and their mount points. + ;; Do this last so the user has something to boot if any + ;; of the previous steps doesn't go as expected. + (installer-step + (id 'partition) + (description (G_ "Partitioning")) + (compute (lambda _ + ((installer-partition-page current-installer)))) + (configuration-formatter user-partitions->configuration)) + (installer-step (id 'final) (description (G_ "Configuration file")) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:47:50 2019 Received: (at 36132) by debbugs.gnu.org; 8 Jun 2019 04:47:50 +0000 Received: from localhost ([127.0.0.1]:52714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTGf-0000it-UU for submit@debbugs.gnu.org; Sat, 08 Jun 2019 00:47:50 -0400 Received: from tobias.gr ([80.241.217.52]:45456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZTGd-0000iU-2z for 36132@debbugs.gnu.org; Sat, 08 Jun 2019 00:47:47 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 753fc507 for <36132@debbugs.gnu.org>; Sat, 8 Jun 2019 04:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=2018; i=me@tobias.gr; bh=lp3QCKWeuDcmMumJ3KFMjvddB0KTlYXApEfUOxi/5cI=; b=dqIRzCME25md CNqqKaQP6i+gp1v/p/WRA5mx0ujbA8KBmnCKDXM8ZtKZF/uKTn5Ljhps57IvpCa6 QsgL1NlL57KjXONtWdpx8AnsUqxoY94JAwfIPFs4Sqbys184buqQi0FCwe7g/+CP MGDIwLxKzLTAiMEn3pvVPWdzvkWxvaoWikmFwBG/LtCHUplSyWrPszi+V6kJN7SH YOGtctO3BGb1j+gDYOGfBQEd8tOO5/hHxdImZFA70LQkgnWP7JdEliGlUM5FUZ7X hfnFWJt6rQdLEZCINjMoLjgXMl7QXAwJ/s1xZjXQoJnh1gJKOWfSmInnHSD0v7Cu hZnwvg1YlQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a904824a (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <36132@debbugs.gnu.org>; Sat, 8 Jun 2019 04:47:42 +0000 (UTC) From: Tobias Geerinckx-Rice To: 36132@debbugs.gnu.org Subject: [PATCH 2/2] installer: Show, don't Hide. Date: Sat, 8 Jun 2019 06:47:29 +0200 Message-Id: <20190608044729.14700-2-me@tobias.gr> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190608044729.14700-1-me@tobias.gr> References: <87y32c663d.fsf@nckx> <20190608044729.14700-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/installer/newt/user.scm (run-user-add-page): Change the input visibility checkbox's text to ‘Show’, and default to unchecked. * gnu/installer/newt/page.scm (run-input-page): Likewise. Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?. --- gnu/installer/newt/page.scm | 9 +++++---- gnu/installer/newt/user.scm | 7 ++++--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/gnu/installer/newt/page.scm b/gnu/installer/newt/page.scm index 728721c08f..b061988336 100644 --- a/gnu/installer/newt/page.scm +++ b/gnu/installer/newt/page.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Ludovic Courtès +;;; Copyright © 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -75,7 +76,7 @@ this page to TITLE." #:key (allow-empty-input? #f) (default-text #f) - (input-hide-checkbox? #f) + (input-show-checkbox? #f) (input-field-width 40) (input-flags 0)) "Run a page to prompt user for an input. The given TEXT will be displayed @@ -88,8 +89,8 @@ input box, such as FLAG-PASSWORD." input-field-width #:flags FLAG-BORDER)) (input-visible-cb - (make-checkbox -1 -1 (G_ "Hide") #\x "x ")) - (input-flags* (if input-hide-checkbox? + (make-checkbox -1 -1 (G_ "Show") #\space "x ")) + (input-flags* (if input-show-checkbox? (logior FLAG-PASSWORD FLAG-SCROLL input-flags) input-flags)) @@ -102,7 +103,7 @@ input box, such as FLAG-PASSWORD." (apply horizontal-stacked-grid GRID-ELEMENT-COMPONENT input-entry - `(,@(if input-hide-checkbox? + `(,@(if input-show-checkbox? (list GRID-ELEMENT-COMPONENT input-visible-cb) '()))) GRID-ELEMENT-COMPONENT ok-button)) diff --git a/gnu/installer/newt/user.scm b/gnu/installer/newt/user.scm index dab805198f..3ef105fe81 100644 --- a/gnu/installer/newt/user.scm +++ b/gnu/installer/newt/user.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Ludovic Courtès +;;; Copyright © 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -55,7 +56,7 @@ REAL-NAME, and HOME-DIRECTORY as the initial values in the form." (entry-home-directory (make-entry -1 -1 entry-width #:initial-value home-directory)) (password-visible-cb - (make-checkbox -1 -1 (G_ "Hide") #\x "x ")) + (make-checkbox -1 -1 (G_ "Show") #\space "x ")) (entry-password (make-entry -1 -1 entry-width #:flags (logior FLAG-PASSWORD FLAG-SCROLL))) @@ -156,7 +157,7 @@ a thunk, if the confirmation doesn't match PASSWORD, and return its result." (run-input-page (G_ "Please confirm the password.") (G_ "Password confirmation required") #:allow-empty-input? #t - #:input-hide-checkbox? #t)) + #:input-show-checkbox? #t)) (if (string=? password confirmation) password @@ -173,7 +174,7 @@ a thunk, if the confirmation doesn't match PASSWORD, and return its result." (run-input-page (G_ "Please choose a password for the system \ administrator (\"root\").") (G_ "System administrator password") - #:input-hide-checkbox? #t)) + #:input-show-checkbox? #t)) (confirm-password password run-root-password-page)) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 11:43:55 2019 Received: (at 36132) by debbugs.gnu.org; 8 Jun 2019 15:43:56 +0000 Received: from localhost ([127.0.0.1]:53542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZdVb-00044Y-MD for submit@debbugs.gnu.org; Sat, 08 Jun 2019 11:43:55 -0400 Received: from tobias.gr ([80.241.217.52]:46686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZdVY-00044L-VM; Sat, 08 Jun 2019 11:43:54 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id a8d4d18b; Sat, 8 Jun 2019 15:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=2018; i=me@tobias.gr; bh=9N62+RIC/ /pq7VU3NVuO7L6CxCCWn1Hu9b1Zw96+sIg=; b=Vhsz4ok6lXMOcLX4m5jO4b1XX FE5aVegb/rx6p8kxaoAe29wkG1O00EcBjX/prAMEBj6Y7h2MzpWweRGqWOhGVW1+ p5gZru14K+i64hTMwBUmStkvQ7YGY82SofMc34tlDcmdXddkyWeINBpVPlhhkpjA tjJ/DgKk3rSwjTkWAxbNjI/AOrsjFLLFmt4FS/s6ci6pRJBIOHO/oRX5Jcwnlq6f xj9KN3nxJmtYpbF9nUAzGMnfgsEbbcO1n0oor76GpkpKPwgjV9V9KvBheyfF1a5u bqjHz2k06oH6KDPslcrHACA3wUddz+6v0q1NgU0EiVe74TSPT0MMBVllCiN6A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 18315f9c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 8 Jun 2019 15:43:46 +0000 (UTC) From: Tobias Geerinckx-Rice To: 36132@debbugs.gnu.org Subject: [PATCH 3/2] installer: Hide the Wi-Fi passphrase by default. Date: Sat, 8 Jun 2019 17:43:38 +0200 Message-Id: <20190608154338.8064-1-me@tobias.gr> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 Cc: 36135@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/installer/newt/wifi.scm (run-wifi-password-page): Add an #:INPUT-SHOW-CHECKBOX? to the input page. --- Guix, This adds a ‘[ ] Show’ checkbox to the newt installer's Wi-Fi passphrase input field, which has also been requested at least twice now. Most recently here[0]. Kind regards, T G-R [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36135 gnu/installer/newt/wifi.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm index 1cb2ef2df3..040e013293 100644 --- a/gnu/installer/newt/wifi.scm +++ b/gnu/installer/newt/wifi.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Meiyo Peng +;;; Copyright © 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,7 +89,8 @@ nmc_wifi_strength_bars." (define (run-wifi-password-page) "Run a page prompting user for a password and return it." (run-input-page (G_ "Please enter the wifi password.") - (G_ "Password required"))) + (G_ "Password required") + #:input-show-checkbox? #t)) (define (run-wrong-password-page service-name) "Run a page to inform user of a wrong password input." -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 11:49:58 2019 Received: (at control) by debbugs.gnu.org; 8 Jun 2019 15:49:58 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZdbS-0004Dy-8n for submit@debbugs.gnu.org; Sat, 08 Jun 2019 11:49:58 -0400 Received: from tobias.gr ([80.241.217.52]:46710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZdbR-0004Dr-5t for control@debbugs.gnu.org; Sat, 08 Jun 2019 11:49:57 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 8165d063 for ; Sat, 8 Jun 2019 15:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :date:message-id:mime-version:content-type; s=2018; i= me@tobias.gr; bh=q1pWJ74GJLzyEYwaLpQqnS2dLCf5cLmjp41zGEQG/0I=; b= dVBzqeSko4QdAtOeiQCRlqTcu7vgFrHPdLU3ddOAyBQlmC2T6FuPjU9ROL3gitPK 8Uxt4pkjfGEKeiC16XU6XdDyUMiPCBQduo0nWAzKHJQQboKJMz81MARhFIn2eIzk l/PNFJrSgeiv+pZOZtzJmpJdjxOgMnTwGTKKLx10M5hbbEtiiMPljIenHCHgxzfQ vO4i+Mq7DHCbPNT4RIQ/NmzvHe1PrzrbklYosXPesbrEeJnIz369Ak3amZh2rdtL zK9FEcfgGBXK86iY2C7L2lOyrZcvMixHIgQ/RHfCbNB1NABEakwh9wE1zr6LUlaX HamCe4csXVaQB834e95RsA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id af2258e0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Sat, 8 Jun 2019 15:49:51 +0000 (UTC) From: Tobias Geerinckx-Rice To: GNU bug tracker automated control server Date: Sat, 08 Jun 2019 17:49:50 +0200 Message-ID: <87v9xg5b6p.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) reassign 35901 guix-patches merge 35901 36132 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 04:03:14 2019 Received: (at 36132) by debbugs.gnu.org; 11 Jun 2019 08:03:15 +0000 Received: from localhost ([127.0.0.1]:57960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1habkQ-0000XC-L7 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 04:03:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1habkN-0000Wo-Bm; Tue, 11 Jun 2019 04:03:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1habkE-0003rf-W3; Tue, 11 Jun 2019 04:03:03 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38894 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1habkD-0001os-M9; Tue, 11 Jun 2019 04:03:02 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step. References: <87y32c663d.fsf@nckx> <20190608044729.14700-1-me@tobias.gr> Date: Tue, 11 Jun 2019 10:02:57 +0200 In-Reply-To: <20190608044729.14700-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Sat, 8 Jun 2019 06:47:28 +0200") Message-ID: <878su87dn2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 Cc: 36132@debbugs.gnu.org, 35901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi!, Tobias Geerinckx-Rice skribis: > Multiple users have been understandably displeased after finding out > that their network card was unsupported, and Internet access mandatory, > after having already formatted their partitions. > > * gnu/installer.scm (installer-steps): Run the =E2=80=98partition=E2=80= =99 step just > before the =E2=80=98final=E2=80=99 one. LGTM! Please add =E2=80=9CFixes .=E2=80=9D in t= he log. Should we also move =E2=80=9CNetwork selection=E2=80=9D above =E2=80=9CHost= name=E2=80=9D? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 04:06:09 2019 Received: (at 36132) by debbugs.gnu.org; 11 Jun 2019 08:06:09 +0000 Received: from localhost ([127.0.0.1]:57967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1habnF-0000bz-Df for submit@debbugs.gnu.org; Tue, 11 Jun 2019 04:06:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1habnE-0000bg-80; Tue, 11 Jun 2019 04:06:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1habn6-0005jG-57; Tue, 11 Jun 2019 04:06:02 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38896 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1habn3-000263-SQ; Tue, 11 Jun 2019 04:05:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#36132] [PATCH 2/2] installer: Show, don't Hide. References: <87y32c663d.fsf@nckx> <20190608044729.14700-1-me@tobias.gr> <20190608044729.14700-2-me@tobias.gr> Date: Tue, 11 Jun 2019 10:05:56 +0200 In-Reply-To: <20190608044729.14700-2-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Sat, 8 Jun 2019 06:47:29 +0200") Message-ID: <8736kg7di3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 Cc: 36132@debbugs.gnu.org, 35901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Tobias Geerinckx-Rice skribis: > * gnu/installer/newt/user.scm (run-user-add-page): Change the input > visibility checkbox's text to =E2=80=98Show=E2=80=99, and default to unch= ecked. > * gnu/installer/newt/page.scm (run-input-page): Likewise. > Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?. I think the argument should perhaps be =E2=80=98input-visibility-checkbox?= =E2=80=99, otherwise I find it a bit unclear (both before and after the patch actually.) Other than that LGTM, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 26 10:00:22 2019 Received: (at 36132-done) by debbugs.gnu.org; 26 Aug 2019 14:00:22 +0000 Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2FXg-0000Zx-JC for submit@debbugs.gnu.org; Mon, 26 Aug 2019 10:00:21 -0400 Received: from tobias.gr ([80.241.217.52]:40992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2FXb-0000Z4-EU for 36132-done@debbugs.gnu.org; Mon, 26 Aug 2019 10:00:17 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id f82c0bec for <36132-done@debbugs.gnu.org>; Mon, 26 Aug 2019 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-type; s=2018; i= me@tobias.gr; bh=yryMe/+XQi67X+PJn+scny0bzBI6hG7IBa2QkY+iFnE=; b= FDcO0T1R5vRUiJP9fhR1/hTnL8NEF01rcQJiNUZuY6KCPIgJg0EVYZmH6F6tRg14 aS3hHv+eSz7HOziPN2+6gbA18b8PVYrYRsqaDr1z75LtriQ464cPLjFYS2y7SVsM XqC0C6wwHr7sVLKNKjR+qYx+M31rJzqhj5V+zvQNu+boxGXgO0FL4XmIBi3gU7lK QifLZqVuKCt0d0o3NIqebhz8mX/qoig2OYfGetNNTqiY79fQbNNiu6rhv8fsiE/l P6vXVpiD0LstcVLcKU1VLmTe113Su8d1A8VbC69y4+BSdA2OrDNOB6aVXPEOxaAz ro8FFsZeeOZ2C3J0wap4dA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 3a31889f (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <36132-done@debbugs.gnu.org>; Mon, 26 Aug 2019 14:00:11 +0000 (UTC) From: Tobias Geerinckx-Rice To: 36132-done@debbugs.gnu.org Subject: Re: Two installer UX tweaks Date: Mon, 26 Aug 2019 16:00:10 +0200 Message-ID: <87mufwqb6d.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo' wrote: > I think the argument should perhaps be=20 > =E2=80=98input-visibility-checkbox?=E2=80=99 Done & pushed as 55c43108ac763c68f95cce3d32c60b8944b771f5 &c. Thanks, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXWPl6gAKCRANsP+IT1Vt eZieAQCrkKkKyThD8ucE6Tca8nF/+i6X+MpPQjQc2qCoKeXt4QD5AWyXfIm/jFrQ dGVS5BNmJymWB2Ap7uVzaX7cF4zPYQA= =hQQk -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 26 10:23:21 2019 Received: (at 36132) by debbugs.gnu.org; 26 Aug 2019 14:23:21 +0000 Received: from localhost ([127.0.0.1]:47031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Ftx-0001Jw-10 for submit@debbugs.gnu.org; Mon, 26 Aug 2019 10:23:21 -0400 Received: from tobias.gr ([80.241.217.52]:41610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Ftu-0001Jf-9B; Mon, 26 Aug 2019 10:23:18 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 4509e346; Mon, 26 Aug 2019 14:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=a0nm+gIfgA5bQd02ODWb2M +tPxCE3EqZIsjOlTRcmFg=; b=lrK88AfP5qX7ath8RCtd2K55SxCI5QfBAKyHR1 totjg95bVULqiBBWDFFDKwXL4Y+j9CsRxv5I098bByLCGLmqHHzaPby9tHJJOtrp GgAj7A5OS7m6DUzorQZS+FeEGjsiuUCQg+mMFJ43bu2wOagZ8xc5HDF8szpvxr4l 8hz6myd2zvvpBdY0uhMZLjCQB9uRsUn2z1+BNffV1ZlbL7WwBXtJZhYeObiqliQ0 WFC3IHgvrPoRkkTKK6ohPqQiFS0CJQR0arwOShydOBf7L/5T/2IQtoypAAKGanpW 65quztZXFzS4Vbk1L2XgrjmvOSCnN73RtGjx7mNUJTs0Dgfg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2f62a482 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 26 Aug 2019 14:23:14 +0000 (UTC) From: Tobias Geerinckx-Rice To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step. References: <87y32c663d.fsf@nckx> <20190608044729.14700-1-me@tobias.gr> <878su87dn2.fsf@gnu.org> In-reply-to: <878su87dn2.fsf@gnu.org> Date: Mon, 26 Aug 2019 16:23:13 +0200 Message-ID: <87lfvgqa3y.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36132 Cc: 36132@debbugs.gnu.org, 35901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A > LGTM! Please add =E2=80=9CFixes .=E2=80=9D in= the=20 > log. Oh, bugger. This message got lost in my messy box (it floated=20 back to the top when I closed the bug). Sorry about that. > Should we also move =E2=80=9CNetwork selection=E2=80=9D above =E2=80=9CHo= stname=E2=80=9D? Perhaps! I'll fire up the installer again and see if anything new=20 seems odd/out of place after these few months.=20 Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXWPrUQAKCRANsP+IT1Vt eQ1yAP0c6rMMB414vgJ8QQM6owjiHAvklmy5/nwSsW5Q7BuucAEA0on33OtTqi3P Q/n5kUcCUX+W8zec0Val9oBuaTVXEAM= =iq60 -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Jun 19 14:17:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator