From unknown Tue Aug 19 05:10:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3613 <3613@debbugs.gnu.org> To: bug#3613 <3613@debbugs.gnu.org> Subject: Status: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser Reply-To: bug#3613 <3613@debbugs.gnu.org> Date: Tue, 19 Aug 2025 12:10:31 +0000 retitle 3613 [PATCH] Allow trailing spaces and " -" in filenames for the co= mpile output parser reassign 3613 emacs submitter 3613 Laurence Darby severity 3613 normal tag 3613 wontfix thanks From ldarby@tuffmail.com Thu Jun 18 18:07:50 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 19 Jun 2009 01:07:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5J17iPZ032600 for ; Thu, 18 Jun 2009 18:07:47 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHSa0-0007OR-HU for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2009 21:07:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHSZw-0007H7-3X for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2009 21:07:44 -0400 Received: from [199.232.76.173] (port=60100 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHSZw-0007H3-0c for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2009 21:07:40 -0400 Received: from mx20.gnu.org ([199.232.41.8]:62941) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MHSZv-0004oI-Dv for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2009 21:07:39 -0400 Received: from mxout-08.mxes.net ([216.86.168.183]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHSZt-000305-W0 for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2009 21:07:38 -0400 Received: from home.eagach.dyndns.org (unknown [81.103.21.187]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTPSA id 65407D0A85 for ; Thu, 18 Jun 2009 21:07:36 -0400 (EDT) Date: Fri, 19 Jun 2009 02:07:35 +0100 From: Laurence Darby To: bug-gnu-emacs@gnu.org Subject: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser Message-Id: <20090619020735.abe167c9.ldarby@tuffmail.com> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.12.9; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Detected-Operating-System: by mx20.gnu.org: FreeBSD 4.6-4.9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Hi, I actually have a lot of files that have " -" in the names, this patch fixes it for me. If anyone understands this regex (I don't really, just kept changing it till it worked), can you see if the change breaks anything else? Thanks, Laurence (Please CC me on replies, I'm not subscribed, thanks) --- lisp/progmodes/compile.el | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 11428d2..328f31f 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -245,11 +245,9 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1)) ;; line number starts with "SS". --Stef ;; The core of the regexp is the one with *?. It says that a file name - ;; can be composed of any non-newline char, but it also rules out some - ;; valid but unlikely cases, such as a trailing space or a space - ;; followed by a -. + ;; can be composed of any non-newline char. "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\ -\\([0-9]*[^0-9\n]\\(?:[^\n ]\\| [^-/\n]\\)*?\\): ?\ +\\([0-9]*[^0-9\n]\\(?:[^\n]\\| [^/\n]\\)*?\\): ?\ \\([0-9]+\\)\\(?:\\([.:]\\)\\([0-9]+\\)\\)?\ \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\ \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\ -- 1.6.2.2 From monnier@iro.umontreal.ca Fri Jun 26 18:13:40 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 27 Jun 2009 01:13:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5R1DaBP011623 for ; Fri, 26 Jun 2009 18:13:37 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKMU4-0001sh-2W for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2009 21:13:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKMTz-0001ox-Fz for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2009 21:13:35 -0400 Received: from [199.232.76.173] (port=51352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKMTz-0001oq-CF for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2009 21:13:31 -0400 Received: from smtp-01.vtx.ch ([212.147.0.84]:37217) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MKMTz-0000ai-1A for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2009 21:13:31 -0400 Received: from alfajor.home (dyn.83-228-218-202.dsl.vtx.ch [83.228.218.202]) by smtp-01.vtx.ch (VTX Services SA) with ESMTP id 4B0E828046; Sat, 27 Jun 2009 03:13:30 +0200 (CEST) Received: by alfajor.home (Postfix, from userid 20848) id 15A2864341; Sat, 27 Jun 2009 03:13:29 +0200 (CEST) From: Stefan Monnier To: Laurence Darby Cc: 3613@debbugs.gnu.org, bug-gnu-emacs@gnu.org Subject: Re: bug#3613: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser Message-ID: References: <20090619020735.abe167c9.ldarby@tuffmail.com> Date: Sat, 27 Jun 2009 03:13:29 +0200 In-Reply-To: <20090619020735.abe167c9.ldarby@tuffmail.com> (Laurence Darby's message of "Fri, 19 Jun 2009 02:07:35 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) > I actually have a lot of files that have " -" in the names, this patch > fixes it for me. If anyone understands this regex (I don't really, > just kept changing it till it worked), can you see if the change breaks > anything else? Your change turns the (core of) regexp back to just ".*?" as it was in the past. We disallowed trailing spaces as well as " -" because they lead to false positives in some cases. There's no way to win in all cases, sadly. Stefan From rgm@gnu.org Wed Nov 4 14:01:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Nov 2009 22:01:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA4M1e7A002782 for ; Wed, 4 Nov 2009 14:01:42 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1N5nv9-0000E4-Ub; Wed, 04 Nov 2009 17:01:39 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19185.63939.653937.427902@fencepost.gnu.org> Date: Wed, 4 Nov 2009 17:01:39 -0500 From: Glenn Morris To: control Subject: control severity 3631 minor severity 3267 minor reassign 3267 emacsbugs.donarmstrong.com severity 3481 minor severity 3644 minor severity 3722 wishlist severity 4360 minor tags 3613 wontfix tags 2134 = severity 4731 minor severity 3849 wishlist close 3564 merge 4668 3227 tags 2792 wontfix minor severity 4433 minor severity 4668 minor severity 4562 minor severity 3934 minor severity 3856 minor severity 3801 minor severity 3615 minor severity 3599 minor severity 3598 minor severity 3575 minor severity 3566 minor severity 3550 minor severity 3549 minor severity 3527 minor severity 3525 minor severity 3524 minor severity 3523 minor severity 3519 minor severity 3509 minor severity 3503 minor severity 3393 minor severity 3371 minor severity 3320 minor severity 3313 minor severity 3249 minor severity 3227 minor severity 3138 minor severity 3135 minor severity 3137 minor severity 3052 minor severity 3042 minor severity 2974 minor severity 2946 minor severity 2792 minor severity 1749 minor severity 1375 minor severity 1144 minor From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 02:19:35 2011 Received: (at control) by debbugs.gnu.org; 17 Sep 2011 06:19:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4oFS-0004b4-BE for submit@debbugs.gnu.org; Sat, 17 Sep 2011 02:19:34 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R4oFQ-0004ax-JT for control@debbugs.gnu.org; Sat, 17 Sep 2011 02:19:33 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R4oAg-0002jL-PY for control@debbugs.gnu.org; Sat, 17 Sep 2011 08:14:38 +0200 Date: Sat, 17 Sep 2011 08:11:20 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #3613 X-MailScanner-ID: 1R4oAg-0002jL-PY X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316844878.85504@GkqYqYHZwHgVit0YmY0WkQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 3613 From unknown Tue Aug 19 05:10:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 Oct 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator