GNU bug report logs - #3613
[PATCH] Allow trailing spaces and " -" in filenames for the compile output parser

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3613 in the body.
You can then email your comments to 3613 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Laurence Darby <ldarby <at> tuffmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow trailing spaces and " -" in filenames for the compile
 output parser
Date: Fri, 19 Jun 2009 02:07:35 +0100

Hi,

I actually have a lot of files that have " -" in the names, this patch
fixes it for me.  If anyone understands this regex (I don't really,
just kept changing it till it worked), can you see if the change breaks
anything else?

Thanks,
Laurence

(Please CC me on replies, I'm not subscribed, thanks)

---
 lisp/progmodes/compile.el |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 11428d2..328f31f 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -245,11 +245,9 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
      ;; line number starts with "SS".  --Stef
 
      ;; The core of the regexp is the one with *?.  It says that a file name
-     ;; can be composed of any non-newline char, but it also rules out some
-     ;; valid but unlikely cases, such as a trailing space or a space
-     ;; followed by a -.
+     ;; can be composed of any non-newline char.
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([0-9]*[^0-9\n]\\(?:[^\n ]\\| [^-/\n]\\)*?\\): ?\
+\\([0-9]*[^0-9\n]\\(?:[^\n]\\| [^/\n]\\)*?\\): ?\
 \\([0-9]+\\)\\(?:\\([.:]\\)\\([0-9]+\\)\\)?\
 \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
-- 
1.6.2.2

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Laurence Darby <ldarby <at> tuffmail.com>
Cc: 3613 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#3613: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser
Date: Sat, 27 Jun 2009 03:13:29 +0200

> I actually have a lot of files that have " -" in the names, this patch
> fixes it for me.  If anyone understands this regex (I don't really,
> just kept changing it till it worked), can you see if the change breaks
> anything else?

Your change turns the (core of) regexp back to just ".*?" as it was in
the past.  We disallowed trailing spaces as well as " -" because they
lead to false positives in some cases.
There's no way to win in all cases, sadly.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.