GNU bug report logs - #36128
Failed tests for sed 4.7 on Solaris 10 x86

Previous Next

To reply to this bug, email your comments to 36128 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dagobert Michelsen <dam <at> opencsw.org>
To: bug-sed <at> gnu.org
Subject: Failed tests for sed 4.7 on Solaris 10 x86
Date: Fri, 7 Jun 2019 14:55:39 +0200

[Message part 1 (text/plain, inline)]

Hi,

I noticed two failed tests on Solaris 10 x86, please see the attached test-suite.log:

FAIL: testsuite/misc.pl
FAIL: testsuite/debug.pl

[test-suite.log (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Please let me know if you need further information or if I should test anything.


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dagobert Michelsen <dam <at> opencsw.org>
To: bug-sed <at> gnu.org
Subject: Re: Failed tests for sed 4.7 on Solaris 10 x86
Date: Tue, 24 Sep 2019 14:15:17 +0200

[Message part 1 (text/plain, inline)]

Hi,

Am 07.06.2019 um 14:55 schrieb Dagobert Michelsen <dam <at> opencsw.org>:
> I noticed two failed tests on Solaris 10 x86, please see the attached test-suite.log:
> 
> FAIL: testsuite/misc.pl
> FAIL: testsuite/debug.pl
> 
> <test-suite.log>
> 
> Please let me know if you need further information or if I should test anything.

The problem still exists and I would really like to release an updated sed.
Can someone please have a look?

[test-suite.log (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

Message #11 received at 36128 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Dagobert Michelsen <dam <at> opencsw.org>, 36128 <at> debbugs.gnu.org
Subject: Re: bug#36128: Failed tests for sed 4.7 on Solaris 10 x86
Date: Wed, 25 Sep 2019 11:57:13 -0600

Hello,

On 2019-09-24 6:15 a.m., Dagobert Michelsen wrote:
> 
> Am 07.06.2019 um 14:55 schrieb Dagobert Michelsen <dam <at> opencsw.org>:
>> I noticed two failed tests on Solaris 10 x86, please see the attached test-suite.log:
>>
>> FAIL: testsuite/misc.pl
>> FAIL: testsuite/debug.pl
>>
>> Please let me know if you need further information or if I should test anything.
> 
> The problem still exists and I would really like to release an updated sed.
> Can someone please have a look?

From a cursory check,
I think this is an issue in the interplay between the old perl (5.8.4)
and the old shell (/bin/sh) on solaris 10.

---

For example, the "space" test (which is the first failure in the log)
is defined like so:
      ['space', q('s/_\S/XX/g;s/\s/_/g'),
          {IN=>  "Hello World\t!\nSecond_line_ of tests\n" },
          {OUT=> "Hello_World_!\nSecondXXine__of_tests\n" }],

When I run it interactively on OpenCSW's unstable10x, it works as expected:

   > printf 'Hello World\t!\nSecond_line_ of tests\n' > space.in
   > ./sed/sed 's/_\S/XX/g;s/\s/_/g' space.in
   Hello_World_!
   SecondXXine__of_tests

The failure in the log can be reproduced interactively if the 
backslashes are removed from the sed script:

   > ./sed/sed 's/_S/XX/g;s/s/_/g' space.in
   Hello World     !
   Second_line_ of te_t_

I take it as a hint that the perl quoting of the string using q('')
then going through /bin/sh somehow "loses" these backslashes.

---

Another example:
If I rebuild sed and forces the shell to be /usr/bin/bash,
all tests pass:

    ./configure SHELL=/usr/bin/bash
    make
    make check

---

As such, I think these are false positives, and the sed-4.7 binary
should work fine on Solaris 10 x86.

It might be worth fixing the tests, or detecting problematic shell
and working around it, but I can't get to that in the near future
(patches are of course welcomed).

Hope this helps,
 - assaf

Message #14 received at 36128 <at> debbugs.gnu.org (full text, mbox):

From: Dagobert Michelsen <dam <at> opencsw.org>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 36128 <at> debbugs.gnu.org
Subject: Re: bug#36128: Failed tests for sed 4.7 on Solaris 10 x86
Date: Mon, 30 Sep 2019 14:05:05 +0200

Hi Assaf,

Am 25.09.2019 um 19:57 schrieb Assaf Gordon <assafgordon <at> gmail.com>:
> On 2019-09-24 6:15 a.m., Dagobert Michelsen wrote:
>> Am 07.06.2019 um 14:55 schrieb Dagobert Michelsen <dam <at> opencsw.org>:
>>> I noticed two failed tests on Solaris 10 x86, please see the attached test-suite.log:
>>> 
>>> FAIL: testsuite/misc.pl
>>> FAIL: testsuite/debug.pl
>>> 
>>> Please let me know if you need further information or if I should test anything.
>> The problem still exists and I would really like to release an updated sed.
>> Can someone please have a look?
> 
> From a cursory check,
> I think this is an issue in the interplay between the old perl (5.8.4)
> and the old shell (/bin/sh) on solaris 10.
...
> It might be worth fixing the tests, or detecting problematic shell
> and working around it, but I can't get to that in the near future
> (patches are of course welcomed).

Thank you very much for the analysis and setting me on the right tracj!
There is already Perl 5.10.1 from OpenCSW pulled in, but the SHELL
as /bin/sh is a real bourne shell instead of bash. When I pass in a more recent Shell
from OpenCSW explicitly the testsuite passes cleanly with
  gmake SHELL=/opt/csw/bin/bash check

I fiddled with the parameters and the final solution was to just tell configure to
use a bash instead of a regular bourne shell on Solaris 10 with
  CONFIG_SHELL=/bin/bash ./configure ...
during configure time.


Thanks again and best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.