GNU bug report logs - #36115
27.0.50; Git master branch compile error with --with-cairo configure flag

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36115 in the body.
You can then email your comments to 36115 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eugene Mah <eugenemah <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50;
 Git master branch compile error with --with-cairo configure flag
Date: Thu, 6 Jun 2019 09:40:14 -0400

[Message part 1 (text/plain, inline)]

When compiling the latest git master branch, the following error occurs:

image.c: In function ‘image_set_crop’:
image.c:2046:16: error: ‘width’ undeclared (first use in this function);
did you mean ‘Qwidth’?
 2046 |   img->width = width;
      |                ^~~~~
      |                Qwidth
image.c:2046:16: note: each undeclared identifier is reported only once for
each function it appears in
image.c:2047:17: error: ‘height’ undeclared (first use in this function);
did you mean ‘Qheight’?
 2047 |   img->height = height;
      |                 ^~~~~~
      |                 Qheight
make[1]: *** [Makefile:394: image.o] Error 1


Configured using:
'./configure --prefix=/opt --with-wide-int --with-sound --with-xwidgets
--with-x --with-modules --with-x-toolkit=gtk3 --with-cairo'

When the --with-cairo flag is omitted, master branch compiles without
issue.

The error occurs in the image_set_crop() function, so perhaps related to
this commit
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9

Eugene
---------------------------------------------------------------------
Eugene Mah, M.Sc., DABR               eugenemah <at> gmail.com
Medical Physicist                     maheug <at> musc.edu
                                      "For I am a Bear of Very Little
                                       Brain, and long words Bother
Charleston, SC 29425                   me." - Winnie the Pooh
http://v16.imablog.net/               Jabber: imabug <at> imabug.net
http://blog.ab4ug.net/
PGP KeyID                                    PGP key available on request O-
0x56B705CAE9542BB8
---------------------------------------------------------------------

[Message part 2 (text/html, inline)]

Message #8 received at 36115 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eugene Mah <eugenemah <at> gmail.com>
Cc: 36115 <at> debbugs.gnu.org
Subject: Re: bug#36115: 27.0.50;
 Git master branch compile error with --with-cairo configure flag
Date: Fri, 07 Jun 2019 08:05:50 -0400

tags 36115 fixed
close 36115 
quit

Eugene Mah <eugenemah <at> gmail.com> writes:

> When compiling the latest git master branch, the following error occurs:
>
> image.c: In function ‘image_set_crop’:
> image.c:2046:16: error: ‘width’ undeclared (first use in this function);
> did you mean ‘Qwidth’?
>  2046 |   img->width = width;

> When the --with-cairo flag is omitted, master branch compiles without
> issue.
>
> The error occurs in the image_set_crop() function, so perhaps related to
> this commit
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9

I believe this was fixed yesterday.

c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16

Message #15 received at 36115 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Eugene Mah <eugenemah <at> gmail.com>, 36115 <at> debbugs.gnu.org
Subject: Re: bug#36115: 27.0.50; Git master branch compile error with
 --with-cairo configure flag
Date: Fri, 7 Jun 2019 17:48:26 +0100

On Fri, Jun 07, 2019 at 08:05:50AM -0400, Noam Postavsky wrote:
> tags 36115 fixed
> close 36115 
> quit
> 
> Eugene Mah <eugenemah <at> gmail.com> writes:
> 
> > When compiling the latest git master branch, the following error occurs:
> >
> > image.c: In function ‘image_set_crop’:
> > image.c:2046:16: error: ‘width’ undeclared (first use in this function);
> > did you mean ‘Qwidth’?
> >  2046 |   img->width = width;
> 
> > When the --with-cairo flag is omitted, master branch compiles without
> > issue.
> >
> > The error occurs in the image_set_crop() function, so perhaps related to
> > this commit
> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9
> 
> I believe this was fixed yesterday.
> 
> c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed"
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16

I hadn’t noticed this. I suspect a merge from master has transposed
part of image_set_size into image_set_crop in my local branch and I
failed to see it before pushing.

I’ll sort this out asap.
-- 
Alan Third

Message #18 received at 36115 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Eugene Mah <eugenemah <at> gmail.com>, 36115 <at> debbugs.gnu.org
Subject: Re: bug#36115: 27.0.50; Git master branch compile error with
 --with-cairo configure flag
Date: Fri, 7 Jun 2019 19:18:22 +0100

On Fri, Jun 07, 2019 at 05:48:26PM +0100, Alan Third wrote:
> On Fri, Jun 07, 2019 at 08:05:50AM -0400, Noam Postavsky wrote:
> > tags 36115 fixed
> > close 36115 
> > quit
> > 
> > Eugene Mah <eugenemah <at> gmail.com> writes:
> > 
> > > When compiling the latest git master branch, the following error occurs:
> > >
> > > image.c: In function ‘image_set_crop’:
> > > image.c:2046:16: error: ‘width’ undeclared (first use in this function);
> > > did you mean ‘Qwidth’?
> > >  2046 |   img->width = width;
> > 
> > > When the --with-cairo flag is omitted, master branch compiles without
> > > issue.
> > >
> > > The error occurs in the image_set_crop() function, so perhaps related to
> > > this commit
> > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9
> > 
> > I believe this was fixed yesterday.
> > 
> > c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed"
> > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16
> 
> I hadn’t noticed this. I suspect a merge from master has transposed
> part of image_set_size into image_set_crop in my local branch and I
> failed to see it before pushing.
> 
> I’ll sort this out asap.

Never mind, Yamamoto Mitsuharu got there before me:

https://git.savannah.gnu.org/cgit/emacs.git/commit/src/image.c?id=3a1f92d09bbcb4dbd2a2ebe1bee0e564e51c4615
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.