GNU bug report logs - #36106
[PATCH] guix: git-download: Remove explicit import.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Robert Vollmert <rob <at> vllmrt.net>
Subject: bug#36106: closed (Re: [bug#36106] [PATCH] guix: git-download:
 Remove explicit import.)
Date: Thu, 06 Jun 2019 15:44:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36106: [PATCH] guix: git-download: Remove explicit import.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36106 <at> debbugs.gnu.org.

-- 
36106: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36106
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 36106-done <at> debbugs.gnu.org
Subject: Re: [bug#36106] [PATCH] guix: git-download: Remove explicit import.
Date: Thu, 06 Jun 2019 17:43:21 +0200

Hi,

Robert Vollmert <rob <at> vllmrt.net> skribis:

> With guile-git version 0.2, repository-working-directory is no
> longer private.
>
> * guix/git-download.scm (git-file-list): Refer to public
> repository-working-directory.

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Cc: Robert Vollmert <rob <at> vllmrt.net>
Subject: [PATCH] guix: git-download: Remove explicit import.
Date: Wed,  5 Jun 2019 20:56:14 +0200

With guile-git version 0.2, repository-working-directory is no
longer private.

* guix/git-download.scm (git-file-list): Refer to public
repository-working-directory.
---
 guix/git-download.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/guix/git-download.scm b/guix/git-download.scm
index 6cf267d6c8..f904d11c25 100644
--- a/guix/git-download.scm
+++ b/guix/git-download.scm
@@ -185,9 +185,7 @@ are relative to DIRECTORY, which is not necessarily the root of the checkout."
          (directory  (string-append (canonicalize-path directory) "/"))
          (dot-git    (repository-discover directory))
          (repository (repository-open dot-git))
-         ;; XXX: This procedure is mistakenly private in Guile-Git 0.1.0.
-         (workdir    ((@@ (git repository) repository-working-directory)
-                      repository))
+         (workdir    (repository-working-directory repository))
          (head       (repository-head repository))
          (oid        (reference-target head))
          (commit     (commit-lookup repository oid))
-- 
2.20.1 (Apple Git-117)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.