From unknown Sat Aug 09 22:10:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#36106] [PATCH] guix: git-download: Remove explicit import. Resent-From: Robert Vollmert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jun 2019 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36106 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 36106@debbugs.gnu.org Cc: Robert Vollmert X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155976100511560 (code B ref -1); Wed, 05 Jun 2019 18:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jun 2019 18:56:45 +0000 Received: from localhost ([127.0.0.1]:48220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYb5Z-00030O-C5 for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYb5X-00030B-U5 for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:45522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYb5S-0000ut-Nn for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYb5R-000704-Sl for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYb5Q-0000tr-Q2 for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:37 -0400 Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:38872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYb5Q-0000pB-KJ for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:36 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id B00C14EF5C; Wed, 5 Jun 2019 20:56:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id wnk_lN-bTbkg; Wed, 5 Jun 2019 20:56:16 +0200 (CEST) From: Robert Vollmert Date: Wed, 5 Jun 2019 20:56:14 +0200 Message-Id: <20190605185614.80737-1-rob@vllmrt.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:67c:2050:104:0:1:25:1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) With guile-git version 0.2, repository-working-directory is no longer private. * guix/git-download.scm (git-file-list): Refer to public repository-working-directory. --- guix/git-download.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/guix/git-download.scm b/guix/git-download.scm index 6cf267d6c8..f904d11c25 100644 --- a/guix/git-download.scm +++ b/guix/git-download.scm @@ -185,9 +185,7 @@ are relative to DIRECTORY, which is not necessarily t= he root of the checkout." (directory (string-append (canonicalize-path directory) "/")) (dot-git (repository-discover directory)) (repository (repository-open dot-git)) - ;; XXX: This procedure is mistakenly private in Guile-Git 0.1.0= . - (workdir ((@@ (git repository) repository-working-directory) - repository)) + (workdir (repository-working-directory repository)) (head (repository-head repository)) (oid (reference-target head)) (commit (commit-lookup repository oid)) --=20 2.20.1 (Apple Git-117) From unknown Sat Aug 09 22:10:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Robert Vollmert Subject: bug#36106: closed (Re: [bug#36106] [PATCH] guix: git-download: Remove explicit import.) Message-ID: References: <87pnnqlnxi.fsf@gnu.org> <20190605185614.80737-1-rob@vllmrt.net> X-Gnu-PR-Message: they-closed 36106 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 36106@debbugs.gnu.org Date: Thu, 06 Jun 2019 15:44:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1559835843-23033-1" This is a multi-part message in MIME format... ------------=_1559835843-23033-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36106: [PATCH] guix: git-download: Remove explicit import. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36106@debbugs.gnu.org. --=20 36106: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36106 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1559835843-23033-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36106-done) by debbugs.gnu.org; 6 Jun 2019 15:43:31 +0000 Received: from localhost ([127.0.0.1]:50455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYuY7-0005yY-DM for submit@debbugs.gnu.org; Thu, 06 Jun 2019 11:43:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYuY6-0005yK-59 for 36106-done@debbugs.gnu.org; Thu, 06 Jun 2019 11:43:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYuXz-0001Tt-V4; Thu, 06 Jun 2019 11:43:23 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=45552 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hYuXz-0006AE-Gx; Thu, 06 Jun 2019 11:43:23 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Robert Vollmert Subject: Re: [bug#36106] [PATCH] guix: git-download: Remove explicit import. References: <20190605185614.80737-1-rob@vllmrt.net> Date: Thu, 06 Jun 2019 17:43:21 +0200 In-Reply-To: <20190605185614.80737-1-rob@vllmrt.net> (Robert Vollmert's message of "Wed, 5 Jun 2019 20:56:14 +0200") Message-ID: <87pnnqlnxi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36106-done Cc: 36106-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Robert Vollmert skribis: > With guile-git version 0.2, repository-working-directory is no > longer private. > > * guix/git-download.scm (git-file-list): Refer to public > repository-working-directory. Applied, thanks! Ludo=E2=80=99. ------------=_1559835843-23033-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Jun 2019 18:56:45 +0000 Received: from localhost ([127.0.0.1]:48220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYb5Z-00030O-C5 for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYb5X-00030B-U5 for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:45522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYb5S-0000ut-Nn for submit@debbugs.gnu.org; Wed, 05 Jun 2019 14:56:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYb5R-000704-Sl for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYb5Q-0000tr-Q2 for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:37 -0400 Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:38872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYb5Q-0000pB-KJ for guix-patches@gnu.org; Wed, 05 Jun 2019 14:56:36 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id B00C14EF5C; Wed, 5 Jun 2019 20:56:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id wnk_lN-bTbkg; Wed, 5 Jun 2019 20:56:16 +0200 (CEST) From: Robert Vollmert To: guix-patches@gnu.org Subject: [PATCH] guix: git-download: Remove explicit import. Date: Wed, 5 Jun 2019 20:56:14 +0200 Message-Id: <20190605185614.80737-1-rob@vllmrt.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:67c:2050:104:0:1:25:1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Robert Vollmert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) With guile-git version 0.2, repository-working-directory is no longer private. * guix/git-download.scm (git-file-list): Refer to public repository-working-directory. --- guix/git-download.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/guix/git-download.scm b/guix/git-download.scm index 6cf267d6c8..f904d11c25 100644 --- a/guix/git-download.scm +++ b/guix/git-download.scm @@ -185,9 +185,7 @@ are relative to DIRECTORY, which is not necessarily t= he root of the checkout." (directory (string-append (canonicalize-path directory) "/")) (dot-git (repository-discover directory)) (repository (repository-open dot-git)) - ;; XXX: This procedure is mistakenly private in Guile-Git 0.1.0= . - (workdir ((@@ (git repository) repository-working-directory) - repository)) + (workdir (repository-working-directory repository)) (head (repository-head repository)) (oid (reference-target head)) (commit (commit-lookup repository oid)) --=20 2.20.1 (Apple Git-117) ------------=_1559835843-23033-1--