GNU bug report logs - #36095
[PATCH] Do not use syntax-ppss-table in syntax-propertize when nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36095 in the body.
You can then email your comments to 36095 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil
Date: Wed, 05 Jun 2019 11:15:48 +0200

[Message part 1 (text/plain, inline)]

Commit 0b3982b1a3 changed syntax-propertize to use syntax-ppss-table
explicitly, similarly to syntax-ppss.  However, it also attempts to do
this when syntax-ppss-table is nil, resulting in an error.  This patch
fixes that.

[0001-Do-not-use-syntax-ppss-table-in-syntax-propertize-wh.patch (text/x-diff, inline)]

From bfa012db3b137262cbdfff827c3b8d367750e0ab Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git <at> gmail.com>
Date: Wed, 5 Jun 2019 11:07:49 +0200
Subject: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil

* lisp/emacs-lisp/syntax.el (syntax-propertize): Use (syntax-table)
instead of syntax-ppss-table when the latter is nil.
---
 lisp/emacs-lisp/syntax.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el
index 1aec1988ab..60ed531e63 100644
--- a/lisp/emacs-lisp/syntax.el
+++ b/lisp/emacs-lisp/syntax.el
@@ -304,7 +304,7 @@ syntax-propertize
 	          #'syntax-ppss-flush-cache 99 t))
       (save-excursion
         (with-silent-modifications
-          (with-syntax-table syntax-ppss-table
+          (with-syntax-table (or syntax-ppss-table (syntax-table))
             (make-local-variable 'syntax-propertize--done) ;Just in case!
             (let* ((start (max (min syntax-propertize--done (point-max))
                                (point-min)))
-- 
2.20.1

[Message part 3 (text/plain, inline)]

-- 
Dario Gjorgjevski :: <dario.gjorgjevski <at> gmail.com>
                  :: 744A 4F0B 4F1C 9371
                  :: +48 1525 8666837

Message #8 received at 36095 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 36095 <at> debbugs.gnu.org
Subject: Re: bug#36095: [PATCH] Do not use syntax-ppss-table in
 syntax-propertize when nil
Date: Wed, 05 Jun 2019 07:30:48 -0400

tags 36095 fixed
close 36095 
quit

Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> writes:

> Commit 0b3982b1a3 changed syntax-propertize to use syntax-ppss-table
> explicitly, similarly to syntax-ppss.  However, it also attempts to do
> this when syntax-ppss-table is nil, resulting in an error.  This patch
> fixes that.

Thanks, pushed to master.

dec148939a 2019-06-05T07:29:23-04:00 "Do not use syntax-ppss-table in syntax-propertize when nil (Bug#36095)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=dec148939aad8391875e73784af2bcb0a01100bb

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.