GNU bug report logs - #36093
[PATCH 0/2] 'guix pack --entry-point' and Singularity service

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ludovic Courtès <ludovic.courtes <at> inria.fr>, 36093 <at> debbugs.gnu.org
Subject: [bug#36093] [PATCH 2/2] pack: Add '--entry-point'.
Date: Wed, 5 Jun 2019 17:06:53 +0200

[Message part 1 (text/plain, inline)]

Hi Ludo,

On Tue,  4 Jun 2019 23:01:15 +0200
Ludovic Courtès <ludo <at> gnu.org> wrote:
> +                   ,@(if entry-point
> +                         `(;; This one if for Singularity 2.x.
> +                           "-p"
> +                           ,(string-append
> +                             "/.singularity.d/actions/run s 777 0 0 "
> +                             (relative-file-name "/.singularity.d/actions"
> +                                                 (string-append #$profile "/"
> +                                                                entry-point)))
> +
> +                           ;; This one is for Singularity 3.x.
> +                           "-p"
> +                           ,(string-append
> +                             "/.singularity.d/runscript s 777 0 0 "
> +                             (relative-file-name "/.singularity.d"
> +                                                 (string-append #$profile "/"
> +                                                                entry-point))))

Hmm, 777 (anyone can write)?  It it necessary?

Also, in general, do we conflate "squashfs" and "singularity"?  It has been
that way in guix/scripts/pack.scm's squashfs-image before this patch already
and a few extra files can't hurt, but we could also just provide a
function "singularity-image" or something.

LGTM!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.