Subject: [bug#36086] [PATCH] services: Add auditd.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 06 Jun 2019 12:57:25 +0200

Hi Danny,

Danny Milosavljevic <[email-masked]> skribis:

> * gnu/services/auditd.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Miscellaneous Services): Document it.

[...]

> +The @code{(gnu services auditd)} module provides the following service.
> +
> +@defvr {Scheme Variable} auditd-service-type
> +
> +This is the type of the service that runs
> +@url{https://people.redhat.com/sgrubb/audit/,auditd},
> +a daemon that track security-relevant information on your system.
                     ^^
“tracks”

Could you add a few words, like whether/how it logs events, what kind of
events it tracks, etc.?

> +; /etc/audit/audit.rules
> +
> +(define-configuration auditd-configuration
> +  (audit
> +   (package audit)
> +   "Audit package."))

I suppose this record could eventually be extended, right?

> +(define auditd-service-type
> +  (service-type (name 'auditd)
> +                (extensions
> +                 (list
> +                  (service-extension shepherd-root-service-type
> +                                     auditd-shepherd-service)))
> +                (default-value (auditd-configuration))))

Please add a ‘description’.

Otherwise LGTM, thanks!

Ludo’.