From unknown Fri Jun 20 07:12:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36082 <36082@debbugs.gnu.org> To: bug#36082 <36082@debbugs.gnu.org> Subject: Status: [PATCH] add gnurobots Reply-To: bug#36082 <36082@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:12:39 +0000 retitle 36082 [PATCH] add gnurobots reassign 36082 guix-patches submitter 36082 Jesse Gibbons severity 36082 normal tag 36082 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 18:14:49 2019 Received: (at submit) by debbugs.gnu.org; 3 Jun 2019 22:14:49 +0000 Received: from localhost ([127.0.0.1]:43340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvE8-0004W3-QY for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:14:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvE6-0004Vo-78 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:14:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:54716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXvE0-0002v3-E4 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:14:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXvDz-0008RU-3g for guix-patches@gnu.org; Mon, 03 Jun 2019 18:14:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXvDx-0002r8-It for guix-patches@gnu.org; Mon, 03 Jun 2019 18:14:39 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:35793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXvDx-0002lP-7M for guix-patches@gnu.org; Mon, 03 Jun 2019 18:14:37 -0400 Received: by mail-pl1-x630.google.com with SMTP id p1so7495724plo.2 for ; Mon, 03 Jun 2019 15:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=9Ep3zG5CiP7IC4bToGN6fLNgzBwEQKcgiDY8gpLut7k=; b=b2BbHlq+m1fisiVDj841m2JJxA+ww0VML+vrTT+rJf+ojwgwzGvbkIOsWmnN3iOcrr Fq61KqIya0TgY0VFQdsO6LnhUzFYEIzBFRXPZvfW96ZbdOLPeK2ozs+5HHFkvw/W3TjT SnwgK36phED805qHYP/BgtErSgM0toM7QzfYEfVA8URMfObHzTxERmNHcOuYoIrw/z60 /F4cbQDYbNw1uQy/uwcvzzW1J4VEV/QbBk0+oxl3FRhX1k5k4qg2bBUMBo4EFa1TXJmE pXZcZZ1eB/kHKXWWtRqksPQ3gb1z8QfOq/PuPNZ0xYiVeiMt07tk4Dxf87t6BCVpAPBq rS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=9Ep3zG5CiP7IC4bToGN6fLNgzBwEQKcgiDY8gpLut7k=; b=T/QSPkU0IVmvCbS0jyJPF1wkmNFQ4CnWyUQg69tb6UhzwqnKj5YBFS9hxxcLToTYyl 1hNRpx4pSKKi3AjCYD7sgXkfUC/7pVTUUOnOELOjKZOYr42jAjMSugfttVM7r+otxCFO +pafPq0zBoT4A+5ufkAdm0CG2X29EcY9zfqIKEFhORHqpLIomNSr06216ZzUD9cBD0hR qBSnUkHUFyg82fCR/AWDQ4d1zrQF4vuhm5zSUQyE7gkVMfYCXJWm5dl69ODM45CHbqK5 0Fnu4kM8ZHnvwoE6pyVYmVE+VtTcnTe2rEanZ88ADoiu3PsY1g6RAu55ax0gtYCgEa7y ST5Q== X-Gm-Message-State: APjAAAUEFYosAXd5WGOS8IjCLAcMRlpI9NAQyxzdy7gObmKswrz7MaSZ FL2MC9RcD11q+PGumgbvBuT6vJsm X-Google-Smtp-Source: APXvYqzbLuLsfwRk4b+j4otVnKP2oOUnhere0/CsTvoM758hj8tyTnpNsA/wD2i6nlmrygHVSOVgIw== X-Received: by 2002:a17:902:a50c:: with SMTP id s12mr31296293plq.273.1559600074237; Mon, 03 Jun 2019 15:14:34 -0700 (PDT) Received: from localhost ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id q20sm14735378pgq.66.2019.06.03.15.14.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jun 2019 15:14:33 -0700 (PDT) Date: Mon, 3 Jun 2019 16:14:31 -0600 From: Jesse Gibbons To: guix-patches@gnu.org Subject: [PATCH] add gnurobots Message-ID: <20190603161431.03842caa@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::630 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) =46rom 77168e843404ba8cddbace220a04d2d30d419a2f Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Mon, 3 Jun 2019 16:10:43 -0600 Subject: [PATCH] add gnurobots --- gnu/packages/games.scm | 49 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 4fdc9b01e6..6416b6b1bc 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -40,6 +40,7 @@ ;;; Copyright =C2=A9 2019 Oleg Pykhalov ;;; Copyright =C2=A9 2019 Pierre Langlois ;;; Copyright =C2=A9 2019 Julien Lepiller +;;; Copyright =C2=A9 2019 Jesse Gibbons ;;; ;;; This file is part of GNU Guix. ;;; @@ -7336,3 +7337,51 @@ Unfortunately, Hacker is not aware of Drascula's real ambitions: DOMINATING the World and demonstrating that he is even more evil than his brother Vlad.") ;; Drascula uses a BSD-like license. (license (license:non-copyleft "file:///readme.txt")))) + + +(define-public gnurobots + (package + (name "gnurobots") + (version "1.2.0") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://gnu/gnurobots/gnurobots-" + version + ".tar.gz")) + (sha256 + (base32 + "07gi3lsmbzzsjambgixj6xy79lh22km84z7bnzgwzxdy806lyvwb")))) + (build-system gnu-build-system) + (inputs + `(("glib" ,glib) + ("gtk+" ,gtk+-2) + ("vte" ,vte/gtk+-2) + ("readline" ,readline) + ("guile" ,guile-1.8) + ("pkg-config" ,pkg-config))) + (arguments '( + ;-Werror=3Ddeprecated-declarations kills the build. Fix it! + #:make-flags '("CFLAGS=3D-Wno-error=3Ddeprecated-declarations") + #:phases + ;readline headers were moved to readline/readline.h. Fix before we compile. + (modify-phases %standard-phases + (add-before 'build 'patch-shell-references + (lambda _ + (begin + (substitute* (find-files "src" "\\.c$") + (("") "")) + (substitute* (find-files "src" "\\.c$") + (("") "")))))))) + (synopsis + "Program a little robot and watch him explore a world") + (description + "GNU Robots is a game in which you program a robot to explore a world +full of enemies that can hurt it, obstacles and food to be eaten. +The goal of the game is to stay alive and collect prizes. The robot +program conveniently may be written in a plain text file in the +Scheme programming language.") + (home-page + "http://www.gnu.org/software/gnurobots/readme.html") + (license gpl3+))) --=20 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 09:38:27 2019 Received: (at 36082) by debbugs.gnu.org; 5 Jun 2019 13:38:27 +0000 Received: from localhost ([127.0.0.1]:46842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYW7W-0004ty-SD for submit@debbugs.gnu.org; Wed, 05 Jun 2019 09:38:27 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYW7T-0004tm-E9 for 36082@debbugs.gnu.org; Wed, 05 Jun 2019 09:38:25 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1559741893; cv=none; d=zoho.com; s=zohoarc; b=Wb6oZTkRjAKaabZsaOZgH/O+b9bXTDtuu5YkCT7DHU8aKWWgtlKt4xeejcZIHClVF3jK0mUYr4BDvpMZvO6WR2o1UwS1GSuGYxc+0h1tXrz+Q8q62O/49Ne+XHTaT9d8DXv8JFoEWWo8V+ddnsZ3WRrpFm9E/D1ptiX6l1raLMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559741893; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=iHlWjDnea1MHd6LGPkEZznq/qn6q9RkMJcd/3ik1t2s=; b=AXAGKd+TuH163zIUnzUYr+W+ZSfMwBFGBoLVa5evojY5B3DY3Q918n364p/PnC6X7ixZAkrwtPrD9pEB1nScHvXnY3070gPIeg2aBXFFItzc7FfE0j6Fitu+wbk+qPsQbNJ0GqHX+7nI+9obSXKfhvdTrAVGGAqOqq0rZW2vmI4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1559741893; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; l=3703; bh=iHlWjDnea1MHd6LGPkEZznq/qn6q9RkMJcd/3ik1t2s=; b=gMuew9fUywZzqUCxe/+AP/GECuPjKbflJNuXVUGsgbKn9hppoIXuNQW7/GyAueH+ wLeNsBHzOC+m4FEBAnMV2rv2nt9o2YSi1h9XdBX4GTNF+oi2zekyuUHhKeVqoHQAUIP Js7WyKV5yFRoanfSlPAiqvTi9fC46/PneQ69xiGo= Received: from localhost (141.80.245.254 [141.80.245.254]) by mx.zohomail.com with SMTPS id 1559741893461388.6296985451306; Wed, 5 Jun 2019 06:38:13 -0700 (PDT) References: <20190603161431.03842caa@gmail.com> User-agent: mu4e 1.2.0; emacs 26.2 From: Ricardo Wurmus To: Jesse Gibbons Subject: Re: [bug#36082] [PATCH] add gnurobots In-reply-to: <20190603161431.03842caa@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 05 Jun 2019 15:38:06 +0200 Message-ID: <87ef48cfup.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36082 Cc: 36082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jesse, > From 77168e843404ba8cddbace220a04d2d30d419a2f Mon Sep 17 00:00:00 2001 > From: Jesse Gibbons > Date: Mon, 3 Jun 2019 16:10:43 -0600 > Subject: [PATCH] add gnurobots Thank you for your patch. It looks like the patch doesn=E2=80=99t apply to= the git repository. Maybe it got mangled by your email client? I=E2=80=99ll continue with some comments about the patch. > + > + Please remove the extra line break. > +(define-public gnurobots > + (package > + (name "gnurobots") > + (version "1.2.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnu/gnurobots/gnurobots-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "07gi3lsmbzzsjambgixj6xy79lh22km84z7bnzgwzxdy806lyvwb")))) The indentation looks off. I can fix this for you, of course, or you could use the automatic indenter script; see the Contributing section in the manual for more information. > + (build-system gnu-build-system) > + (inputs > + `(("glib" ,glib) > + ("gtk+" ,gtk+-2) > + ("vte" ,vte/gtk+-2) > + ("readline" ,readline) > + ("guile" ,guile-1.8) > + ("pkg-config" ,pkg-config))) > + (arguments '( Please don=E2=80=99t leave parentheses dangling on their own like that. Th= ey need company. > + ;-Werror=3Ddeprecated-declarations kills the build. Fix > it! Please use =E2=80=9C;;=E2=80=9D for comments on their own line. Single sem= icolon is used for =E2=80=9Cmargin comments=E2=80=9D, i.e. a comment at the end of a = line. > + #:make-flags > '("CFLAGS=3D-Wno-error=3Ddeprecated-declarations") > + #:phases > + ;readline headers were moved to readline/readline.h. > Fix before we compile. Same here. Please also use full sentences when necessary. I=E2=80=99d say= no comment is necessary here. > + (modify-phases %standard-phases > + (add-before 'build > 'patch-shell-references Please change the name of this build phase. =E2=80=9Cpatch-shell-reference= s=E2=80=9D does not describe what this phase does. > + (lambda _ > + (begin You don=E2=80=99t need =E2=80=9Cbegin=E2=80=9D here. > + > (substitute* (find-files "src" "\\.c$") > + > (("") "")) > + > (substitute* (find-files "src" "\\.c$") > + > (("") "")))))))) You could merge these two substitutions; after all they operate on the same set of files. However, I think that a better approach might be to add the =E2=80=9Creadline=E2=80=9D sub-directory to C_INCLUDE_PATH. So ins= tead of patching files you=E2=80=99d just set one environment variable. > + (synopsis > + "Program a little robot and watch him explore a world") =E2=80=9Chim=E2=80=9D =E2=80=93> =E2=80=9Cit=E2=80=9D > + (description > + "GNU Robots is a game in which you program a robot to explore a > world +full of enemies that can hurt it, obstacles and food to be eaten. > +The goal of the game is to stay alive and collect prizes. The robot > +program conveniently may be written in a plain text file in the > +Scheme programming language.") > + (home-page > + "http://www.gnu.org/software/gnurobots/readme.html") Plesae use HTTPS and remove the =E2=80=9C/readme.html=E2=80=9D part. > + (license gpl3+))) This should be =E2=80=9C(license license:gpl3+)=E2=80=9D because all values= from the (guix licenses) module are imported with a =E2=80=9Clicense:=E2=80=9D prefi= x. Would you like to send a new patch? If you aren=E2=80=99t comfortable with= =E2=80=9Cgit send-email=E2=80=9D please attach the generated patch file to your email (d= on=E2=80=99t copy/paste the contents). Thanks! -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 16:10:32 2019 Received: (at 36082) by debbugs.gnu.org; 5 Jun 2019 20:10:32 +0000 Received: from localhost ([127.0.0.1]:48243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYcEw-0004rv-3H for submit@debbugs.gnu.org; Wed, 05 Jun 2019 16:10:30 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:35428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYcEu-0004rh-ED for 36082@debbugs.gnu.org; Wed, 05 Jun 2019 16:10:29 -0400 Received: by mail-pf1-f175.google.com with SMTP id d126so15500984pfd.2 for <36082@debbugs.gnu.org>; Wed, 05 Jun 2019 13:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=9Saj2lrjWaWG1qqAwuy1Z75gAWGCY0wn3YC/qnY384Y=; b=OkYl51vkv5GKBqyu7reWQwEzTjxJDcf6qRjBLxBXj+3Zjba49YzuiD91gxt+aL2XRo hNyepHYC8RM3cj+ajfAvWnJwyjY3oWudlfP389O7I5Bkh5q76KKOX1+dV2RE5yuSTnLm XJGuInfHvLaIz+j8Pt9MtSsp0rCSO+oDOa+kMYV4V5jFzieIc4hMIGXVoqUlVd+qDIr1 cKFZ6ADIqP+c4EknGzCzhl4HDPKBhBmph20IUrlv5hpGawdgwLmwgcMBYLDDRmpxL5du NJuWeyGliTc/Q5wZqOyHs5ArzjLhf1hzmUDQ5QB6TBS4odMoxCNSZKu5CHBdpN0ukNVA 436w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=9Saj2lrjWaWG1qqAwuy1Z75gAWGCY0wn3YC/qnY384Y=; b=JmHae9JE0f0VoZBcvPA8VTbPM8O311QMZ0HLL8NihYGNiXmFglt606dE5mAxwjjhsy TtpmmqOxp2pLgM45/jEwH1TNlbKK5j2+30i6hzRtGQ7eYPChAvqbuDaqiCrglJMmt4dA OXNJUpOaU588VD8AQaFG6lu4DSucxUtcPPKx0nO7pyAiHGuVdUTW6A378TXtxkLsnet5 0bFKEFoUFAJMBWKooUsmhWHgQPYO5WoZTcZESZuncxH0lRhMlkTyc+cPlp0Y6lj+NbPB L3UedtPZOo3w2sb3wdXwmbMd/S033CtEyYpQfUb78VJtsv9JmRAwlZFWbuvcCqhLbLxO +MPw== X-Gm-Message-State: APjAAAV5Hb7rB6U+swpAfDDQIlp2hvotbyjTULONPJg/dX1M/DXUPbH9 EBRj5rm0pJE/KTPalJBkhDtBfJwY X-Google-Smtp-Source: APXvYqyMAxnidc3bgFH8cROLhjGjokJlkIsy8cMfxFce9wbyqhG5TFL5QCJOrd99VH69/A0HfFaLpw== X-Received: by 2002:a63:fc55:: with SMTP id r21mr624809pgk.441.1559765422342; Wed, 05 Jun 2019 13:10:22 -0700 (PDT) Received: from localhost ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id z4sm21570823pfa.142.2019.06.05.13.10.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 13:10:21 -0700 (PDT) Date: Wed, 5 Jun 2019 14:10:17 -0600 From: Jesse Gibbons To: Ricardo Wurmus Subject: Re: [bug#36082] [PATCH] add gnurobots Message-ID: <20190605141017.363231cb@gmail.com> In-Reply-To: <87ef48cfup.fsf@elephly.net> References: <20190603161431.03842caa@gmail.com> <87ef48cfup.fsf@elephly.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/gctlb2cq60LkJlXWIIfH2Pv" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36082 Cc: 36082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_/gctlb2cq60LkJlXWIIfH2Pv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Thanks for the review. On Wed, 05 Jun 2019 15:38:06 +0200 Ricardo Wurmus wrote: > Hi Jesse, >=20 > > From 77168e843404ba8cddbace220a04d2d30d419a2f Mon Sep 17 00:00:00 > > 2001 From: Jesse Gibbons > > Date: Mon, 3 Jun 2019 16:10:43 -0600 > > Subject: [PATCH] add gnurobots =20 >=20 > Thank you for your patch. It looks like the patch doesn=E2=80=99t apply = to > the git repository. Maybe it got mangled by your email client? >=20 > I=E2=80=99ll continue with some comments about the patch. >=20 > > + > > + =20 >=20 > Please remove the extra line break. >=20 > > +(define-public gnurobots > > + (package > > + (name "gnurobots") > > + (version "1.2.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "mirror://gnu/gnurobots/gnurobots-" > > + version > > + ".tar.gz")) > > + (sha256 > > + (base32 > > + "07gi3lsmbzzsjambgixj6xy79lh22km84z7bnzgwzxdy806lyvwb")))) =20 >=20 > The indentation looks off. I can fix this for you, of course, or you > could use the automatic indenter script; see the Contributing section > in the manual for more information. I tried the indenter script. Made the code look worse. "guix lint" complained about the line length. Furthermore, "guix lint" complains about the line length when I autoindent. New patch leaves scripted indent alone. >=20 > > + (build-system gnu-build-system) > > + (inputs > > + `(("glib" ,glib) > > + ("gtk+" ,gtk+-2) > > + ("vte" ,vte/gtk+-2) > > + ("readline" ,readline) > > + ("guile" ,guile-1.8) > > + ("pkg-config" ,pkg-config))) "guix lint" says pkg-config should be a native-input, but when it is defined as a native-input it says it fails to make derivatives for other systems. Since I am not currently able to reconfigure my system, I'll let someone else handle this problem. > > + (arguments '( =20 >=20 > Please don=E2=80=99t leave parentheses dangling on their own like that. = They > need company. >=20 > > + ;-Werror=3Ddeprecated-declarations kills the build. > > Fix it! =20 >=20 > Please use =E2=80=9C;;=E2=80=9D for comments on their own line. Single s= emicolon is > used for =E2=80=9Cmargin comments=E2=80=9D, i.e. a comment at the end of = a line. >=20 > > + #:make-flags > > '("CFLAGS=3D-Wno-error=3Ddeprecated-declarations") > > + #:phases > > + ;readline headers were moved to > > readline/readline.h. Fix before we compile. =20 >=20 > Same here. Please also use full sentences when necessary. I=E2=80=99d s= ay no > comment is necessary here. Not certain what you mean. The comment contained two complete sentences. Comment removed. >=20 > > + (modify-phases %standard-phases > > + (add-before 'build > > 'patch-shell-references =20 >=20 > Please change the name of this build phase. =E2=80=9Cpatch-shell-referen= ces=E2=80=9D > does not describe what this phase does. >=20 > > + (lambda _ > > + (begin =20 >=20 > You don=E2=80=99t need =E2=80=9Cbegin=E2=80=9D here. >=20 > > + > > (substitute* (find-files "src" "\\.c$") > > + > > (("") "")) > > + > > (substitute* (find-files "src" "\\.c$") > > + > > (("") "")))))))) =20 >=20 > You could merge these two substitutions; after all they operate on the > same set of files. However, I think that a better approach might be > to add the =E2=80=9Creadline=E2=80=9D sub-directory to C_INCLUDE_PATH. S= o instead of > patching files you=E2=80=99d just set one environment variable. I had trouble tredging the documentation to find out how to do this. Some help here would be appreciated. Until we can fix it as you suggest, the original code will be sufficient. Added TODO comment describing the change you suggested. >=20 > > + (synopsis > > + "Program a little robot and watch him explore a world") =20 >=20 > =E2=80=9Chim=E2=80=9D =E2=80=93> =E2=80=9Cit=E2=80=9D Given that these descriptions are from the gnurobots authors, I don't understand why this small change is necessary, but I'll fix. >=20 > > + (description > > + "GNU Robots is a game in which you program a robot to explore a > > world +full of enemies that can hurt it, obstacles and food to be > > eaten. +The goal of the game is to stay alive and collect prizes. > > The robot +program conveniently may be written in a plain text file > > in the +Scheme programming language.") > > + (home-page > > + "http://www.gnu.org/software/gnurobots/readme.html") =20 >=20 > Plesae use HTTPS and remove the =E2=80=9C/readme.html=E2=80=9D part. >=20 > > + (license gpl3+))) =20 >=20 > This should be =E2=80=9C(license license:gpl3+)=E2=80=9D because all valu= es from the > (guix licenses) module are imported with a =E2=80=9Clicense:=E2=80=9D pre= fix. >=20 > Would you like to send a new patch? If you aren=E2=80=99t comfortable wi= th > =E2=80=9Cgit send-email=E2=80=9D please attach the generated patch file t= o your email > (don=E2=80=99t copy/paste the contents). >=20 > Thanks! >=20 > -- > Ricardo >=20 Recommended fixes made where possible, though I need a bit of help with other fixes noted above. New patch generated and attached. --Jesse --MP_/gctlb2cq60LkJlXWIIfH2Pv Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-add-gnurobots.patch =46rom f18d37c3f2072c5f23d868a621e2b92d604761fe Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Wed, 5 Jun 2019 14:03:19 -0600 Subject: [PATCH] add gnurobots --- gnu/packages/games.scm | 49 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 4fdc9b01e6..4b5eedc242 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -40,8 +40,7 @@ ;;; Copyright =C2=A9 2019 Oleg Pykhalov ;;; Copyright =C2=A9 2019 Pierre Langlois ;;; Copyright =C2=A9 2019 Julien Lepiller -;;; -;;; This file is part of GNU Guix. +;;; Copyright =C2=A9 2019 Jesse Gibbons ;;; ;;; GNU Guix is free software; you can redistribute it and/or modify it ;;; under the terms of the GNU General Public License as published by @@ -7336,3 +7335,49 @@ Unfortunately, Hacker is not aware of Drascula's rea= l ambitions: DOMINATING the World and demonstrating that he is even more evil than his brother Vla= d.") ;; Drascula uses a BSD-like license. (license (license:non-copyleft "file:///readme.txt")))) + +(define-public gnurobots + (package + (name "gnurobots") + (version "1.2.0") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://gnu/gnurobots/gnurobots-" + version + ".tar.gz")) + (sha256 + (base32 + "07gi3lsmbzzsjambgixj6xy79lh22km84z7bnzgwzxdy806lyvwb")))) + (build-system gnu-build-system) + (inputs + `(("glib" ,glib) + ("gtk+" ,gtk+-2) + ("vte" ,vte/gtk+-2) + ("readline" ,readline) + ("guile" ,guile-1.8) + ("pkg-config" ,pkg-config))) + (arguments=20 + ;;-Werror=3Ddeprecated-declarations kills the build. + '(#:make-flags '("CFLAGS=3D-Wno-error=3Ddeprecated-declarations") + #:phases + (modify-phases %standard-phases + (add-before 'build 'fix-include + (lambda _ + ;;TODO: Replace with code adding readline directory to C_INCL= UDE_PATH. + (substitute* (find-files "src" "\\.c$") + (("") "")) + (substitute* (find-files "src" "\\.c$") + (("") ""))))))) + (synopsis + "Program a little robot and watch it explore a world") + (description + "GNU Robots is a game in which you program a robot to explore a world +full of enemies that can hurt it, obstacles and food to be eaten. +The goal of the game is to stay alive and collect prizes. The robot +program conveniently may be written in a plain text file in the +Scheme programming language.") + (home-page + "https://www.gnu.org/software/gnurobots") + (license license:gpl3+))) --=20 2.21.0 --MP_/gctlb2cq60LkJlXWIIfH2Pv-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 06:21:01 2019 Received: (at 36082-done) by debbugs.gnu.org; 6 Jun 2019 10:21:01 +0000 Received: from localhost ([127.0.0.1]:49031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYpVz-0001uN-G9 for submit@debbugs.gnu.org; Thu, 06 Jun 2019 06:20:59 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYpVy-0001uF-46 for 36082-done@debbugs.gnu.org; Thu, 06 Jun 2019 06:20:58 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1559816455; cv=none; d=zoho.com; s=zohoarc; b=IC7qrNovOU/xuWi8efiPrtCnRgEVtNGBuNfco92CZuz8/FbB3BGnUqaqQG9UrgLJvm6pbzxa8mezGk14LEFFzfYxZZX9vLF06zRrIHmW854mCxPO5195wkXSW3K+5iQGTDbjaZGIVGI7LUoZQyRdOHttjCkSqGiFrdbRl8kQpDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559816455; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=TLQpQ8xO0rnD1BR2pUd/mNjz3jQv6kETuEF5J7nJiI0=; b=HX1M12ohxOfQ1rtfhrNl+EkFsMSUNz80BjFAwfzRyffjQXRP3MC/ihOORYCDfoOOzZM2GVBhTVRRRn5qDIew3LDWr5NT82dCoVw6WSsvPJ7aT1hERvzmDquFBbcwqHexTb3IMSahuPIyFr5b2ThIjlqCrO1fKYlhyRCxcmlG66E= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1559816455; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; l=450; bh=TLQpQ8xO0rnD1BR2pUd/mNjz3jQv6kETuEF5J7nJiI0=; b=RYRT7CyrOwcRVQYadaYbkswhnlOXx2bZ7fzwK52QAeZ2jhyVc0emLLkN92d7zayz c4IjhVc4pAJdAb00xdaX4ko9km6JHye00lX2O7QEurYkJ0Tp6L1araY2ycpmQCtqwD9 db4HmUBMaxHOHn56cJjPt/LV0N1WJLvpVIkPnXX0= Received: from localhost (141.80.246.188 [141.80.246.188]) by mx.zohomail.com with SMTPS id 1559816452431441.0861473471866; Thu, 6 Jun 2019 03:20:52 -0700 (PDT) References: <20190603161431.03842caa@gmail.com> <87ef48cfup.fsf@elephly.net> <20190605141017.363231cb@gmail.com> User-agent: mu4e 1.2.0; emacs 26.2 From: Ricardo Wurmus To: Jesse Gibbons Subject: Re: [bug#36082] [PATCH] add gnurobots In-reply-to: <20190605141017.363231cb@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 06 Jun 2019 12:20:49 +0200 Message-ID: <87tvd3j9q6.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36082-done Cc: 36082-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jesse, thank you for the updated patch. I pushed it to the master branch with commit 08c2fb8fe9 after a couple of changes: * fixed indentation and formatting; replaced tabs with spaces * added a build phase to install the HOWTO document * replaced the build phase to patch references to headers with a make flag * moved pkg-config to native-inputs * reflowed the description * changed the commit message Thanks! -- Ricardo From unknown Fri Jun 20 07:12:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Jul 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator