GNU bug report logs - #36052
26.2.50; [PATCH] Improve auth-source-pass

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Damien Cassou <damien <at> cassou.me>
Subject: bug#36052: closed (Re: bug#36052: 26.2.50; [PATCH] Improve
 auth-source-pass)
Date: Mon, 24 Jun 2019 14:34:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36052: 26.2.50; [PATCH] Improve auth-source-pass

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36052 <at> debbugs.gnu.org.

-- 
36052: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36052
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: magnus.henoch <at> gmail.com, nicolas <at> petton.fr, tzz <at> lifelogs.com,
 npostavs <at> gmail.com, iku.iwasa <at> gmail.com, 36052-done <at> debbugs.gnu.org,
 gaby.launay <at> tutanota.com, camalot <at> picnicpark.org
Subject: Re: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
Date: Mon, 24 Jun 2019 17:33:28 +0300

> From: Damien Cassou <damien <at> cassou.me>
> Cc: 36052 <at> debbugs.gnu.org, npostavs <at> gmail.com, magnus.henoch <at> gmail.com, tzz <at> lifelogs.com, iku.iwasa <at> gmail.com, camalot <at> picnicpark.org, gaby.launay <at> tutanota.com, nicolas <at> petton.fr
> Date: Mon, 24 Jun 2019 09:26:04 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> > Thanks, these LGTM.
> 
> I've just pushed to master. Because it's my first time, can you please
> check I did it right?

You forgot to mention the bug number, AFAICT (happens to everyone from
time to time).  Other than that, looks OK to me.

> I guess this bug report can be closed now.

Done.

Thanks.

[Message part 3 (message/rfc822, inline)]

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Cc: Magnus Henoch <magnus.henoch <at> gmail.com>, Ted Zlatanov <tzz <at> lifelogs.com>,
 Iku Iwasa <iku.iwasa <at> gmail.com>, Keith Amidon <camalot <at> picnicpark.org>,
 galaunay <gaby.launay <at> tutanota.com>, Nicolas Petton <nicolas <at> petton.fr>
Subject: 26.2.50; [PATCH] Improve auth-source-pass
Date: Sun, 02 Jun 2019 11:11:15 +0200

[Message part 4 (text/plain, inline)]

Hi,

auth-source-pass users have worked hard to improve the package. Everyone
is on CC.

3 have signed the FSF paperwork:

- Keith Amidon:
  https://github.com/DamienCassou/auth-password-store/pull/80#issuecomment-480853577
- Iku Iwasa:
  https://github.com/DamienCassou/auth-password-store/pull/87#issuecomment-480816595
- galaunay:
  https://github.com/DamienCassou/auth-password-store/pull/78#issuecomment-453862089

Magnus Henoch hasn't signed but his contribution is rather small (4
lines of a new unit-test and 2 lines of code). See patch 0001.

Here is a summary of the attached patches.

Damien Cassou (5):
  * lisp/auth-source-pass.el: Version 4.0.2
  * lisp/auth-source-pass.el (auth-source-pass-get): Add autoload
  Refactoring of auth-source-pass
  * lisp/auth-source-pass.el: Version 5.0.0
  * etc/NEWS: Describe changes to auth-source-pass

Iku Iwasa (1):
  Add auth-source-pass-port-separator option

Keith Amidon (4):
  Fix auth-source-pass to search for hostname:port/username
  Split out the attribute retrieval form auth-source-pass-get
  Minimize entry parsing in auth-source-pass
  * lisp/auth-source-pass.el: Add Keith Amidon to authors

Magnus Henoch (1):
  Fix auth-source-pass to return nil if no entry found

galaunay (1):
  Add auth-source-pass-path option

 etc/NEWS                            |  19 ++
 lisp/auth-source-pass.el            | 224 ++++++++-----
 test/lisp/auth-source-pass-tests.el | 473 +++++++++++++++++++---------
 3 files changed, 491 insertions(+), 225 deletions(-)

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Fix-auth-source-pass-to-return-nil-if-no-entry-found.patch (text/x-patch, attachment)]

[0002-lisp-auth-source-pass.el-Version-4.0.2.patch (text/x-patch, attachment)]

[0003-lisp-auth-source-pass.el-auth-source-pass-get-Add-au.patch (text/x-patch, attachment)]

[0004-Add-auth-source-pass-path-option.patch (text/x-patch, attachment)]

[0005-Add-auth-source-pass-port-separator-option.patch (text/x-patch, attachment)]

[0006-Fix-auth-source-pass-to-search-for-hostname-port-use.patch (text/x-patch, attachment)]

[0007-Split-out-the-attribute-retrieval-form-auth-source-p.patch (text/x-patch, attachment)]

[0008-Minimize-entry-parsing-in-auth-source-pass.patch (text/x-patch, attachment)]

[0009-lisp-auth-source-pass.el-Add-Keith-Amidon-to-authors.patch (text/x-patch, attachment)]

[0010-Refactoring-of-auth-source-pass.patch (text/x-patch, attachment)]

[0011-lisp-auth-source-pass.el-Version-5.0.0.patch (text/x-patch, attachment)]

[0012-etc-NEWS-Describe-changes-to-auth-source-pass.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.