GNU bug report logs - #36052
26.2.50; [PATCH] Improve auth-source-pass

Previous Next

Full log

Message #35 received at 36052 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: magnus.henoch <at> gmail.com, nicolas <at> petton.fr, tzz <at> lifelogs.com,
 npostavs <at> gmail.com, iku.iwasa <at> gmail.com, gaby.launay <at> tutanota.com,
 36052 <at> debbugs.gnu.org, camalot <at> picnicpark.org
Subject: Re: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
Date: Sat, 22 Jun 2019 12:02:52 +0300

> From: Damien Cassou <damien <at> cassou.me>
> Cc: 36052 <at> debbugs.gnu.org, npostavs <at> gmail.com, magnus.henoch <at> gmail.com, tzz <at> lifelogs.com, iku.iwasa <at> gmail.com, camalot <at> picnicpark.org, gaby.launay <at> tutanota.com, nicolas <at> petton.fr
> Date: Fri, 14 Jun 2019 18:16:01 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> > These are all described in the patch for the manual, right?  If so,
> > the entries should be marked with "+++", see the beginning of NEWS for
> > instructions about that.
> 
> 
> I'm not sure which patch you reviewed so I attach it again to this new
> email. The first 2 items in NEWS (new user options) are covered by the
> manual so I've added '+++' in front of each. The last 2 items (less
> decryption and autoload) shouldn't be in the manual so I've added '---'
> in front of each.
> 
> 
> > Please make the text describing each @item start on a new line.  Also,
> > it sounds like you want @table here, not @itemize.  And finally,
> > quoting in @code is sub-optimal; would @samp (and losing the quotes)
> > do the job?
> >
> > File names or their parts should have the @file markup, not @code.
> 
> I'm not sure I did it right, but you will find a new patch attached to
> this email.

Thanks, these LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.