GNU bug report logs - #36052
26.2.50; [PATCH] Improve auth-source-pass

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: magnus.henoch <at> gmail.com, nicolas <at> petton.fr, npostavs <at> gmail.com, iku.iwasa <at> gmail.com, gaby.launay <at> tutanota.com, tzz <at> lifelogs.com, 36052 <at> debbugs.gnu.org, camalot <at> picnicpark.org
Subject: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
Date: Sat, 08 Jun 2019 19:02:54 +0300

> From: Damien Cassou <damien <at> cassou.me>
> Date: Sat, 08 Jun 2019 17:47:53 +0200
> Cc: Magnus Henoch <magnus.henoch <at> gmail.com>, Nicolas Petton <nicolas <at> petton.fr>,
>  Iku Iwasa <iku.iwasa <at> gmail.com>, Keith Amidon <camalot <at> picnicpark.org>,
>  galaunay <gaby.launay <at> tutanota.com>, 36052 <at> debbugs.gnu.org,
>  Ted Zlatanov <tzz <at> lifelogs.com>
> 
> +(defcustom auth-source-pass-filename "~/.password-store"
> +  "Path to the password-store folder."
> +  :type 'directory)

Please add/update a :version tag to any defcustom that you introduce
or modify.  This is the basis for a "C-h v" and a few other features
that report on options introduced/changed in a certain Emacs version.

Also, GNU Coding Standards frown on calling "path" anything that is
not colon-separated PATH-style list of directories.

> >From d46e8dd1bbc3a1c7ac6506e3e6cfe3d87e57e99e Mon Sep 17 00:00:00 2001
> From: galaunay <gaby.launay <at> tutanota.com>
> Date: Sun, 13 Jan 2019 21:30:53 +0000
> Subject: [PATCH 04/12] Add auth-source-pass-path option

This patch was included twice, it seems.

> +(defun auth-source-pass--get-attr (key entry-data)
> +  "Return the value associated to KEY in data from an already parsed entry.

We prefer that the first line of a function's doc references all of
the arguments.  In this case, I suggest to reword as follows:

  Return value associated with KEY in an ENTRY-DATA.

What ENTRY-DATA is is explained in the very next line"

> +ENTRY-DATA is the data from a parsed password-store entry.

So you don't need to repeat that in the first line.

> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1485,6 +1485,21 @@ the new variable 'buffer-auto-revert-by-notification' to a non-nil
>  value.  Auto Revert mode can use this information to avoid polling the
>  buffer periodically when 'auto-revert-avoid-polling' is non-nil.
>  
> +** auth-source-pass
> +
> +*** New customizable variable 'auth-source-pass-filename'.
> +Allows setting the path to the password-store, defaults to
> +~/.password-store.
> +
> +*** New customizable variable 'auth-source-pass-port-separator'.
> +Specifies separator between host and port, defaults to colon ":".
> +
> +*** Minimize the number of decryptions during password lookup.
> +This makes the package usable with physical tokens requiring touching
> +a sensor for every decryption.
> +
> +*** 'auth-source-pass-get' is now autoloaded.

Do these changes warrant changes in auth.texi manual?

Thanks for working on this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.