GNU bug report logs - #36034
[PATCH] Zsh extended_history shows up in comint input ring

Previous Next

Full log

Message #8 received at 36034 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthew Bauer <mjbauer95 <at> gmail.com>
Cc: 36034 <at> debbugs.gnu.org
Subject: Re: bug#36034: [PATCH] Zsh extended_history shows up in comint input
 ring
Date: Sun, 23 Jun 2019 18:53:54 +0200

Matthew Bauer <mjbauer95 <at> gmail.com> writes:

> The format of this line looks like this:
>
> : <beginning time>:<elapsed seconds>;<command>
>
> This patch just skips those timestamp to get the <command> part.

[...]

> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -976,7 +976,11 @@ See also `comint-input-ignoredups' and `comint-write-input-ring'."
>                   (setq start
>                         (if (re-search-backward comint-input-ring-separator
>                                                 nil t)
> -                           (match-end 0)
> +                           (progn
> +                             ;; Skip zsh extended_history stamps
> +                             (re-search-forward ": [[:digit:]]+:[[:digit:]]+;" nil t)
> +
> +                             (match-end 0))
>                           (point-min)))
>                   (setq history (buffer-substring start end))
>                   (goto-char start)

I'm not that familiar with the comint/shell code...  but this is done
in the central comint code, so it would do this for all the modes that
use comint?  Couldn't that lead to problems in these other modes that
aren't doing this timestamp thing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.