GNU bug report logs - #36034
[PATCH] Zsh extended_history shows up in comint input ring

Previous Next

Full log

Message #23 received at 36034 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthew Bauer <mjbauer95 <at> gmail.com>
Cc: 36034 <at> debbugs.gnu.org
Subject: Re: bug#36034: [PATCH] Zsh extended_history shows up in comint input
 ring
Date: Tue, 25 Jun 2019 13:05:22 +0200

Matthew Bauer <mjbauer95 <at> gmail.com> writes:

>  -                           (match-end 0)
>  -                         (point-min)))
>  +                           (progn
>  +                             (when (and
>  +                                    comint-input-ring-file-prefix
>  +                                    (looking-at (concat
>  comint-input-ring-separator
>  +                                                        comint-input-ring-file-prefix)))
>  +                               ;; Skip zsh extended_history stamps
>  +                               (re-search-forward comint-input-ring-file-prefix
>  +                                                  nil t))
>  +                             (match-end 0))
>
>  The re-search-forward here doesn't seem necessary -- can't you just go
>  to (match-end 0) here instead?
>
> Without re-search-forward, the “start” integer would just be the character
> right after the newline. re-search-forward skips that prefix.

You first do a

(looking-at (concat comint-input-ring-separator comint-input-ring-file-prefix)))

and then

(re-search-forward comint-input-ring-file-prefix)

This will make point end up at where (match-end 0) would be after the
looking-at, surely?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.