From unknown Mon Jun 23 04:09:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36024 <36024@debbugs.gnu.org> To: bug#36024 <36024@debbugs.gnu.org> Subject: Status: 26.2.50; [PATCH] Fix oauth2 to pass a type parameter when requesting authorization Reply-To: bug#36024 <36024@debbugs.gnu.org> Date: Mon, 23 Jun 2025 11:09:34 +0000 retitle 36024 26.2.50; [PATCH] Fix oauth2 to pass a type parameter when req= uesting authorization reassign 36024 emacs submitter 36024 Damien Cassou severity 36024 normal tag 36024 patch wontfix notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 08:29:46 2019 Received: (at submit) by debbugs.gnu.org; 31 May 2019 12:29:46 +0000 Received: from localhost ([127.0.0.1]:34989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWgfK-0001HA-C7 for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWgfF-0001Gh-C4 for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:60592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWgfA-0000vm-7R for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgf8-0002Dj-MF for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:29:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWgTR-0005zn-4K for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:17:30 -0400 Received: from mail.choca.pics ([2001:bc8:20ab::1]:43794) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWgTQ-0005uN-U8 for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:17:29 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 5CE43F1A3C7; Fri, 31 May 2019 14:17:18 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id Xo_4Vctmym8I; Fri, 31 May 2019 14:17:17 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 54377F1A3C8; Fri, 31 May 2019 14:17:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id yyibPGdnnmWq; Fri, 31 May 2019 14:17:17 +0200 (CEST) Received: from luz4 (arennes-659-1-13-31.w86-215.abo.wanadoo.fr [86.215.172.31]) by mail.choca.pics (Postfix) with ESMTPSA id 06D0FF1A3C7; Fri, 31 May 2019 14:17:17 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: 26.2.50; [PATCH] Fix oauth2 to pass a type parameter when requesting authorization Date: Fri, 31 May 2019 14:17:15 +0200 Message-ID: <87d0jyrf78.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:bc8:20ab::1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Julien Danjou , =?utf-8?Q?R=C3=BCdiger?= Sonderfeld X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, it seems that oauth2 doesn't pass any type parameter when requesting authorization even though it seems to be required by the spec. See the patch for details. I'm no expert so please double-check. --=20 Damien Cassou F=C3=B6retagsplatsen AB Phone/Fax: +46 (0)8 774 63 00 Mobile: +33 (0)6 80 50 18 91 Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm Web: www.foretagsplatsen.se --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-oauth2-to-pass-a-type-parameter-when-requesting-.patch >From a0d2132e5b3c8a47c4d2a2ec9d4233127ad0214c Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Fri, 31 May 2019 14:07:46 +0200 Subject: [PATCH] Fix oauth2 to pass a type parameter when requesting authorization * oauth2.el (oauth2-request-authorization): Add a "type=user_agent" parameter to the URL as it seems to be required by the protocol: https://tools.ietf.org/html/draft-ietf-oauth-v2-05#section-3.5.1 --- oauth2.el | 1 + 1 file changed, 1 insertion(+) diff --git a/oauth2.el b/oauth2.el index c8807f3..f6438ba 100644 --- a/oauth2.el +++ b/oauth2.el @@ -48,6 +48,7 @@ (defun oauth2-request-authorization (auth-url client-id &optional scope state re (if (string-match-p "\?" auth-url) "&" "?") "client_id=" (url-hexify-string client-id) "&response_type=code" + "&type=user_agent" "&redirect_uri=" (url-hexify-string (or redirect-uri "urn:ietf:wg:oauth:2.0:oob")) (if scope (concat "&scope=" (url-hexify-string scope)) "") (if state (concat "&state=" (url-hexify-string state)) ""))) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 09:28:58 2019 Received: (at control) by debbugs.gnu.org; 31 May 2019 13:28:58 +0000 Received: from localhost ([127.0.0.1]:35064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWhab-0005rD-Mo for submit@debbugs.gnu.org; Fri, 31 May 2019 09:28:57 -0400 Received: from mail.choca.pics ([62.210.108.126]:48010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWhaZ-0005r1-Vz for control@debbugs.gnu.org; Fri, 31 May 2019 09:28:56 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 7EE86F1A3CE for ; Fri, 31 May 2019 15:28:52 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 6Dd3G5IcaFvd for ; Fri, 31 May 2019 15:28:52 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id EDF06F1A3CF for ; Fri, 31 May 2019 15:28:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id rieGGLdM-NY2 for ; Fri, 31 May 2019 15:28:51 +0200 (CEST) Received: from luz4 (arennes-659-1-13-31.w86-215.abo.wanadoo.fr [86.215.172.31]) by mail.choca.pics (Postfix) with ESMTPSA id BB66DF1A3CE for ; Fri, 31 May 2019 15:28:51 +0200 (CEST) Date: Fri, 31 May 2019 15:28:51 +0200 Message-Id: <877ea6rbvw.fsf@cassou.me> To: control@debbugs.gnu.org From: Damien Cassou Subject: control message for bug #36024 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36024 notabug wontfix close 36024 quit From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 09:38:11 2019 Received: (at submit) by debbugs.gnu.org; 31 May 2019 13:38:11 +0000 Received: from localhost ([127.0.0.1]:35087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWhjX-0008Mu-D9 for submit@debbugs.gnu.org; Fri, 31 May 2019 09:38:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWhjU-0008MU-LQ for submit@debbugs.gnu.org; Fri, 31 May 2019 09:38:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:57647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWhjO-0001hT-NU for submit@debbugs.gnu.org; Fri, 31 May 2019 09:38:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWhjN-0002uz-BD for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 09:38:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWhZ3-0004VX-2V for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 09:27:23 -0400 Received: from mail.choca.pics ([2001:bc8:20ab::1]:44784) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWhZ1-0004MF-MZ for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 09:27:21 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 457BCF1A3CD; Fri, 31 May 2019 15:27:13 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id VX_bo1MRFNVx; Fri, 31 May 2019 15:27:12 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 563B9F1A3CE; Fri, 31 May 2019 15:27:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id c6KeyoFa3cN8; Fri, 31 May 2019 15:27:12 +0200 (CEST) Received: from luz4 (arennes-659-1-13-31.w86-215.abo.wanadoo.fr [86.215.172.31]) by mail.choca.pics (Postfix) with ESMTPSA id 1AE66F1A3CD; Fri, 31 May 2019 15:27:12 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: Re: 26.2.50; [PATCH] Fix oauth2 to pass a type parameter when requesting authorization In-Reply-To: <87d0jyrf78.fsf@cassou.me> References: <87d0jyrf78.fsf@cassou.me> Date: Fri, 31 May 2019 15:27:11 +0200 Message-ID: <87a7f2rbyo.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:bc8:20ab::1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Julien Danjou , =?utf-8?Q?R=C3=BCdiger?= Sonderfeld X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Damien Cassou writes: > it seems that oauth2 doesn't pass any type parameter when requesting > authorization even though it seems to be required by the spec. See the > patch for details. > > I'm no expert so please double-check. please ignore this patch, I haven't been able to make everything works. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Mon Jun 23 04:09:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 29 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator