GNU bug report logs - #36023
[PATCH] linux-boot: Fix e2fsck warning.

Previous Next

Full log

View this message in rfc822 format

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 36023 <at> debbugs.gnu.org
Subject: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Mon, 3 Jun 2019 19:01:39 +0200

On 6/3/19 6:53 PM, Danny Milosavljevic wrote:
> Hi Jonathan,
>
> On Mon, 3 Jun 2019 18:17:14 +0200
> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:
>
>> On 5/31/19 1:27 PM, Danny Milosavljevic wrote:
>>> +       (setenv "EXT2FS_NO_MTAB_OK" "1")
>>> +
>> [...]
>>> +       (setenv "EXT2FS_NO_MTAB_OK" #f)
>>> +
>>
>> Maybe it would be nice to have them constintly using either "0" and "1"
>> or #t and #f :)
>
> Well, the UNIX environment interface and/or Guile's interface to it doesn't
> work that way.  The UNIX environment is a string array.
>
> e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the entry
> with the key "EXT2FS_NO_MTAB_OK".
>
> So we can set the environment entry to any value we want and e2fsck's "if"
> condition will evaluate to true.
>
> And in order to remove it from the environment again, we call setenv with
> #f.
>
> We could also call unsetenv instead, I guess.  Should we?

Ah, oke. Thanks for the explanation. I think we can leave it as it is...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.