From unknown Mon Jun 23 09:35:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36023 <36023@debbugs.gnu.org> To: bug#36023 <36023@debbugs.gnu.org> Subject: Status: [PATCH] linux-boot: Fix e2fsck warning. Reply-To: bug#36023 <36023@debbugs.gnu.org> Date: Mon, 23 Jun 2025 16:35:39 +0000 retitle 36023 [PATCH] linux-boot: Fix e2fsck warning. reassign 36023 guix-patches submitter 36023 Danny Milosavljevic severity 36023 normal tag 36023 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 07:28:01 2019 Received: (at submit) by debbugs.gnu.org; 31 May 2019 11:28:01 +0000 Received: from localhost ([127.0.0.1]:34927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWfhY-00052z-SK for submit@debbugs.gnu.org; Fri, 31 May 2019 07:28:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWfhW-00052c-IG for submit@debbugs.gnu.org; Fri, 31 May 2019 07:27:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:50413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWfhR-0003Qe-Bw for submit@debbugs.gnu.org; Fri, 31 May 2019 07:27:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWfhQ-00077h-0J for guix-patches@gnu.org; Fri, 31 May 2019 07:27:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWfhO-0003N5-QC for guix-patches@gnu.org; Fri, 31 May 2019 07:27:51 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:59146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWfhI-0003Ci-UB for guix-patches@gnu.org; Fri, 31 May 2019 07:27:45 -0400 Received: from localhost.localdomain (178.113.171.190.wireless.dyn.drei.com [178.113.171.190]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 02723336010C; Fri, 31 May 2019 13:27:36 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] linux-boot: Fix e2fsck warning. Date: Fri, 31 May 2019 13:27:35 +0200 Message-Id: <20190531112735.15985-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Tags: patch Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 85.13.145.193 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/build/linux-boot.scm (boot-system): Fix e2fsck warning. --- gnu/build/linux-boot.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm index a35d18ad7c..03f2ea245c 100644 --- a/gnu/build/linux-boot.scm +++ b/gnu/build/linux-boot.scm @@ -517,6 +517,8 @@ upon error." (unless (pre-mount) (error "pre-mount actions failed"))) =20 + (setenv "EXT2FS_NO_MTAB_OK" "1") + (if root ;; The "--root=3DSPEC" kernel command-line option always prov= ides a ;; string, but the string can represent a device, a UUID, or = a @@ -533,6 +535,8 @@ upon error." (for-each mount-file-system (remove root-mount-point? mounts)) =20 + (setenv "EXT2FS_NO_MTAB_OK" #f) + (if to-load (begin (switch-root "/root") From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 09:14:08 2019 Received: (at 36023) by debbugs.gnu.org; 1 Jun 2019 13:14:08 +0000 Received: from localhost ([127.0.0.1]:37513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX3pn-0005rd-Rp for submit@debbugs.gnu.org; Sat, 01 Jun 2019 09:14:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX3pl-0005qt-L5 for 36023@debbugs.gnu.org; Sat, 01 Jun 2019 09:14:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX3pg-0005U0-Bz; Sat, 01 Jun 2019 09:14:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54796 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hX3pf-0002Ja-RW; Sat, 01 Jun 2019 09:14:00 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Danny Milosavljevic Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. References: <20190531112735.15985-1-dannym@scratchpost.org> Date: Sat, 01 Jun 2019 15:13:58 +0200 In-Reply-To: <20190531112735.15985-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 31 May 2019 13:27:35 +0200") Message-ID: <87r28dfnxl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36023 Cc: 36023@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Danny Milosavljevic skribis: > * gnu/build/linux-boot.scm (boot-system): Fix e2fsck warning. Oooh, thanks for fixing this one. LGTM! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 12:09:56 2019 Received: (at 36023-done) by debbugs.gnu.org; 3 Jun 2019 16:09:56 +0000 Received: from localhost ([127.0.0.1]:42793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXpX2-0004ff-Ct for submit@debbugs.gnu.org; Mon, 03 Jun 2019 12:09:56 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:57572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXpX0-0004fW-Nq for 36023-done@debbugs.gnu.org; Mon, 03 Jun 2019 12:09:55 -0400 Received: from localhost (178.113.175.254.wireless.dyn.drei.com [178.113.175.254]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 2D37833604B2; Mon, 3 Jun 2019 18:09:53 +0200 (CEST) Date: Mon, 3 Jun 2019 18:09:50 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. Message-ID: <20190603180951.16c05fa3@scratchpost.org> In-Reply-To: <87r28dfnxl.fsf@gnu.org> References: <20190531112735.15985-1-dannym@scratchpost.org> <87r28dfnxl.fsf@gnu.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Q8gU_I9jYhH7oaB8GK/AMTz"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36023-done Cc: 36023-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/Q8gU_I9jYhH7oaB8GK/AMTz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thanks for the review! Pushed it to guix master as commit aa901521e4e5625dd8a63e67a64be2f562ca61c7. --Sig_/Q8gU_I9jYhH7oaB8GK/AMTz Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz1Rk8ACgkQ5xo1VCww uqWh8wf+M4odYGOpsVukSINWCuAi0CVRLz1+hJOmpDKylcl+g0wo3GLPkNj8Bnmu S0e3B0ZRB3AoEgI6ZbTWFSJ9XMy0Nb18c1kCRwbVcrZFdjdWkV2Un8tQz2D2spAN vmOD5WnNWteFAAZERMaoeRCsVS8causIctxF5p7NFoA1SLtVdE584TrdBOtdf0y1 deZurWA2xgc06aIv5gIYsEpf8aksKmG7qGsat5fGsqcZjSXYFFBxEhu/NZ0srX/c mAXCTdRrmyloJq8MZZd9Al8k3crDHQ+uSHHeJeDE9IwECrhl4GOa7jmiIKn8MfWx tfuVYgAis1UA/W1wuaQRTm0fqtTNig== =zk1t -----END PGP SIGNATURE----- --Sig_/Q8gU_I9jYhH7oaB8GK/AMTz-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 12:17:31 2019 Received: (at 36023) by debbugs.gnu.org; 3 Jun 2019 16:17:31 +0000 Received: from localhost ([127.0.0.1]:42810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXpeL-0004r3-74 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 12:17:31 -0400 Received: from mout.web.de ([212.227.15.14]:32941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXpeI-0004qn-I6 for 36023@debbugs.gnu.org; Mon, 03 Jun 2019 12:17:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1559578638; bh=VJ16dJOInWSoEEiSMVJyMuWgyanV2CVk1Oyp17Dcjvk=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=aaKyqKlfuEjIIgU08ddnADI82mOj44y++qkpxEJMKKGN+6U1shJCuwN1vjQat/Mdd r/4JFFe++Uxw0AeeG5jrGliq7MgF1pRvNHYRB7VY93x8uunwpC5ZFxZV47Cu79JdrP CxihAySqzJ0mbp1KgcOgU3LzM2sQodhkd3VyjDHk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from e136.suse.de ([195.135.221.2]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MK6mD-1hWSjb06rN-001PdX; Mon, 03 Jun 2019 18:17:18 +0200 Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. To: Danny Milosavljevic , 36023@debbugs.gnu.org References: <20190531112735.15985-1-dannym@scratchpost.org> From: Jonathan Brielmaier Message-ID: <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> Date: Mon, 3 Jun 2019 18:17:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531112735.15985-1-dannym@scratchpost.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:0Zo0kAa3Q+TlO3gpUx8ymY59BRdnGcVgviUVTrN7h9s24K3WY/v 6gUmfKB1tjHHoWA1XgtzjONmKqe8Ew6GQ6IHOjZa8z3MS4iCYKoRmWk6CTJeqXjGeaIW/Xl UBC2NZPjDmhjB19pu1+jiEYNC+sgm6XyGLAJ2DJDHgMaCNtvQCCiIbwhunOwZdj13u87EuU gZJURRuYWM44+nhLyNbGw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NwJ+UpVRGeo=:4LBFkG2IxsOdXDYml43KCh ornPsw+PyKpH2g9J25V/tQwbhEsRQzQWZdWE1fGYjNOcvgr6fmTFCA0+jVLz/Ic6tHbhgkIEQ iO3+5G14nnPPbr/gwLmpfheSTMYUHVZbvex9wQ8P+qLio5dWj2yBWsJAobcM27ugY9dKkxefF XTsQDSAXoRHBHW+kP6E/XoGHT/2njxaji8T+aHapupiX+txEFcpzPm8bRr+dUhN5hm5KerI3I FqdwdR7joExqsr0lqm1SJCVXlwj6tlyFvjAYWNukmDBTThXKMZWKPYgJGGBZrQ+Bqzk0XsILN I3XGQWM28gqHYeheHVF4uNX5W3zdpwV6cb8OeKW3F6qv+rk1eyXop/cOWrfUKPUZ8Zs3WMCjl gsMBWQgOAxrxL0S3PQ8gOQBxZEWJluoI2vYew71movPtD/OQNrvRGK8Qe3xakxAh/4CJP9xt7 cHghtwWNOErh/li0jd4FZ9mJC00+Xw++VB3pwjTQjsbI9zx7bsEoAPy6nTic003ebVupffhDa LWjRpoTyGy0HAthk4MrKB5KhE0kkkE9oB30QnYZQs0cke71pmUA1dZ4HLf0kDqz0GcoqFR291 vAcDHHAdMSVfXhXu+Z9tUK9jdPqcsvLkow36vZX+gMmjk0LADuumzf222W/bxXb+xJ9m19Xn/ 2JOeXbQmR/iYCReMBtxuIGPEZiAvbeKN8AuV+RW/V8MsgMYrqYk5oOSAWHT0zw2bIoh3X8V5Z R3KWiTywEiw6Km5MSO1JCgU+64UMpxMmUr6ka07JDujSs78m7AcDv2aKcXCHME0/9XkYIw61R Q/D5OzH2Npwa/jiS8d8lRTXih1HSnKF/95RO0haAWQAfE/NtKQT5K9f7jdsjGpsaeGvWl3zLO 8t1vuPs7QB+Xgaa2KXPu6a3d5m4flksKsGhOV9MKkJ3Wq30GrlpntarWlPhRalytH6iHl6xk2 +SqwjTz1ma51vaP03mDs2VUxc7yCcaxVVH1HKCSDqlxk45aBzJTtL X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36023 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/31/19 1:27 PM, Danny Milosavljevic wrote: > + (setenv "EXT2FS_NO_MTAB_OK" "1") > + [...] > + (setenv "EXT2FS_NO_MTAB_OK" #f) > + Maybe it would be nice to have them constintly using either "0" and "1" or #t and #f :) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 12:53:57 2019 Received: (at 36023) by debbugs.gnu.org; 3 Jun 2019 16:53:57 +0000 Received: from localhost ([127.0.0.1]:42912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqDc-0005lS-Nm for submit@debbugs.gnu.org; Mon, 03 Jun 2019 12:53:56 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:32930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqDa-0005lH-Gc for 36023@debbugs.gnu.org; Mon, 03 Jun 2019 12:53:54 -0400 Received: from localhost (178.113.175.254.wireless.dyn.drei.com [178.113.175.254]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 966DA33603DF; Mon, 3 Jun 2019 18:53:47 +0200 (CEST) Date: Mon, 3 Jun 2019 18:53:41 +0200 From: Danny Milosavljevic To: Jonathan Brielmaier Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. Message-ID: <20190603185201.0ed67e8c@scratchpost.org> In-Reply-To: <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> References: <20190531112735.15985-1-dannym@scratchpost.org> <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/3Yh7JNp9k6sM3jD76VzIC4l"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36023 Cc: 36023@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/3Yh7JNp9k6sM3jD76VzIC4l Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Jonathan, On Mon, 3 Jun 2019 18:17:14 +0200 Jonathan Brielmaier wrote: > On 5/31/19 1:27 PM, Danny Milosavljevic wrote: > > + (setenv "EXT2FS_NO_MTAB_OK" "1") > > + =20 > [...] > > + (setenv "EXT2FS_NO_MTAB_OK" #f) > > + =20 >=20 > Maybe it would be nice to have them constintly using either "0" and "1" > or #t and #f :) Well, the UNIX environment interface and/or Guile's interface to it doesn't work that way. The UNIX environment is a string array. e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the entry with the key "EXT2FS_NO_MTAB_OK". So we can set the environment entry to any value we want and e2fsck's "if" condition will evaluate to true. And in order to remove it from the environment again, we call setenv with #f. We could also call unsetenv instead, I guess. Should we? --Sig_/3Yh7JNp9k6sM3jD76VzIC4l Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz1UJUACgkQ5xo1VCww uqVXawf9GUr0L0M0cw4o6OJBLQ0T2FywsF8lAoFBBeEMjYlUliYfFA+hzi0RUVyd AMoTBAClxFMvVkFZgCk9SxOSqSPiRJX7i1hpmx56fbJqSAjthPM0gjFQrth9WzDN Y3h/2Hb/Sy53+l+Ae0aLJzKTJG5th3shOLv0qsHqGXUxxQDXi1/5CbltrkhO7VOm 1JxuTls0TSFDHShlsCWmGaJOCYrR+ddfbgm7MinQikeoMMrGW3AF79eRoMU28JC7 QJri+VvkvBVqCNAXWyVM4CbadbCFZoSn96CY01GkR8cSn0SRhraL2WmSwtcIncB1 lNMR/SvHccoRWj1vrTj6kM5UfeLzoQ== =BAkb -----END PGP SIGNATURE----- --Sig_/3Yh7JNp9k6sM3jD76VzIC4l-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 13:01:57 2019 Received: (at 36023) by debbugs.gnu.org; 3 Jun 2019 17:01:57 +0000 Received: from localhost ([127.0.0.1]:42926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqLN-000602-B4 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 13:01:57 -0400 Received: from mout.web.de ([212.227.15.4]:49371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqLL-0005zb-JJ for 36023@debbugs.gnu.org; Mon, 03 Jun 2019 13:01:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1559581303; bh=Osmmr1OC1C/r3YHbO10P7mbI7cQnJ3USx8b9XhJ56fg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=gdrwsO5wwLwImUROkHRarmqUnRrRBev671q7i/f1X3hIoRdehzUSuyLNJMLbtK56g e8tZwdADctdNR+cXgmT/WxQRsk3ZDNLc6TEfBOpI9Il8HNdtm/ExmOh6MfIvBtGQp8 qoc7UTioEY7rKQe5HzHA+M0YEKdfLbGEPHbu5pFQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from e136.suse.de ([195.135.221.2]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lb7vN-1grx8g1e8X-00kbs6; Mon, 03 Jun 2019 19:01:43 +0200 Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. To: Danny Milosavljevic References: <20190531112735.15985-1-dannym@scratchpost.org> <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> <20190603185201.0ed67e8c@scratchpost.org> From: Jonathan Brielmaier Message-ID: <2acaba5c-c28c-5f17-c73c-c0ffdbccd186@web.de> Date: Mon, 3 Jun 2019 19:01:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190603185201.0ed67e8c@scratchpost.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SLLw4dNKTPrvRR0u71hyIEg0WInLYJZvPwz/M+NhHQAKg/Qm9uc RrG6LOxcOeJWpLQa2TlaJFFRzbICjsG3OD3zKqWdhJOgvhs4WvoDT3X4vbADoM+utCyRqo+ pW6xu81JOtwGNKHzsxA53SrZabVPPgMxRB+UMFZBqXdic/YKKfvprjdZlgkaDnOtXNNYQEE 8FNFJzw3R/OiSBm7cBTGQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Mp+77LOsYdM=:L4N9RwDPPKFxlamP2QRwck 7R85vvZhw+lUk/G7UjkpNm8ae5W6wN2R7eoTWTx2A+hNyhMEZLxKszDOGubYLy5zdbGeo9WhH ZBB0g6OitkqDxEUwtJg9KX+7jtliEtZA1r6UNv7vu5jR7YSOlDJGkPq6CC/Bgyl/eX1/8/d4y juiFClqsnwVGmYoAFBtjkdAtPrG7o2E5tYNNcDAoeUWg+zc562Y5GFh4Q5Lhz5b5Q0k3nkLB6 ePkp90rqNwN/Y9+G7r/Ojgw5/iYoNOS0IqzvFTy5sF0BJhFjDgRo+92+MNrbUB61ktrfORhAJ tJHRm6lr+p6pOLbbneb80tza/94+B/EkZp4J6jAozZxU2xEnDrdUKDjSjX8FyeYwu9oD6zTJG kBqVn5lktpliGQfiCMO1JR2v3P0LLdKoShBaO8DfFxJatlymb6wGsvyqxTlcKL0QKQH2U8eXL HsRO9eRc+pg7GJcR0LHlRb4c8ucSDvOnXwE/m/tbwo4tGGStrWaZedZBUusaxID/cI+4gOVyh J6bhExxgBnIzhqggLdp6Xjq0oL2QYIQ5a/9oqEd3/C82oEaJwTEm5II4KadVnwQ3EdIhW8RUT CeU8O12FtvpTVA0IHxTwWJB/qh586s8kwW2q+DZjhYM3Y06jhVjxpPGeJsTnfastu0df8V5lm ldOpWGGrS7aDmlvIS0CdTdJi9jabqv7tC5saGB7BSn//CWvY7DlVt3gxI0A/ddNipfx8K5yqR IBdjL6VvM1NRkoPlL2ciAjv39Ps8jgXDgD1oTZ9h/JbKLlXiDpZS1nrOreZ2POuXjOvBmMZkS V/e3EQcSH5T+P9CBJ4SlRcmvaQbQAKV/N/KxdaOd65R85UAG2sH//RovlS4JFLwPHm+KDe1iT HXTZQZNBCnUIqN42WBpwKZuaBYVzhF+B2r/UmLP2TQllQ9Y5+TSJaQ6s5+zJUFZ5CxpLNAHuh O+bX7TOKXOMqFYtJUoflMLeYDI/cgrw6hOBkTEhe4H4yfKOrQF6k4 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36023 Cc: 36023@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/3/19 6:53 PM, Danny Milosavljevic wrote: > Hi Jonathan, > > On Mon, 3 Jun 2019 18:17:14 +0200 > Jonathan Brielmaier wrote: > >> On 5/31/19 1:27 PM, Danny Milosavljevic wrote: >>> + (setenv "EXT2FS_NO_MTAB_OK" "1") >>> + >> [...] >>> + (setenv "EXT2FS_NO_MTAB_OK" #f) >>> + >> >> Maybe it would be nice to have them constintly using either "0" and "1" >> or #t and #f :) > > Well, the UNIX environment interface and/or Guile's interface to it does= n't > work that way. The UNIX environment is a string array. > > e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the ent= ry > with the key "EXT2FS_NO_MTAB_OK". > > So we can set the environment entry to any value we want and e2fsck's "i= f" > condition will evaluate to true. > > And in order to remove it from the environment again, we call setenv wit= h > #f. > > We could also call unsetenv instead, I guess. Should we? Ah, oke. Thanks for the explanation. I think we can leave it as it is... From unknown Mon Jun 23 09:35:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator