GNU bug report logs - #36011
[PATCH 1/2] gnu: gnucash: Update to 3.5.

Previous Next

Full log

Message #13 received at 36011-done <at> debbugs.gnu.org (full text, mbox):

From: Dumitrascu Vasile <va511e <at> yahoo.com>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 36011-done <at> debbugs.gnu.org
Subject: Re: [bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5.
Date: Sat, 1 Jun 2019 11:28:13 +0000 (UTC)

[Message part 1 (text/plain, inline)]

 
  Hi Kei

Thank you for the corrections and the merge,

  Vasile
 
    On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebreau <kkebreau <at> posteo.net> wrote:  
 
 Hi Vasile,

The patch looks good overall, but the way the commit log is written is a
bit off. It's mostly good though, so I've committed the patch myself
with the changes mentioned below.

Vasile Dumitrascu <va511e <at> yahoo.com> writes:

> * gnu/packages/gnucash.scm (gnucash): Update to 3.5.
> [source]: Remove uneeded patch.
> * gnu/local.mk: Remove delete patch.

The value modified within gnu/local.mk should be specified. In this
case, the line would look line this:
"* gnu/local.mk (dist_patch_DATA): Remove patch."

Also, mention that you actually deleted the obsolete patch:
"* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete file."

Thanks for contributing!
  

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.