From unknown Fri Jun 20 07:28:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36011 <36011@debbugs.gnu.org> To: bug#36011 <36011@debbugs.gnu.org> Subject: Status: [PATCH 1/2] gnu: gnucash: Update to 3.5. Reply-To: bug#36011 <36011@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:28:44 +0000 retitle 36011 [PATCH 1/2] gnu: gnucash: Update to 3.5. reassign 36011 guix-patches submitter 36011 Vasile Dumitrascu severity 36011 normal tag 36011 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 14:50:00 2019 Received: (at submit) by debbugs.gnu.org; 30 May 2019 18:50:00 +0000 Received: from localhost ([127.0.0.1]:33860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWQ7j-0005xG-PF for submit@debbugs.gnu.org; Thu, 30 May 2019 14:50:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWQ7i-0005ws-7B for submit@debbugs.gnu.org; Thu, 30 May 2019 14:49:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:53587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWQ7c-0005vf-DL for submit@debbugs.gnu.org; Thu, 30 May 2019 14:49:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWQ7b-0003W1-4g for guix-patches@gnu.org; Thu, 30 May 2019 14:49:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, LOTS_OF_MONEY,RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWQ7X-0005qx-Em for guix-patches@gnu.org; Thu, 30 May 2019 14:49:50 -0400 Received: from sonic303-21.consmr.mail.ir2.yahoo.com ([77.238.178.202]:46528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWQ7V-0005l1-DX for guix-patches@gnu.org; Thu, 30 May 2019 14:49:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1559242179; bh=cuFlNxR8MugGDyEHdxNVz9IGsdR1nvuKpYOsvtX7wS8=; h=From:To:Cc:Subject:Date:From:Subject; b=N90h0IUc5dzMHpft93zL9PpqSGxdVaYvIYM7mRRMwUe/Do5gYRuw1L6rCM+1UO743tV3UYUSkIm3nzKUR5V/KAQIbbNtSBCCFKFIyhdNwH/HohkvEOf+TmhG9lqZYJgkc35IJdZ4W6c7Rdyz2rnBxny4wh3/Dmo3OwCCnhDQ4ZoXD4vgZOkAUHQLRkm/RsjPfY7TFC5paYTXh8JS91jHBICSCWmC6F+827z5oFl35jaQunGRFvoDOO3i0b2gHNBGZTAb+Uy4jwY0k0U/ycDb3+6P0K2A7kPRQsmksZq72N6l550c0fSvAPZ/3ISPT/RNNR4J7gnO1XuK6qCqgD9BCw== X-YMail-OSG: zHBzca0VM1lQ5SaSlcH8fMi0LTRSAG.gmzkaLIkpihNlF_f1o6hCMLjdk2EgYnr WrPHtgZXRSQ0lQ2l9FVdWVDHueHwwmJimCgSJkjCbgasmfIL_qcD0g7z.hUlF1dGgIzyDR8kS6CQ pdvcufPZxIRbnyJuFPZVpbmzg2BCwVTVNzCcD0Y08EBQWlwtQGuzVsAkRcf3LJf4kUp5sVygqWy. p_mUg8PTEUG2E0f4FROuG1jvQFPWmSysT2tSa3wFiDDhNetyYuSvz26Ushbz7e7mLuR_x1xtJGb4 pFJejUSio.NSJ7JZokPYy.LNt2tUJOp1qvMfr6AdUohZ3.imMRifwmfQIASdyyZPzvjxR.GPepS7 Ru_VZYtNbbt1uFBCnESuZcjv1vngfIzN_7R2VrcsviYpDXYvttf6_uSv8i9XC.rXDc6FfGWRX3uF T6YXZGii7F1cV1it3aPEY3DMkJBEYzxBO6.9ywSiUD919.8kK6fwOtw99FB4O7iLQsUYNbqmY1qO 1PaeKXykidjyjIcpSku011eqBLJLYVs1bp0amnJFUVFSQzwuXSqXyEn3MuZobZhSPVJ_ZjSscZBt lMoCyXI.KJG._yJxOnuNifnZRPFmBHUudXiWEVvMQ.gc6Mq4jW6veXzh1q9WQdR2.jPEQKeVzEW8 JrnMZHEVVPxrfvORHrLnHzOfIKiwEWf82e.qE56WyWTCVjiG2W68z1ontprVO8NmwD9YbDSeFatc 4r9Vsfm8R.ksrZjIFDoQm4v6srVVPGnB09pe6rGX8NdYsp4JiPR9otBsyZ81ZepE6Lgylv63G3GF mgxMiYyt3y_j41ESCwIQnVM3L9K88oIgzgSqdcGGXr9I8JRp1Ghkx64WYZhFu5KUjIJukxLaTsoe OnPhLcBxX3oP4.DpUNEdfmaV.fDbIuPuaPkRMmF1rP.U7RUZwKGWC0KptTWJZsI4fei8lwjfea_A g8gzZDG0_VRk8Pp1NfElB7.EzxYp33U.F9IgSwOQKDVlGl8BoFCKlP44Bq9PRysyv.A144MNeIsZ uu2KTfLFT6cAD6sSg1jp5G6MZfEK8oZLSnaqqhu1ih4xOiR9vX_4kTiHBnf8CvJKEBACZlCEsLpg _UdjNccy7Dx09ny5RFle6RtvQfYitaAnLhu0z.3UgqzgiyDU3T.phh.VdF_4Jl3Q4h6nu80JBTOw 3D5wCbeZ_YqMddj1tELI1cL7WEWYr7wOR Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Thu, 30 May 2019 18:49:39 +0000 Received: from 84-74-184-74.dclient.hispeed.ch (EHLO localhost.localdomain) ([84.74.184.74]) by smtp407.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ddd6fc40132368b43e4d91c718d7c7d7; Thu, 30 May 2019 18:49:35 +0000 (UTC) From: Vasile Dumitrascu To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: gnucash: Update to 3.5. Date: Thu, 30 May 2019 20:49:32 +0200 Message-Id: <20190530184933.14227-1-va511e@yahoo.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.178.202 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit Cc: Vasile Dumitrascu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) * gnu/packages/gnucash.scm (gnucash): Update to 3.5. [source]: Remove uneeded patch. * gnu/local.mk: Remove delete patch. --- gnu/local.mk | 1 - gnu/packages/gnucash.scm | 5 +- ...gnucash-fix-test-transaction-failure.patch | 54 ------------------- 3 files changed, 2 insertions(+), 58 deletions(-) delete mode 100644 gnu/packages/patches/gnucash-fix-test-transaction-failure.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3a199f82f8..e1c1b0202c 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -865,7 +865,6 @@ dist_patch_DATA = \ %D%/packages/patches/gmp-faulty-test.patch \ %D%/packages/patches/gnome-shell-theme.patch \ %D%/packages/patches/gnome-tweaks-search-paths.patch \ - %D%/packages/patches/gnucash-fix-test-transaction-failure.patch \ %D%/packages/patches/gnutls-skip-trust-store-test.patch \ %D%/packages/patches/gobject-introspection-absolute-shlib-path.patch \ %D%/packages/patches/gobject-introspection-cc.patch \ diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm index 5b4da97e5d..e09a7cb0c0 100644 --- a/gnu/packages/gnucash.scm +++ b/gnu/packages/gnucash.scm @@ -54,7 +54,7 @@ ;; directory. (package (name "gnucash") - (version "3.4") + (version "3.5") (source (origin (method url-fetch) @@ -62,8 +62,7 @@ version "/gnucash-" version ".tar.bz2")) (sha256 (base32 - "1ms2wg4sh5gq3rpjmmnp85rh5nc9ahca1imxkvhz4d3yiwy8hm52")) - (patches (search-patches "gnucash-fix-test-transaction-failure.patch")))) + "0ibp7g6aknvnkwkin97kv04ipksy3l18dsz9qysjb7h2nr8hnvbp")))) (build-system cmake-build-system) (inputs `(("guile" ,guile-2.2) diff --git a/gnu/packages/patches/gnucash-fix-test-transaction-failure.patch b/gnu/packages/patches/gnucash-fix-test-transaction-failure.patch deleted file mode 100644 index 7b1b29f06c..0000000000 --- a/gnu/packages/patches/gnucash-fix-test-transaction-failure.patch +++ /dev/null @@ -1,54 +0,0 @@ -# This patch was submitted upstream to: https://bugs.gnucash.org/show_bug.cgi?id=797008. -From c20d74bebca516d0e391724202aad511967fe109 Mon Sep 17 00:00:00 2001 -From: Maxim Cournoyer -Date: Wed, 2 Jan 2019 14:46:28 -0500 -Subject: [PATCH] tests: Fix a test failure in test-transaction.scm. - -With the New Year upon us, a test which was hard-coded to use 2018 now -failed. - -Fixes issue #797008 (see: -https://bugs.gnucash.org/show_bug.cgi?id=797008). - -* gnucash/report/standard-reports/test/test-transaction.scm: -(trep-tests): Use the current year in the test string instead of a -static one. ---- - gnucash/report/standard-reports/test/test-transaction.scm | 7 +++++-- - 1 file changed, 5 insertions(+), 2 deletions(-) - -diff --git a/gnucash/report/standard-reports/test/test-transaction.scm b/gnucash/report/standard-reports/test/test-transaction.scm -index 755aba298..ae3fbd5c1 100644 ---- a/gnucash/report/standard-reports/test/test-transaction.scm -+++ b/gnucash/report/standard-reports/test/test-transaction.scm -@@ -5,6 +5,7 @@ - (use-modules (gnucash report stylesheets)) - (use-modules (gnucash report report-system)) - (use-modules (gnucash report report-system test test-extras)) -+(use-modules (srfi srfi-19)) - (use-modules (srfi srfi-64)) - (use-modules (gnucash engine test srfi64-extras)) - (use-modules (sxml simple)) -@@ -643,7 +644,8 @@ - (set-option! options "General" "Show original currency amount" #t) - (set-option! options "Sorting" "Primary Key" 'date) - (set-option! options "Sorting" "Primary Subtotal for Date Key" 'none) -- (let* ((sxml (options->sxml options "dual columns"))) -+ (let* ((sxml (options->sxml options "dual columns")) -+ (current-year (date->string (current-date) "~y"))) - (test-equal "dual amount column, with original currency headers" - (list "Date" "Num" "Description" "Memo/Notes" "Account" - "Debit (USD)" "Credit (USD)" "Debit" "Credit") -@@ -652,7 +654,8 @@ - (list "Grand Total" "$2,280.00" "$2,280.00") - (get-row-col sxml -1 #f)) - (test-equal "dual amount column, first transaction correct" -- (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00") -+ (list (string-append "01/03/" current-year) "$103 income" -+ "Root.Asset.Bank" "$103.00" "$103.00") - (get-row-col sxml 1 #f))) - ) - --- -2.19.0 - -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 23:07:57 2019 Received: (at 36011-done) by debbugs.gnu.org; 1 Jun 2019 03:07:57 +0000 Received: from localhost ([127.0.0.1]:36761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWuNB-0001UP-Fh for submit@debbugs.gnu.org; Fri, 31 May 2019 23:07:57 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWuN7-0001U5-Nd for 36011-done@debbugs.gnu.org; Fri, 31 May 2019 23:07:55 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 0E9B116005F for <36011-done@debbugs.gnu.org>; Sat, 1 Jun 2019 05:07:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1559358467; bh=GM36cqg7VjWXvFw2aUjregpXIsvI4l8JacKzz4oA9qw=; h=From:To:Cc:Subject:Date:From; b=jOujmaUfaXxRqb0vVqfMib7lNH12NztkTfuNJS6y5VVE8j22cn1Q9MJ1s1NFJX2pQ Air03FhM/1uE9RzWnlZhJWWgjasUkVtroodcuaxxTi+XQ764d/mUT7jOsSXqOdVQ2A QQZ+P1CmG0yFfOO7cn3zh/Uq7RApd+AAIMqq/2C07iE7BClmQLhe02ng9xL30xDgRH SBGCa/glLcB7thCSVvMT1STE5PCzaGbdinOKjcobc9fn/LUrm/bqupTpBDlJG/YmoU YwSF4EfN7Wjxd7qyGcRnR6WOAucrZl2qY4WJpM4WQnxQFLMJeMNKnNj/aDjzs8UGaB dsPnX6BBU0z3Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 45G5pp1Ng6z6tm7; Sat, 1 Jun 2019 05:07:45 +0200 (CEST) From: Kei Kebreau To: Vasile Dumitrascu Subject: Re: [bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5. References: <20190530184933.14227-1-va511e@yahoo.com> Date: Fri, 31 May 2019 23:07:44 -0400 In-Reply-To: <20190530184933.14227-1-va511e@yahoo.com> (Vasile Dumitrascu's message of "Thu, 30 May 2019 20:49:32 +0200") Message-ID: <874l5a2ebj.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36011-done Cc: 36011-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Vasile, The patch looks good overall, but the way the commit log is written is a bit off. It's mostly good though, so I've committed the patch myself with the changes mentioned below. Vasile Dumitrascu writes: > * gnu/packages/gnucash.scm (gnucash): Update to 3.5. > [source]: Remove uneeded patch. > * gnu/local.mk: Remove delete patch. The value modified within gnu/local.mk should be specified. In this case, the line would look line this: "* gnu/local.mk (dist_patch_DATA): Remove patch." Also, mention that you actually deleted the obsolete patch: "* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete file." Thanks for contributing! From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 07:29:26 2019 Received: (at 36011-done) by debbugs.gnu.org; 1 Jun 2019 11:29:26 +0000 Received: from localhost ([127.0.0.1]:37291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX2CU-0007Vk-1Y for submit@debbugs.gnu.org; Sat, 01 Jun 2019 07:29:26 -0400 Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:41614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX2CR-0007VT-VK for 36011-done@debbugs.gnu.org; Sat, 01 Jun 2019 07:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1559388556; bh=cqX6xtY+/ScGck0wLQTTtj6qhJe8VTelmV+cQNuwcLg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=FjTonqARXj7l62SdyEW3lD+PgBzL2HTm2HFpVevJpzgpKxz9YRgcuVxEaFYErTPb4vm41nDjLadv06TfrYV5W5+qQZUMZV5T10iU5m+4XrCH9tNX786E9qQYhiuxV/9DsNZphx88izEuHw3mS/mqt1w9xyNuG3+pIxJLDNkpGEbGM3ySlztKzeKH2ThbejHnSBoHieK/kuLy+LVA8KloauQob4zOtBwjSPEFGQjRfo/JG05uYxN8d2gxh503lrhLI6g+2OQI2H2+qS2tEbxNAJcqS3CyQtEB4JQyRbXmVTwjOSnm74Kn+AMbYpYpkOupP7DOzaOsyYbYMiE9tHHxSg== X-YMail-OSG: pM.g0n0VM1mjO5We4rwPbymPCjMITQdadE8Qiw9.GAvtSAy8Wvh0ZPhlhZIzWvG CxEohQLznehisPNCxpNDpvo7Spi1cbHk4F2QQYje7O9x_BsAJLPpfpikMD5IFA_oYzEbKvrAXwGR 3ieERAZhmzeSHNNvtzPsMPCKAhepdmXXZMP6gSfkACsZSnJ4hzsax9tgZpRHDI2heAaA7USMYjN5 8NRBdIHn_syVwCofFGaKgjlG8mZKtutF6Kf6IGfBXlZBqs6ergXdhePcNcnjeOfa1artOvY9zrf3 nVpSiYXgwgl_PvoBkCmnlVi5JxP_EYa1FOtVjPeFy_xqdHaqqQRtIMAoPolmJGJnAS2v2TOisy7p 8stbNIEExhg2REDMIpCgNngyXWGGc5zsjGW9cEp765UFZLMkTPvc92zjuFVbGVTugQnUv50gWWl4 oCwI71v20gH5nIE4xLNCsW1.IcALR43_m.f8HnBMTr34jsHcpv5GD_uqQrwpQXbi1dIB.AeWbYFG Y8qEXUHrR4oy.jQtOFtawHPKeXHu_RAWBcBSdNL8iQN1XMm2LyIIl4Gbi8__HZ.rjv7ihMDjYSSC H16RksGcFr1xLwLrVffnHffeTxJfpMWUJ5u91wHw6KmpOY.uT2VBfCHKqUXqnd08DARZW3exKK1p drX3zjJboI68G2VQ6IIX1Tyy.bFIakttFXoSl8VvPD34sbtaNobZrVbYEoGDPrsK2JuQ9bhM95ky .crrgby6Zitbu6HsrMRmC2DXeKbWLh2S6L.0vshDIkkxUC1dyHxnq9mQ1BhiyfzosZcXJ1N2gzRK XgzVpj.89HNefxMtH0Kk51p3DyGqnTHcCJoqG8gxCfiMhLufv1.7Smukj89_jdcaLPTEb5bAl_DC OH3ctmjoOu3fdGN6mpViHc16bteCT29uBfWZzWy2PyS7p908hUgGhx9Inz.fS6RILnFmys.pKPb5 .b2Dk2Bdp55fVO2yQ.1Nbxw8nHQOdTecSyow3_7SWfXUhW4LOkesY8ZkYxhexGOV3wMcJpn3rhMm n32tcqCvaBO7wyzVwi1Ivp6adMX4Clp_DJOkJ0Z4oxTfZSJoNed_WBIZ3Cly6jlS.ZlrHPmJP8xj WBF1EXByfzMauF7mPgfQ7fK33OGPOSQI5x7Gem4YRm_XwirfN4hc1YvnKRUpB8Qtun7Sj3A1djm_ 0hLjCaliiPkBbrp_32VNLsq.IpvwZGmBkwMJZPsw5C6icDAPq8OlW4nW8I3aWrfnPxf2DavuEhB7 tIJdgIN1theCHxucu1pVyxxIQ4g-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sat, 1 Jun 2019 11:29:16 +0000 Date: Sat, 1 Jun 2019 11:28:13 +0000 (UTC) From: Dumitrascu Vasile To: Kei Kebreau Message-ID: <1787374743.13222284.1559388493279@mail.yahoo.com> In-Reply-To: <874l5a2ebj.fsf@posteo.net> References: <20190530184933.14227-1-va511e@yahoo.com> <874l5a2ebj.fsf@posteo.net> Subject: Re: [bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5. MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_13222283_1715462178.1559388493276" X-Mailer: WebService/1.1.13634 YMailNorrin Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0 Content-Length: 3395 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36011-done Cc: 36011-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dumitrascu Vasile Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------=_Part_13222283_1715462178.1559388493276 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =20 =C2=A0 Hi Kei Thank you for the corrections and the merge, =C2=A0 Vasile =20 On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebreau wrote: =20 =20 Hi Vasile, The patch looks good overall, but the way the commit log is written is a bit off. It's mostly good though, so I've committed the patch myself with the changes mentioned below. Vasile Dumitrascu writes: > * gnu/packages/gnucash.scm (gnucash): Update to 3.5. > [source]: Remove uneeded patch. > * gnu/local.mk: Remove delete patch. The value modified within gnu/local.mk should be specified. In this case, the line would look line this: "* gnu/local.mk (dist_patch_DATA): Remove patch." Also, mention that you actually deleted the obsolete patch: "* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete = file." Thanks for contributing! =20 ------=_Part_13222283_1715462178.1559388493276 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

  Hi Kei

Thank you for the corrections and the merge,

  Vasile


=20
=20
On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebrea= u <kkebreau@posteo.net> wrote:


Hi Vasile,

The patch looks good overall, but the way the commit log is writ= ten is a
bit off. It's mostly good though, so I've commit= ted the patch myself
with the changes mentioned below.

Vasile Dumitrascu <va511e@yaho= o.com> writes:

> * gnu/packa= ges/gnucash.scm (gnucash): Update to 3.5.
> [source]: = Remove uneeded patch.
> * gnu/local.mk: Remove delete = patch.


The value modified within= gnu/local.mk should be specified. In this
case, the line= would look line this:
"* gnu/local.mk (dist_patch_DATA):= Remove patch."

Also, mention that you= actually deleted the obsolete patch:
"* gnu/packages/pat= ches/gnucash-fix-test-transaction-failure.patch: Delete file."

Thanks for contributing!

<= /div>
------=_Part_13222283_1715462178.1559388493276-- From unknown Fri Jun 20 07:28:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator