GNU bug report logs - #36009
[PATCH] Use lexical-binding in textmodes/page.el and add tests

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 30 May 2019 18:33:02 UTC

Severity: wishlist

Tags: patch

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 36009 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 36009 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: [PATCH] Use lexical-binding in textmodes/page.el and add tests
Date: Sun, 02 Jun 2019 12:25:04 +0200

Oh, sorry Stefan, what a coincidence! I chose that file at random
yesterday. I should do a Debbugs search in advance next time.

Regarding the tests they look almost identical, except that I left out
tests for `count-lines-page' and `what-page', because I was unsure
whether they would be too dependent on the format of the user messages.

Maybe it would be good to factor out the meat of `count-lines-page'
and `what-page' into two internal functions returning just the raw
numbers, test those, and turn the interactive functions into
interfaces for them?

-- Simen
This bug report was last modified 5 years and 337 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.