From unknown Sun Jun 22 00:58:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows Resent-From: Bernhard Rotter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 14:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36004@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155922702019464 (code B ref -1); Thu, 30 May 2019 14:37:03 +0000 Received: (at submit) by debbugs.gnu.org; 30 May 2019 14:37:00 +0000 Received: from localhost ([127.0.0.1]:33510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWMAt-00053s-SZ for submit@debbugs.gnu.org; Thu, 30 May 2019 10:37:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWJQE-00065z-CO for submit@debbugs.gnu.org; Thu, 30 May 2019 07:40:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:49889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWJQ9-0000BY-6j for submit@debbugs.gnu.org; Thu, 30 May 2019 07:40:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWJQ8-0000yV-5B for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWJQ7-0008TQ-8Y for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:32 -0400 Received: from mail-vk1-xa44.google.com ([2607:f8b0:4864:20::a44]:42678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWJQ7-0008KS-01 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:31 -0400 Received: by mail-vk1-xa44.google.com with SMTP id x196so676218vkd.9 for ; Thu, 30 May 2019 04:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=PkwEUjazmiysFGXXz3hk/uu2K869Tcg2vVhuPPJ7d50=; b=jFNmgitomTZBRGorbhN0c0CtKNbyr68z9SVb72IVNFNCFEjlS0U1M7+23VQQpiru0r /VgThyo3evVVlV+k93AGXrUpQg1Vib2d1a7/OKILkqsaIdx0txwf1AiCMsHrfw4ilM90 RZb6cJZWi7JVCComyzcB5nOzRzNAZnQbhharHIZUIA4/c6Du2jYIpqQtHIWto0Cx4bJp VFRh7KNAFo0eOOSEUK3C0hQu41K2++khf7h5ARfZH8bZ2YSqMiW3vP6bF9zSPe2wvJzc E8w8EQKT06rzsa/6vKlhvJ6/nqttisVZomxMeDRT2kX2j6YqiaEbStrdDFWOI66Z5pjP yNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PkwEUjazmiysFGXXz3hk/uu2K869Tcg2vVhuPPJ7d50=; b=HWS5zY/WpCttXSHRHnoEJShNalAmR6C2CtapLDZvXK4EbnCR0K6cyuCkd1Myd+hQsB tbFjROyaexVVyJeIogsPYw2UdqVM68TppzBcl7Wyg3Sl+yEYSnSp9cR/kI23NJBxq5C0 tD9EOnODfwcXHen+oACAxnjuNNzWWHVvfzGX2yjyZz2OWuwfYU4lXtwR6JTYjHUA4byt yz+nD9IUCSwgSjcV8kQEyPnktJjJjOSzs2d+IrFVLYSJS4lld99C0mKvnNXOtr9hmVcE UcidvUC268uybDHAeblbD2WerpojYBKk685gOZ4loPHuVNKrhK87gyKbgxayreljL2RJ cMNg== X-Gm-Message-State: APjAAAU5g6/l6KIwolfHaEV7133YKnAenL5Sjl5xSQSZrHYC4tYZCnvu UFX88dhsOS5wlZKRMwuplRiePnc5HZOS8mOs3m2cvZJ67nc= X-Google-Smtp-Source: APXvYqxNuVtc3uDTtuQfCnXelY+e9O9k5b4wfVjsKOgBVmENXzwknonLNkXxD2/M0yx6oycx6wPl7JPN0mIisja7GGg= X-Received: by 2002:ac5:c7bb:: with SMTP id d27mr1169386vkn.79.1559216429272; Thu, 30 May 2019 04:40:29 -0700 (PDT) MIME-Version: 1.0 From: Bernhard Rotter Date: Thu, 30 May 2019 13:40:02 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000654d02058a195dde" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::a44 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 30 May 2019 10:36:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000654d02058a195dde Content-Type: text/plain; charset="UTF-8" Eshell uses eshell-parse-colon-path to split $PATH. The paths returned have a slash appended, so an absolute path can be contructed simply by concatenating path and filename. On windows the result list of eshell-parse-colon-path is extended further by "." (without a slash). This was no problem for me until I wanted to run git in a directory created by "git worktree add". When eshell was looking for git it found the file ".git" whereas it should have been looking for "./git". The result was an error message. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 built on CIRROCUMULUS Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor 'Microsoft Corp.', version 10.0.17763 --000000000000654d02058a195dde Content-Type: application/octet-stream; name="0001-Fix-path-for-current-directory-in-eshell-on-MS-Windo.patch" Content-Disposition: attachment; filename="0001-Fix-path-for-current-directory-in-eshell-on-MS-Windo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwal3yny0 RnJvbSBmYjYwODhjNzA5ZTUzMTVhYjJjOWQyNDFjMGJkOGQ0YTY1NWRkMmMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuaGFyZCBSb3R0ZXIgPGJlcm5oYXJkLnJvdHRlckBnbWFp bC5jb20+CkRhdGU6IFRodSwgMzAgTWF5IDIwMTkgMTA6MTM6MDAgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggcGF0aCBmb3IgY3VycmVudCBkaXJlY3RvcnkgaW4gZXNoZWxsIG9uIE1TLVdpbmRv d3MKCiogbGlzcC9lc2hlbGwvZW0tY21wbC5lbCAoZXNoZWxsLWNvbXBsZXRlLWNvbW1hbmRzLWxp c3QpOgoqIGxpc3AvZXNoZWxsL2VzaC1leHQuZWwgKGVzaGVsbC1zZWFyY2gtcGF0aCk6Ck9uIE1T LVdpbmRvd3MgUEFUSCBpcyBleHRlbmRlZCBieSBjdXJyZW50IGRpcmVjdG9yeS4gIERvIGl0IHJp Z2h0IGJ5IHVzaW5nIHRoZQpwYXRoIHByZWZpeCAiLi8iIGluc3RlYWQgb2YgIi4iIGp1c3QgYXMg dGhlIG90aGVyIFBBVEggY29tcG9uZW50cyAocmVmYWN0b3JlZAp0byBlc2hlbGwtZ2V0LXBhdGgp LgoqIGxpc3AvZXNoZWxsL2VzaC11dGlsLmVsIChlc2hlbGwtZ2V0LXBhdGgpOiBOZXcgZnVuY3Rp b24uCi0tLQogbGlzcC9lc2hlbGwvZW0tY21wbC5lbCAgfCA0ICstLS0KIGxpc3AvZXNoZWxsL2Vz aC1leHQuZWwgIHwgNCArLS0tCiBsaXNwL2VzaGVsbC9lc2gtdXRpbC5lbCB8IDggKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9saXNwL2VzaGVsbC9lbS1jbXBsLmVsIGIvbGlzcC9lc2hlbGwvZW0tY21wbC5lbApp bmRleCBmODM0ODgyZjdiLi4yMjQ2YjY1MjIwIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1j bXBsLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwKQEAgLTQwOCwxMyArNDA4LDExIEBA IGVzaGVsbC1jb21wbGV0ZS1jb21tYW5kcy1saXN0CiAJICAoc2V0cSBmaWxlbmFtZSAoc3Vic3Ry aW5nIGZpbGVuYW1lIDEpCiAJCXBjb21wbGV0ZS1zdHViIGZpbGVuYW1lCiAJCWdsb2ItbmFtZSB0 KSkKLSAgICAgIChsZXQqICgocGF0aHMgKGVzaGVsbC1wYXJzZS1jb2xvbi1wYXRoIGVzaGVsbC1w YXRoLWVudikpCisgICAgICAobGV0KiAoKHBhdGhzIChlc2hlbGwtZ2V0LXBhdGgpKQogCSAgICAg KGN3ZCAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeQogCQkgICAoZXhwYW5kLWZpbGUtbmFtZSBkZWZh dWx0LWRpcmVjdG9yeSkpKQogCSAgICAgKHBhdGggIiIpIChjb21wcy1pbi1wYXRoICgpKQogCSAg ICAgKGZpbGUgIiIpIChmaWxlcGF0aCAiIikgKGNvbXBsZXRpb25zICgpKSkKLSAgICAgICAgKGlm IChlc2hlbGwtdW5kZXItd2luZG93cy1wKQotICAgICAgICAgICAgKHB1c2ggIi4iIHBhdGhzKSkK IAk7OyBHbyB0aHJ1IGVhY2ggcGF0aCBpbiB0aGUgc2VhcmNoIHBhdGgsIGZpbmRpbmcgY29tcGxl dGlvbnMuCiAJKHdoaWxlIHBhdGhzCiAJICAoc2V0cSBwYXRoIChmaWxlLW5hbWUtYXMtZGlyZWN0 b3J5CmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtZXh0LmVsIGIvbGlzcC9lc2hlbGwvZXNo LWV4dC5lbAppbmRleCBmY2NkYjczYjMxLi4zMzQxNWIwNTA0IDEwMDY0NAotLS0gYS9saXNwL2Vz aGVsbC9lc2gtZXh0LmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1leHQuZWwKQEAgLTc5LDEwICs3 OSw4IEBAIGVzaGVsbC1zZWFyY2gtcGF0aAogICAiU2VhcmNoIHRoZSBlbnZpcm9ubWVudCBwYXRo IGZvciBOQU1FLiIKICAgKGlmIChmaWxlLW5hbWUtYWJzb2x1dGUtcCBuYW1lKQogICAgICAgbmFt ZQotICAgIChsZXQgKChsaXN0IChlc2hlbGwtcGFyc2UtY29sb24tcGF0aCBlc2hlbGwtcGF0aC1l bnYpKQorICAgIChsZXQgKChsaXN0IChlc2hlbGwtZ2V0LXBhdGgpKQogCSAgc3VmZml4ZXMgbjEg bjIgZmlsZSkKLSAgICAgIChpZiAoZXNoZWxsLXVuZGVyLXdpbmRvd3MtcCkKLSAgICAgICAgICAo cHVzaCAiLiIgbGlzdCkpCiAgICAgICAod2hpbGUgbGlzdAogCShzZXRxIG4xIChjb25jYXQgKGNh ciBsaXN0KSBuYW1lKSkKIAkoc2V0cSBzdWZmaXhlcyBlc2hlbGwtYmluYXJ5LXN1ZmZpeGVzKQpk aWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLXV0aWwuZWwgYi9saXNwL2VzaGVsbC9lc2gtdXRp bC5lbAppbmRleCBmOGRkNmYwOGY0Li44Y2JiOGYzMWM5IDEwMDY0NAotLS0gYS9saXNwL2VzaGVs bC9lc2gtdXRpbC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtdXRpbC5lbApAQCAtMjMyLDYgKzIz MiwxNCBAQCBlc2hlbGwtcGF0aC1lbnYKIGBkZWZhdWx0LWRpcmVjdG9yeScgcG9pbnRzIHRvIGEg cmVtb3RlIGhvc3QuIikKIChtYWtlLXZhcmlhYmxlLWJ1ZmZlci1sb2NhbCAnZXNoZWxsLXBhdGgt ZW52KQogCisoZGVmdW4gZXNoZWxsLWdldC1wYXRoICgpCisgICJSZXR1cm4gJFBBVEggYXMgbGlz dC4KK0FkZCB0aGUgY3VycmVudCBkaXJlY3Rvcnkgb24gd2luZG93cy4iCisgIChlc2hlbGwtcGFy c2UtY29sb24tcGF0aAorICAgKGlmIChlc2hlbGwtdW5kZXItd2luZG93cy1wKQorICAgICAgIChj b25jYXQgIi4iIHBhdGgtc2VwYXJhdG9yIGVzaGVsbC1wYXRoLWVudikKKyAgICAgZXNoZWxsLXBh dGgtZW52KSkpCisKIChkZWZ1biBlc2hlbGwtcGFyc2UtY29sb24tcGF0aCAocGF0aC1lbnYpCiAg ICJTcGxpdCBzdHJpbmcgd2l0aCBgcGFyc2UtY29sb24tcGF0aCcuCiBQcmVwZW5kIHJlbW90ZSBp ZGVudGlmaWNhdGlvbiBvZiBgZGVmYXVsdC1kaXJlY3RvcnknLCBpZiBhbnkuIgotLSAKMi4yMS4w Cgo= --000000000000654d02058a195dde-- From unknown Sun Jun 22 00:58:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2019 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Bernhard Rotter Cc: 36004@debbugs.gnu.org Received: via spool by 36004-submit@debbugs.gnu.org id=B36004.155998285124153 (code B ref 36004); Sat, 08 Jun 2019 08:35:01 +0000 Received: (at 36004) by debbugs.gnu.org; 8 Jun 2019 08:34:11 +0000 Received: from localhost ([127.0.0.1]:52813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWnj-0006HV-4v for submit@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWnh-0006HH-AM for 36004@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZWnc-00019Q-5T; Sat, 08 Jun 2019 04:34:04 -0400 Received: from [176.228.60.248] (port=2443 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZWnb-0004DZ-I2; Sat, 08 Jun 2019 04:34:03 -0400 Date: Sat, 08 Jun 2019 11:33:55 +0300 Message-Id: <8336kkpjbg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Bernhard Rotter on Thu, 30 May 2019 13:40:02 +0200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Bernhard Rotter > Date: Thu, 30 May 2019 13:40:02 +0200 > > Eshell uses eshell-parse-colon-path to split $PATH. The paths returned have a > slash appended, so an absolute path can be contructed simply by concatenating > path and filename. On windows the result list of eshell-parse-colon-path is > extended further by "." (without a slash). > > This was no problem for me until I wanted to run git in a directory created by > "git worktree add". When eshell was looking for git it found the file ".git" > whereas it should have been looking for "./git". The result was an error > message. Thanks, pushed to the master branch. From unknown Sun Jun 22 00:58:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bernhard Rotter Subject: bug#36004: closed (Re: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows) Message-ID: References: <831s04pjat.fsf@gnu.org> X-Gnu-PR-Message: they-closed 36004 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 36004@debbugs.gnu.org Date: Sat, 08 Jun 2019 08:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1559982902-24243-1" This is a multi-part message in MIME format... ------------=_1559982902-24243-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36004: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36004@debbugs.gnu.org. --=20 36004: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36004 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1559982902-24243-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36004-done) by debbugs.gnu.org; 8 Jun 2019 08:34:33 +0000 Received: from localhost ([127.0.0.1]:52816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWo5-0006I6-GU for submit@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWo3-0006Hu-SQ for 36004-done@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZWny-0001K9-O4 for 36004-done@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:26 -0400 Received: from [176.228.60.248] (port=2467 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZWnw-0004Ev-Os for 36004-done@debbugs.gnu.org; Sat, 08 Jun 2019 04:34:26 -0400 Date: Sat, 08 Jun 2019 11:34:18 +0300 Message-Id: <831s04pjat.fsf@gnu.org> From: Eli Zaretskii To: 36004-done@debbugs.gnu.org In-reply-to: (message from Bernhard Rotter on Thu, 30 May 2019 13:40:02 +0200) Subject: Re: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 36004-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Closing. ------------=_1559982902-24243-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 May 2019 14:37:00 +0000 Received: from localhost ([127.0.0.1]:33510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWMAt-00053s-SZ for submit@debbugs.gnu.org; Thu, 30 May 2019 10:37:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWJQE-00065z-CO for submit@debbugs.gnu.org; Thu, 30 May 2019 07:40:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:49889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWJQ9-0000BY-6j for submit@debbugs.gnu.org; Thu, 30 May 2019 07:40:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWJQ8-0000yV-5B for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWJQ7-0008TQ-8Y for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:32 -0400 Received: from mail-vk1-xa44.google.com ([2607:f8b0:4864:20::a44]:42678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWJQ7-0008KS-01 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:40:31 -0400 Received: by mail-vk1-xa44.google.com with SMTP id x196so676218vkd.9 for ; Thu, 30 May 2019 04:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=PkwEUjazmiysFGXXz3hk/uu2K869Tcg2vVhuPPJ7d50=; b=jFNmgitomTZBRGorbhN0c0CtKNbyr68z9SVb72IVNFNCFEjlS0U1M7+23VQQpiru0r /VgThyo3evVVlV+k93AGXrUpQg1Vib2d1a7/OKILkqsaIdx0txwf1AiCMsHrfw4ilM90 RZb6cJZWi7JVCComyzcB5nOzRzNAZnQbhharHIZUIA4/c6Du2jYIpqQtHIWto0Cx4bJp VFRh7KNAFo0eOOSEUK3C0hQu41K2++khf7h5ARfZH8bZ2YSqMiW3vP6bF9zSPe2wvJzc E8w8EQKT06rzsa/6vKlhvJ6/nqttisVZomxMeDRT2kX2j6YqiaEbStrdDFWOI66Z5pjP yNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PkwEUjazmiysFGXXz3hk/uu2K869Tcg2vVhuPPJ7d50=; b=HWS5zY/WpCttXSHRHnoEJShNalAmR6C2CtapLDZvXK4EbnCR0K6cyuCkd1Myd+hQsB tbFjROyaexVVyJeIogsPYw2UdqVM68TppzBcl7Wyg3Sl+yEYSnSp9cR/kI23NJBxq5C0 tD9EOnODfwcXHen+oACAxnjuNNzWWHVvfzGX2yjyZz2OWuwfYU4lXtwR6JTYjHUA4byt yz+nD9IUCSwgSjcV8kQEyPnktJjJjOSzs2d+IrFVLYSJS4lld99C0mKvnNXOtr9hmVcE UcidvUC268uybDHAeblbD2WerpojYBKk685gOZ4loPHuVNKrhK87gyKbgxayreljL2RJ cMNg== X-Gm-Message-State: APjAAAU5g6/l6KIwolfHaEV7133YKnAenL5Sjl5xSQSZrHYC4tYZCnvu UFX88dhsOS5wlZKRMwuplRiePnc5HZOS8mOs3m2cvZJ67nc= X-Google-Smtp-Source: APXvYqxNuVtc3uDTtuQfCnXelY+e9O9k5b4wfVjsKOgBVmENXzwknonLNkXxD2/M0yx6oycx6wPl7JPN0mIisja7GGg= X-Received: by 2002:ac5:c7bb:: with SMTP id d27mr1169386vkn.79.1559216429272; Thu, 30 May 2019 04:40:29 -0700 (PDT) MIME-Version: 1.0 From: Bernhard Rotter Date: Thu, 30 May 2019 13:40:02 +0200 Message-ID: Subject: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000654d02058a195dde" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::a44 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 30 May 2019 10:36:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000654d02058a195dde Content-Type: text/plain; charset="UTF-8" Eshell uses eshell-parse-colon-path to split $PATH. The paths returned have a slash appended, so an absolute path can be contructed simply by concatenating path and filename. On windows the result list of eshell-parse-colon-path is extended further by "." (without a slash). This was no problem for me until I wanted to run git in a directory created by "git worktree add". When eshell was looking for git it found the file ".git" whereas it should have been looking for "./git". The result was an error message. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 built on CIRROCUMULUS Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor 'Microsoft Corp.', version 10.0.17763 --000000000000654d02058a195dde Content-Type: application/octet-stream; name="0001-Fix-path-for-current-directory-in-eshell-on-MS-Windo.patch" Content-Disposition: attachment; filename="0001-Fix-path-for-current-directory-in-eshell-on-MS-Windo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwal3yny0 RnJvbSBmYjYwODhjNzA5ZTUzMTVhYjJjOWQyNDFjMGJkOGQ0YTY1NWRkMmMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuaGFyZCBSb3R0ZXIgPGJlcm5oYXJkLnJvdHRlckBnbWFp bC5jb20+CkRhdGU6IFRodSwgMzAgTWF5IDIwMTkgMTA6MTM6MDAgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggcGF0aCBmb3IgY3VycmVudCBkaXJlY3RvcnkgaW4gZXNoZWxsIG9uIE1TLVdpbmRv d3MKCiogbGlzcC9lc2hlbGwvZW0tY21wbC5lbCAoZXNoZWxsLWNvbXBsZXRlLWNvbW1hbmRzLWxp c3QpOgoqIGxpc3AvZXNoZWxsL2VzaC1leHQuZWwgKGVzaGVsbC1zZWFyY2gtcGF0aCk6Ck9uIE1T LVdpbmRvd3MgUEFUSCBpcyBleHRlbmRlZCBieSBjdXJyZW50IGRpcmVjdG9yeS4gIERvIGl0IHJp Z2h0IGJ5IHVzaW5nIHRoZQpwYXRoIHByZWZpeCAiLi8iIGluc3RlYWQgb2YgIi4iIGp1c3QgYXMg dGhlIG90aGVyIFBBVEggY29tcG9uZW50cyAocmVmYWN0b3JlZAp0byBlc2hlbGwtZ2V0LXBhdGgp LgoqIGxpc3AvZXNoZWxsL2VzaC11dGlsLmVsIChlc2hlbGwtZ2V0LXBhdGgpOiBOZXcgZnVuY3Rp b24uCi0tLQogbGlzcC9lc2hlbGwvZW0tY21wbC5lbCAgfCA0ICstLS0KIGxpc3AvZXNoZWxsL2Vz aC1leHQuZWwgIHwgNCArLS0tCiBsaXNwL2VzaGVsbC9lc2gtdXRpbC5lbCB8IDggKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9saXNwL2VzaGVsbC9lbS1jbXBsLmVsIGIvbGlzcC9lc2hlbGwvZW0tY21wbC5lbApp bmRleCBmODM0ODgyZjdiLi4yMjQ2YjY1MjIwIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1j bXBsLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwKQEAgLTQwOCwxMyArNDA4LDExIEBA IGVzaGVsbC1jb21wbGV0ZS1jb21tYW5kcy1saXN0CiAJICAoc2V0cSBmaWxlbmFtZSAoc3Vic3Ry aW5nIGZpbGVuYW1lIDEpCiAJCXBjb21wbGV0ZS1zdHViIGZpbGVuYW1lCiAJCWdsb2ItbmFtZSB0 KSkKLSAgICAgIChsZXQqICgocGF0aHMgKGVzaGVsbC1wYXJzZS1jb2xvbi1wYXRoIGVzaGVsbC1w YXRoLWVudikpCisgICAgICAobGV0KiAoKHBhdGhzIChlc2hlbGwtZ2V0LXBhdGgpKQogCSAgICAg KGN3ZCAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeQogCQkgICAoZXhwYW5kLWZpbGUtbmFtZSBkZWZh dWx0LWRpcmVjdG9yeSkpKQogCSAgICAgKHBhdGggIiIpIChjb21wcy1pbi1wYXRoICgpKQogCSAg ICAgKGZpbGUgIiIpIChmaWxlcGF0aCAiIikgKGNvbXBsZXRpb25zICgpKSkKLSAgICAgICAgKGlm IChlc2hlbGwtdW5kZXItd2luZG93cy1wKQotICAgICAgICAgICAgKHB1c2ggIi4iIHBhdGhzKSkK IAk7OyBHbyB0aHJ1IGVhY2ggcGF0aCBpbiB0aGUgc2VhcmNoIHBhdGgsIGZpbmRpbmcgY29tcGxl dGlvbnMuCiAJKHdoaWxlIHBhdGhzCiAJICAoc2V0cSBwYXRoIChmaWxlLW5hbWUtYXMtZGlyZWN0 b3J5CmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtZXh0LmVsIGIvbGlzcC9lc2hlbGwvZXNo LWV4dC5lbAppbmRleCBmY2NkYjczYjMxLi4zMzQxNWIwNTA0IDEwMDY0NAotLS0gYS9saXNwL2Vz aGVsbC9lc2gtZXh0LmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1leHQuZWwKQEAgLTc5LDEwICs3 OSw4IEBAIGVzaGVsbC1zZWFyY2gtcGF0aAogICAiU2VhcmNoIHRoZSBlbnZpcm9ubWVudCBwYXRo IGZvciBOQU1FLiIKICAgKGlmIChmaWxlLW5hbWUtYWJzb2x1dGUtcCBuYW1lKQogICAgICAgbmFt ZQotICAgIChsZXQgKChsaXN0IChlc2hlbGwtcGFyc2UtY29sb24tcGF0aCBlc2hlbGwtcGF0aC1l bnYpKQorICAgIChsZXQgKChsaXN0IChlc2hlbGwtZ2V0LXBhdGgpKQogCSAgc3VmZml4ZXMgbjEg bjIgZmlsZSkKLSAgICAgIChpZiAoZXNoZWxsLXVuZGVyLXdpbmRvd3MtcCkKLSAgICAgICAgICAo cHVzaCAiLiIgbGlzdCkpCiAgICAgICAod2hpbGUgbGlzdAogCShzZXRxIG4xIChjb25jYXQgKGNh ciBsaXN0KSBuYW1lKSkKIAkoc2V0cSBzdWZmaXhlcyBlc2hlbGwtYmluYXJ5LXN1ZmZpeGVzKQpk aWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLXV0aWwuZWwgYi9saXNwL2VzaGVsbC9lc2gtdXRp bC5lbAppbmRleCBmOGRkNmYwOGY0Li44Y2JiOGYzMWM5IDEwMDY0NAotLS0gYS9saXNwL2VzaGVs bC9lc2gtdXRpbC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtdXRpbC5lbApAQCAtMjMyLDYgKzIz MiwxNCBAQCBlc2hlbGwtcGF0aC1lbnYKIGBkZWZhdWx0LWRpcmVjdG9yeScgcG9pbnRzIHRvIGEg cmVtb3RlIGhvc3QuIikKIChtYWtlLXZhcmlhYmxlLWJ1ZmZlci1sb2NhbCAnZXNoZWxsLXBhdGgt ZW52KQogCisoZGVmdW4gZXNoZWxsLWdldC1wYXRoICgpCisgICJSZXR1cm4gJFBBVEggYXMgbGlz dC4KK0FkZCB0aGUgY3VycmVudCBkaXJlY3Rvcnkgb24gd2luZG93cy4iCisgIChlc2hlbGwtcGFy c2UtY29sb24tcGF0aAorICAgKGlmIChlc2hlbGwtdW5kZXItd2luZG93cy1wKQorICAgICAgIChj b25jYXQgIi4iIHBhdGgtc2VwYXJhdG9yIGVzaGVsbC1wYXRoLWVudikKKyAgICAgZXNoZWxsLXBh dGgtZW52KSkpCisKIChkZWZ1biBlc2hlbGwtcGFyc2UtY29sb24tcGF0aCAocGF0aC1lbnYpCiAg ICJTcGxpdCBzdHJpbmcgd2l0aCBgcGFyc2UtY29sb24tcGF0aCcuCiBQcmVwZW5kIHJlbW90ZSBp ZGVudGlmaWNhdGlvbiBvZiBgZGVmYXVsdC1kaXJlY3RvcnknLCBpZiBhbnkuIgotLSAKMi4yMS4w Cgo= --000000000000654d02058a195dde-- ------------=_1559982902-24243-1--