GNU bug report logs - #36004
[PATCH] Eshell does not extend correctly PATH by "." on MS-Windows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36004 in the body.
You can then email your comments to 36004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Rotter <bernhard.rotter <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eshell does not extend correctly PATH by "." on MS-Windows
Date: Thu, 30 May 2019 13:40:02 +0200

[Message part 1 (text/plain, inline)]

Eshell uses eshell-parse-colon-path to split $PATH. The paths returned have a
slash appended, so an absolute path can be contructed simply by concatenating
path and filename. On windows the result list of eshell-parse-colon-path is
extended further by "." (without a slash).

This was no problem for me until I wanted to run git in a directory created by
"git worktree add". When eshell was looking for git it found the file ".git"
whereas it should have been looking for "./git". The result was an error
message.

In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
 of 2019-04-13 built on CIRROCUMULUS
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor 'Microsoft Corp.', version 10.0.17763

[0001-Fix-path-for-current-directory-in-eshell-on-MS-Windo.patch (application/octet-stream, attachment)]

Message #8 received at 36004 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Bernhard Rotter <bernhard.rotter <at> gmail.com>
Cc: 36004 <at> debbugs.gnu.org
Subject: Re: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on
 MS-Windows
Date: Sat, 08 Jun 2019 11:33:55 +0300

> From: Bernhard Rotter <bernhard.rotter <at> gmail.com>
> Date: Thu, 30 May 2019 13:40:02 +0200
> 
> Eshell uses eshell-parse-colon-path to split $PATH. The paths returned have a
> slash appended, so an absolute path can be contructed simply by concatenating
> path and filename. On windows the result list of eshell-parse-colon-path is
> extended further by "." (without a slash).
> 
> This was no problem for me until I wanted to run git in a directory created by
> "git worktree add". When eshell was looking for git it found the file ".git"
> whereas it should have been looking for "./git". The result was an error
> message.

Thanks, pushed to the master branch.

Message #13 received at 36004-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 36004-done <at> debbugs.gnu.org
Subject: Re: bug#36004: [PATCH] Eshell does not extend correctly PATH by "." on
 MS-Windows
Date: Sat, 08 Jun 2019 11:34:18 +0300

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.