From unknown Sun Aug 17 04:21:28 2025 X-Loop: don@donarmstrong.com Subject: bug#360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers Reply-To: Reuben Thomas , 360@debbugs.gnu.org Resent-From: Reuben Thomas Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 04 Jun 2008 15:00:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 360 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12125911965473 (code B ref -1); Wed, 04 Jun 2008 15:00:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.0 required=4.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Jun 2008 14:53:16 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m54Er5TD005467 for ; Wed, 4 Jun 2008 07:53:08 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3uMK-0001vx-Fr for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:53:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3uMF-0001uV-P2 for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:53:04 -0400 Received: from [199.232.76.173] (port=43617 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3uMF-0001uS-MV for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:52:59 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:46730) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3uME-0005f3-GU for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:52:59 -0400 Received: from mx10.gnu.org ([199.232.76.166]:43144) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1K3uKN-00037S-1l for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:51:03 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1K3uM3-0005dh-UZ for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:52:53 -0400 Received: from pelican.sc3d.org ([216.184.201.86]:2144) by monty-python.gnu.org with esmtps (SSL 3.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3uM2-0005Zk-TX for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:52:47 -0400 DKIM-Signature: a=rsa-sha1; t=1212591088; x=1213195888; s=key1024; d=sc3d.org; c=relaxed/relaxed; q=dns; h=From:Subject:Date:Message-ID:To:MIME-Version:Content-Type:In-Reply-To:References; b=vSFnTJRuBgExSuZeGSMJqopNH9V3a72wrYf+Pf7Wdu5lG9pJySrCW1E5bkPsUVAPMfxfSklB2qPIGPWVuk+jDczV/SPctsMWxZRp4YON+s55Gdbn20A03EY1ZoRf67Mw/giTUDtwxDkYiPi+7ZMO8VNeOjduLdxc41PGhfVCB4c= Received: from canta.config (78-105-4-25.zone3.bethere.co.uk [78.105.4.25]) by pelican.sc3d.org (pf ESMTP spamd IP-based SPAM blocker) with ASMTP (SSL) id KUD65428 for ; Wed, 04 Jun 2008 10:51:28 -0400 Date: Wed, 4 Jun 2008 15:52:19 +0100 (BST) From: Reuben Thomas X-X-Sender: rrt@canta To: bug-emacs@gnu.org In-Reply-To: Message-ID: References: User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-detected-kernel: by monty-python.gnu.org: Windows 2000 SP4, XP SP1+ X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) On Fri, 2 May 2008, Reuben Thomas wrote: > I have whitespace-global-mode on and have it set to auto-cleanup on kill. > This stops read-only buffers from being killed, as auto-cleanup tries to > clean them up, gets an error, and aborts the kill. > > The old whitespace mode used to check to see if it was being called in a > read-only buffer, and didn't try to clean up under those circumstances. > > I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists > in CVS head. This problem can be fixed by wrapping the body of whitespace-clean in (unless buffer-read-only). I don't know if that fix has problems, but it at least works for me. -- http://rrt.sc3d.org/ | Matthew 5:37 <-- tri-state logic considered harmful From unknown Sun Aug 17 04:21:28 2025 X-Loop: don@donarmstrong.com Subject: bug#360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers Reply-To: Stefan Monnier , 360@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 05 Jun 2008 04:35:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 360 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 360-submit@emacsbugs.donarmstrong.com id=B360.121263997611888 (code B ref 360); Thu, 05 Jun 2008 04:35:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-1.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, HELO_LH_HOME,RCVD_IN_SORBS_DUL,RDNS_DYNAMIC autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 360) by emacsbugs.donarmstrong.com; 5 Jun 2008 04:26:16 +0000 Received: from ceviche.home (206-248-132-168.dsl.teksavvy.com [206.248.132.168]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m554QBMV011882 for <360@emacsbugs.donarmstrong.com>; Wed, 4 Jun 2008 21:26:13 -0700 Received: by ceviche.home (Postfix, from userid 20848) id 7C414B4023; Thu, 5 Jun 2008 00:26:11 -0400 (EDT) From: Stefan Monnier To: 360@debbugs.gnu.org Message-ID: References: Date: Thu, 05 Jun 2008 00:26:11 -0400 In-Reply-To: (Reuben Thomas's message of "Wed, 4 Jun 2008 15:52:19 +0100 (BST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> I have whitespace-global-mode on and have it set to auto-cleanup on >> kill. This stops read-only buffers from being killed, as auto-cleanup >> tries to clean them up, gets an error, and aborts the kill. >> >> The old whitespace mode used to check to see if it was being called in >> a read-only buffer, and didn't try to clean up under those circumstances. >> >> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still >> exists in CVS head. > This problem can be fixed by wrapping the body of whitespace-clean in > (unless buffer-read-only). I don't know if that fix has problems, but it at > least works for me. That would probably fix the problem, but now I wonder: why on earth would someone worry about whitespace when killing a buffer? Why would you want to strip whitespace just microseconds before throwing away this piece of data anyway? Stefan From unknown Sun Aug 17 04:21:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Reuben Thomas Subject: bug#360 closed by Glenn Morris (Re: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers) Message-ID: References: <18625.62937.543118.985492@fencepost.gnu.org> X-Emacs-PR-Message: they-closed 360 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo Reply-To: 360@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1220671505-7105-1" This is a multi-part message in MIME format... ------------=_1220671505-7105-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers It has been closed by Glenn Morris . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Glenn Morris by replying to this email. --=20 360: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D360 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1220671505-7105-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From rgm@gnu.org Fri Sep 5 20:17:22 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.5 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 360-done) by emacsbugs.donarmstrong.com; 6 Sep 2008 03:17:22 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m863HJe4005054 for <360-done@emacsbugs.donarmstrong.com>; Fri, 5 Sep 2008 20:17:20 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KboGv-0006mU-JF; Fri, 05 Sep 2008 23:15:37 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18625.62937.543118.985492@fencepost.gnu.org> Date: Fri, 5 Sep 2008 23:15:37 -0400 From: Glenn Morris To: 360-done@debbugs.gnu.org Subject: Re: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: |y#1|.gk2W{.[|8#Z[4AT|)0EgUxqTx?S1gw"Y^DQE$76~Cb;]E@JOb-!;px>78WlVjXo? X-Debbugs-No-Ack: yes 2008-09-05 Vinicius Jose Latorre * whitespace.el: Fix auto-cleanup on kill prevents killing read-only buffers (bug#360). ------------=_1220671505-7105-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From SRS0=2e9579f7083ab31f54ee717fb768d4cddb6e2314=722=sc3d.org=rrt@sc3d.org Wed Jun 4 07:53:15 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.0 required=4.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Jun 2008 14:53:16 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m54Er5TD005467 for ; Wed, 4 Jun 2008 07:53:08 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3uMK-0001vx-Fr for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:53:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3uMF-0001uV-P2 for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:53:04 -0400 Received: from [199.232.76.173] (port=43617 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3uMF-0001uS-MV for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:52:59 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:46730) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3uME-0005f3-GU for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2008 10:52:59 -0400 Received: from mx10.gnu.org ([199.232.76.166]:43144) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1K3uKN-00037S-1l for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:51:03 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1K3uM3-0005dh-UZ for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:52:53 -0400 Received: from pelican.sc3d.org ([216.184.201.86]:2144) by monty-python.gnu.org with esmtps (SSL 3.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3uM2-0005Zk-TX for bug-emacs@gnu.org; Wed, 04 Jun 2008 10:52:47 -0400 DKIM-Signature: a=rsa-sha1; t=1212591088; x=1213195888; s=key1024; d=sc3d.org; c=relaxed/relaxed; q=dns; h=From:Subject:Date:Message-ID:To:MIME-Version:Content-Type:In-Reply-To:References; b=vSFnTJRuBgExSuZeGSMJqopNH9V3a72wrYf+Pf7Wdu5lG9pJySrCW1E5bkPsUVAPMfxfSklB2qPIGPWVuk+jDczV/SPctsMWxZRp4YON+s55Gdbn20A03EY1ZoRf67Mw/giTUDtwxDkYiPi+7ZMO8VNeOjduLdxc41PGhfVCB4c= Received: from canta.config (78-105-4-25.zone3.bethere.co.uk [78.105.4.25]) by pelican.sc3d.org (pf ESMTP spamd IP-based SPAM blocker) with ASMTP (SSL) id KUD65428 for ; Wed, 04 Jun 2008 10:51:28 -0400 Date: Wed, 4 Jun 2008 15:52:19 +0100 (BST) From: Reuben Thomas X-X-Sender: rrt@canta To: bug-emacs@gnu.org Subject: Re: whitespace.el: auto-cleanup on kill prevents killing read-only buffers In-Reply-To: Message-ID: References: User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-detected-kernel: by monty-python.gnu.org: Windows 2000 SP4, XP SP1+ X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) On Fri, 2 May 2008, Reuben Thomas wrote: > I have whitespace-global-mode on and have it set to auto-cleanup on kill. > This stops read-only buffers from being killed, as auto-cleanup tries to > clean them up, gets an error, and aborts the kill. > > The old whitespace mode used to check to see if it was being called in a > read-only buffer, and didn't try to clean up under those circumstances. > > I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists > in CVS head. This problem can be fixed by wrapping the body of whitespace-clean in (unless buffer-read-only). I don't know if that fix has problems, but it at least works for me. -- http://rrt.sc3d.org/ | Matthew 5:37 <-- tri-state logic considered harmful ------------=_1220671505-7105-1--