GNU bug report logs - #360
whitespace.el: auto-cleanup on kill prevents killing read-only buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 360 in the body.
You can then email your comments to 360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-emacs <at> gnu.org
Subject: Re: whitespace.el: auto-cleanup on kill prevents killing read-only
 buffers
Date: Wed, 4 Jun 2008 15:52:19 +0100 (BST)

On Fri, 2 May 2008, Reuben Thomas wrote:

> I have whitespace-global-mode on and have it set to auto-cleanup on kill. 
> This stops read-only buffers from being killed, as auto-cleanup tries to 
> clean them up, gets an error, and aborts the kill.
>
> The old whitespace mode used to check to see if it was being called in a 
> read-only buffer, and didn't try to clean up under those circumstances.
>
> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists 
> in CVS head.

This problem can be fixed by wrapping the body of whitespace-clean in 
(unless buffer-read-only). I don't know if that fix has problems, but it at 
least works for me.

-- 
http://rrt.sc3d.org/ | Matthew 5:37 <-- tri-state logic considered harmful

Message #10 received at 360 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 360 <at> debbugs.gnu.org
Subject: Re: bug#360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers
Date: Thu, 05 Jun 2008 00:26:11 -0400

>> I have whitespace-global-mode on and have it set to auto-cleanup on
>> kill. This stops read-only buffers from being killed, as auto-cleanup
>> tries to clean them up, gets an error, and aborts the kill.
>> 
>> The old whitespace mode used to check to see if it was being called in
>> a read-only buffer, and didn't try to clean up under those circumstances.
>> 
>> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still
>> exists in CVS head.

> This problem can be fixed by wrapping the body of whitespace-clean in
> (unless buffer-read-only). I don't know if that fix has problems, but it at
> least works for me.

That would probably fix the problem, but now I wonder: why on earth
would someone worry about whitespace when killing a buffer?
Why would you want to strip whitespace just microseconds before throwing
away this piece of data anyway?


        Stefan

Message #17 received at 360-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 360-done <at> debbugs.gnu.org
Subject: Re: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers
Date: Fri, 5 Sep 2008 23:15:37 -0400

2008-09-05  Vinicius Jose Latorre  <viniciusjl <at> ig.com.br>

        * whitespace.el: Fix auto-cleanup on kill prevents killing read-only
        buffers (bug#360). 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.